Re: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-16 Thread Nala Ginrut
The faces icons are my speaking freedom as part of text. I grown up in a dictatorship place, they don’t even let me stop typing faces 😁 and no one told me smile faces make things worse. It is interesting to hear it first time in my life. “Well enough to go” means there is enough efforts to show an

RE: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-16 Thread Maxime Devos
>I'm not going to pursued anyone here, just sharing my opinion about a patch >for line parsing in a text file.😄 Then maybe you should stop it with the faces (“😄”) and strawmen. The faces just make things worse. >Yes, some of the parsers don need backwards, but it also doesn't mean others >parser

Re: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-16 Thread Nala Ginrut
I'm not going to pursued anyone here, just sharing my opinion about a patch for line parsing in a text file.😄 Yes, some of the parsers don need backwards, but it also doesn't mean others parsers have priority to occupy a general API. To my experience, a parser author like me prefer to write own p

RE: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-16 Thread Maxime Devos
>You raised this topic from string line reading to more general case. 😄 Yes. >If so, the best way could be providing a general function to wrap rdelim for >for-each-seg-delim, users may pass a delimiter to decide how to delim (even >for bytevectors), and implement for-line-a-file base on it with

Re: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-16 Thread Nala Ginrut
You raised this topic from string line reading to more general case. 😄 If so, the best way could be providing a general function to wrap rdelim for for-each-seg-delim, users may pass a delimiter to decide how to delim (even for bytevectors), and implement for-line-a-file base on it with unicode en

RE: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-16 Thread Maxime Devos
This is overly specific to reading lines, and reading lines with rdelim. If you replace ‘read-line’ by an argument, the procedure becomes more general. For example, by passing ‘get-char’ you can act on each character, with ‘get-line’ I’m not sure what the difference would be, but apparently it’

Re: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-15 Thread Nala Ginrut
Hi Adam! For string manipulation, the proper encoding has to be considered. It's better to use the provided [#:guess-encoding=#f] [#:encoding=#f] as well. You may take a look at call-with-input-file in document: https://www.gnu.org/software/guile/manual/html_node/File-Ports.html BTW, in your case,

[PATCH v2] rdelim: Add new procedure `for-line-in-file`.

2024-12-15 Thread Adam Faiz
>From c8a9904f1b1c09d148de1ec23dc2eb0d433b3141 Mon Sep 17 00:00:00 2001 From: AwesomeAdam54321 Date: Sun, 15 Dec 2024 23:48:30 +0800 Subject: [PATCH v2] rdelim: Add new procedure `for-line-in-file`. * module/ice-9/rdelim.scm (for-line-in-file): Add it. This procedure makes it convenient to