Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-06-30 Thread Andy Wingo
On Fri 20 May 2011 15:47, Jan Nieuwenhuizen writes: > Andy Wingo writes: > >> I don't much like this approach. Besides mixing in a heuristic on all >> machines that is win32-specific, it makes c:/foo.scm collide with >> d:/foo.scm in the cache, and fails to also modify load.c which also does >>

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-06-16 Thread Andy Wingo
Hi, This discussion strayed a bit far from the initial need to concatenate "/foo/bar" with "c:/baz/qux". On Tue 03 May 2011 09:44, Andy Wingo writes: > On Tue 03 May 2011 00:18, l...@gnu.org (Ludovic Courtès) writes: > >> So volumes matter in the file name canonicalization of the .go cache >> r

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-20 Thread Andy Wingo
Hi Jan, On Fri 20 May 2011 15:47, Jan Nieuwenhuizen writes: >> Is anyone interested in implementing a path library? > > What's the status/estimate on this -- of course I agree this would be > nicer, otoh, a patch to these three files is available that makes guile > run on mingw right now. Uncle

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-20 Thread Jan Nieuwenhuizen
Andy Wingo writes: > I don't much like this approach. Besides mixing in a heuristic on all > machines that is win32-specific, it makes c:/foo.scm collide with > d:/foo.scm in the cache, and fails to also modify load.c which also does > autocompilation in other contexts. Yes, a newer version of t

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-17 Thread Mark H Weaver
Noah Lavine writes: > Mark is right that paths are basically just strings, even though > occasionally they're not. I sort of like the idea of the PEP-383 > encoding (making paths strings that can potentially contain unused > codepoints, which represent non-character bytes), but would that make > p

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-17 Thread Mark H Weaver
Hi Noah, Thanks for thinking about this thorny issue. Noah Lavine writes: > Group 1: Treat pathnames as opaque objects that come from outside APIs > and can only be used by passing them to APIs. We can support these in > a way that will be compatible everywhere. > Operations: open file, close fi

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-17 Thread Noah Lavine
Hello all, I've been scanning some file api documentation and wondering what we could do that would translate across platforms reliably. I've been thinking of sort of concentric circles of operations, where the inner circles can easily be supported in a cross-platform way, and the outer ones requi

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-04 Thread Ludovic Courtès
Hi Noah, Noah Lavine writes: > The reason this strangeness enters is that path strings are actually > lists (or vectors) encoded as strings. Conceptually, the path > ~/Desktop/Getting\ a\ Job is the list ("~" "Desktop" "Getting a Job"). > In this representation, there are no escapes and no separ

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-03 Thread Noah Lavine
Hello all, I have another issue to raise. I think this is actually parallel to some of the stuff in the (web) module, as you will see. I've always thought it was ridiculous and hackish that I had to escape spaces in path strings. For instance, I have a folder called "Getting a Job" on my desktop,

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-03 Thread Mark H Weaver
Andy Wingo writes: > That's the crazy thing: file names on GNU aren't in any encoding! They > are byte strings that may or may not decode to a string, given some > encoding. Granted, they're mostly UTF-8 these days, but users have the > darndest files... [...] > On Tue 03 May 2011 00:18, l...@gn

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-03 Thread Ludovic Courtès
Hi, Andy Wingo writes: > On Tue 03 May 2011 00:18, l...@gnu.org (Ludovic Courtès) writes: > >>> I still think that we need at least the ability to pass a bytevector as >>> a path name, on GNU systems; and that if we can do so, then any routine >>> that needs to deal with a path name would then n

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-03 Thread Andy Wingo
On Tue 03 May 2011 00:18, l...@gnu.org (Ludovic Courtès) writes: >> I still think that we need at least the ability to pass a bytevector as >> a path name, on GNU systems; and that if we can do so, then any routine >> that needs to deal with a path name would then need to deal in byte >> vectors i

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-02 Thread Eli Barzilay
[Second attempt, my Emacs has unfortunate issues with Ludovic's name...] An hour ago, Andy Wingo wrote: > On Mon 02 May 2011 22:58, l...@gnu.org (Ludovic Courtès) writes: > > > Andy Wingo writes: > > > >> Basically I think the plan should be to add scm_from_locale_path, > >> scm_from_raw_path,

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-02 Thread Ludovic Courtès
Hello! Andy Wingo writes: > On Mon 02 May 2011 22:58, l...@gnu.org (Ludovic Courtès) writes: [...] > The funny thing is that this doesn't matter at all. Well, I mean that > it's valid to construct pathnames with / as the separator on Windows, as > / and \ are equivalent there. Oh, good. > I

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-02 Thread Andy Wingo
On Mon 02 May 2011 22:58, l...@gnu.org (Ludovic Courtès) writes: > Andy Wingo writes: > >> Basically I think the plan should be to add scm_from_locale_path, >> scm_from_raw_path, etc to filesys.[ch], and change any >> pathname-accepting procedure in Guile to accept path objects, producing >> them

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-02 Thread Ludovic Courtès
Hi, Andy Wingo writes: > Basically I think the plan should be to add scm_from_locale_path, > scm_from_raw_path, etc to filesys.[ch], and change any > pathname-accepting procedure in Guile to accept path objects, producing > them from strings when given strings, and pass the bytevector > represen

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-02 Thread Andy Wingo
On Sun 01 May 2011 23:48, Mark H Weaver writes: > on some systems (e.g. Windows NT) filenames are considered character > data, or at least so says PEP 383 > Ah, interesting, I was blissfully ignorant; not the desired state when one is hacking file-name

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Mark H Weaver
Andy Wingo writes: > On Fri 29 Apr 2011 19:30, Noah Lavine writes: >> Also, are there any characters that are valid in filenames on some >> systems but invalid on other systems? > > Ah, I see you are under the delusion that paths are composed of > characters :) This is not the case. To the OS,

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Andy Wingo
Hi, On Sun 01 May 2011 21:23, Noah Lavine writes: >> Yep!  Check that racket web page I linked to.  You don't have to >> implement all of it, but it should be possible to implement, given the >> path abstraction. > > Okay, I've read it. It doesn't seem very complicated. Should we strive > for AP

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Noah Lavine
> Yep!  Check that racket web page I linked to.  You don't have to > implement all of it, but it should be possible to implement, given the > path abstraction. Okay, I've read it. It doesn't seem very complicated. Should we strive for API compatibility? I don't see any programs needing it right no

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-05-01 Thread Andy Wingo
On Fri 29 Apr 2011 19:30, Noah Lavine writes: >> Is anyone interested in implementing a path library? > > I might be able to work on it. Super! > However, I don't know much about how Windows paths work. Are there any > special considerations beyond the directory separator? Yep! Check that rac

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-04-29 Thread Noah Lavine
> Is anyone interested in implementing a path library? > > Andy I might be able to work on it. I haven't done much for Guile lately, but I expect to have a lot more free time once my semester ends on May 7th. However, I don't know much about how Windows paths work. Are there any special considera

Re: [PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-04-29 Thread Andy Wingo
Hi Jan, On Tue 15 Feb 2011 16:35, Jan Nieuwenhuizen writes: > From: Jan Nieuwenhuizen > > 2011-02-04 Jan Nieuwenhuizen > > * module/system/base/compile.scm (compiled-file-name): Add > directory separator and remove colon for Mingw. Fixes > compilation on Windows. > --- > module

[PATCH 2/5] [mingw]: Have compiled-file-name produce valid names.

2011-02-15 Thread Jan Nieuwenhuizen
From: Jan Nieuwenhuizen 2011-02-04 Jan Nieuwenhuizen * module/system/base/compile.scm (compiled-file-name): Add directory separator and remove colon for Mingw. Fixes compilation on Windows. --- module/system/base/compile.scm |9 +++-- 1 files changed, 7 insertions(+), 2