Re: [PATCH] guile-readline: Use an empty string if HOME is unset

2014-09-21 Thread Mark H Weaver
David Michael writes: > * guile-readline/ice-9/readline.scm (history-file): When the HOME > environment variable is unset, use the empty string in its place. FYI, this was discussed at , and we decided to have guile-readline put .guile_history in the current directory

Re: [PATCH] guile-readline: Use an empty string if HOME is unset

2014-09-10 Thread Eli Zaretskii
> Date: Wed, 10 Sep 2014 14:06:15 -0400 > From: David Michael > Cc: guile-devel@gnu.org > > > How about "./.guile_history" instead? > > That is okay with me. Do you want a new patch with s/""/"."/ and > s/empty string/current directory/? Please wait for others to chime in. I'm not speaking fo

Re: [PATCH] guile-readline: Use an empty string if HOME is unset

2014-09-10 Thread David Michael
On Wed, Sep 10, 2014 at 1:00 PM, Eli Zaretskii wrote: >> From: David Michael >> Date: Tue, 09 Sep 2014 17:28:42 -0400 >> >> -(define-once history-file (string-append (getenv "HOME") "/.guile_history")) >> +(define-once history-file >> + (string-append (or (getenv "HOME") "") "/.guile_history"))

Re: [PATCH] guile-readline: Use an empty string if HOME is unset

2014-09-10 Thread Eli Zaretskii
> From: David Michael > Date: Tue, 09 Sep 2014 17:28:42 -0400 > > -(define-once history-file (string-append (getenv "HOME") "/.guile_history")) > +(define-once history-file > + (string-append (or (getenv "HOME") "") "/.guile_history")) Is there any guarantee that the root directory will be writ

[PATCH] guile-readline: Use an empty string if HOME is unset

2014-09-10 Thread David Michael
* guile-readline/ice-9/readline.scm (history-file): When the HOME environment variable is unset, use the empty string in its place. --- Hi, If a Guile program uses the readline module without setting HOME, it will fail due to string-append getting a #f argument. In particular, this necessitate