> You might consider checking if the string created by normalize_str
> should be reduced to the 1-byte-per-character representation. The procecure
> scm_i_try_narrow_string could be used for that.
Good idea -- I'll add that. Thanks!
> From: Julian Graham
>
> Hi Guilers,
>
> Happy new year!
>
> Find attached a patch that adds C and Scheme support for the four
> Unicode string normalization forms [0], along with documentation and
> unit tests. The API matches the one described in R6RS Standard
> Libraries 1.2 [1]. Question
On Sun 03 Jan 2010 07:15, Julian Graham writes:
>> + }
>> + else w_str = (scm_t_uint32 *) scm_i_string_wide_chars (string);
>>
>> Indentation slightly wrong here.
>
> Huh. Looked okay in Emacs, but I've re-spaced everything -- hope
> that's cleared things up.
I think Ludovic's point was to
Hi Ludovic,
Thanks for the review!
> Looks good to me, please push!
Done.
> + }
> + else w_str = (scm_t_uint32 *) scm_i_string_wide_chars (string);
>
> Indentation slightly wrong here.
Huh. Looked okay in Emacs, but I've re-spaced everything -- hope
that's cleared things up.
Regards,
J
Hi Julian,
Julian Graham writes:
> Find attached a patch that adds C and Scheme support for the four
> Unicode string normalization forms [0], along with documentation and
> unit tests. The API matches the one described in R6RS Standard
> Libraries 1.2 [1]. Questions? Comments?
Looks good to
Hi Guilers,
Happy new year!
Find attached a patch that adds C and Scheme support for the four
Unicode string normalization forms [0], along with documentation and
unit tests. The API matches the one described in R6RS Standard
Libraries 1.2 [1]. Questions? Comments?
Regards,
Julian
[0] - htt