Re: [PATCH] Unicode general categories

2009-12-28 Thread Andy Wingo
On Thu 24 Dec 2009 18:10, Julian Graham writes: > Did we turn off warnings being errors in master? I'm used to having my > builds fail when I'm sloppy. Yes, because we want releases to not have -Werror. But we should (IMO) re-enable -Werror for non-release builds, by default. Andy -- http://wi

Re: [PATCH] Unicode general categories

2009-12-24 Thread Julian Graham
Hi Mike, > Cool.  I have two very minor and pedantic suggestions.  You say that > it will return a "one- or two-letter name".  I'm pretty sure that > this code will always return a two-letter name and not the one-letter > general category. Yes, of course you're right -- uc_general_category_name o

Re: [PATCH] Unicode general categories

2009-12-23 Thread Mike Gran
> Hi all, > > Find attached a patch that adds support for finding out the Unicode > general category [0] for a character, including documentation and unit > tests.  The API is pretty much the same as the one described in R6RS > Standard Libraries 1.1 [1].  I'll push if no one objects. Hi Julian-

[PATCH] Unicode general categories

2009-12-23 Thread Julian Graham
Hi all, Find attached a patch that adds support for finding out the Unicode general category [0] for a character, including documentation and unit tests. The API is pretty much the same as the one described in R6RS Standard Libraries 1.1 [1]. I'll push if no one objects. Regards, Julian [0] -