Re: [PATCH] New division operators, and optimization for fractions

2011-02-15 Thread Ludovic Courtès
Hi Mark, Mark H Weaver writes: > The following patch should fix it. It apparently does, thanks! http://hydra.nixos.org/jobset/gnu/guile-master Ludo’.

Re: [PATCH] New division operators, and optimization for fractions

2011-02-15 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes: > This patch series seems to break compilation on i686-linux-gnu: > > http://hydra.nixos.org/build/913079 > > The relevant part of the log is: > > Running numbers.test > FAIL: numbers.test: Number-theoretic division: truncate/: mixed types: > (130.0 10/

Re: [PATCH] New division operators, and optimization for fractions

2011-02-15 Thread Ludovic Courtès
Hi Mark, This patch series seems to break compilation on i686-linux-gnu: http://hydra.nixos.org/build/913079 The relevant part of the log is: Running numbers.test FAIL: numbers.test: Number-theoretic division: truncate/: mixed types: (130.0 10/7) FAIL: numbers.test: Number-theoretic di

Re: [PATCH] New division operators, and optimization for fractions

2011-02-14 Thread Andy Wingo
On Sun 13 Feb 2011 15:55, Mark H Weaver writes: > I have a new version of the patch set which I believe addresses all of > your (quite reasonable) concerns. The second patch changes the API of > the existing multi-valued operators as you suggest. The third optimizes > the fraction case. The fo

Re: [PATCH] New division operators, and optimization for fractions

2011-02-14 Thread Mark H Weaver
Ken Raeburn writes: > On Feb 12, 2011, at 06:55, Andy Wingo wrote: >> Regarding multiple values: instead of unpacking values objects (ugh), >> can you instead make versions of _divide that return two values >> directly, as output arguments? > > Or maybe a function returning a struct of two SCM fi

Re: [PATCH] New division operators, and optimization for fractions

2011-02-14 Thread Ken Raeburn
On Feb 12, 2011, at 06:55, Andy Wingo wrote: > Regarding multiple values: instead of unpacking values objects (ugh), > can you instead make versions of _divide that return two values > directly, as output arguments? Or maybe a function returning a struct of two SCM fields (or a single array-of-2

Re: [PATCH] New division operators, and optimization for fractions

2011-02-13 Thread Mark Weaver
hanks,     Mark --- On Sat, 2/12/11, Andy Wingo wrote: From: Andy Wingo Subject: Re: [PATCH] New division operators, and optimization for fractions To: "Mark Weaver" Cc: "Ludovic Courtès" , "guile-devel" Date: Saturday, February 12, 2011, 9:54 PM Hi Mark, On

Re: [PATCH] New division operators, and optimization for fractions

2011-02-12 Thread Andy Wingo
Hi Mark, On Sat 12 Feb 2011 22:03, Mark Weaver writes: > I really hope you decide to at least apply the first patch for 2.0. > They are very useful operators, and also they make the existing > floor/ceiling/truncate/round operators a whole lot faster when applied > to fractions. I worked very h

Re: [PATCH] New division operators, and optimization for fractions

2011-02-12 Thread Andy Wingo
Hi list, Mark Weaver writes in to say that his mail server crashed. The heavens conspire against us! I'm mailing the list and bccing Mark at his webmail (in case he is concerned about it leaking into the archives). So this mail is really to Mark. *** Very sorry t

Re: [PATCH] New division operators, and optimization for fractions

2011-02-12 Thread Andy Wingo
On Fri 11 Feb 2011 00:42, Mark H Weaver writes: > Here are three more patches. The first adds fast implementations of the > remaining number-theoretic division operators as described in Taylor > Campbell's proposal: floor/, ceiling/, truncate/, round/, as well as the > single-valued variants. T