Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-28 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Fri, 28 Feb 2014 05:20:11 -0500 > > >> > # define WIFEXITED(stat_val) (((stat_val) & 0xC000) == 0) > >> > # define WIFSIGNALED(stat_val) (((stat_val) & 0xC000) != 0) > >> > >> WIFSIGNALED(x) returns true if either o

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-28 Thread Mark H Weaver
Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: l...@gnu.org, guile-devel@gnu.org >> Date: Fri, 28 Feb 2014 02:22:19 -0500 >> >> However, I don't want to use the "0xC200 + SIGNAL" convention >> "between Guile and itself" that you've invented. Instead, based on what >> you wrote, I gue

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-28 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Fri, 28 Feb 2014 02:22:19 -0500 > > However, I don't want to use the "0xC200 + SIGNAL" convention > "between Guile and itself" that you've invented. Instead, based on what > you wrote, I guess that we should make WIFSIGNA

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-27 Thread Mark H Weaver
Hi Eli, Eli Zaretskii writes: >> The Gnulib sys_wait module says in its comments: >> >> "When an unhandled fatal signal terminates a process, >>the exit code is 3." >> >> If this is wrong, can you help me understand what they might have been >> thinking when they wrote it? > > They were

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-24 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Mon, 24 Feb 2014 13:33:56 -0500 > > >> For example, if it is true that we can avoid all the nasty problems with > >> filename encoding by using the native Windows APIs that use UTF-16 for > >> filenames, then I'd be in favor o

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-24 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Mon, 24 Feb 2014 13:33:56 -0500 > > > I don't think this matters. This convention is used between Guile and > > itself: in scm_kill we tell the process being killed to terminate with > > status of 0xC200 + SIGNAL, and the

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-24 Thread Mark H Weaver
Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: l...@gnu.org, guile-devel@gnu.org >> Date: Sun, 23 Feb 2014 00:50:16 -0500 >> >> Eli Zaretskii writes: >> >> >> Definitions for these on MinGW are available in Gnulib's 'sys_wait' >> >> module. I'll import it soon. >> > >> > Please don't:

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-23 Thread Mark H Weaver
Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: l...@gnu.org, guile-devel@gnu.org >> Date: Sat, 22 Feb 2014 23:40:20 -0500 >> >> Eli Zaretskii writes: >> >> >> It's safe to fork a multithreaded program without using pthread_atfork >> >> if only async-signal-safe functions are called befo

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-23 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Sun, 23 Feb 2014 00:50:16 -0500 > > Eli Zaretskii writes: > > >> Definitions for these on MinGW are available in Gnulib's 'sys_wait' > >> module. I'll import it soon. > > > > Please don't: that gnulib module is dead wrong f

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-23 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Sat, 22 Feb 2014 23:40:20 -0500 > > Eli Zaretskii writes: > > >> It's safe to fork a multithreaded program without using pthread_atfork > >> if only async-signal-safe functions are called before the exec. > > > > You may kno

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Mark H Weaver
Hi Eli, Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org >> Date: Sat, 22 Feb 2014 10:54:16 -0500 >> >> > diff --git a/libguile/posix.c b/libguile/posix.c >> > index 0443f95..69652a3 100644 >> > --- a/libguile/posix.c >> > +++ b/libguile/

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Mark H Weaver
Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: l...@gnu.org, guile-devel@gnu.org >> Date: Sat, 22 Feb 2014 17:02:35 -0500 >> >> Eli Zaretskii writes: >> >> >> From: Mark H Weaver >> >> Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org >> >> Date: Sat, 22 Feb 2014 10:54:16 -0500

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org, guile-devel@gnu.org > Date: Sat, 22 Feb 2014 17:02:35 -0500 > > Eli Zaretskii writes: > > >> From: Mark H Weaver > >> Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org > >> Date: Sat, 22 Feb 2014 10:54:16 -0500 > >> > >> Thanks for working on

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Mark H Weaver
Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org >> Date: Sat, 22 Feb 2014 10:54:16 -0500 >> >> Thanks for working on this, but in a multithreaded program, it's no good >> to change the file descriptors in the main program temporarily befo

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org > Date: Sat, 22 Feb 2014 10:54:16 -0500 > > Thanks for working on this, but in a multithreaded program, it's no good > to change the file descriptors in the main program temporarily before > spawning, and then restor

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org > Date: Sat, 22 Feb 2014 10:54:16 -0500 > > > diff --git a/libguile/posix.c b/libguile/posix.c > > index 0443f95..69652a3 100644 > > --- a/libguile/posix.c > > +++ b/libguile/posix.c > > @@ -85,6 +85,27 @@ > > #if H

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Mark H Weaver
Hi Eli, My last response to this was not finished yet. Please disregard it. (C-c C-c is bound to 'diff-goto-source' in diff-mode, which is what I meant to do :-) Eli Zaretskii writes: > This patch allows the MinGW build of Guile to have the process related > functions (open-process, kill, wait

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org > Date: Sat, 22 Feb 2014 09:59:39 -0500 > > Eli Zaretskii writes: > > > This patch allows the MinGW build of Guile to have the process related > > functions (open-process, kill, waitpid, status:exit-val, etc.). > >

Re: [PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Mark H Weaver
Eli Zaretskii writes: > This patch allows the MinGW build of Guile to have the process related > functions (open-process, kill, waitpid, status:exit-val, etc.). > > Implement open-process and related functions on MinGW > > * libguile/filesys.c (fsync, link) [__MINGW32__]: Redirect Posix > funct

[PATCH] Implement open-process and related functions on MinGW

2014-02-22 Thread Eli Zaretskii
This patch allows the MinGW build of Guile to have the process related functions (open-process, kill, waitpid, status:exit-val, etc.). Implement open-process and related functions on MinGW * libguile/filesys.c (fsync, link) [__MINGW32__]: Redirect Posix functions to their Windows equivalents.