Re: [PATCH] Have string ports honor ‘%default- port-encoding’

2010-01-07 Thread Ludovic Courtès
Hi, Mike Gran writes: >> The (undocumented) ‘scm_to_stringn ()’ returns the number of characters, >> AFAICS. > > I'll try to get a doc patch in this weekend. As a start, I added a small description in the source: http://git.savannah.gnu.org/cgit/guile.git/commit/?id=29bcdbb05948a5f12d2d8cb3

Re: [PATCH] Have string ports honor ‘% default-port-encoding’

2010-01-05 Thread Mike Gran
> Ludo sez: > The (undocumented) ‘scm_to_stringn ()’ returns the number of characters, > AFAICS. I'll try to get a doc patch in this weekend. The second parameter to scm_to_stringn gets filled with the result buffer length from either mem_iconveh or u32_conv_to_encoding, so it is definitely the

Re: [PATCH] Have string ports honor ‘%default- port-encoding’

2010-01-05 Thread Ludovic Courtès
Hello, Mike Gran writes: > When you write... > > +  /* Create a copy of STR in the encoding of Z.  */ > +  buf = scm_to_stringn (str, &str_len, pt->encoding, > +            SCM_FAILED_CONVERSION_ERROR); > +  /* FIXME: strdup doesn't do the right thing if BUF contains zeros, but we > +    don't k

Re: [PATCH] Have string ports honor ‘% default-port-encoding’

2010-01-04 Thread Mike Gran
> From: Ludovic Courtès > > Hello, > > The attached patch fixes string ports so that their encoding defaults to > ‘%default-port-encoding’ (as for other ports) instead of UTF-8. > > Mike: can you review it? Hi Ludovic, It is a bit hard for me to review this as I don't have access to my machi