Re: [PATCH] GC code cleanup

2006-10-16 Thread Ludovic Courtès
Hi, Kevin Ryde <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Ludovic Courtès) writes: >> >> It also fixes (unless I'm mistaken!) the computation of the number of >> cells swept/collected in `scm_i_sweep_some_cards ()'. > > I didn't really look at this change ... is it an actual bug fix? You >

Re: [PATCH] GC code cleanup

2006-10-11 Thread Kevin Ryde
[EMAIL PROTECTED] (Ludovic Courtès) writes: > > It also fixes (unless I'm mistaken!) the computation of the number of > cells swept/collected in `scm_i_sweep_some_cards ()'. I didn't really look at this change ... is it an actual bug fix? You could think about it for the 1.8 branch if so. _

[Ludovic Courtès] Re: [PATCH] GC code cleanup #2

2006-02-13 Thread Ludovic Courtès
Hello, I'm resending the GC-cleanup patch in a hopefully more readable form. Han-Wen: let me know if it's alright. Thanks, Ludovic. --- Begin Message --- Hi, [EMAIL PROTECTED] (Han-Wen Nienhuys) writes: >> void >>-scm_i_adjust_min_yield (scm_t_cell_type_statistics *freelist) >>+scm_i_adjust_mi

Re: [PATCH] GC code cleanup #2

2006-02-10 Thread Han-Wen Nienhuys
In article <[EMAIL PROTECTED]>, Ludovic Courtès <[EMAIL PROTECTED]> wrote: >Hi, > >[EMAIL PROTECTED] (Han-Wen Nienhuys) writes: > >> Looks OK, but I can't apply - I get =20 at line endings once more. > >I don't understand exactly what's happening. I read through gmane which reformats things. >Bas

Re: [PATCH] GC code cleanup #2

2006-02-10 Thread Ludovic Courtès
Hi, [EMAIL PROTECTED] (Han-Wen Nienhuys) writes: > Looks OK, but I can't apply - I get =20 at line endings once more. I don't understand exactly what's happening. Basically, if you copy/paste the patch from within your mail client or from the archive[0], that should be fine. (Remember to update

Re: [PATCH] GC code cleanup #2

2006-02-09 Thread Han-Wen Nienhuys
In article <[EMAIL PROTECTED]>, Ludovic Courtès <[EMAIL PROTECTED]> wrote: > >Please, can somebody review this patch? Looks OK, but I can't apply - I get =20 at line endings once more. ___ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu

Re: [PATCH] GC code cleanup #2

2006-02-09 Thread Ludovic Courtès
Hi folks, [EMAIL PROTECTED] (Ludovic Courtès) writes: > 2006-01-04 Ludovic Courtès <[EMAIL PROTECTED]> > > * libguile/gc-segment.c (scm_i_sweep_some_cards): Take a SWEEP_STATS > argument. Don't refer to SCM_GC_CELLS_COLLECTED and > SCM_CELLS_ALLOCATED. If SEG->FIRST_TIME, le

Re: [PATCH] GC code cleanup #2

2006-01-30 Thread Ludovic Courtès
Hi, [EMAIL PROTECTED] (Ludovic Courtès) writes: > 2006-01-04 Ludovic Courtès <[EMAIL PROTECTED]> > > * libguile/gc-segment.c (scm_i_sweep_some_cards): Take a SWEEP_STATS > argument. Don't refer to SCM_GC_CELLS_COLLECTED and > SCM_CELLS_ALLOCATED. If SEG->FIRST_TIME, let CELL

Re: [PATCH] GC code cleanup #2

2006-01-04 Thread Ludovic Courtès
Hi, [EMAIL PROTECTED] (Han-Wen Nienhuys) writes: >> void >>-scm_i_adjust_min_yield (scm_t_cell_type_statistics *freelist) >>+scm_i_adjust_min_yield (scm_t_cell_type_statistics *freelist, >>+ unsigned cells_collected, >>+ unsigned cells_swept) > > you're pas

Re: [PATCH] GC code cleanup

2005-12-23 Thread Han-Wen Nienhuys
In article <[EMAIL PROTECTED]>, Ludovic Courtès <[EMAIL PROTECTED]> wrote: >Hi, > >The patch below is an attempt to clean up the GC by limiting the use of >global variables for statistics. IMO it makes it easier to read the >code. Furthermore, it's also easier to track the exact number of cells >

[PATCH] GC code cleanup

2005-12-20 Thread Ludovic Courtès
Hi, The patch below is an attempt to clean up the GC by limiting the use of global variables for statistics. IMO it makes it easier to read the code. Furthermore, it's also easier to track the exact number of cells swept/collected at each stage. It also fixes (unless I'm mistaken!) the computat