Re: [PATCH] Fix error messages involving internal definitions

2012-01-27 Thread Mark H Weaver
Andy Wingo writes: >> Thirdly, "definition in expression context" is a confusing message for >> Scheme beginners, who are likely to make this mistake. > > The problem is that I'm not sure that the error message you suggest is > correct. You show: > >> (let ((x 1)) >> #f >> (define blah

Re: [PATCH] Fix error messages involving internal definitions

2012-01-27 Thread Andy Wingo
Hi Mark! Thanks for tracking down this issue. I'm sure it will make it in 2.0.4, but I do have a couple questions. On Fri 27 Jan 2012 08:26, Mark H Weaver writes: > So, what does this fix? The "definition in expression context" error > message is broken in several ways. First of all, source

Re: [PATCH] Fix error messages involving internal definitions

2012-01-26 Thread Mark H Weaver
I wrote: > So, what does this fix? The "definition in expression context" error > message is broken in several ways. First of all, source location > information is _never_ provided, [...] Sorry, I meant to say "is _never_ provided if the rhs expression is an atom". Mark

[PATCH] Fix error messages involving internal definitions

2012-01-26 Thread Mark H Weaver
definitions are not allowed in form (define blah 3) Okay, here's the patch, with the syntax-pp.scm portion removed. Mark >From 278aed1c13ba183458a9e4cd6ec66df1dadf98c9 Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Thu, 26 Jan 2012 23:55:24 -0500 Subject: [PATCH] Fix error me