Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-31 Thread Mark H Weaver
Andy Wingo writes: > I did apply it, but it made the test cases start to fail, because > numbers.test is loaded after ecmascript.test, and: > > scheme@(guile-user)> ,L ecmascript > Happy hacking with ECMAScript! To switch back, type `,L scheme'. > ecmascript@(guile-user)> true * true;

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-31 Thread Andy Wingo
On Mon 31 Jan 2011 21:30, Mark H Weaver writes: > Andy Wingo writes: >> I did apply it, but it made the test cases start to fail, because >> numbers.test is loaded after ecmascript.test, and: >> >> scheme@(guile-user)> ,L ecmascript >> Happy hacking with ECMAScript! To switch back, type

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-31 Thread Mark H Weaver
Andy Wingo writes: > I did apply it, but it made the test cases start to fail, because > numbers.test is loaded after ecmascript.test, and: > > scheme@(guile-user)> ,L ecmascript > Happy hacking with ECMAScript! To switch back, type `,L scheme'. > ecmascript@(guile-user)> true * true;

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-31 Thread Andy Wingo
On Mon 31 Jan 2011 18:35, Mark H Weaver writes: > Andy Wingo writes: >>> The last patch might be slightly controversial. Although it does not >>> make `integer-expt' a generic function, nonetheless it can now >>> exponentiate _any_ scheme object that can be multiplied using `*'. >> >> To me thi

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-31 Thread Andy Wingo
On Mon 31 Jan 2011 18:35, Mark H Weaver writes: > Andy Wingo writes: >>> The last patch might be slightly controversial. Although it does not >>> make `integer-expt' a generic function, nonetheless it can now >>> exponentiate _any_ scheme object that can be multiplied using `*'. >> >> To me thi

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-31 Thread Mark H Weaver
Andy Wingo writes: >> The last patch might be slightly controversial. Although it does not >> make `integer-expt' a generic function, nonetheless it can now >> exponentiate _any_ scheme object that can be multiplied using `*'. > > To me this is fine, in principle; but I wonder about causing `(exp

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-31 Thread Mark H Weaver
Andy Wingo writes: > If you have time though, I wonder would scm_centered_divide be a better > name than scm_centered_quo_and_rem? "Divide" is the pronunciation of > the "/" procedure, I think. Agreed, here's a patch. Mark >From b5441b4fc27ee4c9686c69307369d24f7cacd660 Mon Sep 17 00:00:

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-30 Thread Ludovic Courtès
Hello! Thanks for working on this! There are related test failures on i686-linux-gnu: http://hydra.nixos.org/build/875025 You can see the log and browse the build tree from there. (I don’t want to be offensive, it’s just that I just feel a bit of pressure with this release thing. ;-)) Ludo

Re: [PATCH] Fast R6RS div/mod; improved extensibility of numerics

2011-01-30 Thread Andy Wingo
On Sun 30 Jan 2011 17:27, Mark H Weaver writes: > Here are another four patches of numerics improvements. Applied all up to the last. Sweet! And thank you! > The other three I named `centered/', `centered-quotient', and > `centered-remainder', because the range of their remainder operation is