his would take way too long for me, so I'll leave this up to
another contributor in the future. Would be a great first contribution!
> The rest looks great to me!
>
> Could you send an updated patch?
I've attached the updated patch.
~ Vijay
>From 0b1b46123a62c2c65dd58805592d4
rom 42206dec4d5e9ae51665c6e98ef07715b89b12fe Mon Sep 17 00:00:00 2001
> From: Vijay Marupudi
> Date: Tue, 18 Jan 2022 20:52:08 -0500
> Subject: [PATCH] Added srfi-214: flexvectors
>
> Included code, documentation, and tests
Please use the ChangeLog style for commit messages (see ‘git log’ for
examples);
Hello guile-devel,
Looking for a review and merge of this patch if possible!
~ Vijay
Vijay Marupudi schreef op do 20-01-2022 om 12:57 [-0500]:
> > Here are two examples in the wild (slib):
>
> Thanks, the patch, which is attached, now attributes credit
> appropriately.
>
> Thank you very much for your help Maxime. I believe there is nothing
> else pending and that the patch is re
> I haven't really looked closely at the documentation or code,
> but the structure of the patch seems fine now
That's good to hear, awaiting code review then!
> , except perhaps:
>
>> "Software"), to deal in the Software without restriction, including
>
> Unicode has been a thing now since quite
Vijay Marupudi schreef op do 20-01-2022 om 10:34 [-0500]:
> My latest patch now has documentation, mostly derived from the SRFI-
> 214
> documentation. Who would have figured that conversion to texinfo
> would be the
> most time consuming part of this patch?
>
> I would like advice on how to attri
ed by the maintainer,
> not the contributor.
Sounds good.
Attached is the latest version of the patch.
~ Vijay
>From b55a1e2295013ba6a9e0a1a98d188c17a0fd7058 Mon Sep 17 00:00:00 2001
From: Vijay Marupudi
Date: Tue, 18 Jan 2022 20:52:08 -0500
Subject: [PATCH] Added srfi-2
on Sep 17 00:00:00 2001
From: Vijay Marupudi
Date: Tue, 18 Jan 2022 20:52:08 -0500
Subject: [PATCH] Added srfi-214: flexvectors
Included code, documentation, and tests
---
doc/ref/api-data.texi | 842 -
doc/ref/srfi-modules.texi | 6 +
module/Makef
82a3191a19e1090e485a080834af5adce97 Mon Sep 17 00:00:00 2001
From: Vijay Marupudi
Date: Tue, 18 Jan 2022 20:52:08 -0500
Subject: [PATCH] Added srfi-214: flexvectors
---
module/Makefile.am | 1 +
module/srfi/srfi-214.scm | 735 +
test-suite/M
Vijay Marupudi schreef op wo 19-01-2022 om 10:44 [-0500]:
> > If no copyright assignment has happend, then the copyright still
> > belongs to the author
> > -- from the Git repository's LICENSE: Copyright © Adam Nelson
> > (2020)).
> > While possibly you might have made some small changes to
> > f
Vijay Marupudi schreef op wo 19-01-2022 om 08:51 [-0500]:
> > however, the README says ‘by Adam Nelson’. Did you reach some kind
> > of
> > agreement with Adam Nelson about copyright assignment? And since
> > SRFIs
> > are licensed under Expat (not 100% sure), wouldn't this need to be
> > the
> >
lson/scheme-flexvectors/blob/master/LICENSE>
I have attached the updated patch.
~ Vijay
>From ec49b052809bbe44ee47765db0dd887313702dcc Mon Sep 17 00:00:00 2001
From: Vijay Marupudi
Date: Tue, 18 Jan 2022 20:52:08 -0500
Subject: [PATCH] Added srfi-214: flexvecto
Vijay Marupudi schreef op di 18-01-2022 om 21:34 [-0500]:
> Hello,
>
> I have attached to this email a patch to add support for srfi-214,
> flexvectors.
>
> I have made as few changes to the code from the sample implementation.
>
> If this is accepted, I can work on adding to the documentation.
.
~ Vijay
>From f52164919a50600960aad2df323a3a3f51cf1427 Mon Sep 17 00:00:00 2001
From: Vijay Marupudi
Date: Tue, 18 Jan 2022 20:52:08 -0500
Subject: [PATCH] Added srfi-214: flexvectors
---
module/Makefile.am | 1 +
module/srfi/srfi-214.scm | 730 +++
14 matches
Mail list logo
