On Sun 31 Mar 2013 21:44, Mark H Weaver writes:
> + {
> +GC_finalization_proc prev_finalizer;
> +GC_PTR prev_finalization_data;
> +
> +/* Register a finalizer to close the descriptors. */
> +GC_REGISTER_FINALIZER_NO_ORDER (id, finalize_iconv_descriptors, 0,
> +
Mark H Weaver skribis:
> Andy Wingo writes:
>> Can you take a look at porting
>> 6c98257f2ead0855f218369ea7f9a823cdb9727e?
>
> Okay, here's an updated patch set that's essentially a backport of that
> commit from master, but with 'encoding_mode' and 'iconv_descriptors' put
> in the internal-only
Andy Wingo writes:
> Can you take a look at porting
> 6c98257f2ead0855f218369ea7f9a823cdb9727e?
Okay, here's an updated patch set that's essentially a backport of that
commit from master, but with 'encoding_mode' and 'iconv_descriptors' put
in the internal-only port structure.
What do you think?
Hi Andy,
Thanks for the quick review. I agree with you on all points.
I'll work on a new patch that's more harmonious with master.
Regards,
Mark
Hi,
On Wed 27 Mar 2013 21:00, Mark H Weaver writes:
> index 8737a76..45e770d 100644
> --- a/libguile/ports.c
> +++ b/libguile/ports.c
> @@ -60,6 +60,8 @@
> #include "libguile/fluids.h"
> #include "libguile/eq.h"
>
> +#include "libguile/private-ports.h"
> +
> #ifdef HAVE_STRING_H
> #include
Hi!
Mark H Weaver skribis:
> Here's a patch to add a private port structure. I moved both input_cd
> and output_cd there. I plan to create more patches on top of this very
> soon (BOM handling, more efficient per-port read options, maybe better
> EOF handling), so a prompt review would be very
Hello all,
Here's a patch to add a private port structure. I moved both input_cd
and output_cd there. I plan to create more patches on top of this very
soon (BOM handling, more efficient per-port read options, maybe better
EOF handling), so a prompt review would be very helpful.
What do you thi
