Re: patch to check for GNU flex

2010-11-19 Thread Ramakrishnan Muthukrishnan
On Sat, Nov 20, 2010 at 4:09 AM, Ludovic Courtès wrote: > Hi! > > Flex is only needed when building from Git, not when building from a > tarball, which is why ‘configure’ doesn’t check for it.  (And Flex is Oh.. ok. Didn't know that. > not GNU, BTW.  ;-)) Didn't know that too! Thanks. :-) --

patch to check for GNU flex

2010-11-19 Thread Ramakrishnan Muthukrishnan
Hi, configure currently is not checking for the presence of flex, but it is being used inside libguile/Makefile. The attached patch fixes this. thanks --   Ramakrishnan From 3c4b6f8165e785f602e576a51f645f463f01c836 Mon Sep 17 00:00:00 2001 From: Ramakrishnan Muthukrishnan Date: Fri, 19 Nov

Re: fix for expt bug

2010-11-03 Thread Ramakrishnan Muthukrishnan
On Wed, Nov 3, 2010 at 11:23 PM, Ramakrishnan Muthukrishnan wrote: > On Wed, Nov 3, 2010 at 9:52 PM, Mark H Weaver wrote: >> Ramakrishnan and others, >> >> I just realized that there is a better way to fix these bugs.  We don't >> need a new top-level case

Re: fix for expt bug

2010-11-03 Thread Ramakrishnan Muthukrishnan
On Wed, Nov 3, 2010 at 9:52 PM, Mark H Weaver wrote: > Ramakrishnan and others, > > I just realized that there is a better way to fix these bugs.  We don't > need a new top-level case in expt after all.  Instead, we generalize the > scm_integer_expt case to support inexact integer exponents. > > W

Re: fix for expt bug

2010-11-03 Thread Ramakrishnan Muthukrishnan
Ramakrishnan From 6cca8a66a3daedb551f4f80170966d74b6143ba6 Mon Sep 17 00:00:00 2001 From: Ramakrishnan Muthukrishnan Date: Sun, 31 Oct 2010 23:22:52 +0530 Subject: [PATCH] Adding a case for `expt' when base is negative. * libguile/numbers.c (scm_expt): Add a case when base is a negative number. Also fix the bug for the c

Re: fix for expt bug

2010-11-03 Thread Ramakrishnan Muthukrishnan
Thanks again, Mark and Ludovic. Attached is an updated patch. thanks --   Ramakrishnan From a1dd2da8562ddeb2052f2994ad0302bcc8d5d1a2 Mon Sep 17 00:00:00 2001 From: Ramakrishnan Muthukrishnan Date: Sun, 31 Oct 2010 23:22:52 +0530 Subject: [PATCH] Adding a case for `expt' when base is neg

Re: fix for expt bug

2010-11-01 Thread Ramakrishnan Muthukrishnan
Here is the updated patch. thanks Ramakrishnan From e320d79c8f3cd8b7ddcb9c2d13356e34a3346cfe Mon Sep 17 00:00:00 2001 From: Ramakrishnan Muthukrishnan Date: Sun, 31 Oct 2010 23:22:52 +0530 Subject: [PATCH] Fix for bug #31464. expt needs to treat negative bases specially. * libguile/numbers.c

Re: fix for expt bug

2010-11-01 Thread Ramakrishnan Muthukrishnan
On Tue, Nov 2, 2010 at 10:25 AM, Mark H Weaver wrote: > Hi Ramakrishnan, > > Thanks for the revised patch.  There are still some problems: > [...] > > This is an improvement, but isn't quite right.  scm_integer_expt > requires that y be an exact integer, but x is allowed to be any scheme > number

Re: fix for expt bug

2010-11-01 Thread Ramakrishnan Muthukrishnan
aster. The patch fixes this too.) Also adds some test cases. Please review. Thanks Ramakrishnan From 025bde78d4c199dee1d2857e913d69ce4d7c2e59 Mon Sep 17 00:00:00 2001 From: Ramakrishnan Muthukrishnan Date: Sun, 31 Oct 2010 23:22:52 +0530 Subject: [PATCH] Fix for bug #31464. expt needs to

Re: fix for expt bug

2010-10-31 Thread Ramakrishnan Muthukrishnan
On Mon, Nov 1, 2010 at 5:33 AM, Mark H Weaver wrote: > Ramakrishnan, > > Your fix is incorrect.  You have assumed that (-a)^b = -(a^b), Mark, Yes, you are right. Not sure what I was thinking when I made the patch. :-( > The reported bug is simply due to roundoff error.  You must know > somethin

fix for expt bug

2010-10-31 Thread Ramakrishnan Muthukrishnan
:00:00 2001 From: Ramakrishnan Muthukrishnan Date: Sun, 31 Oct 2010 23:22:52 +0530 Subject: [PATCH] Fix for bug #31464. expt needs to treat negative bases specially. Also adding test-suite cases for expt. * libguile/numbers.c: if base is negative, find the absolute value of the base, find l