Hi Adam,
> On 12/16/24 00:57, Ricardo Wurmus wrote:
>> Hi Adam,
>>
>> has this patch been discussed somewhere else? I'm asking because I have
>> no context other than this patch.
>
> No, actually. Was I supposed to discuss it's use in the patch cover letter?
No, there is no requirement to do so
Hi Adam!
For string manipulation, the proper encoding has to be considered. It's
better to use the provided [#:guess-encoding=#f] [#:encoding=#f] as well.
You may take a look at call-with-input-file in document:
https://www.gnu.org/software/guile/manual/html_node/File-Ports.html
BTW, in your case,
>From c8a9904f1b1c09d148de1ec23dc2eb0d433b3141 Mon Sep 17 00:00:00 2001
From: AwesomeAdam54321
Date: Sun, 15 Dec 2024 23:48:30 +0800
Subject: [PATCH v2] rdelim: Add new procedure `for-line-in-file`.
* module/ice-9/rdelim.scm (for-line-in-file): Add it.
This procedure makes it convenient to do pe
Hi Adam!
I was confused with the name "file" here since it acts more like a port
rather than a filename. If it's expected to be a opened port passed from
the caller, it's better rename to "port".
In your context, I think you want to check if it's the end of file, so you
may use eof-object?
To mak
>From 3c7e1af1f4812d0e4c5d10e841cf9546e5ba2887 Mon Sep 17 00:00:00 2001
From: AwesomeAdam54321
Date: Sun, 15 Dec 2024 23:48:30 +0800
Subject: [PATCH v1] rdelim: Add new procedure `for-line-in-file`.
* module/ice-9/rdelim.scm (for-line-in-file): Add it.
This procedure makes it convenient to do pe
Hi Ricardo,
On 12/16/24 00:57, Ricardo Wurmus wrote:
> Hi Adam,
>
> has this patch been discussed somewhere else? I'm asking because I have
> no context other than this patch.
No, actually. Was I supposed to discuss it's use in the patch cover letter?
The reason I sent this patch was to make i
>Where is BREAK defined?
Break is defined by ‘while’:
https://www.gnu.org/software/guile/manual/html_node/while-do.html
Hi Adam,
has this patch been discussed somewhere else? I'm asking because I have
no context other than this patch.
> From 18485a2b94595ae2239f5dcdeb06d3a80bb04bf1 Mon Sep 17 00:00:00 2001
> From: AwesomeAdam54321
> Date: Sun, 15 Dec 2024 23:48:30 +0800
> Subject: [PATCH] rdelim: Add new procedu
>From 18485a2b94595ae2239f5dcdeb06d3a80bb04bf1 Mon Sep 17 00:00:00 2001
From: AwesomeAdam54321
Date: Sun, 15 Dec 2024 23:48:30 +0800
Subject: [PATCH] rdelim: Add new procedure `for-line-in-file`.
* module/ice-9/rdelim.scm (for-line-in-file): Add it.
---
module/ice-9/rdelim.scm | 12
