Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-03-19 Thread Rob Browning
Denis 'GNUtoo' Carikli writes: > Would something like that be OK instead?: Not sure I understand the question. Were you asking if that'd be OK elsewhere in the function too? > However here (char=? ch #\:) can fail if ch is an eof-object. Apologies for the delay, and good point. I should have

[PATCH v2] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-03-19 Thread Denis 'GNUtoo' Carikli
* module/srfi/srfi-19.scm (zone-reader): handle a colon in the zone. * test-suite/tests/srfi-19.test (SRFI date/time library test): Add test. Signed-off-by: Denis 'GNUtoo' Carikli --- ChangeLog v1->v2: - Improved error message to be more meaningful. - Removed duplicated code: in the v1, the read

Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-03-19 Thread Denis 'GNUtoo' Carikli
On Mon, 11 Mar 2024 19:25:08 +0100 Denis 'GNUtoo' Carikli wrote: > Also note that I didn't test the code above yet. I tested the code afterward and it passes all the tests. I'll send a v2 in case that makes review easier. Denis. pgp3X68eFC1AE.pgp Description: OpenPGP digital signature