Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

2022-10-12 Thread Andrew Whatson
Ludovic Courtès wrote: > > It would be great if you could add a simple test case though, so that > the bug doesn’t eventually come back to haunt us. > > Could you send an updated patch? Ah yes, getting this covered in a test is on my list. I had trouble writing a reproducer previously, I think t

Re: [PATCH v2] Add tests for warning locations.

2022-10-12 Thread Andrew Whatson
Ludovic Courtès wrote: > > One minor nitpick and then we’re ready to go: > > > + (with-test-prefix "location" > > + (define (test-file filename) > > + (string-append > > +(dirname (current-filename)) "/" filename)) > > + > > + (pass-if "unused variable" > > + (let ((w

[PATCH v3] Add tests for warning locations.

2022-10-12 Thread Andrew Whatson
These would have caught . * test-suite/tests/tree-il.test ("warnings")("location")["unused variable", "unbound variable (spaces)", "unbound variable (tabs)"]: New tests. --- test-suite/tests/tree-il.test | 48 ++- 1 file changed, 47 inse

Re: Modernizing autotools and assuming C89 C library

2022-10-12 Thread Dr. Arne Babenhauserheide
Ludovic Courtès writes: > Hi Mike, > > Mike Gran skribis: > >> On Thu, Sep 15, 2022 at 10:20:26PM -0700, Mike Gran wrote: >>> I pushed a git branch: wip-modernize-autotools. >>> >>> It removes some obsolete tests by presuming we at least have a >>> C89-compliant C library. It also uses LT_INIT

Re: map-par slower than map

2022-10-12 Thread Developers list for Guile, the GNU extensibility library
On Wed, 12 Oct 2022, Damien Mattei wrote: > Hello, > all is in the title, i test on a approximately 3 element list , i got > 9s with map and 3min 30s with par-map on exactly the same piece of > code!? I can only speculate here. But trying with a very simple example here: --8<---c

Re: map-par slower than map

2022-10-12 Thread Maxime Devos
On 12-10-2022 22:20, Damien Mattei wrote: Mutex? i do not think code has situation where dead lock could happen, it is a code about minimalising logic expressions, it uses minterms , minterms set is a set of minterms :like this: I didn't mean deadlocks, I just meant a single mutex being take

Re: map-par slower than map

2022-10-12 Thread Zelphir Kaltstahl
Hi! On 10/12/22 22:27, Damien Mattei wrote: https://github.com/damien-mattei/library-FunctProg/blob/master/guile/logiki%2B.scm#L1674 i commited the current version of code here with all files but it is huge :-/ On Wed, Oct 12, 2022 at 10:20 PM Damien Mattei wrote: Mutex? i do not think

Re: Send scheme procedure as callback to foreign thread.

2022-10-12 Thread Ludovic Courtès
Hi, Zhu Zihao skribis: > In Guile FFI programming, we have procedure->pointer, which makes a > Scheme procedure a foreign callback. And foreign library call use this > callback. > > However, if this callback is called in a another foreign thread. The scheme > context is not properly setup, It ma

Re: bug#58109: simple-format vs (ice-9 format) bug in 3.0.7?

2022-10-12 Thread Ludovic Courtès
Hi, Jean Abou Samra skribis: > OK, understood. How about adding comments and documentation? That’s a good idea. Applied with minor tweaks and a commit log. Thanks! Ludo’.

Re: [PATCH v2] Add tests for warning locations.

2022-10-12 Thread Ludovic Courtès
Hi, Andrew Whatson skribis: > These would have caught . > > * test-suite/Makefile.am (SCM_TESTS): Add sample code files. > * test-suite/tests/tree-il.test ("warnings"): New tests. > * test-suite/tests/tree-il/unbound-spaces.scm: > * test-suite/tests/tree-il/unbound-ta

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

2022-10-12 Thread Ludovic Courtès
Hi Andrew, Andrew Whatson skribis: > Workaround for . > > * module/system/vm/frame.scm (frame-call-representation): Treat a > binding as "unspecified" if its slot exceeds 'frame-num-locals'. Yay, great to see that fixed (or almost)! It would be great if you could ad

Re: [PATCH v3] Define SO_RCVTIMEO and SO_SNDTIMEO.

2022-10-12 Thread Ludovic Courtès
Hi, Christopher Baines skribis: > These are important for reliable networking, since they prevent network > operations from hanging indefinitely. > > * libguile/socket.c (scm_init_socket): Define SO_RCVTIMEO and > SO_SNDTIMEO. > (scm_getsockopt, scm_setsockopt): Include SO_RCVTIMEO and SO_SNDTIM

Re: map-par slower than map

2022-10-12 Thread Damien Mattei
https://github.com/damien-mattei/library-FunctProg/blob/master/guile/logiki%2B.scm#L1674 i commited the current version of code here with all files but it is huge :-/ On Wed, Oct 12, 2022 at 10:20 PM Damien Mattei wrote: > Mutex? i do not think code has situation where dead lock could happe

Re: Modernizing autotools and assuming C89 C library

2022-10-12 Thread Ludovic Courtès
Hi Mike, Mike Gran skribis: > On Thu, Sep 15, 2022 at 10:20:26PM -0700, Mike Gran wrote: >> Hello Guile Devel, >> >> I pushed a git branch: wip-modernize-autotools. >> >> It removes some obsolete tests by presuming we at least have a >> C89-compliant C library. It also uses LT_INIT for libtool

Re: map-par slower than map

2022-10-12 Thread Damien Mattei
Mutex? i do not think code has situation where dead lock could happen, it is a code about minimalising logic expressions, it uses minterms , minterms set is a set of minterms :like this: example: ((1 1 0) (1 1 1)) will be unified : (1 1 x) because 0 and 1 are replaced by x the minterms-set could h

Re: guile.scheme.org

2022-10-12 Thread Ludovic Courtès
Hi, Lassi Kortela skribis: > With the permission of the Guile maintainers, could we add > guile.scheme.org redirecting to https://www.gnu.org/software/guile/ > (or any other URL of your choice)? I’m (very) late to the party but that sounds like a good idea! Thank you, Ludo’.

Re: [DRAFT] Improve reporting of exception locations

2022-10-12 Thread Maxime Devos
On 12-10-2022 08:35, Andrew Whatson wrote: Hello guile-dev! I'm working on a revised patch to improve the reporting of exception locations, after last month's initial flawed attempt. The new patch takes the more radical approach of capturing the stack when an exception is created, AFAICT, i

Re: map-par slower than map

2022-10-12 Thread Maxime Devos
On 12-10-2022 19:19, Damien Mattei wrote: Hello, all is in the title, i test on a approximately 3 element list , i got 9s with map and 3min 30s with par-map on exactly the same piece of code!? > [...] > translated from Scheme+ to Scheme: (define unified-minterms-set-1 (map function-unify-m

map-par slower than map

2022-10-12 Thread Damien Mattei
Hello, all is in the title, i test on a approximately 3 element list , i got 9s with map and 3min 30s with par-map on exactly the same piece of code!? what i change in code is in comments: {unified-minterms-set-1 <+ (map function-unify-minterms-list minterms-set)} ;;(par-map function-unify-min

Re: Make the pkgconfig file of Guile relocatable.

2022-10-12 Thread Ludovic Courtès
Hi, Zhu Zihao skribis: > My idea is change the definition of sitedir, siteccachedir, extensiondir > use the variable substition of pkg-config instead of autotools. > > For example > > sitedir=${datadir}/guile/site/@GUILE_EFFECTIVE_VERSION@ > siteccachedir=${libdir}/guile/@GUILE_EFFECTIVE_VERSION

Re: [PATCH] Added srfi-214: flexvectors

2022-10-12 Thread Ludovic Courtès
The following message is a courtesy copy of an article that has been posted to gmane.lisp.guile.devel as well. Hi Vijay, Sorry for the looong delay! Overall the patches look great to me. Below are comments and suggestions, mostly cosmetic. Vijay Marupudi skribis: > From 42206dec4d5e9ae51665c