Hello,
Attached.
Note that the fix might be 'too strong': GUILE_PROG[2.x] will accept Guile 3.x
versions ... I'm not sure about this :) feel free to update this patch in case
we
don't want that...
Cheers,
David
From 2d1593a6f9c7fc5f1636f9695e8685fcc6334cfd Mon Sep 17 00:00:00 2001
From: David P
Andy Wingo writes:
> On Thu 23 Jun 2016 18:57, Mark H Weaver writes:
>
>> Andy Wingo writes:
>>> Or, we could use print states. But print states are not so great and
>>> ideally we would remove them eventually.
>>
>> We will need print states, or something like them, to support writing
>> cycl
Hello Andy,
> > Note that make check leaves the following toplevel file [a symlink to
> > itself]
> > behind:
> >
> > filesys-test-link.tmp
> I have seen this and I don't know why this is, and I would prefer to fix
> it rather than ignoring it.
Ok, as I said I did not look at the test-sui
Hello Andy,
> > diff --git a/.gitignore b/.gitignore
> > index 3deeab2..bce9756 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -13,6 +13,7 @@ config.status
> > config.log
> > config.h
> > *.doc
> > +*.html
> > *.x
> > *.lo
> > *.la
> Can you make it more specific please? I.e. do
> I dunno how much we should push this "processes are a single port"
> abstraction. In many ways for OPEN_BOTH pipes it's easier to deal with
> an input and an output port and a PID instead of the pipe abstraction.
> WDYT? We could just expose `open-process' from (ice-9 popen) to start
> with. I
On Sat 25 Jun 2016 15:51, Josep Portella Florit writes:
>> I dunno how much we should push this "processes are a single port"
>> abstraction. In many ways for OPEN_BOTH pipes it's easier to deal with
>> an input and an output port and a PID instead of the pipe abstraction.
>> WDYT? We could jus
> From: Andy Wingo
> Cc: l...@gnu.org (Ludovic Courtès), guile-devel@gnu.org
> Date: Sat, 25 Jun 2016 16:43:34 +0200
>
> > @@ -659,7 +663,7 @@ SCM_DEFINE (scm_kill, "kill", 2, 0, 0,
> > #else
> >/* Mingw has raise(), but not kill(). (Other raw DOS environments might
> > be similar.)
On Sat 25 Jun 2016 15:31, Eli Zaretskii writes:
> [Please disregard the previous patch and use this one instead.]
Thanks for the updates. I have a couple of additional nits, having
applied and built the patch.
> @@ -659,7 +663,7 @@ SCM_DEFINE (scm_kill, "kill", 2, 0, 0,
> #else
>/* Mingw
[Please disregard the previous patch and use this one instead.]
> From: l...@gnu.org (Ludovic Courtès)
> Cc: Andy Wingo , guile-devel@gnu.org
> Date: Sat, 25 Jun 2016 15:02:42 +0200
>
> >> Great! I have two nits. One, if it is possible for you, please attach
> >> the patch in the format that "
> From: l...@gnu.org (Ludovic Courtès)
> Cc: Andy Wingo , guile-devel@gnu.org
> Date: Sat, 25 Jun 2016 15:02:42 +0200
>
> >> Great! I have two nits. One, if it is possible for you, please attach
> >> the patch in the format that "git format-patch" makes. That makes it
> >> easy to apply, other
Eli Zaretskii skribis:
>> From: Andy Wingo
>> Cc: l...@gnu.org, guile-devel@gnu.org
>> Date: Sat, 25 Jun 2016 11:51:53 +0200
>>
>> On Sat 25 Jun 2016 11:11, Eli Zaretskii writes:
>>
>> > Here's the modified patch with the couple of changes requested in
>> > response to the previous version:
> From: Andy Wingo
> Cc: l...@gnu.org, guile-devel@gnu.org
> Date: Sat, 25 Jun 2016 11:51:53 +0200
>
> On Sat 25 Jun 2016 11:11, Eli Zaretskii writes:
>
> > Here's the modified patch with the couple of changes requested in
> > response to the previous version:
>
> Great! I have two nits. On
On Sat 25 Jun 2016 11:11, Eli Zaretskii writes:
> Here's the modified patch with the couple of changes requested in
> response to the previous version:
Great! I have two nits. One, if it is possible for you, please attach
the patch in the format that "git format-patch" makes. That makes it
ea
On Sat 25 Jun 2016 04:40, David Pirotte writes:
> Note that make check leaves the following toplevel file [a symlink to itself]
> behind:
>
> filesys-test-link.tmp
I have seen this and I don't know why this is, and I would prefer to fix
it rather than ignoring it.
> config.log
> config
On Sat 25 Jun 2016 04:08, David Pirotte writes:
> diff --git a/.gitignore b/.gitignore
> index 3deeab2..bce9756 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -13,6 +13,7 @@ config.status
> config.log
> config.h
> *.doc
> +*.html
> *.x
> *.lo
> *.la
Can you make it more specific please?
Thanks, that's great :)
For this and the other time-related bugs it sounds like you know what
you're doing but I would like someone to check the work just to make
sure we're not introducing new errors.
To that end, I ask guile-devel, in this top-post so that people will see
it :), for a volunteer
Here's the modified patch with the couple of changes requested in
response to the previous version:
Author: Eli Zaretskii
Date: Fri Jun 25 12:10:34 2016 +0300
Provide support for open-process and related functions on MS-Windows
* libguile/w32-proc.c: New file, with MinGW support code
17 matches
Mail list logo
