Re: [PATCH] Fix error messages involving internal definitions

2012-01-26 Thread Mark H Weaver
I wrote: > So, what does this fix? The "definition in expression context" error > message is broken in several ways. First of all, source location > information is _never_ provided, [...] Sorry, I meant to say "is _never_ provided if the rhs expression is an atom". Mark

[PATCH] Fix error messages involving internal definitions

2012-01-26 Thread Mark H Weaver
Hi Andy, I know this is very last minute, but it would be great if you could include this fix in 2.0.4. Since the release is so close, I was _very_ careful writing it and testing it, and am quite confident that it is correct. (After regenerating psyntax-pp.scm, I removed all .go files, recompile

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Mark H Weaver
Hi Noah, Noah Lavine writes: > I am not an expert, but this is my guess about what's happening: you > get the form from the file with scm_read. scm_read returns a regular > s-expression, not a syntax object. Actually, source location information is not stored in syntax objects. Instead, it is as

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Mark H Weaver
Hi Bruce, Bruce Korb writes: > On 01/26/12 18:26, Mark H Weaver wrote: >>> Too bad. I do prefer clue-ful error messages and "unknown location" >>> just wasn't the helpful clue I needed. Perhaps just use "improper >>> location"? >>> "invalid location"? Just not "unknown location". >> >> That p

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Bruce Korb
On 01/26/12 18:59, Noah Lavine wrote: Hello, /* Read expressions from that port; ignore the values. */ for (;;) { SCM form = scm_read(port); if (SCM_EOF_OBJECT_P(form)) break; ans = scm_primitive_eval_x(form); }

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Noah Lavine
Hello, >        /* Read expressions from that port; ignore the values.  */ >        for (;;) { >            SCM form = scm_read(port); >            if (SCM_EOF_OBJECT_P(form)) >                break; >            ans = scm_primitive_eval_x(form); >        } > >        return ans; >    } > } > > Ev

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Bruce Korb
On 01/26/12 18:26, Mark H Weaver wrote: Too bad. I do prefer clue-ful error messages and "unknown location" just wasn't the helpful clue I needed. Perhaps just use "improper location"? "invalid location"? Just not "unknown location". That part of the error message (where "unknown location" w

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Mark H Weaver
Bruce Korb writes: > On 01/26/12 16:10, Mark H Weaver wrote: >>unknown location: definition in expression context in subform >> optname-from > of "_^" >> >> The other interesting thing here is that the error message above says >> "_^" instead of the full string "A-Z_^". That sug

Re: Build Error in master

2012-01-26 Thread Noah Lavine
I don't think so, because I don't get Throw to key misc-error with args ("module-transformer" "no module, and `macroexpand' unbound" () #f). I'm going to try a git bisect and see where this appears. Noah On Thu, Jan 26, 2012 at 5:06 PM, Andy Wingo wrote: > On Thu 26 Jan 2012 15:26, Noah Lavine

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Bruce Korb
On 01/26/12 16:10, Mark H Weaver wrote: unknown location: definition in expression context in subform optname-from of "_^" The other interesting thing here is that the error message above says "_^" instead of the full string "A-Z_^". That suggests that the string literal was not properly r

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Mark H Weaver
Bruce Korb writes: > On 01/25/12 20:22, Mike Gran wrote: >>> From: Bruce Korb >> unknown location: definition in expression context in subform optname-from >>> of "_^" The other interesting thing here is that the error message above says "_^" instead of the full string "A-Z_^". Tha

Re: Build Error in master

2012-01-26 Thread Andy Wingo
On Thu 26 Jan 2012 15:26, Noah Lavine writes: > I just checked out the latest master. I attempted to build it, but got > stuck at this point: Is it http://lists.gnu.org/archive/html/bug-guile/2011-12/msg00058.html ? Andy -- http://wingolog.org/

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Bruce Korb
Hi Mike, On Thu, Jan 26, 2012 at 1:21 PM, Mike Gran wrote: >>I tried it twice last night and it failed this way both times. >>I just retried it and it worked correctly.  It is an inexplicable >>transient error.  An irreproducible result.  Thank you! > > Sorry.  Maybe Andy and Ludo have a better a

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Mike Gran
>To: Mike Gran >> For some reason, it thinks that you're not at the top level, but >> instead in the middle of some expression. >> >> It might be saying that you've missed a close parenthesis >> on a define somewhere above. > >The answer, then, is "I don't know".  The text handed off to the read/

Re: unknown location: definition in expression context in subform optname-from of "_^"

2012-01-26 Thread Bruce Korb
On 01/25/12 20:22, Mike Gran wrote: From: Bruce Korb unknown location: definition in expression context in subform optname-from of "_^" Scheme evaluation error. AutoGen ABEND-ing in template /old-home/ROOT/usr/local/share/autogen/aginfo.tpl on line 163 Failing Guile command:

Re: syntax-local-value patch for discussion

2012-01-26 Thread Stefan Israelsson Tampe
Remember it's not symbols but code objects that this refers to so I need to use the syntactic information and only augment the objects that can be joined and leave the other syntactic objects like symbols from another module and so on. I will try to leave the struct representation and use only lis

Build Error in master

2012-01-26 Thread Noah Lavine
Hello, I just checked out the latest master. I attempted to build it, but got stuck at this point: GENguile-procedures.texi /bin/sh: line 1: 75746 Broken pipe cat alist.doc arbiters.doc array-handle.doc array-map.doc arrays.doc async.doc backtrace.doc boolean.doc bitvectors.doc

Re: Unsafe psyntax label generation

2012-01-26 Thread Andy Wingo
Heya Mark, On Wed 25 Jan 2012 02:41, Mark H Weaver writes: >> On Tue 24 Jan 2012 15:01, Mark H Weaver writes: >> >>> `local-eval' combines syntax objects from two different sessions into a >>> single syntax object (in the wrapper procedure), and thus there may be >>> label name collisions. Now

Re: syntax-local-value patch for discussion

2012-01-26 Thread Andy Wingo
Hi Stefan, On Mon 23 Jan 2012 17:06, Stefan Israelsson Tampe writes: > and when parse is ready to unpack S we could have > > S = #(syntax-object # wrap-part hygiene) > > Now I basically solve this problem by constructing Why do syntax->datum and datum->syntax not work for you to pack and unpac

Re: syntax-local-binding

2012-01-26 Thread Andy Wingo
Thanks for the feedback, Ludovic. On Wed 25 Jan 2012 14:18, l...@gnu.org (Ludovic Courtès) writes: > 1. Such as API is desirable for Guile-internal consumption. > > 2. Exposing it to users may restrict our ability to change the > implementation in the future, just like ‘the-environment’

Re: rackets syntax parse

2012-01-26 Thread Andy Wingo
On Wed 25 Jan 2012 21:37, Stefan Israelsson Tampe writes: > I got it working with an old version of guile but have problem with newest > stable-2.0 What version did you get it working with? In a year there have only been 25 commits to psyntax, and none of them should have changed anything fund