Re: Locks and threads

2009-02-11 Thread Linas Vepstas
2009/2/11 Neil Jerram : > Linas Vepstas writes: > >> Err, sort of, yes, unless I misunderstand. Guile 1.8 makes >> a certain basic assumption that is splattered throughout >> the code; it rather intentionally re-orders the order in which >> one of the locks is taken. If I remember correctly, its

Re: Locks and threads

2009-02-11 Thread Neil Jerram
Linas Vepstas writes: > Err, sort of, yes, unless I misunderstand. Guile 1.8 makes > a certain basic assumption that is splattered throughout > the code; it rather intentionally re-orders the order in which > one of the locks is taken. If I remember correctly, its the > "in guile mode" lock. S

Re: Locks and threads

2009-02-11 Thread Ludovic Courtès
Neil Jerram writes: > * libguile/async.c (scm_async_click): Don't leave Guile mode when > locking async_mutex. We don't need to, because none of the code > that has async_mutex locked can block, and doing so may lead to lock > ordering problems between async_mutex and a thread's heap_mutex

Re: Locks and threads

2009-02-11 Thread Ludovic Courtès
Hi Neil, Neil Jerram writes: > I've started working through the lock ordering and threading issues > that we have. My plan is (with 1.8.x) > > - first to address problems reported by helgrind (since I think we > should take advantage of external tools before adding debug code to > Guile int

Re: Locks and threads

2009-02-11 Thread Linas Vepstas
2009/2/11 Neil Jerram : > I've started working through the lock ordering and threading issues > that we have. My plan is (with 1.8.x) > > - first to address problems reported by helgrind (since I think we > should take advantage of external tools before adding debug code to > Guile internally) >

Re: [BDW-GC] Static allocation of subrs

2009-02-11 Thread Ludovic Courtès
Hi, l...@gnu.org (Ludovic Courtès) writes: > Neil Jerram writes: > >> l...@gnu.org (Ludovic Courtès) writes: > >>> For these reasons, we may want to merge this patch in `master' as >>> well. >> >> Yes, I think so. > > Noted, will do. Done. Note that the patch is slightly different in

Re: Locks and threads

2009-02-11 Thread Neil Jerram
Neil Jerram writes: > - first to address problems reported by helgrind (since I think we > should take advantage of external tools before adding debug code to > Guile internally) Here's the next one. Neil >From 76f55c5796f1fc7aca6c36bc57f06bab72300a94 Mon Sep 17 00:00:00 2001 From: Neil

Locks and threads

2009-02-11 Thread Neil Jerram
I've started working through the lock ordering and threading issues that we have. My plan is (with 1.8.x) - first to address problems reported by helgrind (since I think we should take advantage of external tools before adding debug code to Guile internally) - then to run Linas's define-race

Re: A bug, unless I'm mistaken

2009-02-11 Thread Kjetil S. Matheussen
On Wed, 11 Feb 2009, Kjetil S. Matheussen wrote: But it segfaults for me on linux. Gentoo here as well. Both 1.8.6 and 1.8.4 behave similarly: kje...@ttleush ~ $ /usr/bin/guile guile> (use-modules (oop goops)) guile> (define-class () name) guile> (make )guile> guile> (+ 3 4) Segmentation fa

Re: A bug, unless I'm mistaken

2009-02-11 Thread Kjetil S. Matheussen
"Marijn Schouten (hkBst)": Hash: SHA1 Michael Burschik wrote: (use-modules (oop goops)) (define-class () name) (make ) This makes guile 1.8.5 crash with a segmentation fault on Linux. I don't think it should. Regards Michael Works for me with 1.8.6 on linux. But it segfaults