[Libguestfs] Problem updating V2V's Windows 2016 -> 2022

2025-03-22 Thread Richard W.M. Jones via Libguestfs
Hi Roman, Someone used virt-v2v to convert a Windows 2016 guest, and then tried updating it to a later version (tried 2019 & 2022), and the update doesn't work. https://issues.redhat.com/browse/MTV-2256 After some investigation it seems it might be due to this change from nearly 10 years ago: h

[Libguestfs] Re: guestfs-tools build issues

2025-04-08 Thread Richard W.M. Jones via Libguestfs
On Tue, Apr 08, 2025 at 11:34:40AM -0400, Cole Robinson wrote: > Hi Rich, I've consistently been hitting issues with guestfs-tools > builds. I have workarounds but they are annoying. > > > 1) With a fresh checkout I run: > > $ git submodule init > $ git submodule update > $ autoreconf -if > $ ./

[Libguestfs] Re: Supermin errors with symlinked /etc directories

2025-04-09 Thread Richard W.M. Jones via Libguestfs
On Wed, Apr 09, 2025 at 03:38:55AM +, Leon Blakey wrote: > Host has various /etc directories symlinked to a config git repo. Running > "virt-filesystems -a ./somevm.qcow2" fails with parent directory not found. > Commands ran as root. Filesystem is ZFS and /etc is same dataset as /. > > Can

[Libguestfs] Re: [nbdkit PATCH v2 1/2] server: Fix off-by-one for maximum block_status length [CVE-XXX]

2025-04-23 Thread Richard W.M. Jones via Libguestfs
On Wed, Apr 23, 2025 at 04:06:45PM -0500, Eric Blake wrote: > There has been an off-by-one bug in the code for .extents since the > introduction of that callback. Remember, internally the code allows > plugins to report on extents with 64-bit lengths, but the protocol > only supports 32-bit block

[Libguestfs] Re: [nbdkit PATCH v2 2/2] blocksize: Fix 32-bit overflow in .extents [CVE-XXXX]

2025-04-23 Thread Richard W.M. Jones via Libguestfs
On Wed, Apr 23, 2025 at 04:06:46PM -0500, Eric Blake wrote: > If the original request is larger than 2**32 - minblock, then we were > calling nbdkit_extents_aligned() with a count that rounded up then > overflowed to 0 instead of the intended 4G because of overflowing a > 32-bit type, which in turn

[Libguestfs] Re: [PATCH] curl: add proxy-cafile and proxy-capath

2025-04-24 Thread Richard W.M. Jones via Libguestfs
Thanks. Please try this modified version of your patch: https://gitlab.com/nbdkit/nbdkit/-/merge_requests/87 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compil

[Libguestfs] Re: [nbdkit PATCH] server: Fix off-by-one for maximum block_status length [CVE-XXX]

2025-04-23 Thread Richard W.M. Jones via Libguestfs
On Tue, Apr 22, 2025 at 05:07:17PM -0500, Eric Blake via Libguestfs wrote: > Latent since the introduction of the .extents callback. The loop > intentionally truncates to 2**32-1 bytes, but condition to end the > loop early used > while the assertion after the loop used <=, meaning > that the asse

[Libguestfs] Re: libguestfs-winsupport re-enable NTFS

2025-04-04 Thread Richard W.M. Jones via Libguestfs
On Fri, Apr 04, 2025 at 09:56:17AM +0200, Andrew Lukoshko wrote: > * > Hello everyone, > > Rich, is this something we can consider enabling back in AlmaLinux? > Does it work? Is it safe? From a technical point of view, it all works fine. I cannot comment on why we don't enable this or what you s

[Libguestfs] Re: [PATCH libguestfs-common] mltools: Unreference various objects

2025-04-04 Thread Richard W.M. Jones via Libguestfs
On Thu, Apr 03, 2025 at 11:58:34AM +0100, Richard W.M. Jones via Libguestfs wrote: > diff --git a/mltools/libosinfo-c.c b/mltools/libosinfo-c.c > index 11df1fe..00d74c1 100644 > --- a/mltools/libosinfo-c.c > +++ b/mltools/libosinfo-c.c > @@ -164,17 +164,22 @@ v2v_osinfo_os_find

[Libguestfs] [PATCH libguestfs-common] mltools: Unreference various objects

2025-04-03 Thread Richard W.M. Jones via Libguestfs
Valgrind was complaining about a memory leak in this function. From looking at similar code in libosinfo itself, it appears we ought to be unrefing a lot more references here. This error started happening after the new 'test-phony-win2k25.sh' was added, but it seems to be unrelated to the test it

[Libguestfs] Re: libguestfs-winsupport re-enable NTFS

2025-04-02 Thread Richard W.M. Jones via Libguestfs
On Wed, Apr 02, 2025 at 12:35:50PM +0200, AL13N wrote: > Hi, > > I've noticed you had disabled NTFS support from guestmount (and the > likes), but kept it for v2v. > > Can you tell me the reason why it was disabled from guestmount in > the first place? > > How would I re-enable it in the spec f

[Libguestfs] Re: [nbdkit PATCH v2 0/2] Fix two assertion failures on large block size

2025-05-10 Thread Richard W.M. Jones via Libguestfs
On Thu, May 08, 2025 at 01:51:21PM -0500, Eric Blake via Libguestfs wrote: > On Wed, Apr 23, 2025 at 04:06:44PM -0500, Eric Blake via Libguestfs wrote: > > Still waiting on Red Hat's security team to decide if these get CVE > > designations, but at this point, we consider the impact to be low > > e

[Libguestfs] Re: [nbdkit PATCH v2 0/2] Fix two assertion failures on large block size

2025-05-10 Thread Richard W.M. Jones via Libguestfs
On Sat, May 10, 2025 at 10:08:30AM +0100, Richard W.M. Jones wrote: > On Thu, May 08, 2025 at 01:51:21PM -0500, Eric Blake via Libguestfs wrote: > > On Wed, Apr 23, 2025 at 04:06:44PM -0500, Eric Blake via Libguestfs wrote: > > > Still waiting on Red Hat's security team to decide if these get CVE >

[Libguestfs] Re: GuestMount Was Working

2025-05-13 Thread Richard W.M. Jones via Libguestfs
On Mon, May 12, 2025 at 07:31:33PM -0400, ro...@kleimanup.com wrote: ... > cp: cannot open '/boot/vmlinuz-6.8.0-59-generic' for reading: Permission > denied It's probably: https://libguestfs.org/guestfs-faq.1.html#where-can-i-get-the-latest-binaries-for (under "Debian and Ubuntu") Rich. --

[Libguestfs] Re: [nbdkit PATCH] ext2: Support concurrent connections

2025-05-16 Thread Richard W.M. Jones via Libguestfs
On Fri, May 16, 2025 at 03:28:53PM -0500, Eric Blake via Libguestfs wrote: > Instead of serializing connections (which in turn serializes requests > because it is unsafe to open more than one handle into the filesystem > at the same time), use the recently-added APIs to open the filesystem > during

[Libguestfs] Re: [nbdkit PATCH v2 0/2] Fix two assertion failures on large block size

2025-05-18 Thread Richard W.M. Jones via Libguestfs
On Sat, May 10, 2025 at 10:44:36AM +0100, Richard W.M. Jones via Libguestfs wrote: > On Sat, May 10, 2025 at 10:08:30AM +0100, Richard W.M. Jones wrote: > > On Thu, May 08, 2025 at 01:51:21PM -0500, Eric Blake via Libguestfs wrote: > > > On Wed, Apr 23, 2025 at 04:06:44PM -05

[Libguestfs] ANNOUNCE: guestfs-tools 1.54 new stable version

2025-05-21 Thread Richard W.M. Jones via Libguestfs
I'm pleased to announce the stable release of guestfs-tools 1.54. Guestfs tools is a set of command line tools like virt-customize and virt-edit for inspecting and editing virtual machine disk images. The release notes for the new version are attached below, or can be read on line here: https:

[Libguestfs] New stable versions of libguestfs, guestfs-tools and virt-v2v coming soon

2025-05-15 Thread Richard W.M. Jones via Libguestfs
It's been a while since we released new stable branches of libguestfs, guestfs-tools and virt-v2v. For guestfs-tools, not since January 2024(!) I've prepared preliminary release notes for all three projects here: https://github.com/libguestfs/libguestfs/blob/master/docs/guestfs-release-notes-1.5

[Libguestfs] Re: appliance not getting ipv4 assigned when host kernel has CONFIG_IPV6_SIT builtin

2025-06-20 Thread Richard W.M. Jones via Libguestfs
On Fri, Jun 20, 2025 at 05:12:27PM +0530, Aithal, Srikanth wrote: > Hello all, > > I am encountering an issue with virt-customize when the host kernel, on which > virt-customize runs, has CONFIG_IPV6_SIT built-in. Below is the error output > from the command: > > virt-customize -a noble-server-

[Libguestfs] Re: appliance not getting ipv4 assigned when host kernel has CONFIG_IPV6_SIT builtin

2025-06-24 Thread Richard W.M. Jones via Libguestfs
On Tue, Jun 24, 2025 at 12:37:22PM +0200, Stefano Brivio wrote: > On Tue, 24 Jun 2025 15:46:13 +0530 > "Aithal, Srikanth" wrote: > > > On 6/24/2025 3:04 PM, Stefano Brivio wrote: > > > On Tue, 24 Jun 2025 09:12:33 +0100 > > > "Richard W.M. Jones" wrote: > > > > > >> On Tue, Jun 24, 2025 at 01:2

[Libguestfs] Re: appliance not getting ipv4 assigned when host kernel has CONFIG_IPV6_SIT builtin

2025-06-24 Thread Richard W.M. Jones via Libguestfs
On Tue, Jun 24, 2025 at 01:57:09PM +0200, Stefano Brivio wrote: > On Tue, 24 Jun 2025 12:33:17 +0100 > "Richard W.M. Jones" wrote: > > I'm a bit confused here. How does host IPv4 or IPv6 affect what > > happens in the appliance? > > The appliance still needs to connect to hosts using IPv4 or IPv

[Libguestfs] Re: appliance not getting ipv4 assigned when host kernel has CONFIG_IPV6_SIT builtin

2025-06-24 Thread Richard W.M. Jones via Libguestfs
On Tue, Jun 24, 2025 at 02:33:43PM +0200, Stefano Brivio wrote: > On Tue, 24 Jun 2025 13:15:58 +0100 > "Richard W.M. Jones" wrote: > > If passt is like slirp, then it would originate connections itself > > (ie. calling connect(2) on the host side), so I don't understand how > > the address family

[Libguestfs] Fwd: Re: appliance not getting ipv4 assigned when host kernel has CONFIG_IPV6_SIT builtin

2025-06-24 Thread Richard W.M. Jones via Libguestfs
(Forwarding this because I accidentally fat-fingered the "Reject" button in hyperkitty) - Forwarded message from Stefano Brivio - Date: Tue, 24 Jun 2025 15:31:45 +0200 From: Stefano Brivio To: "Richard W.M. Jones" Cc: "Aithal, Srikanth" , guestfs@lists.libguestfs.org Subject: Re: appli

[Libguestfs] [PATCH libguestfs] appliance: Ignore sit0 network device in the guest

2025-06-24 Thread Richard W.M. Jones via Libguestfs
Reported-by: Srikanth Aithal Fixed-by: Stefano Brivio See: https://lists.libguestfs.org/archives/list/guestfs@lists.libguestfs.org/thread/566LAY7RNM7T7EMQQQYIQA2VK5TXETK5/ --- appliance/init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appliance/init b/appliance/init index

[Libguestfs] Re: [PATCH libguestfs] appliance: Ignore sit0 network device in the guest

2025-06-25 Thread Richard W.M. Jones via Libguestfs
On Wed, Jun 25, 2025 at 03:40:23PM +0530, Aithal, Srikanth wrote: > On 6/24/2025 6:37 PM, Richard W.M. Jones via Libguestfs wrote: > >Reported-by: Srikanth Aithal > >Fixed-by: Stefano Brivio > >See: > >https://lists.libguestfs.org/archives/list/guestfs@

[Libguestfs] Re: appliance not getting ipv4 assigned when host kernel has CONFIG_IPV6_SIT builtin

2025-06-24 Thread Richard W.M. Jones via Libguestfs
On Tue, Jun 24, 2025 at 01:25:47PM +0530, Aithal, Srikanth wrote: > libguestfs: command: run: \ --pid /tmp/libguestfsJamIlZ/passt1.pid ... > Don't run as root. Changing to nobody... ... > PID file open: Permission denied > libguestfs: trace: launch = -1 (error) In libguestfs we already work around

[Libguestfs] ANNOUNCE: libguestfs 1.56 & virt-v2v 2.8 releases

2025-06-12 Thread Richard W.M. Jones via Libguestfs
I'm pleased to announce the stable releases of libguestfs (1.56) and virt-v2v (2.8). Libguestfs is a library for reading and writing virtual machines and disk images. Virt-v2v is program for converting virtual machines from foreign hypervisors to run on qemu/KVM. These were last released over a

[Libguestfs] Re: GuestFish intermittently failing after upgrading Base image to Fedora 40

2025-07-12 Thread Richard W.M. Jones via Libguestfs
On Fri, Jul 11, 2025 at 10:41:59PM +, Chintan Patel wrote: > Hi Richard, > > We were using LibguestFS version 1.52 on Fedora 39 and it was working as > expected since last year, but due to the security issue and Fedora 39 is our > of > support we need to upgrade to Fedora 40 for our container

[Libguestfs] ANNOUNCE: nbdkit 1.44.0

2025-07-01 Thread Richard W.M. Jones via Libguestfs
I'm pleased to announce the new stable release of nbdkit 1.44. nbdkit is a Network Block Device (NBD) server with a stable plugin ABI and a permissive license. nbdkit 1.44.0 can be downloaded here: https://download.libguestfs.org/nbdkit/1.44-stable/ git here: https://gitlab.com/nbdkit/nbdkit Rel

[Libguestfs] Re: Slackware support for libguestfs (was: Re: ocaml-augeas 0.7 source tarball)

2025-07-26 Thread Richard W.M. Jones via Libguestfs
On Sat, Jul 26, 2025 at 02:09:01PM +0100, Richard W.M. Jones wrote: > Are you sure that your Alpine applications can't simply be recreated > (eg. from Ansible playbooks or however you deploy software) on the > target? ... or even just copied as a disk image to KVM? Alpine might already have virti

[Libguestfs] Slackware support for libguestfs (was: Re: ocaml-augeas 0.7 source tarball)

2025-07-26 Thread Richard W.M. Jones via Libguestfs
On Sat, Jul 26, 2025 at 01:36:38PM +0200, 414N wrote: > Il 08/07/25 09:41, Richard W.M. Jones ha scritto: > >Different problem. I can upload a new appliance here, but is there a > >reason not to just generate the appliance? The binary appliance is > >only really intended for very specialized uses