[Libguestfs] Re: [External] Re: [PATCH] VxFS Filesystem support to libguestfs

2024-07-01 Thread Richard W.M. Jones
On Mon, Jul 01, 2024 at 11:24:59AM +, Ravi Singh wrote: > A few basics first: > > - The commit doesn't have an author name. : Fixed > > - The commit has no information at all about the change. : Fixed This commit message is just a list of what changed, which is not how to write good commit m

[Libguestfs] Re: [External] Re: [PATCH] VxFS Filesystem support to libguestfs

2024-07-01 Thread Ravi Singh via Libguestfs
A few basics first: - The commit doesn't have an author name. : Fixed - The commit has no information at all about the change. : Fixed - One file at least has whitespace problems, adding empty lines at the end of the file. : Fixed - There are no tests at all. : In progress. - Copyright dates

[Libguestfs] Re: [External] Re: [PATCH] VxFS Filesystem support to libguestfs

2024-07-01 Thread Richard W.M. Jones
On Mon, Jul 01, 2024 at 06:56:40AM +, Ravi Singh wrote: > Hi Richard, > > As discussed, I have created a fork from the master branch and updated it with > my patch. Here are the details of the testing I conducted: > > 1. Ran `make quickcheck`: Please find the attached log file for the result