Re: Reviewing GVariant, part II

2010-01-21 Thread Vincent Untz
Hey, Le mercredi 13 janvier 2010, à 12:48 -0500, Ryan Lortie a écrit : > Meanwhile, I'll finish off the changes you've suggested in this email. So, is gvariant still going to make it for glib 2.24? The release team has been assuming it would, but if it won't happen before 2.25, we'd like to know

Re: Reviewing GVariant, part II

2010-01-13 Thread Ryan Lortie
Hi Matthias I've started in on the comments in this email. On Sun, 2009-12-06 at 17:01 -0500, Matthias Clasen wrote: > First, I didn't see any documentation improvements after my last > review attempt...are those coming, or are we stuck here ? I wrote an email in reply to your comments on Octobe

Re: Reviewing GVariant, part II

2009-12-08 Thread Ryan Lortie
Hi Matthias Thanks for the further comments. I'm on holiday until the end of the year at this point. I'll get the ball rolling again in early January. Cheers On Sun, 2009-12-06 at 17:01 -0500, Matthias Clasen wrote: > Today I had another go at reviewing the gvariant branch, this time > startin

Reviewing GVariant, part II

2009-12-06 Thread Matthias Clasen
Today I had another go at reviewing the gvariant branch, this time starting from the tests. First, I didn't see any documentation improvements after my last review attempt...are those coming, or are we stuck here ? Here's my observations from looking at the tests: - Some gvariant tests are GPL3,

Re: Reviewing GVariant

2009-10-28 Thread Simon McVittie
On Wed, 28 Oct 2009 at 03:32:16 -0400, Ryan Lortie wrote: > GVariant type strings can be made "indefinite" by the addition of > wildcard characters. For example: > > "(i*)" - a pair where the first element is a 32bit integer and the >second element has any valid type With my D-Bus

Re: Reviewing GVariant

2009-10-28 Thread Ryan Lortie
On Tue, 2009-10-27 at 21:03 -0400, Matthias Clasen wrote: > Just to run down the concepts you meet while reading this chapter, > mostly without introduction or explanation: > - type classes > - basic types, maybe types, container types > - 'any' types > - generic types > - variant types and type st

Reviewing GVariant

2009-10-27 Thread Matthias Clasen
So, today I've built the gsettings branch and set out to review GVariant to make sure it is ready to be merged. I started by reading the docs, and I can't help myself, but I still don't like this GVariantType thing very much. After toiling on this for months, it is probably as obvious to Ryan as G