Re: File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Ryan Lortie
hi, On Wed, Jan 14, 2015, at 20:49, Christian Hergert wrote: > Does anything rely on the delay that happens in the current system? For > example, is it used to coalesce an open(O_CREAT)/rename() into a single > signal emission? I know I've written some things in the past where I've been a bit wor

Re: File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Fan Chun-wei
Hi, Fan Chun-wei 於 2015/1/15 08:13 寫道: ...bug 730116 Perhaps, since this will cover the work for adding file monitoring support for Windows, I am making bug 730116 the tracking bug for this drive for the file monitor rewrite for Windows, to let people know. With blessings, thank you!

Re: File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Christian Hergert
On 01/14/2015 04:13 PM, Ryan Lortie wrote: > Thread safety -- file and mount monitors are currently known to be > crash-prone due to races. > > This has become particularly problematic since GDesktopAppInfo started > using them from the GLib worker thread to watch for changes to desktop > files. >

Re: File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Ryan Lortie
hi, On Wed, Jan 14, 2015, at 19:13, Fan Chun-wei wrote: > I think I can also take a look at the Windows backend for this as well, > since we are actually using the same Windows API for monitoring file and > directory changes, ReadDirectoryChangesW(), as I was trying to get file > monitoring to

Re: File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Fan Chun-wei
Hi, I think I can also take a look at the Windows backend for this as well, since we are actually using the same Windows API for monitoring file and directory changes, ReadDirectoryChangesW(), as I was trying to get file monitoring to work on Windows in bug 730116 a while ago (we only had dir

Re: File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Ryan Lortie
hi, On Wed, Jan 14, 2015, at 18:14, Christian Hergert wrote: > I quickly read over the relevant commit message. I didn't see anything > alluding to the goal of the patch set. I'm sure there is a goal you have > in mind? > > Overhead reduction, performance related I assume? Thread safety -- file

Re: File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Christian Hergert
On 01/14/2015 02:00 PM, Ryan Lortie wrote: > I'm making substantial modifications to the file monitoring system in > GIO. I've gotten to the point where I feel comfortable pushing a branch > that contains the main ideas: > > https://git.gnome.org/browse/glib/log/?h=wip/mount-watcher > > It's n

File monitor rewrite: Solaris (and other) help wanted

2015-01-14 Thread Ryan Lortie
hi, I'm making substantial modifications to the file monitoring system in GIO. I've gotten to the point where I feel comfortable pushing a branch that contains the main ideas: https://git.gnome.org/browse/glib/log/?h=wip/mount-watcher It's not even vaguely tested or stable and will probably c