Re: fsync in glib/gio

2009-03-12 Thread Michael Meeks
On Thu, 2009-03-12 at 21:11 +0100, Alexander Larsson wrote: > With all the recent yahoo about ext4 data loss and fsync I felt I had to > look at glib and make sure we're doing this right. Hmm; is this not just a database guy ? ;-) presumably if -all- file I/O should be synchronous, the ke

Re: fsync in glib/gio

2009-03-12 Thread Alexander Larsson
On Thu, 2009-03-12 at 17:05 -0400, Colin Walters wrote: > 2009/3/12 Alexander Larsson : > > With all the recent yahoo about ext4 data loss and fsync I felt I had to > > look at glib and make sure we're doing this right. > > > > Attached is a patch that makes sure we fsync before closing in the gio

Re: fsync in glib/gio

2009-03-12 Thread Colin Walters
2009/3/12 Alexander Larsson : > With all the recent yahoo about ext4 data loss and fsync I felt I had to > look at glib and make sure we're doing this right. > > Attached is a patch that makes sure we fsync before closing in the gio > file saving code and in g_file_set_contents(). > > It also adds

Re: fsync in glib/gio

2009-03-12 Thread Ray Strode
Hi, 2009/3/12 Alexander Larsson : > With all the recent yahoo about ext4 data loss and fsync I felt I had to > look at glib and make sure we're doing this right. ... > It might also be interesting to look over the rest of our platform for > similar places where fsync is missing. We had to fix this

Re: fsync in glib/gio

2009-03-12 Thread Sven Herzberg
Hi, Am Donnerstag, den 12.03.2009, 21:11 +0100 schrieb Alexander Larsson: > typedef enum { >G_FILE_CREATE_NONE= 0, >G_FILE_CREATE_PRIVATE = (1 << 0), > - G_FILE_CREATE_REPLACE_DESTINATION = (1 << 1) > + G_FILE_CREATE_REPLACE_DESTINATION = (1 << 1), > + G_FILE_CREATE_ASYNC_WRITE = (

fsync in glib/gio

2009-03-12 Thread Alexander Larsson
With all the recent yahoo about ext4 data loss and fsync I felt I had to look at glib and make sure we're doing this right. Attached is a patch that makes sure we fsync before closing in the gio file saving code and in g_file_set_contents(). It also adds G_FILE_CREATE_ASYNC_WRITE flag to disable

Re: Gtk+ 3.0 Theming API Hackfest Minutes

2009-03-12 Thread Alberto Ruiz
2009/3/12 Cody Russell : > On Tue, Feb 24, 2009 at 12:30 AM, Alberto Ruiz wrote: >> >> * All drawing funcitions to use a cario context and hide GtkWidget and >> GdkWindow (Strong request from 3rd party toolkits) > > After thinking some more about this, I'm not convinced that getting rid of > the G

Re: Gtk+ 3.0 Theming API Hackfest Minutes

2009-03-12 Thread Christian Dywan
Am Thu, 12 Mar 2009 18:51:33 +0200 schrieb Cody Russell : > On Tue, Feb 24, 2009 at 12:30 AM, Alberto Ruiz > wrote: > > > * All drawing funcitions to use a cario context and hide GtkWidget > > and GdkWindow (Strong request from 3rd party toolkits) > > > > After thinking some more about this, I'

Re: Gtk+ 3.0 Theming API Hackfest Minutes

2009-03-12 Thread Cody Russell
On Tue, Feb 24, 2009 at 12:30 AM, Alberto Ruiz wrote: > * All drawing funcitions to use a cario context and hide GtkWidget and > GdkWindow (Strong request from 3rd party toolkits) > After thinking some more about this, I'm not convinced that getting rid of the GtkWidget* pointer is a good idea.

Re: High-performance Priority Queue / Heap for glib

2009-03-12 Thread Maik Zumstrull
Maik Zumstrull wrote: > Behdad Esfahbod wrote: > > > I suggest you open a bug on http://bugzilla.gnome.org/ and attach > > your latest patch there. > > I created the bug > (), but I am unable > to attach the patch: Worked on fifth-or-so attempt,

Re: High-performance Priority Queue / Heap for glib

2009-03-12 Thread Maik Zumstrull
Behdad Esfahbod wrote: > I suggest you open a bug on http://bugzilla.gnome.org/ and attach > your latest patch there. I created the bug (), but I am unable to attach the patch: | Internal Error | | Bugzilla has suffered an internal error. Please