From: Kees Cook
GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's
disk.number, which is an internal kernel index. If an array has had drives
added, removed, etc, there may be gaps in GET_DISK_INFO's results. But
since the consumer of devicelist cannot tolerate gaps
("... (grub_util_raid_getmembers): Handle "removed" disks")
Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043
Fixes: https://savannah.gnu.org/bugs/index.php?59887
Signed-off-by: Kees Cook
Index: grub2-2.04/grub-core/o
s://savannah.gnu.org/bugs/index.php?59887
Signed-off-by: Kees Cook
(This is intended to be applied on top of the earlier patch sent in
https://lists.gnu.org/archive/html/grub-devel/2021-01/msg00027.html)
Index: grub2-2.04/grub-c
s: 49de079bbe1c ("... (grub_util_raid_getmembers): Handle "removed" disks")
Fixes: 2b00217369ac ("... Added support for RAID and LVM")
Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043
Fixes: https://savannah.gnu.org/bugs/index.php?59887
Signed-off-by: K
the devicelist index (j).
Fixes: 49de079bbe1c ("... (grub_util_raid_getmembers): Handle "removed" disks")
Fixes: 2b00217369ac ("... Added support for RAID and LVM")
Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043
Fixes: https://savannah.gnu.org/b
Hi Daniel,
On Tue, Oct 05, 2021 at 06:38:13PM +0200, Daniel Kiper wrote:
> On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote:
> > From: Kees Cook
> >
> > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's
> > disk.number, which is
Hi Petr,
On Wed, Oct 06, 2021 at 09:28:32AM +0200, Petr Vorel wrote:
> Hi Kees, Daniel,
>
> > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote:
> > > From: Kees Cook
>
> > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO
On October 11, 2021 8:02:18 AM PDT, Daniel Kiper wrote:
>On Thu, Oct 07, 2021 at 04:33:16PM -0700, Kees Cook wrote:
>> GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's
>> disk.number, which is an internal kernel index. If an array has had drives
>>
making any progress.
The program hangs in a while(1) loop at line 657 in grub-core/fs/hfsplus.c
BTW. I've also tried to contact Macro Gerards (the contributor of the HFS+
code), but I didn't get a reply from him.
--
Kees
___
Grub-devel mailing lis
On 24-02-12 11:34, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
On 23.02.2012 21:46, Kees Bakker wrote:
I've tried to debug this problem, but I am not making any progress.
The program hangs in a while(1) loop at line 657 in
grub-core/fs/hfsplus.c
there is no loop at this
On 24-02-12 11:34, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
On 23.02.2012 21:46, Kees Bakker wrote:
I've tried to debug this problem, but I am not making any progress.
The program hangs in a while(1) loop at line 657 in
grub-core/fs/hfsplus.c
there is no loop at this
On 24-02-12 22:30, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
On 24.02.2012 21:28, Kees Bakker wrote:
Here is the good news: the hang does not happen with the trunk version
anymore.
But there is still a minor bug that you can make this loop hang with a
broken FS (btree loop).
mmit 2a5e3c1f2 (disk/diskfilter: Don't make a RAID array with more
> > than 1024 disks). I think we should sync both numbers down to 1024...
>
> +1
Yeah, seems reasonable, though as I hinted in the original patch, this
number appeared to have been arbitrarily chosen by mdadm at th
On Wed, Jun 07, 2023 at 03:39:24PM +0200, Daniel Kiper wrote:
> On Tue, Jun 06, 2023 at 11:02:31AM -0700, Kees Cook wrote:
> > On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode
> > wrote:
> > >
> > > On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote
> Cc: Daniel Axtens
> Cc: Kees Cook
Yup, looks good to me. Thanks!
Reviewed-by: Kees Cook
-Kees
> ---
> grub-core/disk/diskfilter.c | 4 ++--
> grub-core/osdep/linux/getroot.c | 12 ++--
> include/grub/disk.h | 10 ++
> 3 files changed, 14
15 matches
Mail list logo
