MKPasswd idempotency patch

2018-12-25 Thread grub-devel
l_error("%s", _("couldn't convert hexstring into salt")); +} + } else { +if (grub_get_random (salt, arguments.saltlen)) { memset (pass1, 0, sizeof (pass1)); free (buf); free (salt); grub_util_error ("%s", _("couldn

[PATCH] Re: MKPasswd idempotency patch

2019-01-15 Thread grub-devel
e output slightly to not inlcude the `PBKDF2 hash of your password is > `-part. > > The patch is attached to this mail. > > Best, > Klaus Frank > _______ > Grub-devel mailing list > Grub-de

Re: MKPasswd idempotency patch

2019-01-19 Thread grub-devel
- 48; > > + } else if (65 <= hex && hex <= 90) { > > +return hex - 65 + 10; > > + } else if (97 <= hex && hex <= 122) { > > + return hex - 97 + 10; > > + } else { > > +exit(1); > > + } > > +} > > grub_

grub-install fails with nbd device

2020-06-20 Thread listsb via Grub-devel
tion. Parent PID 10249: grub-install You have a memory leak (not released memory pool): [0x7fcace1b3f80] dtree Internal error: Unreleased memory pool(s) found. Installation finished. No error reported. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread HardenedArray via Grub-devel
ot parse digest 1.` In fact, if you enter NO passphrase and hit Enter, you also get: `error: Could not parse digest 1.` Very frustrating indeed! Does anyone know why grub is failing this way, and does a workaround exist? Thank you for your time...suggestions welcome.__

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread HardenedArray via Grub-devel
t; On 8/28/20 11:28 AM, HardenedArray via Grub-devel wrote: > > > I run Arch Linux as an encrypted /, /boot and swap system. That > > encrypted /boot is nothing more than a folder under /, however two > > Keyslots are required to boot. > > If I understand the boot process

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread HardenedArray via Grub-devel
st 28, 2020 4:51 PM, Patrick Steinhardt wrote: > On Fri, Aug 28, 2020 at 11:37:24AM -0400, Eli Schwartz wrote: > > > On 8/28/20 11:28 AM, HardenedArray via Grub-devel wrote: > > > > > I run Arch Linux as an encrypted /, /boot and swap system. That > > > encrypted

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-29 Thread HardenedArray via Grub-devel
‐‐‐ Original Message ‐‐‐ > > On Friday, August 28, 2020 4:52 PM, Patrick Steinhardt p...@pks.im wrote: > > > > > Manually Cc'ing you as I don't know if you're registered on the mailing > > > list and saw just now that you weren't Cc'd o

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-30 Thread HardenedArray via Grub-devel
----------- > > Eli Schwartz > Arch Linux Bug Wrangler and Trusted User > > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-30 Thread HardenedArray via Grub-devel
19 PM, Patrick Steinhardt wrote: > On Sun, Aug 30, 2020 at 03:30:39PM +0000, HardenedArray via Grub-devel wrote: > > > As a direct consequence of your valuable `--modules=` input, I have > > taken the time and attempted to carefully document my entire LUKS2 > > unlocking

Re: need hostname on menu

2021-01-24 Thread J.Witvliet--- via Grub-devel
mailto:hp...@optusnet.com.au>> Date: Sunday, 24 January 2021 at 01:52:49 To: "grub-devel@gnu.org" mailto:grub-devel@gnu.org>> Subject: need hostname on menu Hi, Currently, the grub menu has no option to display the hostname, but when on a dual-boot system there two sys

Re: need hostname on menu

2021-01-24 Thread J.Witvliet--- via Grub-devel
the sender and delete the message. The State accepts no liability for damage of any kind resulting from the risks inherent in the electronic transmission of messages. _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

grub-2:2.06rc1-2 Installation Messages Related to Secure Boot as Displayed under Arch Linux

2021-04-27 Thread HardenedArray via Grub-devel
ncrypted /boot upon reboot. I am not sure any action is required, I only wanted those involved with Secure Boot to be aware of the information being shown to grub end users on Arch Linux. Cheers___ Grub-devel mailing list Grub-devel@gnu.org https://li

Re: Re: [PATCH] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages

2022-03-16 Thread zhangqiumiao via Grub-devel
On Thu, Feb 17, 2022 at 03:32:52PM -0600, Glenn Washburn wrote: > On Thu, 17 Feb 2022 21:48:58 +0800 > Qiumiao Zhang via Grub-devel wrote: > > > During UEFI PXE boot in IPv6 network, if the DHCP server adopts > > stateful automatic configuration, when th

Re: Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages

2022-04-21 Thread zhangqiumiao via Grub-devel
On Thu, Apr 21, 2022 at 21:41:52PM +0800, Daniel Kiper wrote: > On Sat, Apr 16, 2022 at 09:50:11AM +0800, Qiumiao Zhang via Grub-devel wrote: > > During UEFI PXE boot in IPv6 network, if the DHCP server adopts > > stateful automatic configuration, then the cl

[PATCH] Allow background to be set when theme is set

2024-06-13 Thread Lin via Grub-devel
OUND" != x ] && [ -f "$GRUB_BACKGROUND" ] \ && is_path_readable_by_grub "$GRUB_BACKGROUND"; then gettext_printf "Found background: %s\n" "$GRUB_BACKGROUND" >&2 case "$GRUB_BACKGROUND" in _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: multiboot2 and module2 boot issues via GRUB2

2022-07-19 Thread Bruno via Grub-devel
___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v3 0/3] Cryptomount detached headers

2022-07-29 Thread brutser--- via Grub-devel
and would expect this to be working, so if yes, this seems like a bug. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-07-29 Thread brutser--- via Grub-devel
ience with that, but will try to figure it out. Van: Glenn Washburn Aan: brut...@perso.be Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 29/07/2022 21:27:48 Europe/Paris Cc: grub-devel@gnu.org;    dki...@net-space.pl;    p...@pks.im On Fri, 29 Jul 2022 20:56:18 +0200 (CEST)

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-07-30 Thread brutser--- via Grub-devel
GNU GRUB Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 30/07/2022 08:51:51 Europe/Paris --- Original Message --- On Friday, July 29th, 2022 at 6:56 PM, brutser--- via Grub-devel wrote: testing detached header failed: 1. built grub payload with following modules

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-07-30 Thread brutser--- via Grub-devel
] Cryptomount detached headers Datum: 29/07/2022 21:27:48 Europe/Paris Cc: grub-devel@gnu.org;    dki...@net-space.pl;    p...@pks.im On Fri, 29 Jul 2022 20:56:18 +0200 (CEST) brut...@perso.be wrote: > > testing detached header failed: > > > > 1. built grub payload with follo

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-07-30 Thread brutser--- via Grub-devel
Glenn, The most obvious error that jumps out: Read out of range: sector 0x32000 (attempt to read or write outside partition) Van: brutser--- via Grub-devel Aan: grub-devel@gnu.org Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 30/07/2022 11:54:32 Europe/Paris Cc: brut

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread brutser--- via Grub-devel
Glenn, Still resorted to screenshots for the debug (with the added dprintf): https://imgur.com/a/YkVMdBe Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 01/08/2022 22:50:27 Europe/Paris Cc: brut...@perso.be;    dki

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread brutser--- via Grub-devel
% fine with grub 2.04 and luks1 as i said before... Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 02/08/2022 01:24:47 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl;    p...@pks.im On Tue, 2 Aug 2022 00:21:09 +0200

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread brutser--- via Grub-devel
-devel Aan: grub-devel@gnu.org Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 02/08/2022 01:47:57 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl;    p...@pks.im Debian 11.4 for all the testing. as i said, i execute shell during installation, then simply enter the

答复: [PATCH] util/grub-mkfont: Fix resource leaks

2022-08-02 Thread zhangqiumiao via Grub-devel
OK, that's perfect. -邮件原件- 发件人: Daniel Kiper [mailto:dki...@net-space.pl] 发送时间: 2022年8月2日 18:44 收件人: zhangqiumiao 抄送: Fengtao (fengtao, Euler) ; Chenxiang(Euler) ; Zhaowei (EulerOS) ; grub-devel@gnu.org 主题: Re: [PATCH] util/grub-mkfont: Fix resource leaks Missing Signed-o

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-02 Thread brutser--- via Grub-devel
Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 02/08/2022 20:58:17 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl;    p...@pks.im Hi Bruster, Are you able to add your responses inline like I have been doing in my

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-03 Thread brutser--- via Grub-devel
See comments below. Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 03/08/2022 21:54:14 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl;    p...@pks.im On Tue, 2 Aug 2022 22:49:27 +0200 (CEST) brutser--- via Grub

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-03 Thread brutser--- via Grub-devel
New comments below. See comments below. Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 03/08/2022 21:54:14 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl;    p...@pks.im On Tue, 2 Aug 2022 22:49:27 +0200 (CEST

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-04 Thread brutser--- via Grub-devel
Debug logs: https://imgur.com/a/onRBSMd New comments below. See comments below. Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 03/08/2022 21:54:14 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl;    p...@pks.im

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-04 Thread brutser--- via Grub-devel
d data. Debug logs: https://imgur.com/a/onRBSMd New comments below. See comments below. Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 03/08/2022 21:54:14 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-05 Thread brutser--- via Grub-devel
See below. Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 05/08/2022 07:00:51 Europe/Paris Cc: brut...@perso.be;    dki...@net-space.pl;    p...@pks.im On Thu, 4 Aug 2022 18:56:40 +0200 (CEST) brutser--- via Grub-devel

Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition

2022-08-07 Thread brutser--- via Grub-devel
This patch fixed the issue I had and now makes it possible to decrypt a partition with cryptomount when using a detached header. Glenn, thanks for the patience with my not always efficient approach, but at least I reported something that needed a fix ;-) Van: Glenn Washburn Aan: grub-devel

Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition

2022-08-09 Thread brutser--- via Grub-devel
Hi Daniel! No problem, I will do some more testing end of this week with different setups. Van: Daniel Kiper Aan: Glenn Washburn Onderwerp: Re: [PATCH] cryptodisk: Support encrypted volumes using detached headers on a partition Datum: 09/08/2022 15:17:59 Europe/Paris Cc: grub-devel@gnu.org

Slow loading and GRUB work after commit 938c3760b

2022-09-10 Thread jim945 via Grub-devel
before the menu appears reaches 15-20 minutes. The work is very slow. And in Qemu this problem does not appear. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Slow loading and GRUB work after commit 938c3760b

2022-09-12 Thread jim945 via Grub-devel
12.09.2022 05:15, Gary Lin пишет: On Sat, Sep 10, 2022 at 09:33:47AM +0300, jim945 via Grub-devel wrote: Hi, I am compiling grubx64.efi with modulescpio exfat ext2 fat gzio iso9660 loopback lzopio newc normal ntfs part_gpt part_msdos probe read search tar test configfile echo xzio squash4 sfs

Re: Slow loading and GRUB work after commit 938c3760b

2022-09-12 Thread jim945 via Grub-devel
12.09.2022 14:29, jim945 пишет: 10.09.2022 17:51, Zhang Boyang пишет: Hi On 2022/9/10 14:33, jim945 via Grub-devel wrote: Hi, I am compiling grubx64.efi with modulescpio exfat ext2 fat gzio iso9660 loopback lzopio newc normal ntfs part_gpt part_msdos probe read search tar test

Re: Slow loading and GRUB work after commit 938c3760b

2022-09-12 Thread jim945 via Grub-devel
10.09.2022 17:51, Zhang Boyang пишет: Hi On 2022/9/10 14:33, jim945 via Grub-devel wrote: Hi, I am compiling grubx64.efi with modulescpio exfat ext2 fat gzio iso9660 loopback lzopio newc normal ntfs part_gpt part_msdos probe read search tar test configfile echo xzio squash4 sfs memdisk

Re: [PATCH v2 1/1] mm: Better handling of adding new regions

2022-09-14 Thread jim945 via Grub-devel
d *) 0) #endif +#define GRUB_MM_HEAP_GROW 0x10 + #define GRUB_MM_ADD_REGION_NONE0 #define GRUB_MM_ADD_REGION_CONSECUTIVE (1 << 0) In my case it works great. _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 0/2] bash-completion:fix shellcheck error and warning

2022-09-18 Thread t.feng via Grub-devel
t.feng (2): bash-completion:fix shellcheck error bash-completion:fix shellcheck warning .../bash-completion.d/grub-completion.bash.in | 40 --- 1 file changed, 25 insertions(+), 15 deletions(-) -- 2.27.0 ___ Grub-devel mailing lis

[PATCH 1/2] bash-completion:fix shellcheck error

2022-09-18 Thread t.feng via Grub-devel
mp; { tmp=${tmp##*/} printf '%s\n' ${tmp%.mod} } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 2/2] bash-completion:fix shellcheck warning

2022-09-18 Thread t.feng via Grub-devel
{ - while read -r tmp; do - [ -n "$tmp" ] && { - tmp=${tmp##*/} - printf '%s\n' ${tmp%.mod} - } - done - } - )) +COMPREPLY=() + while read -r line; do +COMPREPLY+=("

Re: [PATCH v2 1/1] mm: Better handling of adding new regions

2022-10-09 Thread jim945 via Grub-devel
="cpio exfat ext2 fat gzio iso9660 loopback lzopio newc normal ntfs part_gpt part_msdos probe read search tar test configfile echo xzio squash4 sfs memdisk" grub-mkimage -d "${modules}" -m "${tmp}"/memdisk.loop -p "/boot/grub" -c "${tmp}"/settings/config.cfg -o "${tmp}"/grubx64.efi -O x86_64-efi $builtin_pl echo "Copying files in ${workdir}/TEST_GRUB" mkdir -p "${workdir}"/TEST_GRUB/EFI/BOOT cp "${tmp}"/grubx64.efi "${workdir}"/TEST_GRUB/EFI/BOOT/BOOTX64.EFI cp "${tmp}"/gp.loop "${workdir}"/TEST_GRUB/gp.loop rm -rf "${tmp}" ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] multiboot: fix memory leak

2022-10-15 Thread t.feng via Grub-devel
lfsyms) (shnum, ehdr->e_shentsize, shstrndx, shdr); + return GRUB_ERR_NONE; } #undef phdr +fail: + grub_free (shdr); return grub_errno; } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] multiboot: fix memory leak

2022-10-28 Thread t.feng via Grub-devel
GRUB_MULTIBOOT (add_elfsyms) (shnum, ehdr->e_shentsize, shstrndx, shdr); + return GRUB_ERR_NONE; + + fail: + grub_free (shdr); } #undef phdr -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2] multiboot: fix memory leak

2022-11-09 Thread t.feng via Grub-devel
um, ehdr->e_shentsize, shstrndx, shdr); + return GRUB_ERR_NONE; + + fail: + grub_free (shdr); } #undef phdr -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 8/9] fs/squash4: Fix memeory leak in grub_squash_iterate_dir

2022-11-19 Thread t.feng via Grub-devel
grub_memcpy (node, dir, sz - sizeof(dir->stack[0])); -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 4/9] fs/ntfs: Fix memory leak in grub_ntfs_read_symlink

2022-11-19 Thread t.feng via Grub-devel
8 (buf16, len / 2); if (!buf) { + grub_free (mft->buf); grub_free (buf16); return NULL; } + + grub_free (mft->buf); grub_free (buf16); for (end = buf; *end; end++) -- 2.27.0 _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 0/9] fix memory leaks in fs module

2022-11-19 Thread t.feng via Grub-devel
grub-core/fs/xfs.c | 11 +-- 9 files changed, 79 insertions(+), 24 deletions(-) -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 9/9] fs/xfs: Fix memory leaks in xfs

2022-11-19 Thread t.feng via Grub-devel
} entries = (grub_be_to_cpu32 (tail->leaf_count) - grub_be_to_cpu32 (tail->leaf_stale)); -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 7/9] fs/iso9660: Fix memory leak in grub_iso9660_susp_iterate

2022-11-19 Thread t.feng via Grub-devel
} entry = (struct grub_iso9660_susp_entry *) sua; } -- 2.27.0 ___________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 5/9] fs/bfs: Fix memory leak in read_bfs_file

2022-11-19 Thread t.feng via Grub-devel
l2_entries); return GRUB_ERR_NONE; } } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 1/9] fs/affs:Fix memory leaks in grub_affs_create_node

2022-11-19 Thread t.feng via Grub-devel
de); + grub_free (hashtable); return 1; } -- 2.27.0 _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 3/9] fs/minix: Fix memory leak in grub_minix_lookup_symlink

2022-11-19 Thread t.feng via Grub-devel
-return grub_errno; +{ + grub_free (symlink); + return grub_errno; +} grub_minix_find_file (data, symlink); + grub_free (symlink); return grub_errno; } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.g

[PATCH 6/9] fs/hfsplus: Fix memory leak in grub_hfsplus_btree_search

2022-11-19 Thread t.feng via Grub-devel
aligned32 (pointer)); match = 1; -- 2.27.0 ___________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 2/9] fs/btrfs: Fix memory leak in find_path

2022-11-19 Thread t.feng via Grub-devel
ree (direl); + grub_free (path_alloc); + grub_free (origpath); + return err; + } } continue; } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailma

[PATCH V2 8/9] fs/squash4: Fix memeory leak in grub_squash_iterate_dir

2022-11-29 Thread t.feng via Grub-devel
; + } grub_memcpy (node, dir, sz - sizeof(dir->stack[0])); -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 9/9] fs/xfs: Fix memory leaks in xfs

2022-11-29 Thread t.feng via Grub-devel
urn 0; + } entries = (grub_be_to_cpu32 (tail->leaf_count) - grub_be_to_cpu32 (tail->leaf_stale)); -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 7/9] fs/iso9660: Fix memory leak in grub_iso9660_susp_iterate

2022-11-29 Thread t.feng via Grub-devel
e (sua); + return err; + } entry = (struct grub_iso9660_susp_entry *) sua; } -- 2.27.0 ___________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 4/9] fs/ntfs: Fix memory leak in grub_ntfs_read_symlink

2022-11-29 Thread t.feng via Grub-devel
} return buf; + + fail: + grub_free (mft->buf); + grub_free (buf16); + return NULL; } static int -- 2.27.0 _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 1/9] fs/affs:Fix memory leaks in grub_affs_create_node

2022-11-29 Thread t.feng via Grub-devel
. */ grub_free (orig_node); + grub_free (hashtable); return 1; } -- 2.27.0 _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 3/9] fs/minix: Fix memory leak in grub_minix_lookup_symlink

2022-11-29 Thread t.feng via Grub-devel
ata, symlink); + fail: + grub_free(symlink); return grub_errno; } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 2/9] fs/btrfs: Fix memory leak in find_path

2022-11-29 Thread t.feng via Grub-devel
grub_free (direl); + grub_free (path_alloc); + grub_free (origpath); + return err; + } } continue; } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu

[PATCH V2 5/9] fs/bfs: Fix memory leak in read_bfs_file

2022-11-29 Thread t.feng via Grub-devel
l1_entries); +grub_free (l2_entries); return GRUB_ERR_NONE; } } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 0/9] fix memory leaks in fs module

2022-11-29 Thread t.feng via Grub-devel
+++--- grub-core/fs/squash4.c | 20 grub-core/fs/xfs.c | 11 +-- 9 files changed, 67 insertions(+), 31 deletions(-) -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo

[PATCH V2 6/9] fs/hfsplus: Fix memory leak in grub_hfsplus_btree_search

2022-11-29 Thread t.feng via Grub-devel
= grub_be_to_cpu32 (grub_get_unaligned32 (pointer)); match = 1; -- 2.27.0 ___________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 1/4] bash-completion:fix shellcheck error

2022-11-30 Thread t.feng via Grub-devel
+ [ -n "$tmp" ] && { tmp=${tmp##*/} printf '%s\n' ${tmp%.mod} } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 3/4] bash-completion:fix shellcheck SC2155-Warning

2022-11-30 Thread t.feng via Grub-devel
x27; COMPREPLY=() while read -r line; do -- 2.27.0 ___________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 2/4] bash-completion:fix shellcheck SC2207-Warning

2022-11-30 Thread t.feng via Grub-devel
quot; | { - while read -r tmp; do - [ -n "$tmp" ] && { - tmp=${tmp##*/} - printf '%s\n' ${tmp%.mod} - } - done - } - )) +COMPREPLY=() + while read -r line; do +COMPREPLY+=(&

[PATCH V2 0/4] bash-completion:fix shellcheck error and warning

2022-11-30 Thread t.feng via Grub-devel
ompletion.d/grub-completion.bash.in | 41 --- 1 file changed, 26 insertions(+), 15 deletions(-) -- 2.27.0 _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 4/4] bash-completion:disable shellcheck SC2120-Warning

2022-11-30 Thread t.feng via Grub-devel
-- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V3 0/4] bash-completion:fix shellcheck error and warning

2022-12-06 Thread t.feng via Grub-devel
n:disable shellcheck SC2120-Warning .../bash-completion.d/grub-completion.bash.in | 47 --- 1 file changed, 29 insertions(+), 18 deletions(-) -- 2.27.0 _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V3 2/4] bash-completion:fix shellcheck SC2207-Warning

2022-12-06 Thread t.feng via Grub-devel
while read -r tmp; do - [ -n "$tmp" ] && { - tmp=${tmp##*/} - printf '%s\n' ${tmp%.mod} - } - done - } - )) +local line tmp IFS=$'\n' +COMPREPLY=() +while read -r line; do +COMPREPLY+=("${line}") +done < <(compgen -f -X '!*/*.mod' -- "${grub_dir}/$cur" | { +while read -r tmp; do +[ -n "$tmp" ] && { +tmp=${tmp##*/} +printf '%s\n' ${tmp%.mod} +} +done +}) } # -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V3 4/4] bash-completion:disable shellcheck SC2120-Warning

2022-12-06 Thread t.feng via Grub-devel
help of the command # - arg: $1 (optional) command to get the long options from +# shellcheck disable=SC2120 __grub_get_options_from_help () { local prog -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V3 3/4] bash-completion:fix shellcheck SC2155-Warning

2022-12-06 Thread t.feng via Grub-devel
ine IFS=$'\n' @@ -129,7 +130,8 @@ __grub_list_menuentries () { } __grub_list_modules () { -local grub_dir=$(__grub_dir) +local grub_dir +grub_dir=$(__grub_dir) local line tmp IFS=$'\n' COMPREPLY=() while read -r line; do -- 2.27.0 ________

[PATCH V3 1/4] bash-completion:fix shellcheck error

2022-12-06 Thread t.feng via Grub-devel
+ [ -n "$tmp" ] && { tmp=${tmp##*/} printf '%s\n' ${tmp%.mod} } -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

clang appends an extra string to Grub2 making it not work with MBR systems

2023-01-02 Thread Immolo via Grub-devel
se ask for them. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

ZFS encryption support clarification

2023-04-01 Thread weuioy via Grub-devel
manual be more precise on that.___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 1/6] ia64: Remove support

2023-05-11 Thread matoro via Grub-devel
rd resets can be done via management console). If there is any way this support can be saved or at least delayed by providing real hardware to work on, please reach out. The environment is completely remote and available for anybody who would like to give it a try. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 1/6] ia64: Remove support

2023-05-11 Thread matoro via Grub-devel
suosl.org//releases/ia64/autobuilds/ I don't have basically any say here. I am not a GRUB developer. I cannot help rewrite the code myself. I'm not even officially representing a distro like Glaubitz. If the GRUB maintainers are of the opinion that it is not worth the effort to maintain the support, that is sad but understandable. Just thought I'd pipe up and offer what little I can to help, if it's desired. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 1/6] ia64: Remove support

2023-05-12 Thread matoro via Grub-devel
sion; - we decide that GRUB 2.xx (whichever was the most recent release at the time of the decision) is good enough to boot Linux on ia64 for the remaining life time of the architecture, and remove it from the GRUB tree. So the final option has my preference (in case that wasn't obvious), an

Re: Re: [PATCH] acpi: use xsdt_addr if present

2023-06-12 Thread zhangqiumiao via Grub-devel
On Thu, Jun 08, 2023 at 07:09:36PM +0800, Qiumiao Zhang via Grub-devel wrote: >> According to the UEFI specification, in ACPI 2.0 or later, an >> ACPI-compatible OS must use the XSDT if present. > Sorry, I cannot find this in the UEFI spec. Though something more generic is >

Slow x86 BIOS load with certain partition CHS values

2023-07-02 Thread ValdikSS via Grub-devel
tors, then 1 sector again, which decreases the performance, but not by much. P.S. nativedisk doesn't have any performance problems. Thanks. OpenPGP_signature Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] i386: flush cache only on VIA C3 and earlier

2023-07-06 Thread ValdikSS via Grub-devel
(((procinfo & 0xF0) >> 4 | (procinfo & 0xF) >> 12) > 10) +return; +} + grub_bios_via_workaround1 = 0x090f; grub_bios_via_workaround2 = 0x090f; asm volatile ("wbinvd"); -- 2.41.0 _______ Grub-devel ma

[PATCH v2] i386: flush cache only on VIA C3 and earlier

2023-07-06 Thread ValdikSS via Grub-devel
(((procinfo & 0xF0) >> 4 | (procinfo & 0xF) >> 12) > 10) +return; +} + grub_bios_via_workaround1 = 0x090f; grub_bios_via_workaround2 = 0x090f; asm volatile ("wbinvd"); -- 2.41.0 _______ Grub-devel ma

[PATCH 0/2] disk: use maximum number of sectors for LBA

2023-07-06 Thread ValdikSS via Grub-devel
. See: https://lists.gnu.org/archive/html/grub-devel/2023-07/msg1.html ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 1/2] disk: read up to 63 sectors in LBA mode

2023-07-06 Thread ValdikSS via Grub-devel
There's no need to obey CHS layout restrictions for LBA reads on LBA disks, it only slows down booting process. See: https://lists.gnu.org/archive/html/grub-devel/2023-07/msg1.html --- grub-core/disk/i386/pc/biosdisk.c | 5 - include/grub/disk.h | 3 +++ 2 files chang

[PATCH 2/2] disk: increase sector size up to 127 for LBA reads

2023-07-06 Thread ValdikSS via Grub-devel
L -- 2.41.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

How to detect the amount of RAM on non-EFI platforms?

2023-07-10 Thread Cyan via Grub-devel
oot kernels which complies with Multiboot specification, so the memory info should be always present. If I missed something, please point it out. Thanks, Cinhi Young _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: How to detect the amount of RAM on non-EFI platforms?

2023-07-13 Thread Cyan via Grub-devel
Hi Daniel, On 7/14/23 02:38, Daniel Kiper wrote: > On Tue, Jul 11, 2023 at 09:37:15PM +0800, Cyan Yang via Grub-devel wrote: > > You are mixing enum and int types. The function should return 0 here. > Yes, the hook function should return zero instead of enum vaule GRUB_ERR_NONE.

How Linus distro like Fedora named all utilities binary file prefixed with grub2-*

2023-09-26 Thread document via Grub-devel
about my poor English :P _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: How Linus distro like Fedora named all utilities binary file prefixed with grub2-*

2023-09-26 Thread document via Grub-devel
> We used to do that on Gentoo, but switched back to the "grub-" names a > few years ago. Changes like this situation always prefer looks like a joke for newbie, and the world always change, but kind heart communite people like you help newbie growing up. Thanks again.___

Re: [PATCH 0/2] disk: use maximum number of sectors for LBA

2023-10-06 Thread ValdikSS via Grub-devel
eatly increased boot times on WYSE C10LE x86 thin client with Phoenix bios. See: https://lists.gnu.org/archive/html/grub-devel/2023-07/msg1.html First, this seems risky to me to be added for the release. Why do we believe that some other bios doesn't have a limit less than 127? I

Re: [PATCH 1/2] disk: read up to 63 sectors in LBA mode

2023-10-06 Thread ValdikSS via Grub-devel
ds, and the later patch increases overall limit value to 127. OpenPGP_signature Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 2/2] disk: increase sector size up to 127 for LBA reads

2023-10-06 Thread ValdikSS via Grub-devel
s, we need to be able to put in the cache up to 65024 bytes. Without this change, GRUB wouldn't try to read more than 64 sectors at once (even if the lower reading layer allows it). OpenPGP_signature Description: OpenPGP digital signature ___________ Grub-

[PATCH v2 0/2] disk: use maximum number of sectors for LBA

2023-10-06 Thread ValdikSS via Grub-devel
x86 thin client with Phoenix bios. See: https://lore.kernel.org/grub-devel/d42a11fa-2a59-b5e7-08b1-d2c60444b...@valdikss.org.ru/ ValdikSS (2): disk: read up to 63 sectors in LBA mode disk: increase sector size up to 127 for LBA reads grub-core/disk/i386/pc/biosdisk.c | 5 - include/grub

[PATCH v2 1/2] disk: read up to 63 sectors in LBA mode

2023-10-06 Thread ValdikSS via Grub-devel
Current code impose limitations on the amount of sectors read in a single call according to CHS layout of the disk, even in LBA read mode. There's no need to obey CHS layout restrictions for LBA reads on LBA disks, it only slows down booting process. See: https://lore.kernel.org/grub-

[PATCH v2 2/2] disk: increase sector size up to 127 for LBA reads

2023-10-06 Thread ValdikSS via Grub-devel
0xULL -- 2.41.0 _______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v3] i386: flush cache only on VIA C3 and earlier

2023-10-06 Thread ValdikSS via Grub-devel
______ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2] i386: flush cache only on VIA C3 and earlier

2023-10-06 Thread ValdikSS via Grub-devel
On 05.10.2023 19:57, Daniel Kiper wrote: On Fri, Jul 07, 2023 at 12:33:32AM +0300, ValdikSS via Grub-devel wrote: The code used to flush the cache on VIA processors unconditionally, which is excessive. Check for cpuid family and execute wbinvd only on C3 and earlier. See: https

  1   2   3   4   5   6   7   8   9   10   >