Re: [PATCH v2 8/8] LoongArch: Add to build system

2022-02-23 Thread WANG Xuerui
Hi, On 2/23/22 21:46, Xiaotian Wu wrote: Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- Makefile.util.def | 1 + conf/Makefile.common| 3 +++ configure.ac| 7 ++ gentpl.py | 25 ++- grub-core/Makefile.am

Re: [PATCH v2 1/8] PE: Add LoongArch definitions

2022-02-23 Thread WANG Xuerui
h this Microsoft PR [2]), so: Reviewed-by: WANG Xuerui [1]: https://docs.microsoft.com/en-us/windows/win32/debug/pe-format [2]: https://github.com/MicrosoftDocs/win32/pull/1067 OpenPGP_0xC01F7214BC931414.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital sig

Re: [PATCH v2 6/8] LoongArch: Add awareness for LoongArch relocations

2022-02-23 Thread WANG Xuerui
Hi, On 2/23/22 21:46, Xiaotian Wu wrote: Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- grub-core/kern/dl.c| 9 +- grub-core/kern/loongarch64/dl.c| 102 + grub-core/kern/loongarch64/dl_helper.c | 198 + include/gru

Re: [PATCH v2 3/8] LoongArch: Add setjmp implementation

2022-02-23 Thread WANG Xuerui
+ +typedef grub_uint64_t grub_jmp_buf[12]; + +int grub_setjmp (grub_jmp_buf env) RETURNS_TWICE; +void grub_longjmp (grub_jmp_buf env, int val) __attribute__ ((noreturn)); + +#endif /* ! GRUB_SETJMP_CPU_HEADER */ With the nit addressed: Reviewed-by: WANG Xuerui OpenPGP_0xC01F7214B

Re: [PATCH v2 4/8] LoongArch: Add early startup code

2022-02-23 Thread WANG Xuerui
d$a0, $a2, 0 + la $a2, EXT_C(grub_efi_system_table) + st.d$a1, $a2, 0 + + b EXT_C(grub_main) Reviewed-by: WANG Xuerui OpenPGP_0xC01F7214BC931414.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP d

Re: [PATCH v2 2/8] Add LoongArch definitions

2022-02-23 Thread WANG Xuerui
R_LARCH_SOP_POP_32_S_0_5_10_16_S2 44 +#define R_LARCH_SOP_POP_32_S_0_10_10_16_S245 + #ifdef GRUB_TARGET_WORDSIZE #if GRUB_TARGET_WORDSIZE == 32 This is consistent with the binutils definitions [1], trimmed down to remove reloc types unused by GRUB, so: Reviewed-by: WANG Xuerui

Re: [PATCH v5 2/9] Add LoongArch definitions

2022-07-29 Thread WANG Xuerui
On 2022/7/29 15:11, Xiaotian Wu wrote: Signed-off-by: Xiaotian Wu Signed-off-by: Zhou Yang --- include/grub/elf.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/grub/elf.h b/include/grub/elf.h index c478933ee..1c8d4f5d5 100644 --- a/include/grub/elf.h ++

Re: [PATCH v13 0/9] Add LoongArch support

2023-03-31 Thread WANG Xuerui
ole series: Tested-by: WANG Xuerui Thanks for all your (and your team's) hard work. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v13 7/9] LoongArch: Add to build system

2023-04-06 Thread WANG Xuerui
Hi, On 2023/4/6 16:36, Xiaotian Wu wrote: I used "git send-email" to send patches #0 to #9, but after #6 patch was sent, the mail server told me: "too many commands", so I sent it again, the error remained. In the end, I sent #7 #8 #9 patches with "git send-email", so they are outside the threa

[PATCH] loongarch: Avoid undefined behavior when popping from an empty reloc stack

2023-05-17 Thread WANG Xuerui
407778 Signed-off-by: WANG Xuerui --- grub-core/kern/loongarch64/dl_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/loongarch64/dl_helper.c b/grub-core/kern/loongarch64/dl_helper.c index e8ec1219f..cda1a53c8 100644 --- a/grub-core/kern/loongarch64

Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-11 Thread WANG Xuerui
On 6/12/23 11:09, Xiaotian Wu wrote: 在 2023-06-12星期一的 06:35 +0800,Xi Ruoyao via Grub-devel写道: On Wed, 2023-06-07 at 15:34 +0800, Xiaotian Wu wrote: Because the binutils of the loongarch architecture adds relaxation support [1], the next version of binutils will not be able to build grub. So w

Re: [PATCH v2 0/5] loongarch: add relaxation support

2023-06-12 Thread WANG Xuerui
On 6/13/23 11:25, mengqinggang wrote: Is this  patch used to check if ld supports --no-relax option? It need to pass -mno-relax option to as or gcc to disable binutils generate relaxation relocations. It shouldn't be necessary to disable relaxation that early, because code before relaxation sh

Re: [PATCH v3 5/5] loongarch: Use the -mno-relax cflags for gcc

2023-06-13 Thread WANG Xuerui
On 2023/6/13 17:06, Xiaotian Wu wrote: Because the binutils of the loongarch architecture adds relaxation support [1], the next version of binutils will not be able to build grub. We can simplify the sentence a bit, like "A working grub cannot be built with upcoming binutils and gcc, because