Re: Additional Relocations (R_ARM_THM_MOVT_ABS) support in mkimage.

2018-05-28 Thread Vladimir 'phcoder' Serbinenko
On Mon, 28 May 2018, 23:08 amit94, wrote: > Hi, > > I'm trying to cross compile grub for armv7, and I get these errors on > running `grub-mkstandalone` > > grub-mkstandalone: error: relocation 0x2f is not implemented yet. > > The issue seems to be that the R_ARM_THM_MOVT_ABS_NC is not supported i

Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning

2018-05-29 Thread Vladimir 'phcoder' Serbinenko
On Tue, 29 May 2018, 13:58 Oleg Solovyov, wrote: > Anybody? > Why do you need this? Normally the same devices should be under /dev/mapper. Using dm-X will mess up some other code most likely > > > 14.05.2018 20:13, Daniel Kiper пишет: > > On Fri, May 11, 2018 at 02:32:48PM +0300, Oleg Solovyov w

Re: Add MD5 support

2018-07-17 Thread Vladimir 'phcoder' Serbinenko
On Wed, 18 Jul 2018, 03:13 Samir Aguiar, wrote: > Hi all, > > We need support for MD5 passwords - which were used in grub legacy - so > we can update to 2.x. Basically we can't migrate existing installations > since it's one-way hashing and so on. > > I will start working on it, but I would like

Re: Recent removal of a.out and COFF support for sparc

2018-08-07 Thread Vladimir 'phcoder' Serbinenko
I can change code to do conversion to coff ourselves. вт, 7 авг. 2018 г., 12:56 John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de>: > Hello! > > binutils/bfd recently removed a.out and COFF support for sparc [1]. > > Unfortunately, this means that we are no longer able to built GRUB > or S

Re: questions about relocator16.S

2018-08-14 Thread Vladimir &#x27;phcoder' Serbinenko
вт, 14 авг. 2018 г., 9:11 Cao jin : > Hi, > > I am learning these code, and now have 2 questions: > > 1. at the bottom of relocator_common.S, there is: > > LOCAL(jump_vector): > /* Jump location. Is filled by the code */ > .long 0 > .long CODE_SEGMENT > > Since it is

Re: Legacy Firmware/INT 13H supporting >512 byte sectors?

2018-08-17 Thread Vladimir &#x27;phcoder' Serbinenko
пт, 17 авг. 2018 г., 17:14 Mihai Moldovan : > Hi > > > Just a quick question: did anyone ever come up a BIOS firmware that > supports > sector sizes higher than 512 bytes (say 4096 bytes)? > Sure. Any BIOS able to read CD supports 2K sectors. If you mean HDD then I have never seen one. I wrote sup

Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-09-06 Thread Vladimir &#x27;phcoder' Serbinenko
Unfortunately this pulls in some problematic graphics drivers that shouldn't be in default payload On Thu, 6 Sep 2018, 14:59 Daniel Kiper, wrote: > On Thu, Aug 09, 2018 at 08:20:07AM +0200, Paul Menzel wrote: > > Date: Sun, 16 Apr 2017 21:02:58 +0200 > > > > The module `all_video` is used in `ut

Re: [PATCH] osdep/linux: convert partition start to disk sector length.

2018-09-06 Thread Vladimir &#x27;phcoder' Serbinenko
Grub partition get start returns in 512B blocks. Can I have more details like which partmap you use? On Mon, 23 Jul 2018, 09:54 Mihai Moldovan, wrote: > When reading data off a disk, sector values are based on the disk sector > length. > > Within grub_util_fd_open_device(), the start of the part

Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

2018-09-06 Thread Vladimir &#x27;phcoder' Serbinenko
On Thu, 6 Sep 2018, 17:03 Paul Menzel, wrote: > Date: Thu, 6 Sep 2018 15:15:45 +0200 > > If executing `efibootmgr` fails, for example, because the system is > booted in legacy mode, but with a mounted EFI System Partition, the > error message mentions *efibootmgr*. To make it easier for users to

Re: arm64/xen: Remove duplicate check for arguments

2018-11-20 Thread Vladimir &#x27;phcoder' Serbinenko
On Tue, 20 Nov 2018, 14:40 Lee Jones, wrote: > From: Lee Jones > > arm64/xen: Remove duplicate check for arguments > It's not duplicate because of argc-- right before it > > Signed-off-by: Lee Jones > > diff --git a/grub-core/loader/arm64/xen_boot.c > b/grub-core/loader/arm64/xen_boot.c > inde

Re: [PATCH v3 (part 2)] generic/blocklist: Fix implicit declaration of function ‘grub_file_filter_disable_compression'

2018-11-20 Thread Vladimir &#x27;phcoder' Serbinenko
LGTM On Tue, 20 Nov 2018, 14:40 Lee Jones, wrote: > From: Lee Jones > > generic/blocklist: Fix implicit declaration of function > ‘grub_file_filter_disable_compression' > > grub_file_filter_disable_compression() no longer exists. > > Signed-off-by: Lee Jones > > diff --git a/grub-core/osdep/ge

GRUB 2.04 freeze date announcement

2019-03-01 Thread Vladimir &#x27;phcoder' Serbinenko
Hello everyone! We are happy to announce that the upcoming release of Grub 2.04 is expected in March. In order to prepare the release we would freeze on Monday, March 11, 23:59:59 UTC. From that point no new features are accepted unless there is a very good reason to. We will still accept bugfixes

[PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-POTFILES-Don-t-include-gnulib-in-grub.pot.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] efi/tpm.c: Add missing casts

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0002-efi-tpm.c-Add-missing-casts.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Propagate GNU_PRINTF from gnulib vfprintf

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-Propagate-GNU_PRINTF-from-gnulib-vfprintf.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] grub-mkimagexx: Fix RISCV error message

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-grub-mkimagexx-Fix-RISCV-error-message.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Rename grub_disk members

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-Rename-grub_disk-members.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] kern/emu/misc.c: Don't include config-util.h when running as GRUB_BUILD

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0003-kern-emu-misc.c-Don-t-include-config-util.h-when-run.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] efi/tpm.h: Fix hash_log_extend_event definition

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0002-efi-tpm.h-Fix-hash_log_extend_event-definition.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Support R_PPC_PLTREL24

2019-03-22 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-Support-R_PPC_PLTREL24.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] efi/tpm.c: Add missing casts

2019-03-25 Thread Vladimir &#x27;phcoder' Serbinenko
On Mon, Mar 25, 2019 at 1:09 PM Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 04:11:10PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > From 9443713c3d3403a21aac9b39de4bbd097a531dd4 Mon Sep 17 00:00:00 2001 > > From: Vladimir Serbinenko > > Date: Fri, 22 M

Re: [PATCH] Propagate GNU_PRINTF from gnulib vfprintf

2019-03-25 Thread Vladimir &#x27;phcoder' Serbinenko
On Mon, Mar 25, 2019 at 1:24 PM Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 04:15:35PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > From ce156e3274e53089b7a9ba432262b8aab75d8ad0 Mon Sep 17 00:00:00 2001 > > From: Vladimir Serbinenko > > Date: Fri, 22 M

Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Vladimir &#x27;phcoder' Serbinenko
-- Forwarded message - From: Vladimir 'phcoder' Serbinenko Date: Mon, Mar 25, 2019 at 3:22 PM Subject: Re: [PATCH] POTFILES: Don't include gnulib in grub.pot To: Daniel Kiper On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper wrote: > > Sadly this patch d

[PATCH v2] POTFILES: Don't include gnulib in grub.pot

2019-03-25 Thread Vladimir &#x27;phcoder' Serbinenko
re/lib/libgcrypt/src/global.c' ! -ipath './grub-core/lib/libgcrypt/src/secmem.c' ! -ipath './util/grub-gen-widthspec.c' ! -ipath './util/grub-gen-asciih.c' ! -ipath './gnulib/*' ! -iname './grub-core/

[PATCH] hostfs: #undef open and close.

2019-03-25 Thread Vladimir &#x27;phcoder' Serbinenko
-173,6 +173,9 @@ grub_hostfs_label (grub_device_t device __attribute ((unused)), return GRUB_ERR_NONE; } +#undef open +#undef close + static struct grub_fs grub_hostfs_fs = { .name = "hostfs", -- 2.11.0 -- Regards Vladimir 'phcoder' Serbinenko _

[PATCH] configure.ac: Use nostdlib when checking for nostdinc

2019-03-25 Thread Vladimir &#x27;phcoder' Serbinenko
_CPPFLAGS -nostdlib -nostdinc -isystem `$TARGET_CC -print-file-name=include`" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include #include int va_arg_func (int fixed, va_list args);]], [[]])], -- 2.11.0 -- Regards Vladimir 'phcoder' Serbinenko ___

[PATCH] A workaround for clang problem assembling startup_raw.S

2019-03-26 Thread Vladimir &#x27;phcoder' Serbinenko
t -- 2.11.0 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Pair -Qn with -Qunused-arguments.

2019-03-26 Thread Vladimir &#x27;phcoder' Serbinenko
yes], [grub_cv_target_cc_qn=no])]) if test "x$grub_cv_target_cc_qn" = xyes; then - TARGET_CFLAGS="$TARGET_CFLAGS -Qn" + TARGET_CFLAGS="$TARGET_CFLAGS -Qn -Qunused-arguments" fi # -- 2.11.0 -- Regards Vladimir 'phcoder' Serbinenko _

[PATCH] Change fs functions to add fs_ prefix

2019-04-07 Thread Vladimir &#x27;phcoder' Serbinenko
B_ERR_NONE) grub_util_error ("%s", grub_errmsg); printf ("%s", uuid); @@ -458,11 +458,11 @@ probe (const char *path, char **device_names, char delim) else if (print == PRINT_FS_LABEL) { char *label; - if (! fs->label) + if (! fs->fs_label) grub_util_error (_("filesystem `%s' does not support labels"), fs->name); - if (fs->label (dev, &label) != GRUB_ERR_NONE) + if (fs->fs_label (dev, &label) != GRUB_ERR_NONE) grub_util_error ("%s", grub_errmsg); printf ("%s", label); diff --git a/util/setup.c b/util/setup.c index 92a5af9ba..6f88f3cc4 100644 --- a/util/setup.c +++ b/util/setup.c @@ -491,7 +491,7 @@ SETUP (const char *dir, goto unable_to_embed; } -if (fs && !fs->embed) +if (fs && !fs->fs_embed) { grub_util_warn (_("File system `%s' doesn't support embedding"), fs->name); @@ -529,8 +529,8 @@ SETUP (const char *dir, err = ctx.dest_partmap->embed (dest_dev->disk, &nsec, maxsec, GRUB_EMBED_PCBIOS, §ors); else - err = fs->embed (dest_dev, &nsec, maxsec, -GRUB_EMBED_PCBIOS, §ors); + err = fs->fs_embed (dest_dev, &nsec, maxsec, + GRUB_EMBED_PCBIOS, §ors); if (!err && nsec < core_sectors) { err = grub_error (GRUB_ERR_OUT_OF_RANGE, -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Change fs functions to add fs_ prefix

2019-04-08 Thread Vladimir &#x27;phcoder' Serbinenko
On Mon, Apr 8, 2019 at 8:07 PM Daniel Kiper wrote: > > On Mon, Apr 08, 2019 at 03:28:48PM +1000, Vladimir 'phcoder' Serbinenko wrote: > > commit 820906d7b1e68559bcf1b3e0cb56e46cded3e84b > > Author: Vladimir Serbinenko > > Date: Mon Apr 8 07:24:24 2019 +0200

GRUB 2.04 RC01 released

2019-04-09 Thread Vladimir &#x27;phcoder' Serbinenko
x86_64-efi flavours) it’s available under http://alpha.gnu.org/gnu/grub/grub-2.04~rc1-for-windows.zip and signature at http://alpha.gnu.org/gnu/grub/grub-2.04~rc1-for-windows.zip.sig Thank you again to all the contributors GRUB maintenance team -- Regards Vladimir 'phco

Re: [PATCH 0/8] fix gcc9 build with -Werror=address-of-packed-member

2019-04-09 Thread Vladimir &#x27;phcoder' Serbinenko
_ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 0/8] fix gcc9 build with -Werror=address-of-packed-member

2019-04-09 Thread Vladimir &#x27;phcoder' Serbinenko
On Tue, Apr 9, 2019 at 9:40 PM Michael Chang wrote: > > On Tue, Apr 09, 2019 at 08:57:25PM +1000, Vladimir 'phcoder' Serbinenko wrote: > > On Tue, Apr 9, 2019 at 8:48 PM Michael Chang wrote: > > > > > > This patch set attempts to resolve the build failure

Re: [PATCH] x86/msr: Fix build with older GCC versions

2019-04-12 Thread Vladimir &#x27;phcoder' Serbinenko
s results in a GP#. > */ > > -extern inline void grub_msr_write(grub_uint32_t msr_id, grub_uint64_t > msr_value) > +static inline void > +grub_msr_write(grub_uint32_t msr_id, grub_uint64_t msr_value) > { >grub_uint32_t low = msr_value, high = msr_value >&

Re: GRUB fails to load kernel on linux-sparc64

2019-04-17 Thread Vladimir &#x27;phcoder' Serbinenko
Try insmod xzio insmod gzio insmod lzopio On Wed, 17 Apr 2019, 07:39 John Paul Adrian Glaubitz, < glaub...@physik.fu-berlin.de> wrote: > Hi Eric! > > On 4/16/19 9:27 PM, Eric Snowberg wrote: > >> @Eric: Does GRUB 2.04~rc1 work fine for you on sparc64? > > > > I boot with an uncompressed kernel an

Re: grub-mkrescue: Problem with MBR partition table at start of EFI partition

2019-04-21 Thread Vladimir &#x27;phcoder' Serbinenko
On Mon, 22 Apr 2019, 01:42 Thomas Schmitt, wrote: > Hi, > > this is about how exactly to solve a diagnosed and worked-around problem. > > Guix is one of the few distros which make their installation ISOs by > help of grub-mkrescue. The EFI boot manager of an old Macbook got stuck > when such an I

Re: [PATCH] arm: Move trampolines into code section

2019-04-30 Thread Vladimir &#x27;phcoder' Serbinenko
LGTM On Tue, 30 Apr 2019, 10:12 Alexander Graf, wrote: > When creating T32->A32 transition jumps, the relocation code in grub > will generate trampolines. These trampolines live in the .data section > of our PE binary which means they are not marked as executable. > > This misbehavior was unmask

Re: [PATCH] arm: Move trampolines into code section

2019-04-30 Thread Vladimir &#x27;phcoder' Serbinenko
On Tue, 30 Apr 2019, 22:15 Leif Lindholm, wrote: > On Tue, Apr 30, 2019 at 02:12:17AM +0200, Alexander Graf wrote: > > When creating T32->A32 transition jumps, the relocation code in grub > > will generate trampolines. These trampolines live in the .data section > > of our PE binary which means t

Re: grub-mkrescue: Problem with MBR partition table at start of EFI partition

2019-04-30 Thread Vladimir &#x27;phcoder' Serbinenko
There is an easy way to check if -k can be used always: have a look at windows install CD/DVD. If it doesn't have partion table then we can drop it as well. On Thu, 25 Apr 2019, 18:16 Thomas Schmitt, wrote: > Hi, > > Daniel Kiper wrote: > > How do you create USB stick from ISO image? > > By plai

Re: [PATCH v3] probe: Support probing for GPT partition UUID with -q

2019-05-13 Thread Vladimir &#x27;phcoder' Serbinenko
On Fri, 10 May 2019, 19:05 Jacob Kroon, wrote: > Linux supports root=PARTUUID= boot argument, so add > support for probing it. Compared to the fs UUID, the partition > UUID does not change when reformatting a partition. > > Signed-off-by: Jacob Kroon > --- > grub-core/commands/probe.c | 35

Re: [PATCH v2] Optimization calculation expression of FOR_MODULES(var)

2019-05-13 Thread Vladimir &#x27;phcoder' Serbinenko
As already noticed this is actually on purpose to align pointer on addr_t size. On Thu, 11 Apr 2019, 20:04 Milo Wenxiang Niu, wrote: > From: Milo Wenxiang X Niu > > It's just to remove the common factor: "sizeof (grub_addr_t)" from the > numerator and denominator of the fractional expression o

Re: [PATCH v5] probe: Support probing for GPT partition UUID with -g

2019-05-13 Thread Vladimir &#x27;phcoder' Serbinenko
Ideally the option shouldn't be specific to GPT as other partmaps also have stable IDs. I think it's better not to have short option at all On Mon, 13 May 2019, 20:33 Jacob Kroon, wrote: > Linux supports root=PARTUUID= boot argument, so add > support for probing it. Compared to the fs UUID, the

[PATCH] configure: Add -fno-ident when available

2019-07-09 Thread Vladimir &#x27;phcoder' Serbinenko
OGRAM([[]], [[]])], + [grub_cv_cc_fno_unwind_tables=yes], + [grub_cv_cc_fno_unwind_tables=no]) +]) + +if test "x$grub_cv_cc_fno_unwind_tables" = xyes; then + TARGET_CFLAGS="$TARGET_CFLAGS -fno-unwind-tables" +fi + CFLAGS="$TARGET_CFLAGS" -- 2.11.0 -- R

Re: [PATCH] configure: Add -fno-ident when available

2019-07-11 Thread Vladimir &#x27;phcoder' Serbinenko
TARGET_CFLAGS="$TARGET_CFLAGS -fno-ident" +fi + CFLAGS="$TARGET_CFLAGS" -- 2.11.0 On Thu, Jul 11, 2019 at 12:32 PM Daniel Kiper wrote: > > On Tue, Jul 09, 2019 at 05:52:58PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On mingw i386-pc without

Re: [PATCH] configure: Add -fno-ident when available

2019-07-11 Thread Vladimir &#x27;phcoder' Serbinenko
On Thu, Jul 11, 2019 at 12:32 PM Daniel Kiper wrote: > > On Tue, Jul 09, 2019 at 05:52:58PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On mingw i386-pc without this option mingw generates a > > rdata$zzz symbol that is page-aligned and hence lzma_decompre

Re: [PATCH] configure: disable arm movw/movt relocations for GCC

2019-07-11 Thread Vladimir &#x27;phcoder' Serbinenko
LGTM On Tue, 4 Jun 2019, 13:40 Leif Lindholm, wrote: > When building for arm, we already disable movw/movt relocations for clang, > since they are incompatible with PE. > > When building with bare metal GCC toolchains (like the one used in the > travis ci scripts), we end up with these relocatio

Re: [PATCH] sparc64: Fix BIOS Boot Partition support

2019-07-16 Thread Vladimir &#x27;phcoder' Serbinenko
= root_dev->disk->partition; > -bl.gpt_offset = 0; > > if (grub_strstr (container->partmap->name, "gpt")) >bl.gpt_offset = grub_partition_get_start (container); > -- > 2.20.1 > > > __________

Re: [PATCH] grub-core/commands/basic_math.c: New commands to perform basic math operations on variables

2019-07-16 Thread Vladimir &#x27;phcoder' Serbinenko
We should rather have $[...] syntax in parser rather than ad-hoc math commands On Tue, 16 Jul 2019, 19:15 glenn tanner, wrote: > Added new commands to add and subtract values from grub variables, was > desirable for automated testing. Compiled and tested under x86_64-efi. > > diff --git a/grub-c

Re: [PATCH] grub-core/commands/basic_math.c: New commands to perform basic math operations on variables

2019-07-16 Thread Vladimir &#x27;phcoder' Serbinenko
On Tue, 16 Jul 2019, 19:15 glenn tanner, wrote: > Added new commands to add and subtract values from grub variables, was > desirable for automated testing. Compiled and tested under x86_64-efi. > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index 474a63e68..c383f0157

Re: [PATCH] sparc64: Fix BIOS Boot Partition support

2019-07-18 Thread Vladimir &#x27;phcoder' Serbinenko
Committed On Thu, Jul 18, 2019 at 12:03 AM John Paul Adrian Glaubitz wrote: > > On 7/16/19 2:02 PM, Vladimir 'phcoder' Serbinenko wrote: > > LGTM. Let's give it another day on ML, then I'll commit it > Friendly reminder ;-). > > Adrian > > -- >

Re: GRUB bug with UEFI mode on HP 250 G6 Notebook

2019-07-18 Thread Vladimir &#x27;phcoder' Serbinenko
mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: APFS support

2019-07-18 Thread Vladimir &#x27;phcoder' Serbinenko
Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 00/10] Travis fixes

2019-07-18 Thread Vladimir &#x27;phcoder' Serbinenko
___________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Grub2.02 installed with Pythin 3, boots Xen Dom0 but not Xen DomU-s

2019-07-21 Thread Vladimir &#x27;phcoder' Serbinenko
Pygrub is not part of grub project. On Sun, 21 Jul 2019, 12:58 Kevin Buckley, wrote: > Hi there, > > this may well fall into a "Grub2 should not be run under Python3" > basket, hence not submitting a bug at savannah, however the fact > that my Grub appears to allow me to boot my Dom0 system, but

Re: Can the grub2.02 improve the limit of initrd size in 64-bit system?

2019-07-31 Thread Vladimir &#x27;phcoder' Serbinenko
> So 32 bit arm requires kernel + initrd less than 512MB, 64 bit > arm requires kernel + inirrd less than 32GB. If I read the code > correctly, booting x86 in efi mode the max initrd file allocation is 1GB > (0x3fff). Seems the code is shared for 32 and 64 bit EFI and doesn't > allow anything

Re: Can the grub2.02 improve the limit of initrd size in 64-bit system? (Lennart Sorensen)

2019-08-01 Thread Vladimir &#x27;phcoder' Serbinenko
On Thu, 1 Aug 2019, 05:20 Zhang, wrote: > > Yes,I want to an initrd as big as possible on the service where ram size > is large. > Why? Please detail your usecase > > ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listin

Re: Can the grub2.02 improve the limit of initrd size in 64-bit system?

2019-08-02 Thread Vladimir &#x27;phcoder' Serbinenko
пт, 2 авг. 2019 г., 08:45 Zhang : > > > Yes,I want to an initrd as big as possible on the service where ram size > is large. Maybe the initrd can include files > 1GB. > > I am sorry that I have a mistake.The right is as follows: > x86_64: > > *It seems good for initrd size between 0x37fe-0x7

Re: [PATCH] grub-mkconfig: Fix typo in --help output

2019-08-23 Thread Vladimir &#x27;phcoder' Serbinenko
LGTM On Fri, 23 Aug 2019, 13:02 Colin Watson, wrote: > The short form of "--version" that grub-mkconfig accepts is "-V", not > "-v". > > Fixes Debian bug #935504. > > Signed-off-by: Colin Watson > --- > util/grub-mkconfig.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: Interest in a patch to edit/view EFI Boot* variables

2019-09-30 Thread Vladimir &#x27;phcoder' Serbinenko
Also we need to add safeguards to never fill more than half of variable storage, same as Linux. Just to avoid bricking bad firmwares On Mon, 30 Sep 2019, 13:16 Daniel Kiper, wrote: > On Sun, Sep 15, 2019 at 05:14:02PM +0200, Sam van Kampen via Grub-devel > wrote: > > Hey all, > > > > To solve a

Re: [PATCH] usb_gamepad: Add support for Logitech Rumble Gamepad F510

2019-09-30 Thread Vladimir &#x27;phcoder' Serbinenko
Patch looks good in concept but I have few questions: 1. How is it different from normal HID 2. Why do you do custom mapping I'm the driver, why not just pass the events pretty much as is 3. Why is it predicated on a particular device model rather than on device class? On Sun, 29 Sep 2019, 15:59 A

Re: [PATCH] Fix security issue when reading username and password

2019-10-24 Thread Vladimir &#x27;phcoder' Serbinenko
; } > > - if (key == GRUB_TERM_BACKSPACE) > + if (key == GRUB_TERM_BACKSPACE && cur_len) > { > if (cur_len) > { > -- > 2.21.0 > > > ___ > Grub-devel mailing list > Grub

Re: [PATCH] Fix security issue when reading username and password

2019-10-24 Thread Vladimir &#x27;phcoder' Serbinenko
On Thu, 24 Oct 2019, 18:11 Daniel Kiper, wrote: > Hi Hector, > > On Thu, Oct 24, 2019 at 03:22:43PM +0100, Hector Marco wrote: > > Hello Daniel, > > > > Something went wrong in my last email, what I wanted to say is: > > > > The patch prevents that "cur_len" underflows. No negative values for > >

Re: [PATCH] Enable pager by default

2019-10-24 Thread Vladimir &#x27;phcoder' Serbinenko
if (cmd->flags & GRUB_COMMAND_FLAG_BLOCKS && > > cmd->flags & GRUB_COMMAND_FLAG_EXTCMD) > > ret = grub_extcmd_dispatcher (cmd, argc, args, ctxt->script); > >else > > ret = (cmd->func) (cmd, argc, args); > > + > > + if (cmd->flags & GRUB_COMMAND_FLAG_PAGINATED) > > +grub_disable_temp_more (); > > } > >else > > ret = grub_errno; > > diff --git a/grub-core/normal/term.c b/grub-core/normal/term.c > > index a1e5c5a0daf..7d4021ff8be 100644 > > --- a/grub-core/normal/term.c > > +++ b/grub-core/normal/term.c > > @@ -57,6 +57,7 @@ static struct term_state *term_states = NULL; > > > > /* If the more pager is active. */ > > static int grub_more; > > +static int temp_more; > > > > static void > > putcode_real (grub_uint32_t code, struct grub_term_output *term, int > > fixed_tab); > > @@ -128,6 +129,22 @@ grub_set_more (int onoff) > >grub_normal_reset_more (); > > } > > > > +void > > +grub_enable_temp_more (void) > > +{ > > + temp_more = grub_more; > > + > > + if (!temp_more) > > +grub_set_more (1); > > Does it change pager variable value? If yes I think > that you should store its original value here and > restore below. > > > +} > > + > > +void > > +grub_disable_temp_more (void) > > +{ > > + if (!temp_more) > > +grub_set_more (0); > > Daniel > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Enable pager by default

2019-10-25 Thread Vladimir &#x27;phcoder' Serbinenko
On Fri, 25 Oct 2019, 08:20 Michael Chang, wrote: > On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote: > > On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrote: > > > On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote: > > > > On Tue, Oct 22, 2019 at 10:30:20AM +0200,

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-29 Thread Vladimir &#x27;phcoder' Serbinenko
What is the problem with main grub.cfg just including the files based on environment variables? On Tue, 29 Oct 2019, 15:16 Javier Martinez Canillas, wrote: > From: Paulo Flabiano Smorigo > > This patch implements a search for a specific configuration when the config > file is on a remoteserver.

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Vladimir &#x27;phcoder' Serbinenko
Oct 2019, 11:40 Javier Martinez Canillas, wrote: > Hello Vladimir, > > On 10/29/19 5:18 PM, Vladimir 'phcoder' Serbinenko wrote: > > What is the problem with main grub.cfg just including the files based on > > environment variables? > > > > Do you mean

Re: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-10-31 Thread Vladimir &#x27;phcoder' Serbinenko
Please don't chain swap_bytes32 with le_to_cpu32 as it's a less readable equivalent of be_to_cpu32 On Thu, 31 Oct 2019, 11:38 Javier Martinez Canillas, wrote: > From: Masahiro Matsuya > > The netmask configured in firmware is not respected on ppc64 (big endian). > When 255.255.252.0 is set as n

Re: [PATCH] tftp: Normalize slashes in tftp paths

2019-10-31 Thread Vladimir &#x27;phcoder' Serbinenko
Having // at the beginning of the path may have special meaning according to posix. I don't know if it applies in particular case and if the special meaning is useful for grub to begin with, just something to check On Thu, 31 Oct 2019, 11:37 Javier Martinez Canillas, wrote: > From: Lenny Szubowi

Re: [PATCH v3 1/2] Add grub_util_readlink()

2019-10-31 Thread Vladimir &#x27;phcoder' Serbinenko
This patch LGTM On Wed, 30 Oct 2019, 11:49 Javier Martinez Canillas, wrote: > From: Peter Jones > > Currently grub-editenv and related tools are not able to follow symbolic > links when finding their config file. For example the grub-editenv create > command will wrongly overwrite a symlink in

Re: [PATCH] arm64: make sure fdt has #address-cells and #size-cells properties

2019-10-31 Thread Vladimir &#x27;phcoder' Serbinenko
This patch looks incomplete. What if "chosen" is there but does not contain the relevant fields? On Thu, 31 Oct 2019, 11:39 Javier Martinez Canillas, wrote: > From: Mark Salter > > Recent upstream changes to kexec-tools relies on #address-cells > and #size-cells properties in the FDT. If grub2

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-06 Thread Vladimir &#x27;phcoder' Serbinenko
Please don't do it this way. The right solution is to move it to separate module and include zstd module when needed. Not everybody uses btrfs embedded area. I recommend not to use it. Using mbr gap or BBP is the recommended way. On Tue, 5 Nov 2019, 01:25 Michael Chang, wrote: > The zstd support

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-06 Thread Vladimir &#x27;phcoder' Serbinenko
On Wed, 6 Nov 2019, 20:55 Michael Chang, wrote: > On Wed, Nov 06, 2019 at 11:15:04AM -0800, Vladimir 'phcoder' Serbinenko > wrote: > > Please don't do it this way. The right solution is to move it to separate > > module and include zstd module when needed. >

Re: workaround for MS Windows' insanity (ignores partition types / hidden flag since 2018)

2019-11-13 Thread Vladimir &#x27;phcoder' Serbinenko
On Wed, 13 Nov 2019, 17:12 Marcel Partap, wrote: > Dear grub devs, > as we have just last week released a hundred of our debian-based > https://github.com/fsfw-dresden/usb-live-linux/ sticks .. and at the > moment are rolling out a version for primary schools, I have stumbled over > the pure stup

Re: Transfering Data from GRUB to userspace?

2019-11-14 Thread Vladimir &#x27;phcoder' Serbinenko
Did you look at cpio generation facility in initrd command? This may be what your are looking for On Mon, 28 Oct 2019, 03:59 Max Tottenham via Grub-devel, wrote: > Hi Folks > > I've often found myself in a position where I've needed to perform some > debugging of remote hardware that does not ha

Re: Disable CLI in submenu but allow users to access it

2019-11-29 Thread Vladimir &#x27;phcoder' Serbinenko
On Fri, 29 Nov 2019, 15:17 Paul Menzel, wrote: > Dear GRUB folks, > > > Is it possible to allow unprivileged users to access a submenu but > not enter the command-line interface? > > Reading the documentation [1] it’s not clear to me how to do that, > and my tests to do that also failed. > > The

Re: Disable CLI in submenu but allow users to access it

2019-12-03 Thread Vladimir &#x27;phcoder' Serbinenko
Can you update the documentation? On Tue, 3 Dec 2019, 12:32 Paul Menzel, wrote: > Dear Vladimir, > > > On 2019-11-29 16:34, Vladimir 'phcoder' Serbinenko wrote: > > On Fri, 29 Nov 2019, 15:17 Paul Menzel, wrote: > > >> Is it possible to allow unprivilege

Fwd: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-12-13 Thread Vladimir &#x27;phcoder' Serbinenko
-- Forwarded message - From: Vladimir 'phcoder' Serbinenko Date: Fri, 13 Dec 2019, 15:56 Subject: Re: [PATCH] ofnet: Fix incorrect mask for ppc64 To: Javier Martinez Canillas On Fri, 13 Dec 2019, 15:33 Javier Martinez Canillas, wrote: > Hello Vladimir, > &g

Re: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-12-13 Thread Vladimir &#x27;phcoder' Serbinenko
On Fri, 13 Dec 2019, 15:56 Vladimir 'phcoder' Serbinenko, wrote: > > -- Forwarded message ----- > From: Vladimir 'phcoder' Serbinenko > Date: Fri, 13 Dec 2019, 15:56 > Subject: Re: [PATCH] ofnet: Fix incorrect mask for ppc64 > To: Javier Marti

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-05 Thread Vladimir &#x27;phcoder' Serbinenko
Please evaluate size increase for this. In the past passing file and line number to grub_dprintf was a huge source of increased Kern and core size Le mer. 4 mars 2020 à 13:01, Javier Martinez Canillas a écrit : > From: Peter Jones > > Add file and line to grub_error() output to make troubleshoo

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir &#x27;phcoder' Serbinenko
Le ven. 6 mars 2020 à 12:38, Javier Martinez Canillas a écrit : > Hello Vladimir, > > Thanks a lot for your feedback. > > On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: > > Please evaluate size increase for this. In the past passing file and line > &

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir &#x27;phcoder' Serbinenko
Le ven. 6 mars 2020 à 13:43, Daniel Kiper a écrit : > Re-adding grub-devel@gnu.org... > > On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > Le ven. 6 mars 2020 à 12:42, Daniel Kiper a écrit > : > > > > > On T

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir &#x27;phcoder' Serbinenko
as occupied > > I just hope this question is not too silly... > > Best regards, > Didier > > > [1]https://uefi.org/sites/default/files/resources/UEFI_Spec_2_8_A_Feb14.pdf > § 5.3.1 GPT overview > > ___________

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir &#x27;phcoder' Serbinenko
> It would be best to use a boot partition so the core.img space is > reserved by the GPT, but I once wanted to tack i386-pc GRUB onto an > existing UEFI GPT disk, so I wrote the commands that do what you're > describing here: > > https://github.com/dm0-/installer/blob/master/examples/systems/fitpc

[PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-10 Thread Vladimir &#x27;phcoder' Serbinenko
il/setup.c +++ b/util/setup.c @@ -254,7 +254,8 @@ SETUP (const char *dir, const char *boot_file, const char *core_file, const char *dest, int force, int fs_probe, int allow_floppy, - int add_rs_codes __attribute__ ((unused))) /* unused on sparc64 */ + int add

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
nvinced me to phase out small MBR gaps > > support gradually. This is first step in this journey. We think that we > > have to build some warnings into the code and extend documentation. > > Please chime in what you think about that... > > > > On Tue, Mar 10, 2020 at 01:23

Re: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID

2020-03-27 Thread Vladimir &#x27;phcoder' Serbinenko
Could you explain why we would need this patch? It changes nothing AFAICT On Fri, Mar 27, 2020, 12:01 Flavio Suligoi wrote: > Signed-off-by: Flavio Suligoi > --- > include/grub/efi/api.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/grub/efi/api.h b/include/g

[PATCH] mips/cache: Add missing nop's in delay slots

2020-04-27 Thread Vladimir &#x27;phcoder' Serbinenko
$ra + nop -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-04-27 Thread Vladimir &#x27;phcoder' Serbinenko
first step in this journey. We think that we > have to build some warnings into the code and extend documentation. > Please chime in what you think about that... > > On Tue, Mar 10, 2020 at 01:23:10PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > Daniel, do you want to

[PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-04-27 Thread Vladimir &#x27;phcoder' Serbinenko
const char *dest, int force, int fs_probe, int allow_floppy, - int add_rs_codes __attribute__ ((unused))) /* unused on sparc64 */ + int add_rs_codes __attribute__ ((unused)), /* unused on sparc64 */ + int warn_small) { char *core_path; char *boot_img, *core

Re: [PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-05-29 Thread Vladimir &#x27;phcoder' Serbinenko
On Tue, May 12, 2020 at 1:48 PM Daniel Kiper wrote: > > On Mon, Apr 27, 2020 at 05:51:34PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > We don't want to support small MBR gap in pair with anything but > > the simplest config of biosdisk+part_msdos+simple fil

Re: [PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-05-29 Thread Vladimir &#x27;phcoder' Serbinenko
Signed-off-by: Bladimir Serbinenko On Fri, May 29, 2020 at 3:09 PM Vladimir 'phcoder' Serbinenko wrote: > > On Tue, May 12, 2020 at 1:48 PM Daniel Kiper wrote: > > > > On Mon, Apr 27, 2020 at 05:51:34PM +0200, Vladimir 'phcoder' Serbinenko > > wro

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir &#x27;phcoder' Serbinenko
On Mon, Jun 1, 2020, 15:21 Chris Coulson wrote: > When a file is verified, the entire contents of the verified file are > loaded in to memory and retained until the file handle is closed. A > consequence of this is that opening a loopback image can incur a > significant memory cost. > > As loopba

Re: [PATCH] tests: remove cmdline_cat and gfxterm_menu tests

2020-06-02 Thread Vladimir &#x27;phcoder' Serbinenko
On Tue, Jun 2, 2020, 10:40 Daniel Axtens wrote: > cmdline_cat takes a checksum of a screen that includes the grub > version number, so it has been broken since commit 94d9926a6640 > ("Release 2.04~rc1"). That was in April 2019. > > I have not been able to get the gfxterm_menu tests to pass under

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir &#x27;phcoder' Serbinenko
On Tue, Jun 2, 2020, 13:21 Dimitri John Ledkov wrote: > On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > > > On Mon, Jun 1, 2020, 15:21 Chris Coulson > wrote: > >> > >> When a file is verified, the enti

Re: [RFC PATCH 3/3] efi: mm: implement runtime addition of pages

2020-06-02 Thread Vladimir &#x27;phcoder' Serbinenko
On Mon, Jun 1, 2020, 21:34 Patrick Steinhardt wrote: > Adjust the interface of `grub_efi_mm_add_regions ()` to take a set of > `GRUB_MM_REGION_*` flags, which most notably is currently only the > `CONSECUTVE` flag. This allows us to set the function up as callback for > the memory subsystem and h

[PATCH 0/3] cmdline fixes for acpi_osi

2020-06-12 Thread Vladimir &#x27;phcoder' Serbinenko
This patch series introduces an escaping of spaces that is compatible with linux parameter parsing. Also it adds some needed tests for this part of code -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu

[PATCH 1/3] Put quote after equal sign when it makes sense

2020-06-12 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-Put-quote-after-equal-sign-when-it-makes-sense.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 2/3] cmdline: Make arguments const

2020-06-12 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0002-cmdline-Make-arguments-const.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 3/3] Add tests for cmdline module

2020-06-12 Thread Vladimir &#x27;phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0003-Add-tests-for-cmdline-module.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Re: [PATCH 1/1] grub-menulst2cfg.c

2020-07-11 Thread Vladimir &#x27;phcoder' Serbinenko
On Sat, Jul 11, 2020, 13:01 Vladimir 'phcoder' Serbinenko wrote: > > > On Fri, Jul 10, 2020, 11:19 朱光宏 wrote: > >> >> In many cases, entryname is null, so there is no need to call this >> function often, it is faster to do this, what do you thin

  1   2   3   4   5   6   7   8   9   10   >