Hello Daniel, Hello Glenn,
I'm now finally completing my patch for search command to add support
to search partition devices by PARTUUID, which I submitted in Apr 2021 [1].
I also integrated support to search by partition label submitted by Daniel
Wagenknecht in Sep 2022 [2].
I (hopefully) address
Hi Glenn,
On Mon, 2023-08-21 at 14:52 -0500, Glenn Washburn wrote:
> On Sun, 20 Aug 2023 12:28:57 +
> Vitaly Kuzmichev wrote:
>
> > Hello Daniel, Hello Glenn,
>
> Hi Vitaly,
>
> >
> > I'm now finally completing my patch for search command t
Transform get_utf8() function to use grub_utf16_to_utf8_alloc()
helper function to convert strings from UTF-16 to UTF-8.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/fs/ntfs.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/grub-core/fs/ntfs.c b/grub-core
Improve 'search' grub-shell command with functionality to search for
a partition by PARTUUID string. This is useful for embedded systems
where FSUUID is not guaranteed to be constant, e.g. it is not preserved
between system updates, and modifying grub.cfg is undesired.
Signed-off-
character '-'.
Signed-off-by: Vitaly Kuzmichev
---
include/grub/misc.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/grub/misc.h b/include/grub/misc.h
index 1b35a167f..12fade5de 100644
--- a/include/grub/misc.h
+++ b/include/grub/misc.h
@@ -264,7 +264,8 @@ grub_uui
Improve 'search' grub-shell command with functionality to search for
a partition by PARTLABEL string, which is known as GPT partition name
on GPT formatted disks.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/Makefile.core.def | 5 +
grub-core/commands/search.c
Update documentation with new options '--part-uuid' and '--part-label'
added to 'probe' and 'search' grub-shell commands.
Signed-off-by: Vitaly Kuzmichev
---
docs/grub.texi | 47 +++
1 file changed, 35 insertion
This patch adds a function to provide partition PARTUUID on MBR
formatted disks by extracting 32-bit disk signature code from MBR
at offset 0x01B8 and adding partition number to it, similarly to
'blkid' output.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/partmap/msdos.c
Transform grub_fat_label() function to use grub_utf16_to_utf8_alloc()
helper function to convert volume label from UTF-16 to UTF-8.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/fs/fat.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/grub-core/fs/fat.c
Simplify 'probe --part-uuid' command to use just added helper functions
grub_gpt_partition_get_uuid() and grub_mbr_partition_get_uuid().
Signed-off-by: Vitaly Kuzmichev
---
grub-core/commands/probe.c | 59 ++
1 file changed, 15 insertions(+), 44
This patch adds a function to provide partition PARTUUID on GPT
formatted disks by extracting 16 bytes GUID from corresponding GPT
entry and formatting it similarly to 'blkid' output.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/partmap/gpt.c
Improve 'probe' grub-shell command with functionality to read and
display a partition PARTLABEL string, which is known as GPT partition
name on GPT formatted disks.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/commands/probe.c | 22 ++
1 file changed, 22 insertion
Add two functions to calculate UTF-16 string length. The address to
UTF-16 string could be unaligned, so use grub_get_unaligned16() to
iterate over characters.
Signed-off-by: Vitaly Kuzmichev
---
include/grub/charset.h | 26 ++
1 file changed, 26 insertions(+)
diff
Transform grub_iso9660_convert_string() function to use
grub_utf16_to_utf8_alloc() helper function to convert file names and
volume name from UTF-16 to UTF-8.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/fs/iso9660.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff
grub_utf16_to_utf8(). This parameter makes no functional changes.
Also change characters reading in grub_utf16_to_utf8() to use
grub_get_unaligned16(), as some buffer pointers could be unaligned.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/commands/efi/lsefisystab.c | 2 +-
grub-core/commands/usbtest.c
Transform grub_f2fs_utf16_to_utf8() function to use
grub_utf16_to_utf8_alloc() helper function to convert volume label
from UTF-16 to UTF-8.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/fs/f2fs.c | 24 +---
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/grub
Signed-off-by: Vitaly Kuzmichev
---
V2:
This patch is based on Michael Grzeschik version from 27 May 2019 [1]
with the following changes:
1. Addressed review feedback from Daniel Kiper [2] and Nick Vinson [3].
2. Added support for GPT PARTUUID.
3. Moved MBR disk signature reading from partmap/
This patch adds a function to provide partition PARTLABEL on GPT
formatted disks by extracting first 72 bytes of UTF-16LE encoded
partition name from corresponding GPT entry and converting it
to UTF-8 string.
Signed-off-by: Vitaly Kuzmichev
---
grub-core/partmap/gpt.c | 36
-off-by: Vitaly Kuzmichev
---
include/grub/charset.h | 28
1 file changed, 28 insertions(+)
diff --git a/include/grub/charset.h b/include/grub/charset.h
index 099f23fbe..4324fefb8 100644
--- a/include/grub/charset.h
+++ b/include/grub/charset.h
@@ -20,6 +20,9
Hi Vladimir,
On Wed, 2023-08-23 at 00:02 +0200, Vladimir 'phcoder' Serbinenko wrote:
>
> >
> > + {
> > + disk = grub_disk_open (dev->disk->name);
> > + if (disk && grub_disk_read (disk, pt->offset, pt->index,
> > + sizeof (gptdata), &gptd
Hi Vladimir,
On Tue, 2023-08-22 at 23:55 +0200, Vladimir 'phcoder' Serbinenko wrote:
>
> >
> >
> > diff --git a/include/grub/charset.h b/include/grub/charset.h
> > index 31a3b52dd..635d6df9e 100644
> > --- a/include/grub/charset.h
> > +++ b/include/grub/charset.h
> > @@ -49,6 +49,13 @@
> > #de
function in ntfs
module. All 3 places would expand with grub_utf16_to_utf8_alloc and
grub_utf16_to_utf8 code, causing increase of .mod file size.
With Best Regards,
Vitaly.
>
> Le mar. 22 août 2023, 23:40, Vitaly Kuzmichev
> a écrit :
> > Transform get_utf8() function
e
module size by double the size of grub_utf16_to_utf8_alloc and
grub_utf16_to_utf8 functions.
>
> Le mar. 22 août 2023, 23:41, Vitaly Kuzmichev
> a écrit :
> > Transform grub_iso9660_convert_string() function to use
> > grub_utf16_to_utf8_alloc() helper function to convert
utf8, so no code duplication of inline
functions.
Best Regards,
Vitaly.
>
> Le mar. 22 août 2023, 23:41, Vitaly Kuzmichev
> a écrit :
> > Transform grub_f2fs_utf16_to_utf8() function to use
> > grub_utf16_to_utf8_alloc() helper function to convert volume label
> > from UTF-
Hi Daniel,
On Wed, 2023-08-30 at 16:26 +0200, Daniel Kiper wrote:
> Adding Daan who sent similar patch a day earlier...
>
> On Tue, Aug 22, 2023 at 11:39:08PM +0200, Vitaly Kuzmichev wrote:
> > Improve 'search' grub-shell command with functionality to search
> >
Hi Daniel,
On Thu, 2023-08-31 at 19:09 +0200, Daniel Kiper wrote:
> On Tue, Aug 22, 2023 at 11:39:12PM +0200, Vitaly Kuzmichev wrote:
> > Fix comparison of two identical UUID strings ending with dash '-'.
> >
> > In this case grub_uuidcasecmp() passes through the
[1] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00124.html
[2] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00131.html
[3] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00134.html
Signed-off-by: Vitaly Kuzmichev
---
grub-core/Makefile.core.def | 5 ++
[1] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00124.html
[2] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00131.html
[3] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00134.html
V3:
Minor coding style and spelling fixes.
Signed-off-by: Vitaly Kuzmichev
---
is needed.
[1] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00124.html
[2] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00131.html
[3] https://lists.gnu.org/archive/html/grub-devel/2019-05/msg00134.html
V3, V4:
Coding style and spelling fixes.
Signed-off-by: Vitaly Kuzmichev
Hello Glenn,
On 2/9/22 6:48 PM, Glenn Washburn wrote:
On Wed, 9 Feb 2022 13:08:51 +0300
Vitaly Kuzmichev via Grub-devel wrote:
Improve 'search' grub-shell command with functionality to search for
a partition by PARTUUID string. This is useful for embedded systems
where FSU
30 matches
Mail list logo
