[PATCH] ofnet: Do not set SUFFIX for sun4v network devices

2015-07-16 Thread Stanislav Kholmanskikh
and filename must be specified WARNING: /virtual-devices@100/channel-devices@200/network@0: Can't open OBP standard TFTP package Can't open device ok Therefore, let's not set SUFFIX for such devices. Signed-off-by: Stanislav Kholmanskikh --- grub-core/net/drivers/ieee1275/ofnet.

Re: [PATCH] ofnet: Do not set SUFFIX for sun4v network devices

2015-07-21 Thread Stanislav Kholmanskikh
On 07/17/2015 07:58 PM, Andrei Borzenkov wrote: В Thu, 16 Jul 2015 10:21:41 +0300 Stanislav Kholmanskikh пишет: sun4v vnet devices do not implement the support of duplex and speed instance attributes. An attempt to open such a device with the attributes will fail: ok select net:speed=auto

Re: [PATCH] ofnet: Do not set SUFFIX for sun4v network devices

2015-07-29 Thread Stanislav Kholmanskikh
Hi! On 07/21/2015 10:48 AM, Stanislav Kholmanskikh wrote: On 07/17/2015 07:58 PM, Andrei Borzenkov wrote: В Thu, 16 Jul 2015 10:21:41 +0300 Stanislav Kholmanskikh пишет: sun4v vnet devices do not implement the support of duplex and speed instance attributes. An attempt to open such a

Re: [PATCH] ofnet: Do not set SUFFIX for sun4v network devices

2015-09-07 Thread Stanislav Kholmanskikh
Hi. On 08/08/2015 11:47 AM, Andrei Borzenkov wrote: В Thu, 16 Jul 2015 10:21:41 +0300 Stanislav Kholmanskikh пишет: sun4v vnet devices do not implement the support of duplex and speed instance attributes. An attempt to open such a device with the attributes will fail: ok select net:speed

[PATCH V2] ofnet: Do not set SUFFIX for sun4v network devices

2015-09-07 Thread Stanislav Kholmanskikh
and filename must be specified WARNING: /virtual-devices@100/channel-devices@200/network@0: Can't open OBP standard TFTP package Can't open device ok Therefore, let's not set SUFFIX for such devices. Signed-off-by: Stanislav Kholmanskikh --- Changes since V1: * handle "com

Re: [PATCH V2] ofnet: Do not set SUFFIX for sun4v network devices

2015-10-07 Thread Stanislav Kholmanskikh
Hi! On 09/07/2015 02:13 PM, Stanislav Kholmanskikh wrote: sun4v vnet devices do not implement the support of duplex and speed instance attributes. An attempt to open such a device with the attributes will fail: ok select net:speed=auto,duplex=auto Unknown key 'speed' Unknown k

Re: sparc64 network autoconfiguration

2016-03-19 Thread Stanislav Kholmanskikh
Hi! On 03/18/2016 11:30 AM, Andrei Borzenkov wrote: On Fri, Mar 18, 2016 at 11:07 AM, Vladimir 'phcoder' Serbinenko wrote: Le ven. 18 mars 2016 08:30, Andrei Borzenkov a écrit : Documentation says On sparc64 GRUB is unable to determine which server it was booted from. Could someone clar

[PATCH 2/2] ofnet: implement a receive buffer

2016-04-12 Thread Stanislav Kholmanskikh
example could be transmission of TFTP packets with 0x400 blksize via a network card with 0x1 MTU. This patch implements a per-card receive buffer in a way similar to efinet.c, and makes get_card_packet() allocate a netbuff of the received data size. Signed-off-by: Stanislav Kholmanskikh ---

[PATCH 1/2] ieee1275: alloc-mem and free-mem

2016-04-12 Thread Stanislav Kholmanskikh
Add wrappers for memory allocation using alloc-mem and free-mem commands from the User Interface. Signed-off-by: Stanislav Kholmanskikh --- grub-core/kern/ieee1275/openfw.c | 68 ++ include/grub/ieee1275/ieee1275.h |2 + 2 files changed, 70 insertions

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-05-10 Thread Stanislav Kholmanskikh
Hi. Could anybody have a look at this series, please? Thanks. On 04/12/2016 03:39 PM, Stanislav Kholmanskikh wrote: get_card_packet() from ofnet.c allocates a netbuff based on the device's MTU: nb = grub_netbuff_alloc (dev->mtu + 64 + 2); In the case when the MTU is large,

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-07-13 Thread Stanislav Kholmanskikh
Hi. On 05/10/2016 01:45 PM, Stanislav Kholmanskikh wrote: Hi. Could anybody have a look at this series, please? Ping. Thanks. On 04/12/2016 03:39 PM, Stanislav Kholmanskikh wrote: get_card_packet() from ofnet.c allocates a netbuff based on the device's MTU: nb = grub_netbuff_

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-10-13 Thread Stanislav Kholmanskikh
Hi. I still believe this series may be useful for the community. So here is one more ping. Thanks. On 07/13/2016 05:35 PM, Stanislav Kholmanskikh wrote: > Hi. > > On 05/10/2016 01:45 PM, Stanislav Kholmanskikh wrote: >> Hi. >> >> Could anybody have a look at thi

Re: [PATCH 1/2] ieee1275: alloc-mem and free-mem

2016-11-18 Thread Stanislav Kholmanskikh
Hi, Daniel. Thank you for review. My comments are below. On 11/16/2016 12:22 AM, Daniel Kiper wrote: > On Tue, Apr 12, 2016 at 03:39:55PM +0300, Stanislav Kholmanskikh wrote: >> Add wrappers for memory allocation using >> alloc-mem and free-mem commands from the User Interface. &

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-11-18 Thread Stanislav Kholmanskikh
On 11/16/2016 01:34 AM, Daniel Kiper wrote: > On Tue, Apr 12, 2016 at 03:39:56PM +0300, Stanislav Kholmanskikh wrote: >> get_card_packet() from ofnet.c allocates a netbuff based on the device's MTU: >> >> nb = grub_netbuff_alloc (dev->mtu + 64 + 2); >> >&g

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-11-22 Thread Stanislav Kholmanskikh
On 11/22/2016 12:48 AM, Daniel Kiper wrote: > On Fri, Nov 18, 2016 at 04:29:24PM +0300, Stanislav Kholmanskikh wrote: >> On 11/16/2016 01:34 AM, Daniel Kiper wrote: >>> On Tue, Apr 12, 2016 at 03:39:56PM +0300, Stanislav Kholmanskikh wrote: >>>> get_card_packet() fr

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-11-23 Thread Stanislav Kholmanskikh
On 11/23/2016 02:16 PM, Daniel Kiper wrote: > On Tue, Nov 22, 2016 at 05:08:25PM +0300, Stanislav Kholmanskikh wrote: >> On 11/22/2016 12:48 AM, Daniel Kiper wrote: >>> On Fri, Nov 18, 2016 at 04:29:24PM +0300, Stanislav Kholmanskikh wrote: >>>> On 11/16/201

How to enable MM debugging?

2016-11-29 Thread Stanislav Kholmanskikh
Hi! Does anybody use MM debugging? If so, what is the recommended/working way of enabling it? These steps do not work: 1. Run ./configure with '--enable-mm-debug'. It reports: With memory debugging: Yes 2. Then build and install the binaries, and install the boot loader 3. Then set 'grub_mm_d

Re: How to enable MM debugging?

2016-11-29 Thread Stanislav Kholmanskikh
On 11/29/2016 05:17 PM, Andrei Borzenkov wrote: > On Tue, Nov 29, 2016 at 4:52 PM, Stanislav Kholmanskikh > wrote: >> Hi! >> >> Does anybody use MM debugging? If so, what is the recommended/working >> way of enabling it? >> >> These steps do not work:

Re: [PATCH 2/2] ofnet: implement a receive buffer

2016-11-30 Thread Stanislav Kholmanskikh
On 11/23/2016 06:09 PM, Stanislav Kholmanskikh wrote: > > > On 11/23/2016 02:16 PM, Daniel Kiper wrote: >> On Tue, Nov 22, 2016 at 05:08:25PM +0300, Stanislav Kholmanskikh wrote: >>> On 11/22/2016 12:48 AM, Daniel Kiper wrote: >>>> On Fri, Nov 18,

[PATCH V2 2/4] ofnet: move the allocation of the transmit buffer into a function

2016-12-02 Thread Stanislav Kholmanskikh
is still needed. However, further changes to ofnet will require to execute this workaround one more time. Therefore, to avoid possible duplication of code I'm moving this piece of code into a function. Signed-off-by: Stanislav Kholmanskikh --- grub-core/net/drivers/iee

[PATCH V2 3/4] ofnet: free memory on module unload

2016-12-02 Thread Stanislav Kholmanskikh
On module unload each of its network cards are unregistered, but corresponding memory areas are not freed. This commit is to fix this situation. Freeing the transmit buffer goes via a special function, since it is allocated via ofnet_alloc_netbuf(). Signed-off-by: Stanislav Kholmanskikh

[V2] Implementing the receive buffer for ofnet

2016-12-02 Thread Stanislav Kholmanskikh
Hi! This is V2 of the series: http://lists.gnu.org/archive/html/grub-devel/2016-04/msg00015.html with the final aim of enabling the receive buffer in the ofnet module. The first version received a number of comments: http://lists.gnu.org/archive/html/grub-devel/2016-11/msg00054.html http://lis

[PATCH V2 1/4] ofnet: add error check for grub_netbuff_reserve

2016-12-02 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh --- grub-core/net/drivers/ieee1275/ofnet.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/grub-core/net/drivers/ieee1275/ofnet.c b/grub-core/net/drivers/ieee1275/ofnet.c index 6bd3b92..8332d34 100644 --- a/grub-core/net

[PATCH V2 4/4] ofnet: implement the receive buffer

2016-12-02 Thread Stanislav Kholmanskikh
example could be transmission of TFTP packets with 0x400 blksize via a network card with 0x1 MTU. This patch implements a per-card receive buffer in a way similar to efinet.c, and makes get_card_packet() allocate a netbuff of the received data size. Signed-off-by: Stanislav Kholmanskikh ---

Re: [PATCH V2 2/4] ofnet: move the allocation of the transmit buffer into a function

2016-12-12 Thread Stanislav Kholmanskikh
On 12/05/2016 06:52 PM, Daniel Kiper wrote: > On Fri, Dec 02, 2016 at 06:10:03PM +0300, Stanislav Kholmanskikh wrote: >> In the current code search_net_devices() uses the "alloc-mem" command >> from the IEEE1275 User Interface for allocation of the transmit bu

Re: [PATCH V2 3/4] ofnet: free memory on module unload

2016-12-12 Thread Stanislav Kholmanskikh
On 12/10/2016 09:18 PM, Andrei Borzenkov wrote: > 02.12.2016 18:10, Stanislav Kholmanskikh пишет: >> On module unload each of its network cards are unregistered, >> but corresponding memory areas are not freed. >> >> This commit is to fix this situation. >> &g

Re: [PATCH V2 1/4] ofnet: add error check for grub_netbuff_reserve

2016-12-12 Thread Stanislav Kholmanskikh
On 12/10/2016 09:08 PM, Andrei Borzenkov wrote: > 02.12.2016 18:10, Stanislav Kholmanskikh пишет: >> Signed-off-by: Stanislav Kholmanskikh >> --- >> grub-core/net/drivers/ieee1275/ofnet.c |6 +- >> 1 files changed, 5 insertions(+), 1 deletions(-) >&

Re: [PATCH V2 2/4] ofnet: move the allocation of the transmit buffer into a function

2016-12-12 Thread Stanislav Kholmanskikh
ree to send this cleanup as separate patch. Thank you. I'll stick to 'return 0' for this series. > > On Mon, Dec 12, 2016 at 12:47 PM, Stanislav Kholmanskikh > wrote: >> >> >> On 12/05/2016 06:52 PM, Daniel Kiper wrote: >>> On Fri, Dec 02, 20

[PATCH V3 1/2] ofnet: move the allocation of the transmit buffer into a function

2016-12-12 Thread Stanislav Kholmanskikh
is still needed. However, further changes to ofnet will require to execute this workaround one more time. Therefore, to avoid possible duplication of code I'm moving this piece of code into a function. Signed-off-by: Stanislav Kholmanskikh --- grub-core/net/drivers/iee

[V3] Implementing the receive buffer for ofnet

2016-12-12 Thread Stanislav Kholmanskikh
Hi! This is V3 of the series: http://lists.gnu.org/archive/html/grub-devel/2016-04/msg00015.html Changes since V2: http://lists.gnu.org/archive/html/grub-devel/2016-12/msg5.html - Removed the patch which adds a check for error for grub_netbuff_reserve(nb, 2) - Keep 'return 0' in search_net

[PATCH V3 2/2] ofnet: implement the receive buffer

2016-12-12 Thread Stanislav Kholmanskikh
example could be transmission of TFTP packets with 0x400 blksize via a network card with 0x1 MTU. This patch implements a per-card receive buffer in a way similar to efinet.c, and makes get_card_packet() allocate a netbuff of the received data size. Signed-off-by: Stanislav Kholmanskikh ---

[RFC PATCH] configure check for ld's --no-relax flag

2014-08-01 Thread Stanislav Kholmanskikh
Early versions of binutils doesn't support --no-relax flag, so commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building with such versions. Signed-off-by: Stanislav Kholmanskikh --- conf/Makefile.common |8 configure.ac | 10 ++ 2 files change

Re: [RFC PATCH] configure check for ld's --no-relax flag

2014-08-03 Thread Stanislav Kholmanskikh
Hi! On 08/01/2014 07:40 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 01.08.2014 17:35, Andrey Borzenkov wrote: В Fri, 1 Aug 2014 16:15:56 +0400 Stanislav Kholmanskikh пишет: Early versions of binutils doesn't support --no-relax