About the code style requirement

2021-09-28 Thread Qu Wenruo via Grub-devel
Hi, I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to GRUB, so that we can have more unified code base, with more features (and of-course bug fixes) But the first blockage I'm hitting is the code style. It looks like GRUB is using its own code style which is not found i

Re: About the code style requirement

2021-09-29 Thread Qu Wenruo via Grub-devel
On 2021/9/29 14:34, Vladimir 'phcoder' Serbinenko wrote: Le mer. 29 sept. 2021, 07:42, Qu Wenruo via Grub-devel mailto:grub-devel@gnu.org>> a écrit : Hi, I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to GRUB, so that we can have m

Re: About the code style requirement

2021-09-29 Thread Qu Wenruo via Grub-devel
On 2021/9/29 23:38, Lennart Sorensen wrote: On Wed, Sep 29, 2021 at 03:04:59PM +0800, Qu Wenruo via Grub-devel wrote: Oh, didn't know there would be license problem. There often is. :) Then it would be complex. Quite some code is directly copied from kernel without modification,

Re: About the code style requirement

2021-10-01 Thread Qu Wenruo via Grub-devel
;> a écrit : On 2021/9/29 23:38, Lennart Sorensen wrote: > On Wed, Sep 29, 2021 at 03:04:59PM +0800, Qu Wenruo via Grub-devel wrote: >> Oh, didn't know there would be license problem. > > There often is. :) > >> Then it

Re: About the code style requirement

2021-10-07 Thread Qu Wenruo via Grub-devel
On 2021/10/7 21:51, Daniel Kiper wrote: On Fri, Oct 01, 2021 at 03:14:02PM +0800, Qu Wenruo via Grub-devel wrote: On 2021/10/1 14:08, Vladimir 'phcoder' Serbinenko wrote: [...] GRUB already has a btrfs implementation. Writing new one from scratch instead of existing one is unwel

Re: About the code style requirement

2021-10-15 Thread Qu Wenruo via Grub-devel
On 2021/10/8 08:22, Qu Wenruo via Grub-devel wrote: On 2021/10/7 21:51, Daniel Kiper wrote: On Fri, Oct 01, 2021 at 03:14:02PM +0800, Qu Wenruo via Grub-devel wrote: On 2021/10/1 14:08, Vladimir 'phcoder' Serbinenko wrote: [...] GRUB already has a btrfs implementation. Writi

[PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-15 Thread Qu Wenruo via Grub-devel
[BUG] Grub btrfs implementation can't handle two very basic btrfs file layouts: 1. Mixed inline/regualr extents # mkfs.btrfs -f test.img # mount test.img /mnt/btrfs # xfs_io -f -c "pwrite 0 1k" -c "sync" -c "falloc 0 4k" \ -c "pwrite 4k 4k" /mnt/btrfs/file # umount /mnt/

Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-18 Thread Qu Wenruo via Grub-devel
On 2021/10/18 18:49, David Disseldorp wrote: Tested-by: David Disseldorp This fixes the failures seen with the Dracut reflinked initramfs patchset at https://github.com/dracutdevs/dracut/pull/1531 . Thanks, David Missing CC to grub mail list I guess? Thanks, Qu _

Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-28 Thread Qu Wenruo via Grub-devel
Gentle ping? Without this patch, the new mkfs.btrfs NO_HOLES feature would break any kernel/initramfs with hole in it. And considering the modification is already small, I believe this patch is definitely worthy as a bug fix. Thanks, Qu On 2021/10/16 09:40, Qu Wenruo wrote: [BUG] Grub btr

[PATCH v2] fs/btrfs: Make extent item iteration to handle gaps

2021-10-28 Thread Qu Wenruo via Grub-devel
[BUG] Grub btrfs implementation can't handle two very basic btrfs file layouts: 1. Mixed inline/regualr extents # mkfs.btrfs -f test.img # mount test.img /mnt/btrfs # xfs_io -f -c "pwrite 0 1k" -c "sync" -c "falloc 0 4k" \ -c "pwrite 4k 4k" /mnt/btrfs/file # umount /mnt/