Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Philip Müller via Grub-devel
On 30.08.22 23:34, Javier Martinez Canillas wrote: You could add a feature flag, which causes grub-core to set an environment variable when a new feature is supported. See the features array in grub-core/normal/main.c. You would then check for this feature flag in the grub.d snippet before calli

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Philip Müller via Grub-devel
On 31.08.22 00:43, Javier Martinez Canillas wrote: To prevent that, let's partially revert the mentioned commit and keep the old logic that didn't execute the `fwsetup` command and just included an entry for it if GRUB is executed in an EFI platform. I was about to do the same on my end when we

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-09-01 Thread Philip Müller via Grub-devel
On 31.08.22 20:44, Robbie Harwood wrote: While we could revert the entire --is-supported logic as well, since this is upstream pre-release code, it's probably easier for the downstreams that pulled this change if we don't, so: Reviewed-by: Robbie Harwood. Yep, that would also work. For example