[PATCH] term/serial: Add support for PCI serial devices

2022-08-24 Thread Peter Zijlstra
Loosely based on early_pci_serial_init() from Linux, allow GRUB to make use of PCI serial devices. Specifically, my Alderlake NUC exposes the Intel AMT SoL UART as a PCI enumerated device but doesn't include it in the EFI tables. Tested and confirmed working on a "Lenovo P360 Tiny" with Intel AM

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-24 Thread Peter Zijlstra
unity. > On Wed, 24 Aug 2022 13:28:03 +0200 > Peter Zijlstra wrote: > > > > > Loosely based on early_pci_serial_init() from Linux, allow GRUB to make > > use of PCI serial devices. > > > > Specifically, my Alderlake NUC exposes the Intel AMT SoL UART as a

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-25 Thread Peter Zijlstra
On Wed, Aug 24, 2022 at 06:36:27PM -0500, Glenn Washburn wrote: > Yeah, it can get tricky. Its kind of custom build system layered on top > of autotools. The file you're looking for is > grub-core/Makefile.core.def. > > Looking at this again, it looks like pci is only supported on x86 and > mips_l

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-25 Thread Peter Zijlstra
On Wed, Aug 24, 2022 at 06:36:27PM -0500, Glenn Washburn wrote: > You will need to run the bootstrap script in the root of the repo to > rebuild the build scripts before running configure and make. FWIW bootstrap scribbles INSTALL ___ Grub-devel mailing

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-25 Thread Peter Zijlstra
On Wed, Aug 24, 2022 at 03:13:55PM -0500, Glenn Washburn wrote: > > Index: grub2-2.06/include/grub/pci.h > > === > > --- grub2-2.06.orig/include/grub/pci.h > > +++ grub2-2.06/include/grub/pci.h > > @@ -83,6 +83,9 @@ > > #define GRUB_

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-25 Thread Peter Zijlstra
How's this then? seems to build. If this looks allright, I'll post it as v2 I suppose. --- diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 5212dfab1369..c0683da2353b 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -224,12 +224,14 @@ kern

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-25 Thread Peter Zijlstra
On Thu, Aug 25, 2022 at 10:51:29AM -0500, Glenn Washburn wrote: > On Thu, 25 Aug 2022 09:57:32 +0200 > Peter Zijlstra wrote: > > > On Wed, Aug 24, 2022 at 06:36:27PM -0500, Glenn Washburn wrote: > > > You will need to run the bootstrap script in the root of the repo to

Re: [PATCH] term/serial: Add support for PCI serial devices

2022-08-25 Thread Peter Zijlstra
On Thu, Aug 25, 2022 at 02:23:34PM -0500, Glenn Washburn wrote: > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > > index 5212dfab1369..c0683da2353b 100644 > > --- a/grub-core/Makefile.core.def > > +++ b/grub-core/Makefile.core.def > > @@ -224,12 +224,14 @@ kernel = { >

Re: [PATCH v2 2/3] term/serial: Add support for PCI serial devices

2022-08-29 Thread Peter Zijlstra
On Fri, Aug 26, 2022 at 01:32:25PM -0500, Glenn Washburn wrote: > On Fri, 26 Aug 2022 13:01:44 +0200 > pet...@infradead.org wrote: > > > Loosely based on early_pci_serial_init() from Linux, allow GRUB to make > > use of PCI serial devices. > > > > Specifically, my Alderlake NUC exposes the Intel

Re: [PATCH v2 2/3] term/serial: Add support for PCI serial devices

2023-01-26 Thread Peter Zijlstra
se add a blurb how to use this driver to the docs/grub.texi file. > > > GRUB_TERMINAL="serial console" > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > > > > Index: grub/grub-core/Makefile.core.def > > ==

Re: [PATCH v2 2/3] term/serial: Add support for PCI serial devices

2023-02-09 Thread Peter Zijlstra
On Thu, Jan 26, 2023 at 10:37:35AM +0100, Peter Zijlstra wrote: > On Wed, Dec 21, 2022 at 01:59:02PM +0100, Daniel Kiper wrote: > > Sorry for late reply... > > > > May I ask you to send the patches using "git send-email"? > > I'll try -- I'm one of