Re: GRUB 2.06 release

2020-10-19 Thread Pete Batard
Hi Daniel, On 2020.07.29 18:46, Daniel Kiper wrote: I think this link [1] will explain my long absence... Sorry about that. I am going to go back to GRUB work next week. I will triage all the patches and take all (obvious) fixes. Then I will release rc1 ASAP... All new features will be taken af

Re: GRUB 2.06 release

2020-10-20 Thread Pete Batard
Hi Eli, On 2020.10.20 20:12, Eli Schwartz wrote: I'd like to instead propose a third option though. grub could benefit from a policy to fork off maintenance branches for CVE fixes, and all distros would upgrade to 2.04.1 (or 2.02.1), then later on a couple of rolling release distros would upgrad

Re: GRUB 2.06 release

2020-10-20 Thread Pete Batard
Hi Julian, On 2020.10.20 20:00, Julian Andres Klode wrote: That's a misunderstanding, nobody would upgrade existing OS to 2.06, you can't just upgrade the entire bootloader in a stable OS. We're talking about distro maintainers adding a GRUB bootloader for ISO/image boot. We're not talking ab

[PATCH] fs: remove implicit compiler calls to memset/memcpy

2016-04-10 Thread Pete Batard
Regards, /Pete [1] https://github.com/pbatard/efifs From f107607cbe2052effe09aadd1e441d416c73f95f Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Sun, 10 Apr 2016 14:45:05 +0200 Subject: [PATCH] fs: remove implicit compiler calls to memset/memcpy Some compilers may insert calls to memset/memcp

Re: [PATCH] fs: remove implicit compiler calls to memset/memcpy

2016-04-10 Thread Pete Batard
On 2016.04.10 16:30, Vladimir 'phcoder' Serbinenko wrote: Why is the same solution not suitable for you? That's the first thing I attempted, but the MSVC compiler is uncooperative. If you try to redefine memset/memcpy, you get the following compiler error: error C2169: '_memcpy' : Intrinsic f

Re: [PATCH] fs: remove implicit compiler calls to memset/memcpy

2016-04-18 Thread Pete Batard
On 2016.04.18 07:50, Vladimir 'phcoder' Serbinenko wrote: You can use asm to get around msvc limitations. Sth like .global memcpy memcpy: jmp grub_memcpy Yes I'm well aware I could try to create my own library (or equivalent) that redefines memcpy/memset, using some workaround to avoid

Re: [PATCH] fs: remove implicit compiler calls to memset/memcpy

2016-04-18 Thread Pete Batard
On 2016.04.18 12:49, Vladimir 'phcoder' Serbinenko wrote: In any case it's not 2.02 material, so I put it lower in my priority list Thanks for considering it further - much appreciated. I should point out that there's obviously nothing blocking for me, so I'm fine with any delay. On 2016.04

[PATCH] Add missing va_end() to xasprintf() in grub-emu

2016-08-13 Thread Pete Batard
Hi, I believe there's an unbalanced va_start/va_end pair in grub-emu. This patch fixes it. Regards, /Pete From 0ed65abd009b79955c8578bfb40cc33e51e463ae Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Sat, 13 Aug 2016 10:51:34 +0200 Subject: [PATCH] Add missing va_end() to xasprintf() in

[PATCH 1/3] zfs: remove size_t typedef and use grub_size_t instead

2017-08-03 Thread Pete Batard
Regards, /Pete From 9b3a9fd2b24dc80cee38646dbdc3bbb686cc91ff Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Thu, 3 Aug 2017 15:46:15 +0100 Subject: [PATCH 1/3] zfs: remove size_t typedef and use grub_size_t instead * Prevents some toolchains from issuing a warning on size_t redef. --- grub

[PATCH 0/3] misc changes to improve toolchain compatibility

2017-08-03 Thread Pete Batard
Hi, The following is a series of 3 small changes that aim at making the GRUB codebase more palatable to toolchains such as the EDK2. The main aim is to enable the use the EDK2 and the GRUB fs code to compile read-only EFI file system drivers (such as the ones from my efifs project [1]). It n

[PATCH 3/3] io: add a GZ prefix to gzio specific defines

2017-08-03 Thread Pete Batard
Regards, /Pete From 331ec3f7567f3f86e4d4d78fd173079d39d4eb8d Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Thu, 3 Aug 2017 16:20:31 +0100 Subject: [PATCH 3/3] io: add a GZ prefix to gzio specific defines * This is done to avoid a conflict with a PACKED define in the EDK2 --- grub-core/io

[PATCH 2/3] crypto: switch nonstandard escape sequence to its hex value

2017-08-03 Thread Pete Batard
Regards, /Pete From 3660346530b5cb39c81e71dbfb488c8315aa8b78 Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Thu, 3 Aug 2017 16:16:43 +0100 Subject: [PATCH 2/3] crypto: switch nonstandard escape sequence to its hex value * '\e' is not in the C standard and produces an error

Re: [PATCH 1/3] zfs: remove size_t typedef and use grub_size_t instead

2017-08-07 Thread Pete Batard
Thanks. I'll submit a v2 for 2 & 3 shortly, as per your comments. Regards, /Pete On 2017.08.07 15:26, Vladimir 'phcoder' Serbinenko wrote: Committed, thanks Le Thu, Aug 3, 2017 à 6:12 PM, Pete Batard <mailto:p...@akeo.ie>> a écrit

Re: [PATCHv2 2/3] core: use GRUB_TERM_ definitions when handling term characters

2017-08-07 Thread Pete Batard
add new #include directives for the GRUB_TERM_ defs. Of course, this patch was also validated to confirm it doesn't break compilation. Regards, /Pete From 231792eeb40bf6ef590ba2dfc9615f8ab725e779 Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Mon, 7 Aug 2017 16:20:30 +0100 Subject: [PATCH

Re: [PATCHv2 3/3] io: add a GRUB_GZ prefix to gzio specific defines

2017-08-07 Thread Pete Batard
As requested, this new proposal uses GRUB_GZ_ instead of GZ_ as the new prefix. Regards, /Pete From de3f6990c7705dd66b608684066b35ce3f0628e4 Mon Sep 17 00:00:00 2001 From: Pete Batard Date: Mon, 7 Aug 2017 16:23:12 +0100 Subject: [PATCH 3/3] io: add a GRUB_GZ prefix to gzio specific defines

Re: [PATCHv2 2/3] core: use GRUB_TERM_ definitions when handling term characters

2017-08-07 Thread Pete Batard
On 2017.08.07 18:29, Vladimir 'phcoder' Serbinenko wrote: In several places it was misused. I've thrown them away and committed the rest Looks good. Thanks. /Pete ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/

Re: [PATCH] F2FS support

2018-03-18 Thread Pete Batard
+1 for F2FS integration, which I also requested a few months back and which I know has also been requested by other people before that. While I understand that the GRUB project's priorities might be elsewhere, I'm just going to point out that I am growing a bit tired of having had to keep and

[PATCH] F2FS support

2018-03-22 Thread Pete Batard
Hi, Please find attached a rebased version of the F2FS patch sent by Jaegeuk Kim to this mailing list on 2017.05.04. The original patch was rebased against the latest mainline and we also validated that there were no compilation issues on a Debian 9 x64 platform. Here are the notes from the

Re: [PATCH] F2FS support

2018-03-29 Thread Pete Batard
Hi Daniel, Thanks for reviewing the patch. Here's a v2 that takes your comments into account. Regards, /Pete On 2018.03.28 13:04, Daniel Kiper wrote: On Thu, Mar 22, 2018 at 04:47:47PM +0000, Pete Batard wrote: From 40030514e682191281e8ddba8d1e0835e6b685dc Mon Sep 17 00:00:00 2001

Re: [PATCH] F2FS support

2018-04-01 Thread Pete Batard
ements are a deal breaker for me. If this result in this patch being dropped, so be it. Regards, /Pete On 2018.03.31 21:47, Paul Menzel wrote: Dear Pete, Am Donnerstag, den 29.03.2018, 17:08 +0100 schrieb Pete Batard: Thanks for reviewing the patch. Here's a v2 that takes your commen

Re: [PATCH] F2FS support

2018-04-04 Thread Pete Batard
On 2018.04.04 21:37, Daniel Kiper wrote: Thanks, LGTM +/- some nitpicks which I fix before committing. If there are no significant objections I will apply this patch in a week or so. Thanks Daniel. Much appreciated. Regards, /Pete ___ Grub-devel ma

[PATCH 1/3] grub-mkrescue: Add support for FAT and NTFS on EFI boot

2022-06-06 Thread Pete Batard
. This mandatorily includes FAT and we also include NTFS as the latter is also commonly supported on modern x64 platforms. Signed-off-by: Pete Batard --- util/grub-mkrescue.c | 5 + 1 file changed, 5 insertions(+) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index ba89b1394

[PATCH 2/3] grub-mkrescue: Preserve a copy of the EFI bootloaders on the ISO9660 file system

2022-06-06 Thread Pete Batard
directory to create the efi/ content, to instead place it at the root of the ISO9660 content. Signed-off-by: Pete Batard --- util/grub-mkrescue.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index 1257476fb..4596f0ea7 100644

[PATCH 3/3] grub-mkrescue: Search by file UUID file rather than partition UUID for EFI boot

2022-06-06 Thread Pete Batard
the block level and not at the file system level. To accomplish this for EFI boot, we now create a UUID file in a .disk/ directory, that we can then search for. Signed-off-by: Pete Batard --- util/grub-mkrescue.c | 47 1 file changed, 39 insertions

[PATCH 0/3] Add support for EFI file system transposition

2022-06-06 Thread Pete Batard
duced-to-712-KB-Is-it-normal-If-not-then-how-can-I-fix-it [11] https://askubuntu.com/questions/289971/usbs-storage-capacity-reduced-to-2-mb-from-16-gb [12] https://askubuntu.com/questions/611325/capacity-of-pen-drive-shown-is-less-than-the-actual [13] https://forums.raspberrypi.com/viewtopic.ph

Re: [PATCH 0/3] Add support for EFI file system transposition

2022-06-07 Thread Pete Batard
Hi Thomas. Thanks for replying. On 2022.06.07 08:16, Thomas Schmitt wrote: we will point out that we consider it should really be the job of xorriso, rather than grub-mkrescue, to accomplish this duplication (hence why I am CC'ing Thomas), but we don't know the technical difficulties that result

Re: GRUB 2.12 release, etc.

2022-06-11 Thread Pete Batard
Hi Daniel. Thanks for keeping the list posted on your release plans. On 2022.06.10 18:20, Daniel Kiper wrote: If you think some features and fixes should land in the GRUB 2.12 please replay to this email. Well, I sure would like the grub-mkrescue patches I posted on 06/06, that fix support f

Re: GRUB 2.12 release - update

2022-10-28 Thread Pete Batard via Grub-devel
Hi Daniel, Thanks for keeping us updated on your the release progress and release plans. On 2022.10.26 15:52, Daniel Kiper wrote: We are getting closer to the 2.12 release. Sadly we still do not have many of important patch sets in the tree. So, I am going to spend more time on reviews in the

Re: GRUB 2.12 release - update

2022-11-03 Thread Pete Batard via Grub-devel
Hi Daniel, On 2022.11.03 17:59, Daniel Kiper wrote: Thank you for detailed explanation. I can consider your patches as more than "nice to have" but it may mean we will have to delay code freeze and maybe release date. To reduce impact on dates please be ready to reply to my comments as quickly a

[PATCH v2 2/3] grub-mkrescue: Preserve a copy of the EFI bootloaders on the ISO9660 file system

2022-11-25 Thread Pete Batard via Grub-devel
directory to create the efi/ content, to instead place it at the root of the ISO9660 content. Signed-off-by: Pete Batard --- util/grub-mkrescue.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index 1257476fb..4596f0ea7 100644

[PATCH v2 1/3] grub-mkrescue: Add support for FAT and NTFS on EFI boot

2022-11-25 Thread Pete Batard via Grub-devel
. This mandatorily includes FAT, but we also include NTFS as the latter is also commonly supported on modern x64 platforms. Signed-off-by: Pete Batard --- util/grub-mkrescue.c | 5 + 1 file changed, 5 insertions(+) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index ba89b1394

[PATCH v2 3/3] grub-mkrescue: Search by file UUID file rather than partition UUID for EFI boot

2022-11-25 Thread Pete Batard via Grub-devel
level and not at the file system level. To accomplish this for EFI boot, we now create a UUID file in a .disk/ directory, that can then be searched for. Note: The switch from make_image_fwdisk_abs() to make_image_abs() is needed in order to use the search functionality. Signed-off-by: Pete Batard

[PATCH v2 0/3] Add support for EFI file system transposition

2022-11-25 Thread Pete Batard via Grub-devel
ttps://www.quora.com/After-making-my-32-GB-pen-drive-Kali-Linux-bootable-its-size-reduced-to-712-KB-Is-it-normal-If-not-then-how-can-I-fix-it [11] https://askubuntu.com/questions/289971/usbs-storage-capacity-reduced-to-2-mb-from-16-gb [12] https://askubuntu.com/questions/611325/capacity-of-pen-dr

Re: [PATCH v2 3/3] grub-mkrescue: Search by file UUID file rather than partition UUID for EFI boot

2022-11-26 Thread Pete Batard via Grub-devel
Just noticed that there's a typo in the title ("file UUID file") so please make sure to remove one of the "file" from the commit title if this patch does get validated for integration. Thanks, /Pete On 2022.11.25 17:22, Pete Batard wrote: The final piece neede

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Pete Batard via Grub-devel
Hello all, On 2022.12.20 22:58, Robbie Harwood wrote: Zhang Boyang writes: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is checked at module loading time. That module will be rejected if

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-21 Thread Pete Batard via Grub-devel
Hi Zhang, On 2022.12.21 11:38, Zhang Boyang wrote: Hi, On 2022/12/21 17:43, Thomas Schmitt wrote: Hi, Pete Batard wrote: unlike what is the case for UEFI, one can not expect to be able to pick all the GRUB core files needed to convert a GRUB based ISO bootable media to a GRUB based USB

Re: [RFC PATCH v2 1/1] kern/dl: Add module version check

2022-12-21 Thread Pete Batard via Grub-devel
Hi again Zhang, I hadn't had a chance to properly look at your v2 before replying earlier, and it looks like it addresses the elements I had an issue with. On 2022.12.21 12:11, Zhang Boyang wrote: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as

Re: [RFC PATCH v3 0/1] kern/dl: Add module version check

2022-12-22 Thread Pete Batard via Grub-devel
I'm sorry but that's NO_GO for me. This is a major step back from v2, where the check was never applicable for BIOS and I believe I explained why a module check that can be enforced for BIOS is going to create a major headache for end-users. It seems pretty obvious that, if distro maintainers

Re: [RFC PATCH v3 0/1] kern/dl: Add module version check

2022-12-23 Thread Pete Batard via Grub-devel
On 2022.12.23 07:18, Zhang Boyang wrote: This feature is implemented in kern/dl.c in core.img, which is UNDER YOUR CONTROL. Let me analyze the worst case from your perspective: 1) Every distro is enforcing version check, even in BIOS mode. 2) Because this check is in kern/dl.c, there is no su

Re: [RFC PATCH v4 1/1] kern/dl: Add module vermagic check

2022-12-29 Thread Pete Batard via Grub-devel
XX.c @@ -492,6 +492,7 @@ SUFFIX(grub_module_verify) (const char * const filename, Elf_Shdr *s; const char *modname; + const char *modver; s = find_section (arch, e, ".modname"); if (!s) @@ -499,6 +500,15 @@ SUFFIX(grub_module_verify) (const char * const filename,

Re: [RFC PATCH v4 0/1] kern/dl: Add module vermagic check

2022-12-29 Thread Pete Batard via Grub-devel
Hi, I finally got a chance to test this proposal (mostly in the context of Rufus and for BIOS boot), and everything looks good to me. Thanks a lot for adding an option to disable the warning when invoking configure! I also second the idea that we want a unique identifier added to the versi

Re: GRUB 2.12~rc1 released

2023-07-12 Thread Pete Batard via Grub-devel
Hi Daniel, Thanks for the long awaited 2.12~rc1. As I have mentioned in the past, and I feel need to mention again on account that it continues causes real-life grievances for downstream GRUB end users and especially people trying to install Linux, the formal GRUB 2.12 release cannot come soo

Re: grub FTBFS on ia64: awk: ./genmoddep.awk: line 106: function asorti never defined

2023-07-22 Thread Pete Batard via Grub-devel
Hi Adrian, On 2023.07.22 11:25, John Paul Adrian Glaubitz wrote: OK, seems like this was just related to mawk vs. gawk. Builds fine with gawk. Yes, this is what I also reported in an earlier post to this list: https://lists.gnu.org/archive/html/grub-devel/2023-07/msg00047.html Regards, /Pete