Enabling hardware flow control for serial console?

2025-06-30 Thread Nick
How is this accomplished, if it's even possible? I see the following, however I don't think any flow control gets enabled: GRUB_CMDLINE_LINUX_DEFAULT="nofb nomodeset console=ttyS0,115200" GRUB_TERMINAL="serial" GRUB_SERIAL_COMMAND="serial --speed=115200 --unit=0 --word=8 --parity=no --stop=1" __

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-10 Thread Nick Vinson
On 04/10/2018 01:52 PM, Daniel Kiper wrote: > On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documentation. The following table >> shows how GRUB_DISABLE_LINUX_UUID, GRU

Re: [GRUB PARTUUID PATCH V9 0/5] Add PARTUUID detection support

2018-04-10 Thread Nick Vinson
On 04/10/2018 01:56 PM, Daniel Kiper wrote: > On Sat, Apr 07, 2018 at 04:28:09PM -0700, Nicholas Vinson wrote: >> Changes from Patch v8: >> - Renamed GRUB_ENABLE_LINUX_PARTUUID to GRUB_DISABLE_LINUX_PARTUUID >> - Updated the 10_linux logic so GRUB_ENABLE_LINUX_PARTUUID and >> GRUB_E

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-11 Thread Nick Vinson
On 04/11/2018 01:31 AM, Daniel Kiper wrote: > On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: >> On 04/10/2018 01:52 PM, Daniel Kiper wrote: >>> On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: >>>> Update grub-mkconfig.in and 10_linux.

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-16 Thread Nick Vinson
On 04/16/2018 04:47 AM, Daniel Kiper wrote: > On Wed, Apr 11, 2018 at 07:45:01AM -0700, Nick Vinson wrote: >> On 04/11/2018 01:31 AM, Daniel Kiper wrote: >>> On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: >>>> On 04/10/2018 01:52 PM, Daniel Kiper wrote:

Re: [GRUB PARTUUID PATCH V10 4/4] Update grub script template files

2018-04-17 Thread Nick Vinson
On 04/17/2018 06:36 AM, Daniel Kiper wrote: > On Mon, Apr 16, 2018 at 10:36:26PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documentation. The following table >> shows how GRUB_DISABLE_LINUX_UUID, GRUB_

[PATCH 0/3] btrfs: Add zstd support to btrfs

2018-08-27 Thread Nick Terrell
this project! I started my patch from where he left off. Best, Nick Terrell Nick Terrell (3): Import kernel zstd Patch the kernel zstd Add btrfs zstd support Makefile.util.def |8 +- grub-core/Makefile.core.def | 10 +- grub-core/fs/btrfs.c|

[PATCH 3/3] btrfs: Add zstd support to btrfs

2018-08-27 Thread Nick Terrell
that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- Makefile.util.def| 8 - grub-core/Makefile.core.def | 10 -- grub-core/fs/btrfs.c | 85 +++- tests/btrfs_test.in | 1 + tests/util/gr

[PATCH 2/3] btrfs: Patch the kernel zstd

2018-08-27 Thread Nick Terrell
ypedef. * Remove the module code. * Switch the memcpy() in ZSTD_copy8() to __builtin_memcpy(). Signed-off-by: Nick Terrell --- grub-core/lib/zstd/bitstream.h | 6 grub-core/lib/zstd/decompress.c | 56 ++ grub-core/lib/zstd/error_private.h | 3 +- grub

Re: [PATCH 0/3] btrfs: Add zstd support to btrfs

2018-09-11 Thread Nick Terrell
> On Sep 11, 2018, at 3:23 AM, David Sterba wrote: > > On Mon, Aug 27, 2018 at 06:36:51PM -0700, Nick Terrell wrote: >> Hi all, >> >> This patch set imports the upstream kernel zstd library, patches it to work >> in grub, adds zstd support to the btrfs m

Re: [PATCH 1/3] btrfs: Import kernel zstd

2018-09-21 Thread Nick Terrell
> On Sep 21, 2018, at 11:10 AM, Daniel Kiper wrote: > > On Mon, Aug 27, 2018 at 06:36:52PM -0700, Nick Terrell wrote: >> Import xxhash and zstd from the upstream kernel as-is. This will not >> compile. The next patch in the series contains all the changes needed to &g

[PATCH v2 0/2] btrfs: Add zstd support to grub btrfs

2018-10-08 Thread Nick Terrell
"zstd-1.3.6/lib" DST_LIB="grub-core/lib/zstd" rm -rf $DST_LIB mkdir -p $DST_LIB cp $SRC_LIB/zstd.h $DST_LIB/ cp $SRC_LIB/common/*.[hc] $DST_LIB/ cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ rm $DST_LIB/{pool.[hc],threading.[hc]} rm -rf zstd-1.3.6* echo SUCCESS! --- Best, Nick Terrell

[PATCH v2 2/2] btrfs: Add zstd support to grub btrfs

2018-10-08 Thread Nick Terrell
that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Kiper Makefile.util.def| 10 +++- grub-core/Makefile.core.def | 10 +++- grub-core/fs/btrfs.c | 105 ++- grub-core/lib

Re: [PATCH v2 2/2] btrfs: Add zstd support to grub btrfs

2018-10-09 Thread Nick Terrell
> On Oct 9, 2018, at 12:07 PM, Daniel Kiper wrote: > On Mon, Oct 08, 2018 at 04:06:21PM -0700, Nick Terrell wrote: >> Adds zstd support to the btrfs module. I'm not sure that my changes to the >> Makefiles are correct, please let me know if I need to do something >>

[PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-09 Thread Nick Terrell
"zstd-1.3.6/lib" DST_LIB="grub-core/lib/zstd" rm -rf $DST_LIB mkdir -p $DST_LIB cp $SRC_LIB/zstd.h $DST_LIB/ cp $SRC_LIB/common/*.[hc] $DST_LIB/ cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ rm $DST_LIB/{pool.[hc],threading.[hc]} rm -rf zstd-1.3.6* echo SUCCESS! --- Best, Nick Terrell

[PATCH v3 2/2] btrfs: Add zstd support to grub btrfs

2018-10-09 Thread Nick Terrell
Adds zstd support to the btrfs module. Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd compression. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Ki

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-10 Thread Nick Terrell
functions that zstd needs to decompress (memcpy, and memmove). Theres some other stuff in the library that requires libc functionality that GRUB doesn't provide, but that isn't used during decompression. We strip those files out in the import. Let me know if you want me to switch to

Re: [PATCH v3 2/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Nick Terrell
> On Oct 11, 2018, at 10:55 AM, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 04:21:37PM -0700, Nick Terrell wrote: >> Adds zstd support to the btrfs module. >> >> Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd >> compression.

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Nick Terrell
> On Oct 11, 2018, at 11:15 AM, Daniel Kiper wrote: > > Hi Nick, > > CC-ing Goffredo. > > On Tue, Oct 09, 2018 at 04:21:35PM -0700, Nick Terrell wrote: >> Hi all, >> >> This patch set imports the upstream zstd library, adds zstd support to the >

Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-10-22 Thread Nick Terrell
t; Comments are welcome. > > In general whole patch series LGTM. +/- some nit picks including changes > for patch #7. If you are OK with them and there are no objections then > I will apply the patches in a week or so. Awesome! I'll look for the update and send an rebased version of

[PATCH v4 0/2] btrfs: Add zstd support to grub btrfs

2018-10-31 Thread Nick Terrell
"zstd-1.3.6/lib" DST_LIB="grub-core/lib/zstd" rm -rf $DST_LIB mkdir -p $DST_LIB cp $SRC_LIB/zstd.h $DST_LIB/ cp $SRC_LIB/common/*.[hc] $DST_LIB/ cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ rm $DST_LIB/{pool.[hc],threading.[hc]} rm -rf zstd-1.3.6* echo SUCCESS! ``` Best, Nick Terrell

[PATCH v4 2/2] btrfs: Add zstd support to grub btrfs

2018-10-31 Thread Nick Terrell
Adds zstd support to the btrfs module. Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd compression. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Ki

Re: [PATCH v4 1/2] Import upstream zstd-1.3.6

2018-11-06 Thread Nick Terrell
> On Nov 6, 2018, at 6:48 AM, Daniel Kiper wrote: > > On Wed, Oct 31, 2018 at 10:56:16AM -0700, Nick Terrell wrote: >> Import zstd-1.3.6 from upstream [1]. Only the files need for decompression >> are imported. Additionally makes zstd a module by adding module.c which &g

[PATCH v5 0/2] btrfs: Add zstd support to grub btrfs

2018-11-12 Thread Nick Terrell
Hi all, This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without zstd compression and rebooting. Best, Nick Terrell Changelog: v1 -> v2: - S

[PATCH v5 2/2] btrfs: Add zstd support to grub btrfs

2018-11-12 Thread Nick Terrell
ssion. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Kiper. v2 -> v3: - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). - Fix style and formatting comments

[PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-15 Thread Nick Terrell
ssion. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Kiper. v2 -> v3: - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). - Fix style and formatting comments

[PATCH v6 0/2] btrfs: Add zstd support to grub btrfs

2018-11-15 Thread Nick Terrell
Hi all, This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without zstd compression and rebooting. Best, Nick Terrell Changelog: v1 -> v2: - S

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
> On Nov 19, 2018, at 7:11 AM, Daniel Kiper wrote: > >> On Mon, Nov 19, 2018 at 03:22:51PM +0100, Daniel Kiper wrote: >>> On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote: >>> - Adds zstd support to the btrfs module. >>> - Adds a test cas

[PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
Hi all, This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without zstd compression and rebooting. Best, Nick Terrell Changelog: v1 -> v2: - S

[PATCH v7 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
ssion. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell Reviewed-by: Daniel Kiper --- v1 -> v2: - Fix comments from Daniel Kiper. v2 -> v3: - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). - Fi

Re: [PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-26 Thread Nick Terrell
> On Nov 19, 2018, at 12:34 PM, Daniel Kiper wrote: > > On Mon, Nov 19, 2018 at 11:20:06AM -0800, Nick Terrell wrote: >> Hi all, >> >> This patch set imports the upstream zstd library, adds zstd support to the >> btrfs module, and adds a test case. I'v

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-15 Thread Nick Vinson
Paul, Let me start of by saying that I am a contributor and do not have any authority to approve or deny patches to GRUB. That said I do have a few comments below that I would like for you to consider. On 2/15/19 3:07 AM, Paul Menzel wrote: > Date: Thu, 10 Nov 2016 13:44:25 -0500 > > Add GRUB_F

Re: [PATCH v2] Optimization calculation expression of FOR_MODULES(var)

2019-04-11 Thread Nick Vinson
You cannot remove sizeof(A) from the expression, as doing so may cause the updated expression to compute a different answer. Consider ((H*)var)->size = 64, B = 32, and A = 64. In the original form, you have the expression (64 + 64 - 1) / 64 * 64 / 32 which equals 2. In your proposal, you have the

Re: [PATCH] grub2: add support to search for partuuid

2019-05-28 Thread Nick Vinson
On 5/27/19 1:07 AM, Michael Grzeschik wrote: > With this feature the grub-shell is able to search for partuuid strings. > This reduces the complexity to find the correct boot partition on > systems with unspecified device connectivity. > > Signed-off-by: Michael Grzeschik > --- > grub-core/Mak

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-06 Thread Nick Terrell
that is 18 KB uncompressed and 8 KB compressed, but it can’t be used in production, since it isn’t hardened against invalid inputs. But, it shows the zstd format can be decompressed with a small library. If we (upstream) add a smaller zstd decompressor, we will put a patch up to use it in GRUB.

Re: strip --strip-unneeded adds back section symbols

2016-02-01 Thread Nick Clifton
the simplest solution will be to make strip rerun its symbol removing pass after having copied all of the sections. Cheers Nick ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [GRUB PARTUUID PATCH 2/2] Update grub script template files

2016-07-19 Thread Nick Vinson
My apologies. It looks like most of my reply was cut-off when this email was sent. I'm pasting the missing part below. Thanks, Nicholas Vinson > I found a minor error in my original patch for 10_linux.in. I created the > patch > below to fix it. My apologies for not noticing it in the origin

Re: [GRUB PARTUUID PATCH 2/2] Update grub script template files

2016-07-27 Thread Nick Vinson
On 07/26/2016 10:01 PM, Andrei Borzenkov wrote: > 20.06.2016 04:37, Nicholas Vinson пишет: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. >> >> Signed-off-by: Nicholas Vinson >> --- >> util/grub-mkconfig.in | 2 ++ >> util/grub.d/10_linux.in | 11 +

Re: Grub module to return partuuid of a device such as (hd0, gpt1) at boot time

2016-08-15 Thread Nick Vinson
Steve, I'm not part of the mailing list and I only periodically check it. However, I was wondering if your request is the same as the code request that I made earlier this month (http://lists.gnu.org/archive/html/grub-devel/2016-08/msg00018.html). If not could you tell me how it's different? If t

Re: Grub module to return partuuid of a device such as (hd0, gpt1) at boot time

2016-08-15 Thread Nick Vinson
der version of this patch set that I submitted back in June. You may find the review comments helpful. The link to the comments are: http://lists.gnu.org/archive/html/grub-devel/2016-07/msg00043.html Thanks, Nicholas Vinson > > On August 14, 2016 9:43:14 PM CDT, Nick Vinson wrote: >

Re: [PATCH 1/1] add --partuuid to probe

2017-02-14 Thread Nick Vinson
I'll need to check it against the 2.02 sources, but even if it needs updating, it shouldn't be too hard to do it. I can add your changes to the patchset. -Nick On 02/14/2017 11:39 AM, Steve Kenton wrote: > Nick, > > What is the state of your patch set? I think mine is

Re: [GRUB PARTUUID PATCH V3 0/5] Add PARTUUID detection support

2017-05-08 Thread Nick Vinson
I would like to remind grub-devel of this patch set. Since the last time I submitted this, Flex-2.6.4 has been released, so Part 1 of this patch set can now be dropped. Part 5 is optional and can be removed if the development team does not approve of its changes. Finally, this is the version tha

Re: [GRUB PARTUUID PATCH V4 0/3] Add PARTUUID detection support

2017-07-23 Thread Nick Vinson
Hello, I submitted this patch set back in May and have not heard anything. I noticed it also has not been merged into the GRUB tree. Is there some issue with the patches that I still need to fix? If so, please let me know so I can make the corrections and submit an updated patch set. Thanks, N

Re: [GRUB PARTUUID PATCH V5 1/3] Update grub_gpt_partentry; centralize guid prints

2018-03-18 Thread Nick Vinson
Sorry for the delay in responding. I just now saw these replies. On 02/20/2018 09:30 AM, Daniel Kiper wrote: > On Sun, Feb 04, 2018 at 11:47:35AM -0800, Nicholas Vinson wrote: >> To help clean the code and simplify the code in util/grub-probe.c, this >> patch renames grub_gpt_part_type to grub_gp

Re: [GRUB PARTUUID PATCH V5 2/3] Add PARTUUID detection support to grub-probe

2018-03-18 Thread Nick Vinson
On 02/20/2018 09:41 AM, Daniel Kiper wrote: > On Sun, Feb 04, 2018 at 11:47:36AM -0800, Nicholas Vinson wrote: >> Add PARTUUID detection support grub-probe for MBR and GPT partition >> schemes. The Linux kernel supports mounting the root filesystem by >> Linux device name or by the Partition [GU]U

Re: [GRUB PARTUUID PATCH V5 3/3] Update grub script template files

2018-03-18 Thread Nick Vinson
On 02/20/2018 09:45 AM, Daniel Kiper wrote: > On Sun, Feb 04, 2018 at 11:47:37AM -0800, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. > > As earlier lack of SOB. Otherwise LGTM. Will be added in V6

Re: [GRUB PARTUUID PATCH V6 4/4] Update grub script template files

2018-03-22 Thread Nick Vinson
On 03/22/2018 06:56 AM, Daniel Kiper wrote: > On Sun, Mar 18, 2018 at 12:06:03PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. >> >> Signed-off-by: Nicholas Vinson >> --- >> docs/grub.texi

Re: [GRUB PARTUUID PATCH V6 3/4] Add PARTUUID detection support to grub-probe

2018-03-22 Thread Nick Vinson
On 03/22/2018 06:51 AM, Daniel Kiper wrote: > On Sun, Mar 18, 2018 at 12:06:02PM -0700, Nicholas Vinson wrote: >> Add PARTUUID detection support grub-probe for MBR and GPT partition >> schemes. >> >> Signed-off-by: Nicholas Vinson >> --- >> util/grub-probe.c | 51 +

Re: [GRUB PARTUUID PATCH V7 3/4] Add PARTUUID detection support to grub-probe

2018-03-27 Thread Nick Vinson
On 03/27/2018 01:52 PM, Daniel Kiper wrote: > On Mon, Mar 26, 2018 at 11:07:58PM -0700, Nicholas Vinson wrote: >> Add PARTUUID detection support grub-probe for MBR and GPT partition >> schemes. >> >> Signed-off-by: Nicholas Vinson >> --- >> util/grub-probe.c | 48 +

Re: [GRUB PARTUUID PATCH V8 4/4] Update grub script template files

2018-04-04 Thread Nick Vinson
On 04/04/2018 01:23 PM, Daniel Kiper wrote: > On Wed, Mar 28, 2018 at 08:32:54AM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. >> >> Signed-off-by: Nicholas Vinson >> --- >> docs/grub.texi

Suggestion for grub beep notification

2022-09-09 Thread Nick F
Hi guys, I am using grub to book a dual OS computer. When I start/restart the computer, I want to be notified by a beep, so I can make the OS selection. I enabled the beep by uncommenting the line GRUB_INIT_TUNE in /etc/default/grub but the beep comes up a few seconds before the grub menu is disp

Re: Suggestion for grub beep notification

2022-09-16 Thread Nick F
t, 10 Sep 2022 16:41:21 +1000 > Nick F wrote: > > > Hi guys, > > > > I am using grub to book a dual OS computer. When I start/restart the > > computer, I want to be notified by a beep, so I can make the OS > selection. > > I enabled the beep by uncommenting