gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
With the latest grub HEAD (620857c4dccb8f0548cdb855f6b2f46ebea3919e) I'm getting the following compilation error with gcc-9.1: /home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.1-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc -DHAVE_CONFIG_H -I. -Wall -W -DGRUB_UTIL=1 -D_FIL

Re: gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
Mon, 6 May 2019 at 18:32, Bruce Dubbs wrote: > > On 5/6/19 12:15 PM, Neil MacLeod wrote: > > With the latest grub HEAD (620857c4dccb8f0548cdb855f6b2f46ebea3919e) > > I'm getting the following compilation error with gcc-9.1: > > > > /home/ubuntu/projects/LibreELE

Re: gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
different repo in my original post! Regards Neil On Mon, 6 May 2019 at 18:59, John Paul Adrian Glaubitz wrote: > > On 5/6/19 7:15 PM, Neil MacLeod wrote: > > Does anyone have a patch? > > Try the attached patch. > > Adrian > > -- > .''`. John Pau

Re: gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
(it includes your patch): http://ix.io/1IfC Many thanks Neil On Mon, 6 May 2019 at 19:19, Neil MacLeod wrote: > > Thanks Adrian - testing with your patch now, will be another hour or > so until the build is complete (cross-compiling environment with own > toolchain etc.) >

Re: gcc9.1 and f2fs

2019-05-07 Thread Neil MacLeod
27;t actually say if it works at run-time. Many thanks Neil On Mon, 6 May 2019 at 20:58, Neil MacLeod wrote: > > Hi Adrian > > With your patch, grub now fails to build as follows: > > fs/f2fs.c: In function 'grub_f2fs_get_block': > fs/f2fs.c:864:43: error: &#

Re: gcc9.1 and f2fs

2019-05-07 Thread Neil MacLeod
Sorry, wrong patch in previous email - this is the one for grub! Neil On Wed, 8 May 2019 at 01:51, Neil MacLeod wrote: > > Adrian > > I used the attached patch and grub is now building for me with gcc-9.1. > > I've no idea if this is the right solution, but it does at l

Re: [PATCH] f2fs: Fix gcc9 error -Werror=maybe-uninitialized

2019-05-17 Thread Neil MacLeod
ignify an error that the input block cannot be handled. Any caller > > should therefore check level is negative or not before processing the > > output. > > > > Reported-by: Neil MacLeod > > Signed-off-by: Michael Chang > > --- > > grub-core/fs/f2fs.c | 7 +++

Re: [PATCH] f2fs: Fix gcc9 error -Werror=maybe-uninitialized

2019-05-22 Thread Neil MacLeod
wrote: > > On Fri, May 17, 2019 at 05:16:34PM +0100, Neil MacLeod wrote: > > Hi Daniel & Michael > > > > I've tested the new patch (in place of my attempt) and grub is > > building successfully so it looks good here! > > Thanks! I allowed myself to

Re: [PATCH] f2fs: Disable gcc9 -Waddress-of-packed-member

2019-05-29 Thread Neil MacLeod
Hi Daniel I can confirm that grub (based on 53e70d30cf0d18e6c28bab0ab8d223a90d3e1b46) is building with gcc-9.1 and this new patch. I'm not in a position to run-time test the resulting grub binary, but it does at least now build! Many thanks Neil On Wed, 29 May 2019 at 12:18, Daniel Kiper wrote