On Tue, Mar 2, 2021 at 4:08 PM Daniel Kiper wrote:
>
> Hi Adrian,
>
> On Tue, Mar 02, 2021 at 08:37:14PM +0100, John Paul Adrian Glaubitz wrote:
> > Hi Daniel!
> >
> > On 3/2/21 7:00 PM, Daniel Kiper wrote:
> > > The BootHole vulnerability [1][2] announced last year encouraged many
> > > people t
On Fri, Oct 11, 2024 at 6:40 PM Leo Sandoval wrote:
>
> From: Michael Chang
>
> Signed-off-by: Michael Chang
This patch needs a real commit message. I know which series of patches
this comes from, and they *all* need real commit messages. Can you and
Michael work to figure out proper messages
On Fri, Oct 11, 2024 at 6:40 PM Leo Sandoval wrote:
>
> From: Michael Chang
>
> Signed-off-by: Michael Chang
> Signed-off-by: Robbie Harwood
This needs a real commit message describing what this does. Please
work with Michael to come up with one. :)
> ---
> grub-core/fs/btrfs.c | 107 +++
On Fri, Oct 11, 2024 at 6:39 PM Leo Sandoval wrote:
>
> This is the second patch series, taken from Fedora Rawhide spec [1] that
> is distro-agnostic. The goal is to merge most of them so all the
> community/distros
> would benefit.
>
> Changes since v1:
> - delete 0024-efinet-and-bootp-add-s
On Fri, Oct 11, 2024 at 6:39 PM Leo Sandoval wrote:
>
> From: Michael Chang
>
> Signed-off-by: Michael Chang
> Signed-off-by: Robbie Harwood
Can we have a description of what this patch does for the commit
message? The bug report[1] is private, so I have no context here.
[1]: https://bugzilla
On Tue, Oct 8, 2024 at 2:59 AM Michael Chang via Grub-devel
wrote:
>
> On Mon, Oct 07, 2024 at 09:40:40PM GMT, Vladimir 'phcoder' Serbinenko wrote:
> > What do you try to achieve with this that can't be achieved with using full
> > path? We should avoid using hidden state for directory parsing. So
)
> +{
> + result = grub_strtoull(val, NULL, 10);
> + if (grub_errno)
> +return NULL;
> +}
> +
> + grub_free (btrfs_default_subvol);
> + btrfs_default_subvol = NULL;
> + btrfs_default_subvolid = result;
> + return grub_strdup(val);
> +}
> +
> +static const
}
>
> - if (data->sblock.label)
> + if (data->sblock.label[0])
> grub_printf("Label: '%s' ", data->sblock.label);
>else
> grub_printf("Label: none ");
> --
> 2.46.2
>
Straightforward and reasonable.
Reviewed-by: Nea
> subvol_set_env);
>grub_register_variable_hook ("btrfs_subvolid", subvolid_get_env,
> subvolid_set_env);
> + grub_env_export ("btrfs_subvol");
> + grub_env_export ("btrfs_subvolid");
> }
>
> GRUB_MOD_F
" != x ]; then
> GRUB_CMDLINE_LINUX="rootflags=subvol=${rootsubvol}
> ${GRUB_CMDLINE_LINUX}"
> + fi
> fi;;
> xzfs)
> rpool=`${grub_probe} --device ${GRUB_DEVICE} --target=fs_label
> 2>/dev/null || true`
> diff --git a/util/grub.d/20_linux
cpu_to_le64_compile_time
> (GRUB_BTRFS_OBJECT_ID_CHUNK);
> + key->type = GRUB_BTRFS_ITEM_TYPE_DIR_ITEM;
> + key->offset = 0;
> + }
> + else
> + {
> + *type = GRUB_BTRFS_DIR_ITEM_TYPE_DIRECTORY;
> + *tree = data->sblock.root_tree;
> + key->object_id = data->sblock.root_dir_objectid;
> + key->type = GRUB_BTRFS_ITEM_TYPE_DIR_ITEM;
> + key->offset = 0;
> + follow_default = 1;
> + }
> }
> else
> {
> @@ -2922,6 +2966,7 @@ GRUB_MOD_INIT (btrfs)
> subvolid_set_env);
>grub_env_export ("btrfs_subvol");
>grub_env_export ("btrfs_subvolid");
> + grub_env_export ("btrfs_relative_path");
> }
>
> GRUB_MOD_FINI (btrfs)
> --
> 2.46.2
>
LGTM. :)
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
(varname, output);
> + else
> +grub_printf ("%s\n", output);
> +
> + grub_free (output);
> + grub_free (subvol);
> +
> + grub_btrfs_unmount (data);
> + grub_device_close (dev);
> +
> + return GRUB_ERR_NONE;
> +}
> +
> static struct grub_fs g
On Fri, Oct 18, 2024 at 1:39 PM Vladimir 'phcoder' Serbinenko
wrote:
>
>
>
> Le lun. 14 oct. 2024, 20:10, Leo Sandoval a écrit :
>>
>> From: Jeff Mahoney
>>
>> This patch adds the ability to specify a different root on a btrfs
>> filesystem too boot from other than the default one.
>
> Does it m
On Mon, Oct 21, 2024 at 4:29 AM Vladimir 'phcoder' Serbinenko
wrote:
>
>
>
> Le lun. 21 oct. 2024, 06:49, Michael Chang via Grub-devel
> a écrit :
>>
>> On Fri, Oct 18, 2024 at 08:39:01PM GMT, Vladimir 'phcoder' Serbinenko wrote:
>> > Le lun. 14 oct. 2024, 20:10, Leo Sandoval a écrit :
>> >
>>
On Thu, Oct 31, 2024 at 3:43 PM Leo Sandoval wrote:
>
> From: Jan Hlavac
>
> For each platform, GRUB is shipped as a kernel image and a set of
> modules. These files are then used by the grub-install utility to
> install GRUB on a specific device. However, in order to support UEFI
> Secure Boot,
On Thu, Oct 31, 2024 at 3:43 PM Leo Sandoval wrote:
>
> From: Marta Lewandowska
>
> UEFI Secure Boot requires signed grub binaries to work, so grub-
> install should not be used. However, users who have Secure Boot
> disabled and wish to use the command should not be prevented from
> doing so if
btrfs: Fixup for newer compiler
>
> grub-core/fs/btrfs.c | 629 ---
> include/grub/btrfs.h | 1 +
> 2 files changed, 595 insertions(+), 35 deletions(-)
>
> --
> 2.46.2
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
17 matches
Mail list logo
