the surrounding
double-quotes added is kept as it used to protect space.
[1] https://www.gnu.org/software/grub/manual/grub/html_node/linux.html#linux
[2]
https://www.gnu.org/software/grub/manual/grub/html_node/xen_005fhypervisor.html
Signed-off-by: Michael Chang
---
grub-core/lib/cmdline.c | 12
And this bug report seems relevant ..
https://savannah.gnu.org/bugs/?49937
On Wed, Apr 11, 2018 at 04:58:54PM +0800, Michael Chang wrote:
> The command line has been processed by grub shell, then the result is expected
> to be passed to kernel command line as verbatim according to th
can be
set arbitrary value.
This patch fixes the next_buf calculation to accept any integers.
Signed-off-by: Michael Chang
---
grub-core/io/bufio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/io/bufio.c b/grub-core/io/bufio.c
index 22438277d..d0b0f71b6 100644
--
On Tue, Apr 17, 2018 at 06:37:06PM +0200, Daniel Kiper wrote:
> On Wed, Apr 11, 2018 at 05:17:03PM +0800, Michael Chang wrote:
> > And this bug report seems relevant ..
> >
> > https://savannah.gnu.org/bugs/?49937
> >
> > On Wed, Apr 11, 2018 at 04:58:54PM +080
On Tue, Apr 17, 2018 at 07:11:34PM +0200, Daniel Kiper wrote:
> CC-ing Vladimir.
>
> On Mon, Apr 16, 2018 at 06:05:04PM +0800, Michael Chang wrote:
> > The next_buf is the offset to the next cached block rounded to the size of
> > bufio->block_size. However the calculation
Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf
calcuation in grub_bufio_read.
Signed-off-by: Michael Chang
---
grub-core/io/bufio.c | 8
1 file changed, 8 insertions(+)
diff --git a/grub-core/io/bufio.c b/grub-core/io/bufio.c
index 22438277d..4d66b6
On Mon, Apr 23, 2018 at 03:57:22PM +0200, Daniel Kiper wrote:
> On Fri, Apr 20, 2018 at 03:21:30PM +0800, Michael Chang wrote:
> > Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf
> > calcuation in grub_bufio_read.
> >
> > Signed-off-by: Mi
Rounding up the bufio->block_size to meet power of 2 to facilitate next_buf
calcuation in grub_bufio_read.
Signed-off-by: Michael Chang
v2:
- Use a more terse approach to round up size suggested by Daniel
- Added comment to explain why to have the size rounded
---
grub-core/io/bufio.c
On Wed, Apr 25, 2018 at 12:45:15PM -0700, Andrew Jeddeloh wrote:
> > As Michael said, "0x0202 + byte value at offset 0x0201" is your friend.
>
> I think Michael's message got lost; I think he replied to just you? I
> didn't receive it and I don't see it in the archives.
Yes, it got lost. I don't
On Tue, Apr 24, 2018 at 12:03:21PM +0200, Daniel Kiper wrote:
> On Wed, Apr 18, 2018 at 03:07:15PM +0800, Michael Chang wrote:
> > On Tue, Apr 17, 2018 at 06:37:06PM +0200, Daniel Kiper wrote:
> > > On Wed, Apr 11, 2018 at 05:17:03PM +0800, Michael Chang wrote:
> > >
On Wed, May 09, 2018 at 03:23:56PM +0200, Daniel Kiper wrote:
> On Thu, Apr 26, 2018 at 04:42:30PM +0800, Michael Chang wrote:
> > On Tue, Apr 24, 2018 at 12:03:21PM +0200, Daniel Kiper wrote:
> > > On Wed, Apr 18, 2018 at 03:07:15PM +0800, Michael Chang wrote:
> > > &
The ipv4 address field is not initialized to zero that would make the
subsequent check to become false positive. The outcome is broken network
interface being created with garbage value which may potentially break network
connectivity.
This patch fixes the problem by initializing them to zero as n
In hostdisk.c::grub_util_fd_open_device, there's a workaround to linux disk
cache described below.
"Linux has a bug that the disk cache for a whole disk is not consistent with
the one for a partition of the disk."
The workaround will result in using the partition device for writing the image
of w
Actually I also have a similar patch posted one month ago for the very same
problem.
https://lists.gnu.org/archive/html/grub-devel/2018-07/msg00103.html
But as long as either way will do, I don't mind which one is going to be
reviewed and eventually merged. :)
On Thu, Aug 23, 2018 at 02:12:56PM
On Tue, Sep 04, 2018 at 04:46:31PM +0200, Daniel Kiper wrote:
> On Wed, Jul 25, 2018 at 04:49:15PM +0800, Michael Chang wrote:
> > In hostdisk.c::grub_util_fd_open_device, there's a workaround to linux disk
>
> s#hostdisk.c::grub_util_fd_open_device#g
work commit message.
Signed-off-by: Michael Chang
---
grub-core/osdep/linux/hostdisk.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/grub-core/osdep/linux/hostdisk.c b/grub-core/osdep/linux/hostdisk.c
index 06179fca7..ed530bdc4 100644
--- a/grub-core/osdep/linux/hostdisk.c
+++ b/grub-co
When booting from NVME SSD with 4k sector size, it fails with the message.
error: attempt to read or write outside of partition.
This patch fixes the problem by fixing overflow in converting partition start
and length into 512B blocks.
Signed-off-by: Michael Chang
---
grub-core/partmap
On Wed, Sep 19, 2018 at 03:28:34PM +0200, Daniel Kiper wrote:
> On Thu, Sep 13, 2018 at 03:20:34PM +0800, Michael Chang wrote:
> > In grub-core/osdep/linux/hostdisk.c::grub_util_fd_open_device() there's
> > comment
> > about linux disk cache issue as below:
> >
&
On Thu, Sep 13, 2018 at 06:06:15PM -0600, Micah Parrish wrote:
> Hi, new subscriber here. We have a problem with Grub 2 and its use of SNP
> instead of MNP. Our UEFI driver for a network card parses the relevant DHCP
> options for iSCSI boot, generates an iBFT table, then gets closed by Grub
> wh
n firmware without MNP implemented.
Signed-off-by: Michael Chang
---
grub-core/net/drivers/efi/efinet.c | 304 -
include/grub/efi/api.h | 109 -
include/grub/net.h | 2 +
3 files changed, 410 insertions(+), 5 deletions(-)
di
On Thu, Sep 20, 2018 at 02:01:08PM +0200, Daniel Kiper wrote:
> On Thu, Sep 20, 2018 at 06:38:07PM +0800, Michael Chang wrote:
> > On Thu, Sep 13, 2018 at 06:06:15PM -0600, Micah Parrish wrote:
> > > Hi, new subscriber here.? We have a problem with Grub 2 and its use of SNP
&g
On Thu, Sep 20, 2018 at 01:26:47PM -0600, Micah Parrish wrote:
>
>
> On 09/20/2018 07:47 AM, grub-devel-requ...@gnu.org wrote:
> > On Thu, Sep 20, 2018 at 06:38:07PM +0800, Michael Chang wrote:
> > > On Thu, Sep 13, 2018 at 06:06:15PM -0600, Micah Parrish wrote:
> &g
Let's refine
the application interface to accept file path rather than descriptor, in
this way the caller doesn't have to care about closing the descriptor by
delegating it to grub_verify_signature() with full tracing to opened
file descriptor by itself.
Signed-off-by: Michael Chang
On Wed, Nov 14, 2018 at 05:23:58PM +0100, Daniel Kiper wrote:
> On Tue, Nov 13, 2018 at 02:31:18PM +0800, Michael Chang wrote:
> > An error emerged as when I was tesing the verifiers branch, so instead
> > of putting it in pgp prefix, the verifiers is used to reflect what the
> &
Let's refine
the application interface to accept file path rather than descriptor, in
this way the caller doesn't have to care about closing the descriptor by
delegating it to grub_verify_signature() with full tracing to opened
file descriptor by itself.
Signed-off-by: Michael Chang
v1 -
On Fri, Nov 16, 2018 at 03:01:30PM +0100, Daniel Kiper wrote:
> On Thu, Nov 15, 2018 at 06:13:11PM +0800, Michael Chang wrote:
> > An error emerged as when I was tesing the verifiers branch, so instead
> > of putting it in pgp prefix, the verifiers is used to reflect what the
> &
error
returning path.
Signed-off-by: Michael Chang
v1 -> v2:
- drop change in grub_verify_signature_init()
v2 -> v3
- Making it clear that sig descriptor is not referenced in error
returning path of grub_verify_signature_init()
---
grub-core/commands/pgp.c | 35 +--
Hi,
With the advent of new verifier framework and shim lock protocol support
to the grub's community, we are driving to the world of UEFI Secure
Boot, well, almost ..
There is a missing piece in the puzzle remaining, that is booting linux
kernel via it's own EFI Handover Protocol's entry. Strictl
On Fri, Jan 11, 2019 at 10:58:54AM +, Leif Lindholm wrote:
> On Thu, Jan 10, 2019 at 09:59:38AM +0100, Alexander Graf wrote:
> > > Am 10.01.2019 um 09:12 schrieb Michael Chang :
> > >
> > > Hi,
> > >
> > > With the advent of new verifier frame
On Fri, Jan 11, 2019 at 03:17:54PM +0100, Ard Biesheuvel wrote:
> On Fri, 11 Jan 2019 at 11:58, Leif Lindholm wrote:
> >
> > On Thu, Jan 10, 2019 at 09:59:38AM +0100, Alexander Graf wrote:
> > > > Am 10.01.2019 um 09:12 schrieb Michael Chang :
> > > >
>
On Mon, Jan 14, 2019 at 08:07:34AM +0100, Ard Biesheuvel wrote:
> On Mon, 14 Jan 2019 at 05:58, Michael Chang wrote:
> >
> > On Fri, Jan 11, 2019 at 10:58:54AM +, Leif Lindholm wrote:
> > > On Thu, Jan 10, 2019 at 09:59:38AM +0100, Alexander Graf wrote:
> >
On Mon, Jan 14, 2019 at 08:41:21AM +0100, Ard Biesheuvel wrote:
> On Mon, 14 Jan 2019 at 08:30, Michael Chang wrote:
> >
> > On Fri, Jan 11, 2019 at 03:17:54PM +0100, Ard Biesheuvel wrote:
> > > On Fri, 11 Jan 2019 at 11:58, Leif Lindholm
> > > wrote:
> >
On Mon, Jan 14, 2019 at 10:57:10AM +0100, Ard Biesheuvel wrote:
> On Mon, 14 Jan 2019 at 10:53, Michael Chang wrote:
> >
> > On Mon, Jan 14, 2019 at 08:41:21AM +0100, Ard Biesheuvel wrote:
> > > On Mon, 14 Jan 2019 at 08:30, Michael Chang wrote:
> > > >
> &
On Mon, Jan 14, 2019 at 11:22:23AM +0100, Alexander Graf wrote:
> On 01/14/2019 10:14 AM, Michael Chang wrote:
> > On Mon, Jan 14, 2019 at 08:07:34AM +0100, Ard Biesheuvel wrote:
> > > On Mon, 14 Jan 2019 at 05:58, Michael Chang wrote:
> > > > On Fri, Jan 11,
On Mon, Jan 14, 2019 at 01:42:29PM -0500, Peter Jones wrote:
> On Mon, Jan 14, 2019 at 05:14:21PM +0800, Michael Chang wrote:
> > > > 3. The Shim's fallback mode has been used to recreate boot entries after
> > > > firmware update for x86, not sure if that any
On Fri, Jan 11, 2019 at 08:49:28PM +0100, Alexander Graf wrote:
>
>
> On 11.01.19 20:32, Matthew Garrett wrote:
> > On Thu, Jan 10, 2019 at 12:59 AM Alexander Graf wrote:
> >> So really dumb question here: What if we didn't use the MS key? What if
> >> instead, we just provide a SUSE/openSUSE k
alignment requirement
and the outcome is risky to memory alignment fault on some architecture
when deferencing it.
Please help to review.
Thanks.
Michael Chang (8):
cpio: fix gcc9 error address-of-packed-member
jfs: fix gcc9 error address-of-packed-member
hfs: fix gcc9 error address-of-packed
ct grub_efi_file_path_device_path' may result in an unaligned
pointer value [-Werror=address-of-packed-member]
[ 255s] 900 | *grub_utf16_to_utf8 (buf, fp->path_name,
[ 255s] | ~~^~~
Signed-off-by: Michael Chang
---
grub-core/kern/efi/
result in an unaligned pointer value
[-Werror=address-of-packed-member]
[ 83s] 700 | : (&data->sblock.extent_recs));
[ 83s] |~^~~~~~
Signed-off-by: Michael Chang
---
include/grub/hfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
er value
[-Werror=address-of-packed-member]
[ 59s] 1019 | *grub_utf16_to_utf8 ((grub_uint8_t *) (*label), catkey->name,
[ 59s] | ~~^~
Signed-off-by: Michael Chang
---
grub-core/fs/hfsplus.c | 57 +
packed-member]
[ 59s]62 | namesize = read_number (hd.namesize, ARRAY_SIZE
(hd.namesize));
[ 59s] | ~~^
Signed-off-by: Michael Chang
---
grub-core/fs/cpio.c| 5 +++--
grub-core/fs/cpio_be.c | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
d
*string, descstrp->str,
[ 229s] | ^~~~~
Signed-off-by: Michael Chang
---
grub-core/commands/usbtest.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/grub-core/commands/usbtest.c b/grub-core/commands
[-Werror=address-of-packed-member]
[ 60s] 570 | le_to_cpu16_copy (filename + strpos, next_leaf->namepart, len
< 15 ? len : 15);
[ 60s] | ~^~
[ 60s] cc1: all warnings being treated as errors
Signed-off-by: Michael Chang
---
of packed member of 'struct grub_efi_file_path_device_path' may result in an
unaligned pointer value [-Werror=address-of-packed-member]
[ 243s] 138 | for (p = fp->path_name; p < fp->path_name + size; p++)
[ 243s] |^~
Signed-off-by: Michael Cha
ommands/lsacpi.c:23:
[ 233s] ../../include/grub/acpi.h:50:8: note: defined here
[ 233s]50 | struct grub_acpi_table_header
[ 233s] |^~
[ 233s] ../../include/grub/acpi.h:90:8: note: defined here
[ 233s]90 | struct grub_acpi_madt
[ 233s] |^~~
On Tue, Apr 09, 2019 at 08:57:25PM +1000, Vladimir 'phcoder' Serbinenko wrote:
> On Tue, Apr 9, 2019 at 8:48 PM Michael Chang wrote:
> >
> > This patch set attempts to resolve the build failure in openSUSE build
> > service equipped with new gcc 9 compiler, which h
On Tue, Apr 09, 2019 at 10:15:33PM +1000, Vladimir 'phcoder' Serbinenko wrote:
> On Tue, Apr 9, 2019 at 9:40 PM Michael Chang wrote:
> >
> > On Tue, Apr 09, 2019 at 08:57:25PM +1000, Vladimir 'phcoder' Serbinenko
> > wrote:
> > > O
) *string, descstrp->str,
[ 229s] | ~~~~^
Signed-off-by: Michael Chang
---
grub-core/commands/usbtest.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/grub-core/commands/usbtest.c b/grub-core/commands/usbtest.c
index 01cdca9
27; may result in an unaligned pointer value
[-Werror=address-of-packed-member]
[ 59s] 1019 | *grub_utf16_to_utf8 ((grub_uint8_t *) (*label), catkey->name,
[ 59s] | ~~^~
Signed-off-by: Michael Chang
---
grub-core/fs/hfspl
address
of packed member of 'struct grub_efi_file_path_device_path' may result in an
unaligned pointer value [-Werror=address-of-packed-member]
[ 243s] 138 | for (p = fp->path_name; p < fp->path_name + size; p++)
[ 243s] |^~
Signed-off-by: Michael Cha
in an unaligned pointer value
[-Werror=address-of-packed-member]
[ 83s] 700 | : (&data->sblock.extent_recs));
[ 83s] | ~^~
Signed-off-by: Michael Chang
---
include/grub/hfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
*grub_utf16_to_utf8 (buf, fp->path_name,
[ 255s] | ~~^~~
Signed-off-by: Michael Chang
---
grub-core/kern/efi/efi.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/grub-core/kern/efi/efi.c b/grub-core/kern/efi/efi.c
index 708581
3:
[ 233s] ../../include/grub/acpi.h:50:8: note: defined here
[ 233s]50 | struct grub_acpi_table_header
[ 233s] |^~
[ 233s] ../../include/grub/acpi.h:90:8: note: defined here
[ 233s]90 | struct grub_acpi_madt
[ 233s] |^~
ddress-of-packed-member]
[ 59s]62 | namesize = read_number (hd.namesize, ARRAY_SIZE
(hd.namesize));
[ 59s] | ~~^
Signed-off-by: Michael Chang
---
grub-core/fs/cpio_common.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/grub-core/fs/cpio_common.
x27; may result in an unaligned pointer value
[-Werror=address-of-packed-member]
[ 60s] 570 | le_to_cpu16_copy (filename + strpos, next_leaf->namepart, len
< 15 ? len : 15);
[ 60s] | ~^~
[ 60s] cc1: all warnings being treated
alignment requirement
and the outcome is risky to memory alignment fault on some architecture
when deferencing it.
Please help to review.
Thanks.
v2: Disable -Werror=address-of-packed-member if its diagnose turns out
to be false positive.
Michael Chang (8):
cpio: disable gcc9 -Waddress-of-packed
Hello John,
Except for lacking commit message and SOB, the fix is LGTM.
You could add my Reviewed-by: Michael Chang if you
resend the patch to mailing list with those missing message fixed.
Thanks,
Michael
On Mon, May 06, 2019 at 07:59:42PM +0200, John Paul Adrian Glaubitz wrote:
> On 5/6
On Wed, May 08, 2019 at 01:51:20AM +0100, Neil MacLeod wrote:
> Adrian
>
> I used the attached patch and grub is now building for me with gcc-9.1.
>
> I've no idea if this is the right solution, but it does at least work
> (ie. builds) which is all I require for now as I'm not personally
> using
be processed.
The fix is to set level = -1 as return value by grub_get_node_path to
signify an error that the input block cannot be handled. Any caller
should therefore check level is negative or not before processing the
output.
Reported-by: Neil MacLeod
Signed-off-by: Michael Chang
---
grub
On Wed, May 22, 2019 at 05:35:34PM +0100, Neil MacLeod wrote:
> > Thanks! I allowed myself to add your Tested-by. I hope this is not a
> > problem for you
>
> Not at all!
>
> > This and other fixes posted earlier are now in the tree.
>
> Latest grub HEAD (53e70d30cf0d18e6c28bab0ab8d223a90d3e1b4
: Michael Chang
---
docs/grub.texi | 4
util/grub-mkconfig.in | 3 ++-
util/grub.d/30_os-prober.in | 4
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/docs/grub.texi b/docs/grub.texi
index 3d50b16ba..0295d1e67 100644
--- a/docs/grub.texi
+++ b/docs
On Mon, Jul 15, 2019 at 05:26:55PM +0100, Colin Watson wrote:
> On Mon, Jul 15, 2019 at 09:28:31AM +0000, Michael Chang wrote:
> > This patch adds support to disable os-prober debug output while running
> > grub-mkconfig through GRUB_OS_PROBER_DISABLE_DEBUG=true in simple
&g
On Tue, Jul 23, 2019 at 07:41:12PM +0100, Colin Watson wrote:
> On Tue, Jul 16, 2019 at 07:28:32AM +0000, Michael Chang wrote:
> > What about changing the os-prober default to disable the debug output ?
>
> I haven't thought about it in detail, but that seems reasonable enough
re not
activated and mounted, IMHO it should be fine to read directly from
original lv since all cached data should have been flushed back in the
process of taking it offline.
Signed-off-by: Michael Chang
---
grub-core/disk/lvm.c | 125 +++
1 file cha
On Wed, Oct 23, 2019 at 12:48:23PM +0200, Daniel Kiper wrote:
> On Wed, Oct 16, 2019 at 06:15:30AM +0000, Michael Chang wrote:
> > The lvm cache logical volume is the logical volume consisting of the
> > original and the cache pool logical volume. The original is usually on a
> &
On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote:
> On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote:
> > Hello Daniel,
> >
> > On 10/21/19 4:56 PM, Daniel Kiper wrote:
> > > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote:
> > >> From: P
On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote:
> On Thu, Oct 24, 2019 at 06:54:53AM +0000, Michael Chang wrote:
> > On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote:
> > > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote:
&g
On Thu, Oct 24, 2019 at 05:21:04PM +0200, Daniel Kiper wrote:
> On Thu, Oct 24, 2019 at 04:43:58AM +0000, Michael Chang wrote:
> > On Wed, Oct 23, 2019 at 12:48:23PM +0200, Daniel Kiper wrote:
> > > On Wed, Oct 16, 2019 at 06:15:30AM +0000, Michael Chang wrote:
> > > >
On Fri, Oct 25, 2019 at 08:48:05AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Fri, 25 Oct 2019, 08:20 Michael Chang, wrote:
>
> > On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote:
> > > On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrot
ve it sparse the
filesystem which could lead to unexpected outcome.
This patch adds message in grubenv file to warn the user from editing it by
tools other than grub-editenv.
Signed-off-by: Michael Chang
---
util/editenv.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --
64KB but works. This is simple workaround until a proper fix
landed upstream.
Signed-off-by: Michael Chang
---
grub-core/fs/btrfs.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c
index 48bd3d04a..8f98892d3 100644
--- a/grub-
y the exec()
family of functions.
Signed-off-by: Michael Chang
---
grub-core/osdep/linux/hostdisk.c | 3 +++
grub-core/osdep/unix/hostdisk.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/grub-core/osdep/linux/hostdisk.c b/grub-core/osdep/linux/hostdisk.c
index 8b92f8528..da62f924e 100644
re not
activated and mounted, IMHO it should be fine to read directly from
original lv since all cached data should have been flushed back in the
process of taking it offline.
Signed-off-by: Michael Chang
---
Changes since v2:
* Move struct cache_lv definition to the beginning of file
* Add handli
On Tue, Nov 05, 2019 at 11:52:44AM +0100, Paul Menzel wrote:
> Dear Michael,
>
>
> Thank you for your patch.
>
> On 2019-11-05 10:19, Michael Chang wrote:
> > The zstd support in btrfs has dependenciy to zstd module and core.img
>
> dependency
OK. The typo
s,
Michael
>
> On Tue, 5 Nov 2019, 01:25 Michael Chang, wrote:
>
> > The zstd support in btrfs has dependenciy to zstd module and core.img
> > grows its size significantly to 75KB on my system. The resulted image
> > cannot be installed into btrfs bootloader area in
On Wed, Nov 06, 2019 at 01:40:30PM +0100, David Sterba wrote:
> On Tue, Nov 05, 2019 at 09:19:59AM +0000, Michael Chang wrote:
> > The zstd support in btrfs has dependenciy to zstd module and core.img
> > grows its size significantly to 75KB on my system. The resulted image
> >
On Wed, Nov 06, 2019 at 09:08:41PM -0800, Vladimir 'phcoder' Serbinenko wrote:
> On Wed, 6 Nov 2019, 20:55 Michael Chang, wrote:
>
> > On Wed, Nov 06, 2019 at 11:15:04AM -0800, Vladimir 'phcoder' Serbinenko
> > wrote:
> > > Please don't
On Tue, Nov 05, 2019 at 12:49:08PM +0100, Javier Martinez Canillas wrote:
> Hello Michael,
>
> On 11/5/19 10:20 AM, Michael Chang wrote:
> > The environment block is a preallocated 1024-byte file serves as persistent
> > storage for environment variables. It has its own form
size should be above 1MB (or such). You should go check with your disk
tools to find the suitable parameter to fulfill the requirement, for eg,
the partition alignment would mostly affect this.
Thanks,
Michael
>
> > Daniel
> >
> > > On Tue, 5 Nov 2019, 01:25 Michael Chang,
On Thu, Oct 24, 2019 at 05:21:04PM +0200, Daniel Kiper wrote:
> On Thu, Oct 24, 2019 at 04:43:58AM +0000, Michael Chang wrote:
> > On Wed, Oct 23, 2019 at 12:48:23PM +0200, Daniel Kiper wrote:
> > > On Wed, Oct 16, 2019 at 06:15:30AM +0000, Michael Chang wrote:
> > > >
On Wed, Nov 13, 2019 at 03:10:41PM +0100, Daniel Kiper wrote:
> On Tue, Nov 05, 2019 at 09:33:00AM +0000, Michael Chang wrote:
> > The lvm cache logical volume is the logical volume consisting of the
> > original and the cache pool logical volume. The original is usually on a
> &
On Mon, Nov 18, 2019 at 01:09:23PM +0100, Daniel Kiper wrote:
> On Mon, Nov 18, 2019 at 08:05:22AM +0000, Michael Chang wrote:
> > On Thu, Oct 24, 2019 at 05:21:04PM +0200, Daniel Kiper wrote:
> > > On Thu, Oct 24, 2019 at 04:43:58AM +0000, Michael Chang wrote:
> > > &
On Fri, Nov 15, 2019 at 12:42:52PM +0100, Daniel Kiper wrote:
> On Thu, Nov 14, 2019 at 09:53:54AM +0000, Michael Chang wrote:
> > On Wed, Nov 13, 2019 at 12:00:50PM +0100, Daniel Kiper wrote:
> > > On Thu, Nov 07, 2019 at 12:52:35PM +0100, Daniel Kiper wrote:
> > > >
his for booting rogue uefi image.
error: bad shim signature
error: you need to load the kernel first
Press any key to continue...
and then you can go back to boot menu by pressing any key or after a few
seconds expired.
Signed-off-by: Michael Chang
---
grub-core/commands/verifiers.c | 3 ++-
On Mon, Feb 24, 2020 at 10:30:36AM -0800, Paul Dagnelie wrote:
> On Mon, Feb 24, 2020 at 3:03 AM Daniel Kiper wrote:
> >
> >
> > Why "root" not "boot"?
> That was a typo on my part; the code uses grub_guess_root_device to
> find the devices backing the default grub directory, but in most
> configu
nce the case is only
applicable to writeback mode which is sensitive to data lost in nature, I'd
still like to propose my (relatively simple) patch and treat reading dirty
cache as improvement.
Signed-off-by: Michael Chang
---
Changes since v3:
* Add some issue discussed in review proces
Add notes on LVM cache booting to the GRUB manual to help user understanding
the outstanding issue and status.
Signed-off-by: Michael Chang
---
docs/grub.texi | 21 +
1 file changed, 21 insertions(+)
diff --git a/docs/grub.texi b/docs/grub.texi
index 83979af38..8e6f9acec
On Tue, Mar 03, 2020 at 05:59:12PM +0100, Daniel Kiper wrote:
> On Tue, Nov 19, 2019 at 08:34:12AM +0000, Michael Chang wrote:
> > On Fri, Nov 15, 2019 at 12:42:52PM +0100, Daniel Kiper wrote:
> > > On Thu, Nov 14, 2019 at 09:53:54AM +0000, Michael Chang wrote:
> > > &
the size requirement bigger but no way
for the user to relocate their partitions.
The patch tries to correct the paragraph with a more practical size that
works for grub and also for modern computer systems in general.
[1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html
Si
On Thu, Mar 05, 2020 at 03:38:20PM +0100, Daniel Kiper wrote:
> On Thu, Mar 05, 2020 at 06:40:01PM +0800, Michael Chang wrote:
> > Further to the discussion about disabling btrfs zstd support for
> > i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to
>
On Thu, Mar 05, 2020 at 05:00:11PM +0100, C. Masloch wrote:
> Two small suggestions inlined in the quoted part.
>
> Regards,
> ecm
>
>
> On at 2020-03-05 15:38 +0100, Daniel Kiper wrote:
> > On Thu, Mar 05, 2020 at 06:40:01PM +0800, Michael Chang wrote:
> >
t the paragraph with a more practical size that
works for grub and also for modern computer systems in general.
[1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html
Signed-off-by: Michael Chang
---
Changes since v2:
* Rework a paragraph in commit message and also some places in
On Wed, Mar 11, 2020 at 01:43:14PM +0100, Daniel Kiper wrote:
> Adding Michael, Mihai, Javier and Peter...
>
> Below you can find what more or less Vladimir and I agreed WRT small MBR
> gap. In general Vladimir convinced me to phase out small MBR gaps
> support gradually. This is first step in thi
On Fri, Mar 13, 2020 at 01:23:42PM +0100, Daniel Kiper wrote:
> On Wed, Mar 04, 2020 at 02:44:52PM +0800, Michael Chang wrote:
[snip]
> > @@ -243,6 +279,8 @@ grub_lvm_detect (grub_disk_t disk,
> >
> >if (! vg)
> > {
> > + struct cache_lv *cache_lvs
nce the case is only
applicable to writeback mode which is sensitive to data lost in nature, I'd
still like to propose my (relatively simple) patch and treat reading dirty
cache as improvement.
Signed-off-by: Michael Chang
---
Changes since v4:
* Use grub_size_t for sz
* Fix potential null
Add notes on LVM cache booting to the GRUB manual to help user understanding
the outstanding issue and status.
Signed-off-by: Michael Chang
Reviewed-by: Daniel Kiper
---
docs/grub.texi | 21 +
1 file changed, 21 insertions(+)
diff --git a/docs/grub.texi b/docs/grub.texi
Hi Olaf,
The patch rang a bell to me and eventually I figured out that I had
similar patch posted.
https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00038.html
In short, the issue is not only in the fix itself, but also to take care
and provide a measure to avoid incompatible grub.cfg bef
build error in zfs that I managed to come up with
a patch as well. I attached both my patch here for your refernce.
It would be great if you can help to test patch to solve the build
problem for gcc-10 in your system or not.
Thanks,
Michael
>
>
> Have a nice day :)
>
> Thomas
>
On Wed, Mar 25, 2020 at 12:13:49PM +0100, Thomas Schmitt wrote:
> Hi,
>
> Michael Chang wrote in patch 2/2:
> > ../../grub-core/fs/zfs/zfs.c:2263:44: error: array subscript '' is
> > outside the bounds of an interior zero-length array 'grub_uint16_t[0]' {
On Wed, Mar 25, 2020 at 08:35:58AM -0700, PGNet Dev wrote:
> On 3/25/20 12:27 AM, Michael Chang wrote:
> > It would be great if you can help to test patch to solve the build
> > problem for gcc-10 in your system or not.
>
> with your patches, no immediate mdraid1x or zfs b
1 - 100 of 439 matches
Mail list logo
