Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression

2018-11-20 Thread Julien Grall
ll_get_blocklist (grub_device_t root_dev, grub_file_t file; /* Now read the core image to determine where the sectors are. */ - grub_file_filter_disable_compression (); file = grub_file_open (core_path_dev); if (! file) grub_util_error

Re: arm64/xen: Fix too few arguments to function ‘grub_file_open’

2018-11-20 Thread Julien Grall
e similar to x86 Xen. In that case it would be GRUB_FILE_TYPE_LINUX_KERNEL. Cheers, -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’

2018-11-20 Thread Julien Grall
r_t grub_create_loader_cmdline (int argc, char *argv[], char *buf, Signed-off-by: Lee Jones Reviewed-by: Julien Grall Cheers, diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c index 1003a0b99..33a855df4 100644 --- a/grub-core/loader/arm64/xen_boot.c +++ b/grub-core/loader/ar

Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression

2018-11-20 Thread Julien Grall
Hi, On 20/11/2018 11:22, Lee Jones wrote: On Tue, 20 Nov 2018, Julien Grall wrote: On 20/11/2018 10:46, Lee Jones wrote: From: Lee Jones arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression This patch seems to drop support for --nounzip. Can you explain

[PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

2016-02-19 Thread Julien Grall
Xen is currently crashing because of malformed compatible property for the boot module. This is because the property string is not null-terminated as requested by the ePAR spec. --- grub-core/loader/arm64/xen_boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/load

Re: [Xen-devel] [PATCH v3 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-03-09 Thread Julien Grall
this? please correct me if I misunderstand it I'm fine with this plan, it matches the x86 behavior. Cheers, -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

2016-03-30 Thread Julien Grall
Hello, Ping? Regards, On 19/02/16 16:28, Julien Grall wrote: Xen is currently crashing because of malformed compatible property for the boot module. This is because the property string is not null-terminated as requested by the ePAR spec. --- grub-core/loader/arm64/xen_boot.c | 2 +- 1

Re: [Xen-devel] [PATCH v4 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-05-16 Thread Julien Grall
one. What about: "Modules should be loaded in the following order: - dom0 kernel image - dom0 ramdisk if present - XSM policy if present" Regards, -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailma

Re: [Xen-devel] [PATCH v4 0/4] arm64, xen: add xen_boot support into grup-mkconfig

2016-07-05 Thread Julien Grall
changed, 45 insertions(+), 27 deletions(-) -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [Xen-devel] [PATCH v4 0/4] arm64, xen: add xen_boot support into grup-mkconfig

2016-07-06 Thread Julien Grall
Hi Fu Wei, On 06/07/16 18:58, Fu Wei wrote: On 5 July 2016 at 18:48, Julien Grall wrote: Hi Fu Wei, What is the status of this series? IIRC the comments on this version were minor. Sorry, I missed the suggestion of docs, I have rebased them to latest upstream grub and posted v5 just now

Re: [PATCH v5 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-07-12 Thread Julien Grall
module. Signed-off-by: Fu Wei Reviewed-by: Julien Grall Regards, -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v5 3/4] * util/grub.d/20_linux_xen.in: Add xen_boot command support

2016-07-12 Thread Julien Grall
mdisk isn't identifier. Should be translated. message="$(gettext_printf "Loading initial ramdisk ...")" sed "s/^/$submenu_indentation/" << EOF echo'$(echo "$message" | grub_quote)' - module --nounzip ${rel_dirname}/${in

Re: [PATCH v6 0/4] arm64, xen: add xen_boot support into grup-mkconfig

2016-09-01 Thread Julien Grall
/grub-devel/2016-07/ Fix Coding style of util/grub.d/20_linux_xen.in, use soft tab. v5: http://lists.gnu.org/archive/html/grub-devel/2016-07/msg8.html Update the introduction of xen_module commands in docs/grub.texi, according to the suggestion from Julien Grall v4: http

Re: [Xen-devel] [PATCH v6 0/4] arm64, xen: add xen_boot support into grup-mkconfig

2016-09-06 Thread Julien Grall
On 01/09/16 22:51, Daniel Kiper wrote: Hey Julien, Hi Daniel, On Thu, Sep 01, 2016 at 01:47:05PM +0100, Julien Grall wrote: We have a couple series (this series and [1]) to allow grub booting Xen on ARM that have been waiting on the GRUB ML for a while to be pushed. Those patches have

Re: [Xen-devel] GRUB ARM Xen patches

2016-11-02 Thread Julien Grall
relevant patch(es) and do not miss other required GRUB ARM Xen pieces. Cheers, -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [Xen-devel] [PATCH v7 2/3] * util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-05-05 Thread Julien Grall
nual/multiboot/multiboot.html [2] https://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v8 0/3] arm64, xen: add xen_boot support into grub-mkconfig

2017-05-15 Thread Julien Grall
/archive/html/grub-devel/2016-02/msg00205.html -- Julien Grall ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] arm64/xen: Add missing #address-cells and #size-cells properties

2017-11-29 Thread Julien Grall
they are never set by GRUB and will result to later failure when the device-tree is generated by GRUB or contain different values. To prevent this failure, create the both properties in the chosen nodes. Signed-off-by: Julien Grall --- grub-core/loader/arm64/xen_boot.c | 11 +++ 1 f

Re: [PATCH] arm64/xen: Add missing #address-cells and #size-cells properties

2017-11-30 Thread Julien Grall
Hi Daniel, On 30/11/17 13:06, Daniel Kiper wrote: On Wed, Nov 29, 2017 at 05:08:12PM +, Julien Grall wrote: The properties #address-cells and #size-cells are used to know the number of cells for ranges provided by "regs". If they don't exist, the value are resp. 2 and 1.

Re: [PATCH] arm64/xen: Add missing #address-cells and #size-cells properties

2017-12-01 Thread Julien Grall
On 30 November 2017 at 21:22, Daniel Kiper wrote: > On Thu, Nov 30, 2017 at 01:22:37PM +0000, Julien Grall wrote: >> Hi Daniel, >> >> On 30/11/17 13:06, Daniel Kiper wrote: >> >On Wed, Nov 29, 2017 at 05:08:12PM +, Julien Grall wrote: >> >>The pro