boot directory prefix in grub-install (even with --root-directory)

2009-12-22 Thread Grégoire Sutre
Hi, grub-install copies GRUB images into ${rootdir}/boot/grub (where ${rootdir} is empty by default and can be changed with --root-directory). To install GRUB files on a partition that contains a /boot file, one must specify a non-empty --root-directory, and grub files are then copied into /

Re: boot directory prefix in grub-install (even with --root-directory)

2009-12-22 Thread Grégoire Sutre
Vladimir 'φ-coder/phcoder' Serbinenko wrote: The main problem is with scripts already using --root-directory and relying on existing behaviour. Yes, you're right. I propose add a new option --grub-directory=DIR which defaults to ROOTDIR/boot/grub What do you think about this? Nice, I'm loo

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

2009-12-22 Thread Grégoire Sutre
Hi, > Unfortunately, I couldn't test this on NetBSD, where old technique was > reported failing as GCC optimizations didn't happen. Can Grégoire > Sutr or anybody else try this out on NetBSD and confirm? Thanks for looking into this. I tested the second version of the patch. Linking now works

Non-static variables and nested function pointers [bug #28392]

2009-12-23 Thread Grégoire Sutre
Hi, I am trying to add NetBSD specific code to util/hostdisk.c in order to make grub-probe work. This part is almost finished. However, I had a hard time dealing with segfaults in callbacks (hook function pointers) in a number of places of the vanilla code. Actually, I get segfaults in gru

Re: Non-static variables and nested function pointers [bug #28392]

2009-12-23 Thread Grégoire Sutre
Seth Goldberg wrote: Your problem is probably lack of executable stack support, or at least you haven't linked your application with a linker mapfile that specifies an executable stack -- the callbacks require the use of trampolines to access local variables, which require an executable stac

Re: Non-static variables and nested function pointers [bug #28392]

2009-12-23 Thread Grégoire Sutre
Seth Goldberg wrote: Exactly -- the presence of the execstack attribute in the segment is merely a request -- the kernel is free to discard it, and many OSes do, as you've found :). The problem is more complex: I tried a simple example with a pointer to a nested function, and it runs withou

Re: Non-static variables and nested function pointers [bug #28392]

2009-12-26 Thread Grégoire Sutre
Robert Millan wrote: The following snippet (kern/misc.c) comes to mind: #ifdef NEED_ENABLE_EXECUTE_STACK /* Some gcc versions generate a call to this function in trampolines for nested functions. */ void __enable_execute_stack (void *addr __attribute__ ((unused))) { } #endif I was away fr

[PATCH] grub-probe support for NetBSD

2009-12-27 Thread Grégoire Sutre
Hi, I finished adding NetBSD specific code for grub-probe. A patch and a changelog entry are attached. A few notes: - devices are required to be character (raw) devices. In NetBSD, those are of the form "/dev/r[wsc]d[0-9]+[a-z]" for hard disk drives and CD-ROM drives, as far as I know. -

Re: [PATCH] grub-probe support for NetBSD

2009-12-28 Thread Grégoire Sutre
Hi, Here is a new version of the patch (the change log remains the same as in the original email). The new version does not attempt to read from a floppy device in grub_util_biosdisk_open. Indeed, on NetBSD, reading from the floppy device (e.g. cat /dev/fd0a) takes a _long_ time to abort wh

Re: Compilation under MacOSX

2009-12-29 Thread Grégoire Sutre
Hi Yves, the main trunk (mainline) can be compile on Mac OSX (snow leopard) but i need to add a LDFLAGS="-lintl" so utils like grub-mkimage can link. I experienced a similar problem when compiling trunk on NetBSD: http://savannah.gnu.org/bugs/?28356 Adding LDFLAGS="-lintl" also solved the p

Config file generation failure on Linux

2009-12-30 Thread Grégoire Sutre
Hi, Config file generation with grub-mkconfig fails on Linux when grub is not installed in the same prefix as gettext, since the script util/grub.d/10_linux.in contains: . ${bindir}/gettext.sh A possible patch is given below, but there are surely other ways to deal with it. The patch simpl

[PATCH] Handling of TARGET_IMG_LDFLAGS_AC in configure (bug #28335)

2009-12-30 Thread Grégoire Sutre
Hi, The following patch fixes bug report #28335. http://savannah.gnu.org/bugs/?28335 The definitions and uses of TARGET_IMG_LDFLAGS_AC have been changed so that, in all cases, a number is supposed to be appended to it. In particular, in the case where a linker script if present (lines 311-3

Re: [PATCH] grub-probe support for NetBSD

2010-01-02 Thread Grégoire Sutre
Robert Millan wrote: On Tue, Dec 29, 2009 at 02:31:46AM +0100, Grégoire Sutre wrote: +#if defined(__NetBSD__) + /* Convert this block device to its character (raw) device */ + res = xmalloc (strlen (cwd) + strlen (ent->d_name) + 3); + sprintf (res, "%s/r%s&qu

Re: [PATCH] grub-probe support for NetBSD

2010-01-02 Thread Grégoire Sutre
Vladimir 'φ-coder/phcoder' Serbinenko wrote: One byte is cheap. No need for gimmicks just to save one byte. You can always allocate with +3 Ok :-) Grégoire ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-d

Disable -Werror when error attribute generates warnings

2010-01-02 Thread Grégoire Sutre
Hi, With an older version of gcc that does not understand the error attribute, gcc generates warnings when compiling files that include include/grub/list.h. Since TARGET_CFLAGS contains -Werror by default, the build of modules fails. The following patch checks whether the C compiler support

Re: Config file generation failure on Linux (gettext.sh)

2010-01-02 Thread Grégoire Sutre
Robert Millan wrote: A possible patch is given below, but there are surely other ways to deal with it. The patch simply falls back to echo instead of gettext if the gettext binary cannot be found. It'd be better if this was an autoconf check. You mean with an AC_PATH_PROG(GETTEXTBIN, get

Re: Disable -Werror when error attribute generates warnings

2010-01-02 Thread Grégoire Sutre
Colin Watson wrote: Instead of this, why not only use the attribute if it's available? I couldn't find an entry about it in GCC's human-readable change summaries, but support was committed on 2007-09-23 so I think it's available from GCC 4.3. I use this GNUC_PREREQ approach in other projects an

Check for device type (block/character) in grub-setup?

2010-01-02 Thread Grégoire Sutre
Hi, I'm wondering why there is no check for device type (block/character) in grub-setup.c whereas the function probe() in grub-probe.c exits with error if the device is not of the expected type. Shouldn't there be a similar check in grub-setup? Currently, on NetBSD (with in-progress patches)

Re: Config file generation failure on Linux (gettext.sh)

2010-01-03 Thread Grégoire Sutre
Robert Millan wrote: On Sun, Jan 03, 2010 at 05:50:08PM +0100, Robert Millan wrote: As long as the script complains appropiately and exits non-zero if gettext was installed, I would consider it robust (keep in mind grub.cfg isn't ^^^ I meant "wasn't" of course. Ok, here is the new patch.

Re: [PATCH] grub-probe support for NetBSD

2010-01-03 Thread Grégoire Sutre
Hi, This the new version of the patch adding grub-probe (and grub-setup) support for NetBSD. The main changes are: - in function grub_util_biosdisk_get_grub_dev(), merge of the new NetBSD code with the original Linux code. - re-enabled disk size detection for floppy. This is done as for t

Invalid symbol table on NetBSD boot

2010-01-06 Thread Grégoire Sutre
Hi, When booting a NetBSD 5.0 (i386 or amd64) kernel with knetbsd (as per docs/grub.cfg), the first message displayed by the NetBSD kernel is: [ Kernel symbol table invalid! ] and after boot, the device /dev/ksyms is not configured. The same problem occurs with multiboot instead of knetbsd (fo

Re: Check for device type (block/character) in grub-setup?

2010-01-07 Thread Grégoire Sutre
Robert Millan wrote: On Sun, Jan 03, 2010 at 03:54:49AM +0100, Grégoire Sutre wrote: Hi, I'm wondering why there is no check for device type (block/character) in grub-setup.c whereas the function probe() in grub-probe.c exits with error if the device is not of the expected type. Shou

Re: Invalid symbol table on NetBSD boot

2010-01-07 Thread Grégoire Sutre
Robert Millan wrote: I suggest you test if GRUB Legacy's Multiboot loader supports this properly, as the code I used derives from that. Yes, the problem disappears with GRUB Legacy's multiboot. Moreover, I noticed another issue: the command line is stripped (first word missing) with GRUB 2'

Re: Invalid symbol table on NetBSD boot

2010-01-09 Thread Grégoire Sutre
Robert Millan wrote: grub> multiboot /netbsd.generic -z root=wd0a There was an intentional backward-incompatible (but still compatible with the specification) change. The equivalent command on GRUB 2 would be: grub> multiboot /netbsd.generic /netbsd.generic -z root=wd0a Ok. First argumen

Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread Grégoire Sutre
Hi, When NLS is disabled or not supported, the macro ENABLE_NLS is not defined, and this breaks compilation of GRUB modules as they are compiled with -Werror -Wundef by default. This is with bazaar trunk. $ ./autogen.sh && ./configure && gmake [...] gcc -Ikern -I./kern -nostdinc -isystem /us

Re: Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread Grégoire Sutre
richardvo...@gmail.com wrote: This fix breaks when ENABLE_NLS is defined as 0. AFAICS, in the implementation of AM_GNU_GETTEXT, ENABLE_NLS is either not defined or set to 1. But I agree that my proposed fix is too dependent on the implementation of AM_GNU_GETTEXT, which may change. Anoth

Re: Build error: "ENABLE_NLS" is not defined

2010-01-12 Thread Grégoire Sutre
richardvo...@gmail.com wrote: Another option would be to replace #if ENABLE_NLS by #if defined(ENABLE_NLS) && ENABLE_NLS. I know the C compiler short-circuits &&, if the preprocessor does also then this looks like the best solution. If not, then nested #if. Yes the preprocessor also short-c

[multiboot] abstractmbi, modules

2010-01-14 Thread Grégoire Sutre
Hi, I made some tests with the people/phcoder/abstractmbi branch, but I'm a bit late reporting them... Better late than never I guess :-) I compiled the branch and installed GRUB from Linux on a USB stick, and then booted my NetBSD box from the stick, with multiboot. It worked like a charm

[build failure] GCC 4.1.3 support?

2012-07-27 Thread Grégoire Sutre
Hi, Configuring GRUB 2.00 on NetBSD 5.1.2 gives the following error: checking if C symbols get an underscore after compilation... configure: error: gcc failed to produce assembly code This comes from warnings -Waddress, -Wempty-body and -Woverflow that are not supported by gcc on this system,

Re: [build failure] GCC 4.1.3 support?

2012-07-27 Thread Grégoire Sutre
More data, this time on Debian GNU/Linux (squeeze) amd64. - successful build with GCC 4.4.5 - build failure with GCC 4.3.5 The failure with GCC 4.3.5 is: make[2]: Entering directory `/tmp/grub-2.00' gcc-4.3 -DHAVE_CONFIG_H -I. -Wall -W -I./include -DGRUB_UTIL=1 -DGRUB_LIBDIR=\"/usr/local/lib

[PATCH] Update manual NetBSD-wise

2012-07-29 Thread Grégoire Sutre
The attached patch updates the NetBSD-specific parts of the manual. Grégoire === modified file 'docs/grub.texi' --- docs/grub.texi 2012-06-23 08:55:14 + +++ docs/grub.texi 2012-07-29 23:01:27 + @@ -311,8 +311,10 @@ tables are also loaded. @item Support non-Multiboot kernels Support ma

Re: [PATCH] Update manual NetBSD-wise

2012-07-31 Thread Grégoire Sutre
On 07/31/2012 03:28 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.07.2012 01:06, Grégoire Sutre wrote: The attached patch updates the NetBSD-specific parts of the manual. Go ahead Done, thanks. Grégoire ___ Grub-devel mailing

[PATCH] Strengthen the test for working -nostdinc -isystem

2012-07-31 Thread Grégoire Sutre
This prevents configure from believing that -nostdinc -isystem works in some cases where it doesn't (NetBSD with non-native gcc 4.4). The patch simply adds the requirement that #include works with -nostdinc -isystem. Grégoire --- configure.ac.orig 2012-07-28 17:41:28.0 + +++ confi

[PATCH] Add gnulib's stpcpy.

2012-07-31 Thread Grégoire Sutre
The attached patch adds gnulib's stpcpy. This is required on systems lacking stpcpy, e.g., NetBSD 5.1. Note: I used gnulib's sources from 2010-09-20, since this is, afaics, the date of import of gnulib files in GRUB. Grégoire === modified file 'grub-core/gnulib/Makefile.am' --- grub-core/gnuli

Re: [PATCH] Add gnulib's stpcpy.

2012-08-05 Thread Grégoire Sutre
On 08/05/2012 12:02 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 01.08.2012 01:26, Grégoire Sutre wrote: The attached patch adds gnulib's stpcpy. This is required on systems lacking stpcpy, e.g., NetBSD 5.1. Where do we need it? It may make more sense to just use

Re: [PATCH] Strengthen the test for working -nostdinc -isystem

2012-08-05 Thread Grégoire Sutre
On 08/05/2012 12:02 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 01.08.2012 01:20, Grégoire Sutre wrote: This prevents configure from believing that -nostdinc -isystem works in some cases where it doesn't (NetBSD with non-native gcc 4.4). The patch simply adds the r

[PATCH] NetBSD boot disk info

2013-07-19 Thread Grégoire Sutre
Hi, The attached patch improves knetbsd regarding boot disk info: - the boot disk info is filled unconditionally, - toplevel BSD disk labels are not ignored anymore. This makes knetbsd's behavior closer to that of the NetBSD native boot loader with respect to boot disk info. Grégoire === modif

Build failure: GRUB_DISK_DEVICE_UBOOTDISK_ID

2013-07-21 Thread Grégoire Sutre
Latest trunk fails to build with: commands/nativedisk.c: In function 'get_uuid': commands/nativedisk.c:63:3: error: enumeration value 'GRUB_DISK_DEVICE_UBOOTDISK_ID' not handled in switch [-Werror=switch] cc1: all warnings being treated as errors This is on Debian GNU/Linux with gcc 4.7.3. Gr

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Grégoire Sutre
On 08/14/2013 03:31 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 14.08.2013 15:09, Ilya Bakulin wrote: ./lib/posix_wrap/sys/types.h:25: error: conflicting types for 'size_t' /usr/include/stddef.h:48: error: previous declaration of 'size_t' was here gmake[3]: *** [fs/squash4_module-squash4

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-15 Thread Grégoire Sutre
On 08/15/2013 05:00 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: This is not right fix. Many systems incorrectly define wchar_t as 16-bit type whil GRUB needs at least 21 as we handle all unicode characters. Please try: === modified file 'grub-core/lib/posix_wrap/wchar.h' --- grub-core/lib/p

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-16 Thread Grégoire Sutre
On 08/16/2013 04:33 PM, Ilya Bakulin wrote: So the types "double" and "float" are not recognized. Could you please help me to debug this? I get the exact same problem on NetBSD. A simple (temporary) work-around is to remove the flags: -Dfloat=__grub_poision -Ddouble=__grub_poision Those ar

[multiboot] command-line format

2010-01-14 Thread Grégoire Sutre
Hi, Vladimir just sent a patch regarding this issue, but I had this long (sorry!) email almost finished already, so here it is. And this might give more context for Vladimir's email. As mentioned in a previous thread, I had some problems getting multiboot options recognized by the NetBSD ke

Re: [multiboot] abstractmbi, modules

2010-01-14 Thread Grégoire Sutre
Vladimir 'φ-coder/phcoder' Serbinenko wrote: It's known problem: xen makes inappropriate assumptions about mbi placement I'm wondering why it works with the NetBSD boot-loader. What are these assumptions? Grégoire ___ Grub-devel mailing list G

Re: [multiboot] command-line format

2010-01-14 Thread Grégoire Sutre
Seth Goldberg wrote: Solaris uses the first argument (and it is essential to the kernel loading process actually). That's good to know, thanks. So the list of multiboot-compliant kernels that (are known to) assume a GRUB Legacy command-line format becomes: Xen, Solaris, NetBSD. Does any

Re: [multiboot] command-line format

2010-01-14 Thread Grégoire Sutre
Seth Goldberg wrote: Linux doesn't use multiboot -- it has its own convention for passing information between the boot loader and the kernel. Ok. I was refering to Robert's email mentioning wraplinux: http://lists.gnu.org/archive/html/grub-devel/2010-01/msg00046.html I glanced over the cod

Wiki page on NetBSD for GRUB developers

2010-01-16 Thread Grégoire Sutre
Hi, I added to the wiki a NetBSD page aimed at GRUB developers with: - how to download sources and cross-build a NetBSD kernel, and - the status of booting NetBSD from GRUB (this has improved a lot recently thanks to Vladimir's work). http://grub.enbug.org/NetBSD Don't hesitate to send your

Re: [multiboot] command-line format

2010-01-17 Thread Grégoire Sutre
Hi Robert, Thanks for your detailed explanation, it was really helpful to me. I understand that for compatibility with some platforms, GRUB must provide a way to specify two potentially different file parameters: (a) the GRUB path to the booted file; this path does not appear in the multibo

Re: Trouble booting from a large USB hard drive

2010-01-17 Thread Grégoire Sutre
Daniel Richard G. wrote: Knowing that Windows would only mount the first partition when the drive was plugged in Does this only apply to external hard drives? I've always put Linux as my first partition on my single hard drive without any problem (now it's with XP, but AFAIR also with 98SE

Re: [multiboot] command-line format

2010-01-20 Thread Grégoire Sutre
Hi Robert, On Sun, Jan 17, 2010 at 01:39:48PM -0600, richardvo...@gmail.com wrote: I think a bootloader with "universal" in its name should be doing everything possible to avoid this. If I want to multiboot between Linux, NetBSD, OpenSolaris, and OpenBSD, do I load my MBR with the BSD fork of

Re: Build error: "ENABLE_NLS" is not defined

2010-01-20 Thread Grégoire Sutre
Robert Millan wrote: This affects gnulib/error.c and gnulib/gettext.h which would be much better not to change, as they're being imported semi-automatically. I understand. But could this be actually a bug in gnulib? The problem only occurs when gettext is not found and when compiling with -

Re: [multiboot] abstractmbi, modules

2010-01-20 Thread Grégoire Sutre
Seth Goldberg wrote: The latest version of Solaris xVM (based on Xen 3.4) is bootable from GRUB2, so that confirms that the bug was fixed in 3.4, so please give that a try. Indeed, Xen 3.4.2 (i386) boots fine with GRUB 2. For the record, the command I used is: grub> multiboot (...)/xen.

Re: [PATCH] nested partitions

2010-01-25 Thread Grégoire Sutre
Robert Millan wrote: With this approach, the burden is no longer in GRUB. Then I don't care how weird disk layouts can become, because GRUB doesn't have to probe them. We can even support things like this if it makes users happy: (hd0,bsd2,msdos1,sun1,apple4,msdos1) I like this generic ap

[PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-01-25 Thread Grégoire Sutre
Hi, This message concerns both gnulib and grub. As discussed on irc and on the list [1], ENABLE_NLS is not used correctly, which leads to a build failure when gettext is not detected (or with configure option --disable-nls). ENABLE_NLS is defined in AM_GNU_GETTEXT and the documentation of t

Multiboot's boot_device field specification + implementation bug

2010-01-25 Thread Grégoire Sutre
Hi, I'm trying to understand the specification of the multiboot boot_device field. How should this information be interpreted by a kernel that uses a native (non-DOS) disk label? For instance, if the MBI passed to the NetBSD kernel says part1=5 and part2=part3=0xFF, does this mean: - 6th p

Re: Multiboot's boot_device field specification + implementation bug

2010-01-26 Thread Grégoire Sutre
Hi, (a) set root=(hd1,2,a) ; multiboot /mbtest ; boot --> boot_device = 0x810100ff (b) multiboot (hd1,2,a)/mbtest ; boot --> boot_device = 0x8000 Out of curiosity, I tried equivalent commands with GRUB Legacy, and I get boot_device = 0x810100ff in both cases. Best regards, Gré

Re: Is it possible to have grub2's boot.img as my MBR, but have it look in a separate partition for core.img?

2010-01-29 Thread Grégoire Sutre
Wesley Smith wrote: Thanks for your help, but no, it appears you cannot do this by simply using "grub-install /dev/sdx". I tried this, and yes, it did make the target partition bootable (it contained a Grub loader in its PBR). However, to ensure the disk MBR had also been updated and was now get

Re: [PATCH] --foo bar cmdline argument parsing support for grub-* scripts

2010-02-09 Thread Grégoire Sutre
BVK Chaitanya wrote: I assume you are talking about /usr/bin/getopt (not libc getopt). /usr/bin/getopt comes with util-linux package (in debian), and yes, I too dont think it would be available on other platforms as bash or coreutils does. You might want to use the POSIX shell built-in getopts

[PATCH] Lexer sed post-processing instead of pragmas

2010-03-16 Thread Grégoire Sutre
Hi, The lexer code in script/yylex.l uses pragmas that are not supported by gcc < 4.2. However, without these pragmas, the build fails because of warnings in the lexer code generated by flex (recall that some targets are built with -Werror by default). I've discussed this issue with sethmeister

Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-03-16 Thread Grégoire Sutre
n #if directives. In fact, any package which makes good use of Autoconf cannot support -Wundef. I don't see why. Could you please elaborate? Best regards, Grégoire Sutre [1] http://lists.gnu.org/archive/html/bug-gnulib/2010-01/msg00316.html [2] http://lists.gnu.org/archive/html/bug-gnul

Re: update-grub & Xen boot stanza generation

2010-05-21 Thread Grégoire Sutre
Bruce Edge wrote: I actually had the kernel arg=val repeated twice originally, but the xen-devel guys said to use dummy=dummy. Maybe the xen-devel guys meant the following grub command: multiboot /boot/xen.gz dummy=dummy [other options] which will pass to xen the following multiboot-protocol

Option handling in grub-mkconfig

2010-05-21 Thread Grégoire Sutre
Hi, The processing of option `-o' in grub-mkconfig only works when it is the first option. The code is: # Check the arguments. for option in "$@"; do case "$option" in [...] -o) shift grub_cfg=$1 ;; --output=*) grub_cfg=`echo "$option" | sed 's/--outp

Re: Option handling in grub-mkconfig

2010-05-21 Thread Grégoire Sutre
On 05/21/2010 12:57 PM, Colin Watson wrote: Thanks for the patch, it works fine. I'm just wondering: Is keeping `-o' worth the extra complication? Grégoire How about: === modified file 'util/grub-mkconfig.in' --- util/grub-mkconfig.in 2010-04-19 19:25:41 + +++ util/grub-mkconfig.in

Re: [Patch] [bug #26237] multiple problems with usb devices

2010-05-21 Thread Grégoire Sutre
On 05/22/2010 01:46 AM, Aleš Nesrsta wrote: I cannot get actual bzr code because of this error: $ bzr get http://bzr.savannah.gnu.org/r/grub bzr: ERROR: Not a branch: "http://bzr.savannah.gnu.org/r/grub/.bzr/branch/";. For trunk, use: bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub

[Patch] Unifont search in configure.ac

2010-05-22 Thread Grégoire Sutre
Hi, With the attached patch, unifont is searched by extension first (pcf being the preferred one), and then by directory. The first directory being searched is `.', which allows non-root users to install ascii.pf2 and unifont.pf2 by first downloading unifont in the build directory. Grégoire ===

Re: Are BSD partitions not supported?

2010-05-23 Thread Grégoire Sutre
On 05/19/2010 09:20 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: [snip] - delta = grub_partition_get_start (disk->partition); + delta = grub_le_to_cpu32 (whole_disk_be.offset); As dicsussed on irc, this makes the delta completely dependent on the c: entry of the disklabel, which could

Re: Are BSD partitions not supported?

2010-05-23 Thread Grégoire Sutre
On 05/23/2010 05:44 PM, C. P. Ghost wrote: With bsdlabel_v3.diff, and the image I've posted here, I get dropped into grub_rescue. This breaks Vladimir's second patch on FreeBSD. :-( Thanks for testing the patch. But I honestly don't understand why it does not work on your system. I could rep

Re: Option handling in grub-mkconfig

2010-05-24 Thread Grégoire Sutre
On 05/24/2010 06:42 AM, BVK Chaitanya wrote: 2010/5/21 Grégoire Sutre: The processing of option `-o' in grub-mkconfig only works when it is the first option. IMO this issue might have been fixed in experimental branch, by fix-cmdline-parsing (or similar) branch. I am on travel, so I c

[Patch] File name transformations & grub-mkconfig --root-directory

2010-05-24 Thread Grégoire Sutre
Hi, The attached patch fixes problems with file name transformations, which are partly broken in trunk. With this patch, several installations of grub can coexist with no conflict (at least they should), sharing however the same configuration directory (etc/grub.d). It also adds --root-director

grub-setup failure with (primary) BSD disklabel

2010-05-25 Thread Grégoire Sutre
Hi, When there is both a MBR partition table and a (primary) BSD disklabel, grub-setup returns an error: No DOS-style partitions found. Yet, the partition containing the GRUB images is in the MBR. But we are actually lucky, since it could be worse. Below is a detailed example on NetBSD/i386 st

[Patch] Discard incorrect nested partitions (fixes #29956)

2010-05-27 Thread Grégoire Sutre
Hi, Regarding the nested partition code, there is an implicit assumption that each partition should be contained in its parent, i.e. its sectors should also be sectors of its parent. This ``physical nesting'' is checked in grub_disk_read, but it would be better to check it before that. The att

Re: Are BSD partitions not supported?

2010-06-01 Thread Grégoire Sutre
On 05/31/2010 11:16 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Looks like we have to have different behaviour for different BSDs. Since it looks like generic code would fail for ThisBSD or ThatBSD, I propose to go by as-needed basis. So I think we should: -restrict bsdlabel to being embed

[Patch] Use absolute offset for embedding area in grub-setup (i386-pc)

2010-06-04 Thread Grégoire Sutre
Hi, The attached patch uses grub_partition_get_start (p) instead of p->start in grub-setup's iteration over partitions. While we are at it, also use grub_partition_get_len (p) instead of p->len. An alternative would be to assume that partitions are properly nested, and therefore iterate only ov

Re: Are BSD partitions not supported?

2010-06-06 Thread Grégoire Sutre
On 06/01/2010 01:21 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: For FreeBSD we have to investigate 'c' partition to determine delta. Right. In short, the normal interpretation of BSD label offsets would be the relative one (b), and we would make an exception to handle NetBSD and OpenBSD

Which partitioning schemes should be supported by GRUB?

2010-06-06 Thread Grégoire Sutre
Hi, Tests of GRUB on NetBSD (and FreeBSD) have raised several issues (most of them reported on the list) regarding partition detection. However, I have the feeling that some of these issues are not considered as real issues since the test configuration is not supported by GRUB. This surprises m

Re: [PATCH] File name transformations (split into 7 diffs)

2010-06-07 Thread Grégoire Sutre
On 06/07/2010 11:16 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Regarding file-name-transformations_1.diff: phco...@debian.bg45.phnet:~$ /usr/local/bin/grub-mkfont --help Usage: /usr/local/bin/grub-mkfont [OPTIONS] FONT_FILES So I would prefer not to use basename for uniformity. Otherwise p

Re: [PATCH] Improve man page headers

2010-06-08 Thread Grégoire Sutre
On 06/08/2010 19:46, Colin Watson wrote: In a recent message sent to the list [1], I proposed the following modification [2] to account for filename transformations in man pages: + * Makefile.in (install-local): Use installed files on help2man command + line to account for file name

Re: [PATCH] Improve man page headers

2010-06-09 Thread Grégoire Sutre
On 06/08/2010 20:26, Colin Watson wrote: Could your approach also support filename transformations? I'm not sure how that would work. I guess you'd need program_transform_name applied to the .h2m files. Do you want me to put my patch in a bzr branch so that you can experiment with that? I'm

Re: Which partitioning schemes should be supported by GRUB?

2010-06-09 Thread Grégoire Sutre
On 06/07/2010 10:46 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: There are two parts of this question: 1) Which partition schemes should GRUB be able to read modules and payloads from ? It's platform-indepedent Agreed. and 2 conditions apply: - Usage. There are OS which are able to boot

[grub-setup] New procedure to choose the embedding area

2010-06-10 Thread Grégoire Sutre
Hi, [ This is an extended summary of discussions that took place on irc. ] The current version of grub-setup requires an msdos or gpt partitioning scheme, and is not compatible with hybrid partitioning schemes (i.e. two top-level disklabels). Some disklabels have a specific partition type for b

Re: [Patch] Discard incorrect nested partitions (fixes #29956)

2010-06-12 Thread Grégoire Sutre
On 05/31/2010 08:35 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: There are few ramifications of this patch. First of all some partitions which are just barely outside of the host partition will lead to something like "partition not found" errors in grub-probe. It's not ideal, but IMHO it's

Re: Which partitioning schemes should be supported by GRUB?

2010-06-12 Thread Grégoire Sutre
On 06/07/2010 10:46 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: There are two parts of this question: 1) Which partition schemes should GRUB be able to read modules and payloads from ? It's platform-indepedent and 2 conditions apply: - Usage. There are OS which are able to boot from such OS

Re: [PATCH] Fix grub-probe partition naming on FreeBSD

2010-06-13 Thread Grégoire Sutre
Hi Colin, The following patch is aimed at fixing this Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585068 I've tested it on Debian GNU/kFreeBSD and it seems to be producing sensible output now. In another thread [1], it was observed that offsets are not absolute in FreeBSD

Re: Which partitioning schemes should be supported by GRUB?

2010-06-13 Thread Grégoire Sutre
On 06/12/2010 07:26 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Any "hybrid" cofiguration fails the criteria of non confusability. I was assuming the new partition notation. The old notation is clearly ambiguous when there are multiple partmaps, and AFAIR the new notation was introduced

Re: Which partitioning schemes should be supported by GRUB?

2010-06-14 Thread Grégoire Sutre
On 06/14/2010 18:43, Colin Watson wrote: Do you have any suggestions on how to deal with that? I'm not familiar with multiboot and need guidance. A possible solution would be to use the multiboot-command line. AFAIK, the boot_device field of the multiboot information structure is supposed to

Re: Which partitioning schemes should be supported by GRUB?

2010-06-15 Thread Grégoire Sutre
On 06/15/2010 01:21 PM, Colin Watson wrote: A possible solution would be to use the multiboot-command line. AFAIK, the boot_device field of the multiboot information structure is supposed to pass this kind of partition information, but you cannot specify the partmaps in this field, hence its in

Re: Which partitioning schemes should be supported by GRUB?

2010-06-16 Thread Grégoire Sutre
Hi, I made several tests, and the patch works fine with standard boot. When multibooting core.img, the command-line is taken into account correctly. However, if no multiboot command-line is given, the prefix is set as before (old partition naming style). This comes from the fact that the modifi

[Patch] Do not embed with multiple partmaps

2010-06-17 Thread Grégoire Sutre
Hi, As a (temporary) solution to the problem of embedding with multiple top-level partmaps, the attached patch simply disables embedding when there are multiple partmaps (i.e. apply the same behavior as when there is no partmap). This prevents grub-setup from overwriting e.g. a BSD label if it f

Re: [Patch] Do not embed with multiple partmaps

2010-07-04 Thread Grégoire Sutre
On 07/01/2010 10:52 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Go ahead. Just replace "BAD IDEA" with "not supported yet" Thanks, I replaced "BAD IDEA" with "not supported yet" and committed. Grégoire. ___ Grub-devel mailing list Grub-devel@g

Re: [Patch] Discard incorrect nested partitions (fixes #29956)

2010-07-06 Thread Grégoire Sutre
Hi, This is the reworked version of the patch. There are few ramifications of this patch. First of all some partitions which are just barely outside of the host partition will lead to something like "partition not found" errors in grub-probe. This message should be more informative (the easiest

Re: [Patch] Discard incorrect nested partitions (fixes #29956)

2010-07-09 Thread Grégoire Sutre
On 07/08/2010 02:28, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Attached is the new version of the patch. As I already told you in real dprintf isn't seen by user. One need to grub_dprintf (); #ifdef GRUB_UTIL grub_util_warn (...); #endif Ok. For partition.c, this is now done in the ch

[Patch] strip disk->name of partition suffix in grub_disk_open

2010-07-09 Thread Grégoire Sutre
Hi, When the argument passed to grub_disk_open is a string containing a partition, e.g. "hd0,msdos3,bsd7", disk->name is set to the full string instead of just the prefix up to the first ',' (here "hd0"). This leads to incorrect partition identifiers when the disk name and the partition name are

Re: [Patch] Discard incorrect nested partitions (fixes #29956)

2010-07-14 Thread Grégoire Sutre
On 07/13/2010 11:53 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: I mean that the files we need are below the limit but some parts of partition are above the limit. It will work the current boot but will break in the future. I see. Go ahead for trunk. Thanks, I committed the patch. Gr

Re: [Patch] strip disk->name of partition suffix in grub_disk_open

2010-07-20 Thread Grégoire Sutre
On 07/20/2010 03:52 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Which functions concatenate disk->name with anything else? It looks like disk->name is with partitions by design. In several places, the (full) grub partition name is obtained by concatenating disk->name with the result of gr

Re: Improperly nested partitions, help needed!

2010-09-21 Thread Grégoire Sutre
On 09/21/2010 09:31, Svante Signell wrote: When installing a new kernel or a new version of grub I get a warning that /dev/sda1 (windows rescue) and /dev/sda3 (linux root /) are improperly nested: /usr/sbin/grub-probe: warn: Discarding improperly nested partition (hd1,msdos3,msdos1). Assuming

Re: Improperly nested partitions, help needed!

2010-09-21 Thread Grégoire Sutre
On 09/21/2010 16:54, Lennart Sorensen wrote: What does improperly nested mean: overlapping, or something else? How to resolve this problem? According to fdisk the sda1 and sda3 partitions are _not_ overlapping: Additionally, does the same warning have to be repeated so many times for every ke

Re: Improperly nested partitions, help needed!

2010-09-21 Thread Grégoire Sutre
On 09/21/2010 09:42 PM, Svante Signell wrote: # file /tmp/sda3.mbr /tmp/sda3.mbr: x86 boot sector; GRand Unified Bootloader, stage1 version 0x3, 1st sector stage2 0xdd29b38; partition 1: ID=0x83, starthead 239, startsector 63, 35153937 sectors, extended partition table (last)\011, code offset 0x

Re: Improperly nested partitions, help needed!

2010-09-22 Thread Grégoire Sutre
On 09/22/2010 18:44, Lennart Sorensen wrote: After all msdos partitions tables may only exist in MBR and extended partitions According to which standard? Grégoire ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo

[PATCH] Fix getline name clash

2010-09-23 Thread Grégoire Sutre
Hi, On NetBSD 5, the latest trunk does not build: $ ./autogen.sh ; ./configure CFLAGS='-std=gnu99' ; gmake [...] gcc -DHAVE_CONFIG_H -I. -Wall -W -I./include -DGRUB_UTIL=1 -DGRUB_LIBDIR=\"/usr/local/lib/grub\" -DLOCALEDIR=\"/usr/local/share/locale\" -DGRUB_MACHINE_PCBIOS=1 -DGRUB_MACHINE=I3

Portable mktemp invocation?

2010-09-23 Thread Grégoire Sutre
Hi, We use `mktemp' or `mktemp -d' (with no argument) in the shell scripts: - grub-core/genmod.sh.in - tests/util/grub-shell.in - tests/util/grub-shell-tester.in - tests/grub_script_blockarg.in - tests/partmap_test.in - util/powerpc/ieee1275/grub-mkrescue.in But such invocations of mktemp fail

[PATCH] Uninitialized variable

2010-09-23 Thread Grégoire Sutre
Hi, This is catched (as a warning) by gcc 4.1.3 -- gcc 4.4 does not complain (maybe some command-line option is missing?). Grégoire 2010-09-23 Grégoire Sutre * grub-core/commands/acpihalt.c (get_sleep_type): Initialize prev. === modified file 'grub-core/commands/acpih

  1   2   >