Re: [PATCH v9 00/22] Automatic Disk Unlock with TPM2

2024-02-21 Thread Gary Lin via Grub-devel
On Thu, Feb 08, 2024 at 08:58:43PM +0100, Daniel Kiper wrote: > Hey, > > Adding Patrick... > > On Mon, Feb 05, 2024 at 03:39:33PM +0800, Gary Lin wrote: > > GIT repo for v9: https://github.com/lcp/grub2/tree/tpm2-unlock-v9 > > > > This patch series is based on "Automatic TPM Disk Unlock"(*1) post

Re: [PATCH v9 00/22] Automatic Disk Unlock with TPM2

2024-03-07 Thread Gary Lin via Grub-devel
On Thu, Feb 08, 2024 at 08:58:43PM +0100, Daniel Kiper wrote: > Hey, > --8<-- > > And I have attached the Coverity report. All issues reported there have > to be fixed. If you cannot fix an issue you have to explain why you > cannot do that and what is potential impact on the code stability, > se

Re: [PATCH RFC 0/2] use confidential computing provisioned secrets for disk decryption

2024-03-12 Thread Gary Lin via Grub-devel
On Tue, Mar 12, 2024 at 11:03:17AM +0800, Hyman Huang wrote: Hi Hyman, > This patchset aims to supplement James's previous work, please refer to > the following link for details: > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00257.html > > The alterations listed below were made in li

Re: [PATCH RFC 0/2] use confidential computing provisioned secrets for disk decryption

2024-03-12 Thread Gary Lin via Grub-devel
On Tue, Mar 12, 2024 at 04:00:02PM +0800, Yong Huang wrote: > On Tue, Mar 12, 2024 at 3:28 PM Gary Lin wrote: > > > On Tue, Mar 12, 2024 at 11:03:17AM +0800, Hyman Huang wrote: > > Hi Hyman, > > > > > This patchset aims to supplement James's previous work, please refer to > > > the following link

[PATCH] util/bash-completion: Fix for bash-completion 2.12

2024-03-24 Thread Gary Lin via Grub-devel
_split_longopt() was the bash-completion private API and removed since bash-completion 2.12. This commit initializes the bash-completion general variables with _init_completion() to avoid the potential 'command not found' error. Although bash-completion 2.12 introduces _comp_initialize() to deprec

Re: [PATCH v9 00/22] Automatic Disk Unlock with TPM2

2024-04-07 Thread Gary Lin via Grub-devel
On Thu, Apr 04, 2024 at 11:03:47PM +0200, Daniel Kiper wrote: > On Thu, Mar 07, 2024 at 04:59:05PM +0800, Gary Lin via Grub-devel wrote: > > On Thu, Feb 08, 2024 at 08:58:43PM +0100, Daniel Kiper wrote: > > > Hey, > > > > > --8<-- > > > > > &g

[PATCH v10 03/20] libtasn1: disable code not needed in grub

2024-04-09 Thread Gary Lin via Grub-devel
From: Daniel Axtens We don't expect to be able to write ASN.1, only read it, so we can disable some code. Do that with #if 0/#endif, rather than deletion. This means that the difference between upstream and grub is smaller, which should make updating libtasn1 easier in the future. With these ex

[PATCH v10 04/20] libtasn1: changes for grub compatibility

2024-04-09 Thread Gary Lin via Grub-devel
From: Daniel Axtens Do a few things to make libtasn1 compile as part of grub: - remove _asn1_strcat and replace strcat with the bound-checked _asn1_str_cat except the one inside _asn1_str_cat. That strcat is replaced with strcpy. - adjust header paths in libtasn1.h - adjust header pat

[PATCH v10 01/20] posix_wrap: tweaks in preparation for libtasn1

2024-04-09 Thread Gary Lin via Grub-devel
From: Daniel Axtens - Define SIZEOF_UNSIGNED_LONG_INT, it's the same as SIZEOF_UNSIGNED_LONG. - Define WORD_BIT, the size in bits of an int. This is a defined in the Single Unix Specification and in gnulib's limits.h. gnulib assumes it's 32 bits on all our platforms, including 64 bit

[PATCH v10 14/20] tpm2: Support authorized policy

2024-04-09 Thread Gary Lin via Grub-devel
This commit handles the TPM2_PolicyAuthorize command from the key file in TPM 2.0 Key File format. TPM2_PolicyAuthorize is the essential command to support authorized policy which allows the users to sign TPM policies with their own keys. Per TPM 2.0 Key File(*1), CommandPolicy for TPM2_PolicyAuth

[PATCH v10 09/20] key_protector: Add key protectors framework

2024-04-09 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma

[PATCH v10 17/20] cryptodisk: wipe out the cached keys from protectors

2024-04-09 Thread Gary Lin via Grub-devel
An attacker may insert a malicious disk with the same crypto UUID and trick grub2 to mount the fake root. Even though the key from the key protector fails to unlock the fake root, it's not wiped out cleanly so the attacker could dump the memory to retrieve the secret key. To defend such attack, wip

[PATCH v10 05/20] libtasn1: fix the potential buffer overrun

2024-04-09 Thread Gary Lin via Grub-devel
In _asn1_tag_der(), the first while loop for the long form may end up with a 'k' value with 'ASN1_MAX_TAG_SIZE' and cause the buffer overrun in the second while loop. This commit tweaks the conditional check to avoid producing a too large 'k'. This is a quick fix and may differ from the official u

[PATCH v10 18/20] diskfilter: look up cryptodisk devices first

2024-04-09 Thread Gary Lin via Grub-devel
When using disk auto-unlocking with TPM 2.0, the typical grub.cfg may look like this: tpm2_key_protector_init --tpm2key=(hd0,gpt1)/boot/grub2/sealed.tpm cryptomount -u -P tpm2 search --fs-uuid --set=root Since the disk search order is based on the order of module loading, the attacker cou

[PATCH v10 12/20] cryptodisk: Support key protectors

2024-04-09 Thread Gary Lin via Grub-devel
From: Hernan Gatta Add a new parameter to cryptomount to support the key protectors framework: -P. The parameter is used to automatically retrieve a key from specified key protectors. The parameter may be repeated to specify any number of key protectors. These are tried in order until one provide

[PATCH v10 16/20] cryptodisk: Fallback to passphrase

2024-04-09 Thread Gary Lin via Grub-devel
From: Patrick Colp If a protector is specified, but it fails to unlock the disk, fall back to asking for the passphrase. However, an error was set indicating that the protector(s) failed. Later code (e.g., LUKS code) fails as `grub_errno` is now set. Print the existing errors out first, before pr

[PATCH v10 13/20] util/grub-protect: Add new tool

2024-04-09 Thread Gary Lin via Grub-devel
From: Hernan Gatta To utilize the key protectors framework, there must be a way to protect full-disk encryption keys in the first place. The grub-protect tool includes support for the TPM2 key protector but other protectors that require setup ahead of time can be supported in the future. For the

[PATCH v10 19/20] tpm2: Enable tpm2 module for grub-emu

2024-04-09 Thread Gary Lin via Grub-devel
As a preparation to test TPM 2.0 TSS stack with grub-emu, the new option, --tpm-device, is introduced to specify the TPM device for grub-emu so that grub-emu can share the emulated TPM device with the host. Since grub-emu can directly access the device node on host, it's easy to implement the esse

[PATCH v10 06/20] libtasn1: compile into asn1 module

2024-04-09 Thread Gary Lin via Grub-devel
From: Daniel Axtens Create a wrapper file that specifies the module license. Set up the makefile so it is built. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- grub-core/Makefile.core.def| 15 +++ grub-core/lib/libtasn1_wrap/wrap

[PATCH v10 20/20] tests: Add tpm2_test

2024-04-09 Thread Gary Lin via Grub-devel
For the tpm2 module, the TCG2 command submission function is the only difference between the a QEMU instance and grub-emu. To test TPM key unsealing with a QEMU instance, it requires an extra OS image to invoke grub-protect to seal the LUKS key, rather than a simple grub-shell rescue CD image. On t

[PATCH v10 08/20] libtasn1: Add the documentation

2024-04-09 Thread Gary Lin via Grub-devel
Document libtasn1 in docs/grub-dev.texi and add the upgrade steps. Also add the patches to make libtasn1 compatible with grub code. Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- docs/grub-dev.texi| 28 ++ ...asn1-disable-code-not-needed-in-grub.patch

[PATCH v10 15/20] tpm2: Implement NV index

2024-04-09 Thread Gary Lin via Grub-devel
From: Patrick Colp Currently with the TPM2 protector, only SRK mode is supported and NV index support is just a stub. Implement the NV index option. Note: This only extends support on the unseal path. grub2_protect has not been updated. tpm2-tools can be used to insert a key into the NV index.

[PATCH v10 11/20] key_protector: Add TPM2 Key Protector

2024-04-09 Thread Gary Lin via Grub-devel
From: Hernan Gatta The TPM2 key protector is a module that enables the automatic retrieval of a fully-encrypted disk's unlocking key from a TPM 2.0. The theory of operation is such that the module accepts various arguments, most of which are optional and therefore possess reasonable defaults. On

Re: [PATCH v10 10/20] tpm2: Add TPM Software Stack (TSS)

2024-04-09 Thread Gary Lin via Grub-devel
On Tue, Apr 09, 2024 at 11:32:44AM -0400, Stefan Berger wrote: > > > On 4/9/24 04:30, Gary Lin via Grub-devel wrote: > > From: Hernan Gatta > > > > A Trusted Platform Module (TPM) Software Stack (TSS) provides logic to > > compose, submit, and parse TPM c

Re: [PATCH v10 00/20] Automatic Disk Unlock with TPM2

2024-04-11 Thread Gary Lin via Grub-devel
On Tue, Apr 09, 2024 at 04:30:32PM +0800, Gary Lin wrote: > GIT repo for v10: https://github.com/lcp/grub2/tree/tpm2-unlock-v10 > > This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by > Hernan Gatta to introduce the key protector framework and TPM2 stack > to GRUB2, and this co

[PATCH v11 01/20] posix_wrap: tweaks in preparation for libtasn1

2024-04-12 Thread Gary Lin via Grub-devel
From: Daniel Axtens - Define SIZEOF_UNSIGNED_LONG_INT, it's the same as SIZEOF_UNSIGNED_LONG. - Define WORD_BIT, the size in bits of an int. This is a defined in the Single Unix Specification and in gnulib's limits.h. gnulib assumes it's 32 bits on all our platforms, including 64 bit

[PATCH v11 04/20] libtasn1: changes for grub compatibility

2024-04-12 Thread Gary Lin via Grub-devel
From: Daniel Axtens Do a few things to make libtasn1 compile as part of grub: - remove _asn1_strcat and replace strcat with the bound-checked _asn1_str_cat except the one inside _asn1_str_cat. That strcat is replaced with strcpy. - adjust header paths in libtasn1.h - adjust header pat

[PATCH v11 05/20] libtasn1: fix the potential buffer overrun

2024-04-12 Thread Gary Lin via Grub-devel
In _asn1_tag_der(), the first while loop for the long form may end up with a 'k' value with 'ASN1_MAX_TAG_SIZE' and cause the buffer overrun in the second while loop. This commit tweaks the conditional check to avoid producing a too large 'k'. This is a quick fix and may differ from the official u

[PATCH v11 03/20] libtasn1: disable code not needed in grub

2024-04-12 Thread Gary Lin via Grub-devel
From: Daniel Axtens We don't expect to be able to write ASN.1, only read it, so we can disable some code. Do that with #if 0/#endif, rather than deletion. This means that the difference between upstream and grub is smaller, which should make updating libtasn1 easier in the future. With these ex

[PATCH v11 00/20] Automatic Disk Unlock with TPM2

2024-04-12 Thread Gary Lin via Grub-devel
GIT repo for v11: https://github.com/lcp/grub2/tree/tpm2-unlock-v11 This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by Hernan Gatta to introduce the key protector framework and TPM2 stack to GRUB2, and this could be a useful feature for the systems to implement full disk encry

[PATCH v11 08/20] libtasn1: Add the documentation

2024-04-12 Thread Gary Lin via Grub-devel
Document libtasn1 in docs/grub-dev.texi and add the upgrade steps. Also add the patches to make libtasn1 compatible with grub code. Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- docs/grub-dev.texi| 28 ++ ...asn1-disable-code-not-needed-in-grub.patch

[PATCH v11 17/20] cryptodisk: wipe out the cached keys from protectors

2024-04-12 Thread Gary Lin via Grub-devel
An attacker may insert a malicious disk with the same crypto UUID and trick grub2 to mount the fake root. Even though the key from the key protector fails to unlock the fake root, it's not wiped out cleanly so the attacker could dump the memory to retrieve the secret key. To defend such attack, wip

[PATCH v11 06/20] libtasn1: compile into asn1 module

2024-04-12 Thread Gary Lin via Grub-devel
From: Daniel Axtens Create a wrapper file that specifies the module license. Set up the makefile so it is built. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- grub-core/Makefile.core.def| 15 +++ grub-core/lib/libtasn1_wrap/wrap

[PATCH v11 16/20] cryptodisk: Fallback to passphrase

2024-04-12 Thread Gary Lin via Grub-devel
From: Patrick Colp If a protector is specified, but it fails to unlock the disk, fall back to asking for the passphrase. However, an error was set indicating that the protector(s) failed. Later code (e.g., LUKS code) fails as `grub_errno` is now set. Print the existing errors out first, before pr

[PATCH v11 09/20] key_protector: Add key protectors framework

2024-04-12 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma

[PATCH v11 14/20] tpm2: Support authorized policy

2024-04-12 Thread Gary Lin via Grub-devel
This commit handles the TPM2_PolicyAuthorize command from the key file in TPM 2.0 Key File format. TPM2_PolicyAuthorize is the essential command to support authorized policy which allows the users to sign TPM policies with their own keys. Per TPM 2.0 Key File(*1), CommandPolicy for TPM2_PolicyAuth

[PATCH v11 12/20] cryptodisk: Support key protectors

2024-04-12 Thread Gary Lin via Grub-devel
From: Hernan Gatta Add a new parameter to cryptomount to support the key protectors framework: -P. The parameter is used to automatically retrieve a key from specified key protectors. The parameter may be repeated to specify any number of key protectors. These are tried in order until one provide

[PATCH v11 15/20] tpm2: Implement NV index

2024-04-12 Thread Gary Lin via Grub-devel
From: Patrick Colp Currently with the TPM2 protector, only SRK mode is supported and NV index support is just a stub. Implement the NV index option. Note: This only extends support on the unseal path. grub2_protect has not been updated. tpm2-tools can be used to insert a key into the NV index.

[PATCH v11 19/20] tpm2: Enable tpm2 module for grub-emu

2024-04-12 Thread Gary Lin via Grub-devel
As a preparation to test TPM 2.0 TSS stack with grub-emu, the new option, --tpm-device, is introduced to specify the TPM device for grub-emu so that grub-emu can share the emulated TPM device with the host. Since grub-emu can directly access the device node on host, it's easy to implement the esse

[PATCH v11 20/20] tests: Add tpm2_test

2024-04-12 Thread Gary Lin via Grub-devel
For the tpm2 module, the TCG2 command submission function is the only difference between the a QEMU instance and grub-emu. To test TPM key unsealing with a QEMU instance, it requires an extra OS image to invoke grub-protect to seal the LUKS key, rather than a simple grub-shell rescue CD image. On t

[PATCH v11 11/20] key_protector: Add TPM2 Key Protector

2024-04-12 Thread Gary Lin via Grub-devel
From: Hernan Gatta The TPM2 key protector is a module that enables the automatic retrieval of a fully-encrypted disk's unlocking key from a TPM 2.0. The theory of operation is such that the module accepts various arguments, most of which are optional and therefore possess reasonable defaults. On

[PATCH v11 18/20] diskfilter: look up cryptodisk devices first

2024-04-12 Thread Gary Lin via Grub-devel
When using disk auto-unlocking with TPM 2.0, the typical grub.cfg may look like this: tpm2_key_protector_init --tpm2key=(hd0,gpt1)/boot/grub2/sealed.tpm cryptomount -u -P tpm2 search --fs-uuid --set=root Since the disk search order is based on the order of module loading, the attacker cou

[PATCH v11 13/20] util/grub-protect: Add new tool

2024-04-12 Thread Gary Lin via Grub-devel
From: Hernan Gatta To utilize the key protectors framework, there must be a way to protect full-disk encryption keys in the first place. The grub-protect tool includes support for the TPM2 key protector but other protectors that require setup ahead of time can be supported in the future. For the

Re: [PATCH v10 20/20] tests: Add tpm2_test

2024-04-14 Thread Gary Lin via Grub-devel
On Fri, Apr 12, 2024 at 12:09:36PM -0400, Stefan Berger wrote: > > > On 4/9/24 04:30, Gary Lin via Grub-devel wrote: > > For the tpm2 module, the TCG2 command submission function is the only > > difference between the a QEMU instance and grub-emu. To test TPM key >

Re: [PATCH v11 10/20] tpm2: Add TPM Software Stack (TSS)

2024-04-14 Thread Gary Lin via Grub-devel
On Fri, Apr 12, 2024 at 11:26:48AM -0400, Stefan Berger wrote: > > > On 4/12/24 04:39, Gary Lin wrote: > > From: Hernan Gatta > > > > A Trusted Platform Module (TPM) Software Stack (TSS) provides logic to > > compose, submit, and parse TPM commands and responses. > > compose and submit TPM com

Re: [PATCH v11 11/20] key_protector: Add TPM2 Key Protector

2024-04-15 Thread Gary Lin via Grub-devel
On Fri, Apr 12, 2024 at 02:57:42PM -0400, Stefan Berger wrote: > > > On 4/12/24 04:39, Gary Lin via Grub-devel wrote: > > From: Hernan Gatta > > > > The TPM2 key protector is a module that enables the automatic retrieval > > of a fully-encrypted disk's un

Re: [PATCH v11 13/20] util/grub-protect: Add new tool

2024-04-15 Thread Gary Lin via Grub-devel
On Fri, Apr 12, 2024 at 04:52:02PM -0400, Stefan Berger wrote: > > > On 4/12/24 04:39, Gary Lin via Grub-devel wrote: > > From: Hernan Gatta > > > > To utilize the key protectors framework, there must be a way to protect > > full-disk encryption keys in the f

Re: [PATCH v11 00/20] Automatic Disk Unlock with TPM2

2024-04-15 Thread Gary Lin via Grub-devel
On Fri, Apr 12, 2024 at 12:24:36PM -0400, Stefan Berger wrote: > > > On 4/12/24 04:39, Gary Lin via Grub-devel wrote: > > GIT repo for v11: https://github.com/lcp/grub2/tree/tpm2-unlock-v11 > > > > This patch series is based on "Automatic TPM Disk Unlock&qu

Re: [PATCH v11 13/20] util/grub-protect: Add new tool

2024-04-15 Thread Gary Lin via Grub-devel
On Mon, Apr 15, 2024 at 05:40:53PM +0800, Gary Lin wrote: > On Fri, Apr 12, 2024 at 04:52:02PM -0400, Stefan Berger wrote: > > > > > > On 4/12/24 04:39, Gary Lin via Grub-devel wrote: > > > From: Hernan Gatta > > > > > > To utilize the key prot

Re: [PATCH v11 00/20] Automatic Disk Unlock with TPM2

2024-04-15 Thread Gary Lin via Grub-devel
On Mon, Apr 15, 2024 at 10:26:32AM -0400, Stefan Berger wrote: > > > On 4/15/24 05:45, Gary Lin wrote: > > On Fri, Apr 12, 2024 at 12:24:36PM -0400, Stefan Berger wrote: > > > > > > > > > On 4/12/24 04:39, Gary Lin via Grub-devel wrote: > > &g

[PATCH v12 04/20] libtasn1: changes for grub compatibility

2024-04-19 Thread Gary Lin via Grub-devel
From: Daniel Axtens Do a few things to make libtasn1 compile as part of grub: - remove _asn1_strcat and replace strcat with the bound-checked _asn1_str_cat except the one inside _asn1_str_cat. That strcat is replaced with strcpy. - adjust header paths in libtasn1.h - adjust header pat

[PATCH v12 03/20] libtasn1: disable code not needed in grub

2024-04-19 Thread Gary Lin via Grub-devel
From: Daniel Axtens We don't expect to be able to write ASN.1, only read it, so we can disable some code. Do that with #if 0/#endif, rather than deletion. This means that the difference between upstream and grub is smaller, which should make updating libtasn1 easier in the future. With these ex

[PATCH v12 06/20] libtasn1: compile into asn1 module

2024-04-19 Thread Gary Lin via Grub-devel
From: Daniel Axtens Create a wrapper file that specifies the module license. Set up the makefile so it is built. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- grub-core/Makefile.core.def| 15 +++ grub-core/lib/libtasn1_wrap/wrap

[PATCH v12 12/20] cryptodisk: Support key protectors

2024-04-19 Thread Gary Lin via Grub-devel
From: Hernan Gatta Add a new parameter to cryptomount to support the key protectors framework: -P. The parameter is used to automatically retrieve a key from specified key protectors. The parameter may be repeated to specify any number of key protectors. These are tried in order until one provide

[PATCH v12 01/20] posix_wrap: tweaks in preparation for libtasn1

2024-04-19 Thread Gary Lin via Grub-devel
From: Daniel Axtens - Define SIZEOF_UNSIGNED_LONG_INT, it's the same as SIZEOF_UNSIGNED_LONG. - Define WORD_BIT, the size in bits of an int. This is a defined in the Single Unix Specification and in gnulib's limits.h. gnulib assumes it's 32 bits on all our platforms, including 64 bit

[PATCH v12 00/20] Automatic Disk Unlock with TPM2

2024-04-19 Thread Gary Lin via Grub-devel
GIT repo for v12: https://github.com/lcp/grub2/tree/tpm2-unlock-v12 This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by Hernan Gatta to introduce the key protector framework and TPM2 stack to GRUB2, and this could be a useful feature for the systems to implement full disk encry

[PATCH v12 11/20] key_protector: Add TPM2 Key Protector

2024-04-19 Thread Gary Lin via Grub-devel
From: Hernan Gatta The TPM2 key protector is a module that enables the automatic retrieval of a fully-encrypted disk's unlocking key from a TPM 2.0. The theory of operation is such that the module accepts various arguments, most of which are optional and therefore possess reasonable defaults. On

[PATCH v12 05/20] libtasn1: fix the potential buffer overrun

2024-04-19 Thread Gary Lin via Grub-devel
In _asn1_tag_der(), the first while loop for the long form may end up with a 'k' value with 'ASN1_MAX_TAG_SIZE' and cause the buffer overrun in the second while loop. This commit tweaks the conditional check to avoid producing a too large 'k'. This is a quick fix and may differ from the official u

[PATCH v12 13/20] util/grub-protect: Add new tool

2024-04-19 Thread Gary Lin via Grub-devel
From: Hernan Gatta To utilize the key protectors framework, there must be a way to protect full-disk encryption keys in the first place. The grub-protect tool includes support for the TPM2 key protector but other protectors that require setup ahead of time can be supported in the future. For the

[PATCH v12 18/20] diskfilter: look up cryptodisk devices first

2024-04-19 Thread Gary Lin via Grub-devel
When using disk auto-unlocking with TPM 2.0, the typical grub.cfg may look like this: tpm2_key_protector_init --tpm2key=(hd0,gpt1)/boot/grub2/sealed.tpm cryptomount -u -P tpm2 search --fs-uuid --set=root Since the disk search order is based on the order of module loading, the attacker cou

[PATCH v12 08/20] libtasn1: Add the documentation

2024-04-19 Thread Gary Lin via Grub-devel
Document libtasn1 in docs/grub-dev.texi and add the upgrade steps. Also add the patches to make libtasn1 compatible with grub code. Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- docs/grub-dev.texi| 28 ++ ...asn1-disable-code-not-needed-in-grub.patch

[PATCH v12 17/20] cryptodisk: wipe out the cached keys from protectors

2024-04-19 Thread Gary Lin via Grub-devel
An attacker may insert a malicious disk with the same crypto UUID and trick grub2 to mount the fake root. Even though the key from the key protector fails to unlock the fake root, it's not wiped out cleanly so the attacker could dump the memory to retrieve the secret key. To defend such attack, wip

[PATCH v12 14/20] tpm2: Support authorized policy

2024-04-19 Thread Gary Lin via Grub-devel
This commit handles the TPM2_PolicyAuthorize command from the key file in TPM 2.0 Key File format. TPM2_PolicyAuthorize is the essential command to support authorized policy which allows the users to sign TPM policies with their own keys. Per TPM 2.0 Key File(*1), CommandPolicy for TPM2_PolicyAuth

[PATCH v12 16/20] cryptodisk: Fallback to passphrase

2024-04-19 Thread Gary Lin via Grub-devel
From: Patrick Colp If a protector is specified, but it fails to unlock the disk, fall back to asking for the passphrase. However, an error was set indicating that the protector(s) failed. Later code (e.g., LUKS code) fails as `grub_errno` is now set. Print the existing errors out first, before pr

[PATCH v12 20/20] tests: Add tpm2_test

2024-04-19 Thread Gary Lin via Grub-devel
For the tpm2 module, the TCG2 command submission function is the only difference between the a QEMU instance and grub-emu. To test TPM key unsealing with a QEMU instance, it requires an extra OS image to invoke grub-protect to seal the LUKS key, rather than a simple grub-shell rescue CD image. On t

[PATCH v12 19/20] tpm2: Enable tpm2 module for grub-emu

2024-04-19 Thread Gary Lin via Grub-devel
As a preparation to test TPM 2.0 TSS stack with grub-emu, the new option, --tpm-device, is introduced to specify the TPM device for grub-emu so that grub-emu can share the emulated TPM device with the host. Since grub-emu can directly access the device node on host, it's easy to implement the esse

[PATCH v12 09/20] key_protector: Add key protectors framework

2024-04-19 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma

[PATCH v12 15/20] tpm2: Implement NV index

2024-04-19 Thread Gary Lin via Grub-devel
From: Patrick Colp Currently with the TPM2 protector, only SRK mode is supported and NV index support is just a stub. Implement the NV index option. Note: This only extends support on the unseal path. grub2_protect has not been updated. tpm2-tools can be used to insert a key into the NV index.

Re: [PATCH v12 11/20] key_protector: Add TPM2 Key Protector

2024-04-22 Thread Gary Lin via Grub-devel
On Fri, Apr 19, 2024 at 08:23:44AM -0400, James Bottomley wrote: > On Fri, 2024-04-19 at 16:30 +0800, Gary Lin wrote: > >    TPMKey ::= SEQUENCE { > > type    OBJECT IDENTIFIER > > emptyAuth   [0] EXPLICIT BOOLEAN OPTIONAL > > policy  [1] EXPLICIT SEQUENCE OF TPMPolicy OPTION

Re: [PATCH v12 20/20] tests: Add tpm2_test

2024-04-22 Thread Gary Lin via Grub-devel
On Fri, Apr 19, 2024 at 09:12:00AM -0400, Stefan Berger wrote: > > > On 4/19/24 04:31, Gary Lin via Grub-devel wrote: > > For the tpm2 module, the TCG2 command submission function is the only > > difference between the a QEMU instance and grub-emu. To test TPM key >

[PATCH v13 01/20] posix_wrap: tweaks in preparation for libtasn1

2024-04-25 Thread Gary Lin via Grub-devel
From: Daniel Axtens - Define SIZEOF_UNSIGNED_LONG_INT, it's the same as SIZEOF_UNSIGNED_LONG. - Define WORD_BIT, the size in bits of an int. This is a defined in the Single Unix Specification and in gnulib's limits.h. gnulib assumes it's 32 bits on all our platforms, including 64 bit

[PATCH v13 00/20] Automatic Disk Unlock with TPM2

2024-04-25 Thread Gary Lin via Grub-devel
GIT repo for v13: https://github.com/lcp/grub2/tree/tpm2-unlock-v13 This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by Hernan Gatta to introduce the key protector framework and TPM2 stack to GRUB2, and this could be a useful feature for the systems to implement full disk encry

[PATCH v13 06/20] libtasn1: compile into asn1 module

2024-04-25 Thread Gary Lin via Grub-devel
From: Daniel Axtens Create a wrapper file that specifies the module license. Set up the makefile so it is built. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- grub-core/Makefile.core.def| 15 +++ grub-core/lib/libtasn1_wrap/wrap

[PATCH v13 04/20] libtasn1: changes for grub compatibility

2024-04-25 Thread Gary Lin via Grub-devel
From: Daniel Axtens Do a few things to make libtasn1 compile as part of grub: - remove _asn1_strcat and replace strcat with the bound-checked _asn1_str_cat except the one inside _asn1_str_cat. That strcat is replaced with strcpy. - adjust header paths in libtasn1.h - adjust header pat

[PATCH v13 16/20] cryptodisk: Fallback to passphrase

2024-04-25 Thread Gary Lin via Grub-devel
From: Patrick Colp If a protector is specified, but it fails to unlock the disk, fall back to asking for the passphrase. However, an error was set indicating that the protector(s) failed. Later code (e.g., LUKS code) fails as `grub_errno` is now set. Print the existing errors out first, before pr

[PATCH v13 12/20] cryptodisk: Support key protectors

2024-04-25 Thread Gary Lin via Grub-devel
From: Hernan Gatta Add a new parameter to cryptomount to support the key protectors framework: -P. The parameter is used to automatically retrieve a key from specified key protectors. The parameter may be repeated to specify any number of key protectors. These are tried in order until one provide

[PATCH v13 08/20] libtasn1: Add the documentation

2024-04-25 Thread Gary Lin via Grub-devel
Document libtasn1 in docs/grub-dev.texi and add the upgrade steps. Also add the patches to make libtasn1 compatible with grub code. Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- docs/grub-dev.texi| 28 ++ ...asn1-disable-code-not-needed-in-grub.patch

[PATCH v13 15/20] tpm2: Implement NV index

2024-04-25 Thread Gary Lin via Grub-devel
From: Patrick Colp Currently with the TPM2 protector, only SRK mode is supported and NV index support is just a stub. Implement the NV index option. Note: This only extends support on the unseal path. grub2_protect has not been updated. tpm2-tools can be used to insert a key into the NV index.

[PATCH v13 05/20] libtasn1: fix the potential buffer overrun

2024-04-25 Thread Gary Lin via Grub-devel
In _asn1_tag_der(), the first while loop for the long form may end up with a 'k' value with 'ASN1_MAX_TAG_SIZE' and cause the buffer overrun in the second while loop. This commit tweaks the conditional check to avoid producing a too large 'k'. This is a quick fix and may differ from the official u

[PATCH v13 09/20] key_protector: Add key protectors framework

2024-04-25 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma

[PATCH v13 19/20] tpm2: Enable tpm2 module for grub-emu

2024-04-25 Thread Gary Lin via Grub-devel
As a preparation to test TPM 2.0 TSS stack with grub-emu, the new option, --tpm-device, is introduced to specify the TPM device for grub-emu so that grub-emu can share the emulated TPM device with the host. Since grub-emu can directly access the device node on host, it's easy to implement the esse

[PATCH v13 20/20] tests: Add tpm2_test

2024-04-25 Thread Gary Lin via Grub-devel
For the tpm2 module, the TCG2 command submission function is the only difference between the a QEMU instance and grub-emu. To test TPM key unsealing with a QEMU instance, it requires an extra OS image to invoke grub-protect to seal the LUKS key, rather than a simple grub-shell rescue CD image. On t

[PATCH v13 11/20] key_protector: Add TPM2 Key Protector

2024-04-25 Thread Gary Lin via Grub-devel
From: Hernan Gatta The TPM2 key protector is a module that enables the automatic retrieval of a fully-encrypted disk's unlocking key from a TPM 2.0. The theory of operation is such that the module accepts various arguments, most of which are optional and therefore possess reasonable defaults. On

[PATCH v13 18/20] diskfilter: look up cryptodisk devices first

2024-04-25 Thread Gary Lin via Grub-devel
When using disk auto-unlocking with TPM 2.0, the typical grub.cfg may look like this: tpm2_key_protector_init --tpm2key=(hd0,gpt1)/boot/grub2/sealed.tpm cryptomount -u -P tpm2 search --fs-uuid --set=root Since the disk search order is based on the order of module loading, the attacker cou

[PATCH v13 03/20] libtasn1: disable code not needed in grub

2024-04-25 Thread Gary Lin via Grub-devel
From: Daniel Axtens We don't expect to be able to write ASN.1, only read it, so we can disable some code. Do that with #if 0/#endif, rather than deletion. This means that the difference between upstream and grub is smaller, which should make updating libtasn1 easier in the future. With these ex

[PATCH v13 14/20] tpm2: Support authorized policy

2024-04-25 Thread Gary Lin via Grub-devel
This commit handles the TPM2_PolicyAuthorize command from the key file in TPM 2.0 Key File format. TPM2_PolicyAuthorize is the essential command to support authorized policy which allows the users to sign TPM policies with their own keys. Per TPM 2.0 Key File(*1), CommandPolicy for TPM2_PolicyAuth

[PATCH v13 17/20] cryptodisk: wipe out the cached keys from protectors

2024-04-25 Thread Gary Lin via Grub-devel
An attacker may insert a malicious disk with the same crypto UUID and trick grub2 to mount the fake root. Even though the key from the key protector fails to unlock the fake root, it's not wiped out cleanly so the attacker could dump the memory to retrieve the secret key. To defend such attack, wip

[PATCH v13 13/20] util/grub-protect: Add new tool

2024-04-25 Thread Gary Lin via Grub-devel
From: Hernan Gatta To utilize the key protectors framework, there must be a way to protect full-disk encryption keys in the first place. The grub-protect tool includes support for the TPM2 key protector but other protectors that require setup ahead of time can be supported in the future. For the

Re: [PATCH v13 08/20] libtasn1: Add the documentation

2024-04-28 Thread Gary Lin via Grub-devel
On Sat, Apr 27, 2024 at 03:27:57AM -0500, Glenn Washburn wrote: > On Thu, 25 Apr 2024 16:01:54 +0800 > Gary Lin wrote: > > > Document libtasn1 in docs/grub-dev.texi and add the upgrade steps. > > Also add the patches to make libtasn1 compatible with grub code. > > > > Signed-off-by: Gary Lin >

Re: [PATCH v13 20/20] tests: Add tpm2_test

2024-04-29 Thread Gary Lin via Grub-devel
On Fri, Apr 26, 2024 at 05:18:04PM -0500, Glenn Washburn wrote: > On Thu, 25 Apr 2024 16:02:06 +0800 > Gary Lin wrote: > > > For the tpm2 module, the TCG2 command submission function is the only > > difference between the a QEMU instance and grub-emu. To test TPM key > > unsealing with a QEMU ins

Re: [PATCH v13 20/20] tests: Add tpm2_test

2024-04-30 Thread Gary Lin via Grub-devel
On Mon, Apr 29, 2024 at 04:10:05PM +0800, Gary Lin wrote: > On Fri, Apr 26, 2024 at 05:18:04PM -0500, Glenn Washburn wrote: > > On Thu, 25 Apr 2024 16:02:06 +0800 > > Gary Lin wrote: > > > > > For the tpm2 module, the TCG2 command submission function is the only > > > difference between the a QEM

[PATCH v14 12/20] cryptodisk: Support key protectors

2024-05-02 Thread Gary Lin via Grub-devel
From: Hernan Gatta Add a new parameter to cryptomount to support the key protectors framework: -P. The parameter is used to automatically retrieve a key from specified key protectors. The parameter may be repeated to specify any number of key protectors. These are tried in order until one provide

[PATCH v14 03/20] libtasn1: disable code not needed in grub

2024-05-02 Thread Gary Lin via Grub-devel
From: Daniel Axtens We don't expect to be able to write ASN.1, only read it, so we can disable some code. Do that with #if 0/#endif, rather than deletion. This means that the difference between upstream and grub is smaller, which should make updating libtasn1 easier in the future. With these ex

[PATCH v14 20/20] tests: Add tpm2_test

2024-05-02 Thread Gary Lin via Grub-devel
For the tpm2 module, the TCG2 command submission function is the only difference between the a QEMU instance and grub-emu. To test TPM key unsealing with a QEMU instance, it requires an extra OS image to invoke grub-protect to seal the LUKS key, rather than a simple grub-shell rescue CD image. On t

[PATCH v14 18/20] diskfilter: look up cryptodisk devices first

2024-05-02 Thread Gary Lin via Grub-devel
When using disk auto-unlocking with TPM 2.0, the typical grub.cfg may look like this: tpm2_key_protector_init --tpm2key=(hd0,gpt1)/boot/grub2/sealed.tpm cryptomount -u -P tpm2 search --fs-uuid --set=root Since the disk search order is based on the order of module loading, the attacker cou

[PATCH v14 00/20] Automatic Disk Unlock with TPM2

2024-05-02 Thread Gary Lin via Grub-devel
GIT repo for v14: https://github.com/lcp/grub2/tree/tpm2-unlock-v14 This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by Hernan Gatta to introduce the key protector framework and TPM2 stack to GRUB2, and this could be a useful feature for the systems to implement full disk encry

[PATCH v14 09/20] key_protector: Add key protectors framework

2024-05-02 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma

[PATCH v14 06/20] libtasn1: compile into asn1 module

2024-05-02 Thread Gary Lin via Grub-devel
From: Daniel Axtens Create a wrapper file that specifies the module license. Set up the makefile so it is built. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin Reviewed-by: Vladimir Serbinenko --- grub-core/Makefile.core.def| 15 +++ grub-core/lib/libtasn1_wrap/wrap

[PATCH v14 15/20] tpm2: Implement NV index

2024-05-02 Thread Gary Lin via Grub-devel
From: Patrick Colp Currently with the TPM2 protector, only SRK mode is supported and NV index support is just a stub. Implement the NV index option. Note: This only extends support on the unseal path. grub2_protect has not been updated. tpm2-tools can be used to insert a key into the NV index.

[PATCH v14 13/20] util/grub-protect: Add new tool

2024-05-02 Thread Gary Lin via Grub-devel
From: Hernan Gatta To utilize the key protectors framework, there must be a way to protect full-disk encryption keys in the first place. The grub-protect tool includes support for the TPM2 key protector but other protectors that require setup ahead of time can be supported in the future. For the

  1   2   3   4   5   6   7   >