[PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-25 Thread Erwan Velu
8 efi/ fs/xfs.c:515: Reading inode (3145856) - 1464904, 0 grub2/ fs/xfs.c:515: Reading inode (132) - 64, 1024 grub/ fs/xfs.c:515: Reading inode (139) - 64, 2816 grub> Signed-off-by: Erwan Velu --- grub-core/fs/xfs.c | 10 ++ 1 file changed, 6 insertions(

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-26 Thread Erwan Velu
I should have cc Carlos Maiolino who authored this patch. This is now done. Le mer. 25 août 2021 à 15:32, Erwan Velu a écrit : > Commit 8b1e5d1936fffc490510e85c95f93248453586c1 introduced the support > of bigtime by adding the some features in inodes V3. > > This change extended gr

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-26 Thread Erwan Velu
> > [...] > Thanks for spotting this! > We got hit in production with it, that's why we investigate this issue. It's deployed on our infra & works fine on the affected servers but works fine too on the servers running V5 fs. I don't know what is the policy of this project, but a point release wou

Resurrecting the UEFI Watchdog

2021-08-27 Thread Erwan Velu
Hey list, I'd like to share again a patch that got posted a long while ago here and never seen to get attention on it: https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html I found this patch useful as it allows my servers to reboot automatically if grub is unable to boots within a

Re: Resurrecting the UEFI Watchdog

2021-08-30 Thread Erwan Velu
As per Paul Menzel email, I'm adding the 4 maintainers in CC of this original email. I can offer to refresh & resent this patch to the mailing list if this helps its adoption. Erwan, Le ven. 27 août 2021 à 17:23, Erwan Velu a écrit : > Hey list, > > I'd like to share

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-30 Thread Erwan Velu
Good day list, Le jeu. 26 août 2021 à 15:26, Carlos Maiolino a écrit : > [..] > > Thanks for spotting this! > > I'm adding the maintainers in CC. Carlos who commit the patch I'm fixing, agreed on the content. This patch is important as it prevents the 2.06 version to turn XFS v4 system into an u

Re: Resurrecting the UEFI Watchdog

2021-08-30 Thread Erwan Velu
I'll do it, thx ! Le lun. 30 août 2021 à 12:02, Paul Menzel a écrit : > Dear Erwan, > > > Am 30.08.21 um 11:14 schrieb Erwan Velu: > > As per Paul Menzel email, I'm adding the 4 maintainers in CC of this > > original email. > > I am sorry for the misu

[PATCH] kern/efi: Adding efi-watchdog command

2021-08-30 Thread Erwan Velu
h success. Signed-off-by: Erwan Velu --- docs/grub.texi| 15 ++ grub-core/kern/efi/init.c | 63 ++- include/grub/efi/efi.h| 2 ++ 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/docs/grub.texi b/docs/grub.texi index f8

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Erwan Velu
> > Cool! Thanks a lot! > > I have a question about this. Considering the impact of this issue, does this trigger a point-release of GRUB ? ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
[...] The ext_cmd change is cool except the linker isn't happy as it cannot find the associated symbols. I asked a question on the IRC channel on this point. I'm not familiar with the dependencies definition in this project, where should I work to get ext_cmd being linked with kern/efi ? I tried in

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Erwan Velu
[...] > Nope... > > I'm pretty new at contributing to see project but I really wonder what's the rational being this. I mean, 2.06 is very recent, debuting its life cycle and its now known as totally broken on XFS V4 and we have here a very simple patch. How can we prevent users from installing th

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le 01/09/2021 à 18:24, Daniel Kiper a écrit : First of all, thanks for your extensive review, I'll fix all this in a V2. [...] Here you should add Signed-off-by of original author. Yeah, I was wondering that but the only email I have was from his previous company. I have no idea what email

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Erwan Velu
Le 02/09/2021 à 15:31, Daniel Kiper a écrit : Making a release is a big hassle for the project right now. I hope it will change in the future but it is what it is. I think distros will take this patch immediately. If that helps I can announce here in separate thread when patch lands in the git r

[PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
ave no impact on the default GRUB's behavior. This patch is used in production for month on a 50K server platform with success. Signed-off-by: Erwan Velu Signed-off-by: Arthur Mesh --- docs/grub.texi | 13 ++ grub-core/kern/efi/init.c | 85 ++

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le jeu. 2 sept. 2021 à 11:08, Erwan Velu a écrit : > Le 01/09/2021 à 18:24, Daniel Kiper a écrit : > > First of all, thanks for your extensive review, I'll fix all this in a V2. > > [...] Just sent the V2, hope you'll enjoy this version of the patch. I learned many thin

Re: [PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le 03/09/2021 à 04:09, Michael Chang a écrit : [...] I'd suggest to move this efi-watchdog command registration to grub_register_core_commands() in grub-core/kern/corecmd.c as that helps us tracing or knowing available commands in grub's rescue mode. Also it would be great to see the explainatio

Re: [PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-07 Thread Erwan Velu
Daniel, anything more about this V2 before I prepare the V3 ? Le ven. 3 sept. 2021 à 08:34, Erwan Velu a écrit : > Le 03/09/2021 à 04:09, Michael Chang a écrit : > [...] > > I'd suggest to move this efi-watchdog command registration to > > grub_register_core_comma

Re: [PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-07 Thread Erwan Velu
Thanks ! Le mar. 7 sept. 2021 à 20:01, Daniel Kiper a écrit : > On Tue, Sep 07, 2021 at 01:20:05PM +0200, Erwan Velu wrote: > > Daniel, anything more about this V2 before I prepare the V3 ? > > I will be looking at it this week. > > Daniel >

Re: Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock)

2021-09-08 Thread Erwan Velu
M +0200, Carlos Maiolino wrote: > > > > Hi. > > > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > > > >Good day list, > > > > >Le jeu. 26 août 2021 à 15:26, Carlos Maiolino > > > > > <[1]cmaiol...@redha

Re: Where is the testing? (was: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock)

2021-09-08 Thread Erwan Velu
When this topic will be out, I'd would be glad to help. Cheers, Erwan, Le mer. 8 sept. 2021 à 18:19, Daniel Kiper a écrit : > On Wed, Sep 08, 2021 at 11:20:08AM +0200, Erwan Velu wrote: > > Le mer. 8 sept. 2021 à 03:24, Glenn Washburn < > developm...@efficientek.com> >

Re: [PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-10 Thread Erwan Velu
Thanks for your review, I'll rework my patch according to your comments. I just kept the open points in this thread. Le 09/09/2021 à 17:46, Daniel Kiper a écrit : +static grub_err_t grub_efi_set_watchdog_timer(unsigned long timeout) Please use grub_efi_uintn_t instead of unsigned long. However,

Re: GRUB 2.12 release, etc.

2022-06-15 Thread Erwan Velu
Le ven. 10 juin 2022 à 19:21, Daniel Kiper a écrit : > Hi, > > {...} > I am not going to release any of earlier released versions with recent > security fixes on top of them. Though if somebody wants to step up and > prepare them I am happy to create relevant branch in the GRUB git > repository.