Hi, yesterday I submitted a bug report about wrong backspace key
behavior in superuser login prompt and I finally found it. So I attach
patch with my fix so it can be merged into upstream.
>From a227f1a2c54aa420e016ffb5ca1c41fe93a2bd68 Mon Sep 17 00:00:00 2001
From: Egor Ignatov
Date: Fri,
From: Egor Ignatov
Make backspace work in superuser login prompt.
The problem was that bidi logical to visual ignored BN type,
so you couldn't print control characters.
Use grub_printf() 3 times, because a line wrap will cause
the cursor to get stuck at the end of the terminal line.
Res
From: Egor Ignatov
Make backspace work in superuser login prompt.
The problem was that bidi logical to visual ignored BN type,
so you couldn't print control characters.
Use grub_printf() 3 times, because a line wrap will cause
the cursor to get stuck at the end of the terminal line.
Res
ff-by: Egor Ignatov
---
grub-core/normal/auth.c| 4 +++-
grub-core/normal/charset.c | 1 +
grub-core/term/gfxterm.c | 9 -
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/grub-core/normal/auth.c b/grub-core/normal/auth.c
index 6be678c0d..ffbf6d890 100644
--- a/grub
can
still type more.
This may be irrelevant because I doubt anyone is using a username longer
than one line, but it solves the problem.
On 3/1/21 8:26 PM, Lennart Sorensen wrote:
On Mon, Mar 01, 2021 at 10:58:40AM +0300, Egor Ignatov wrote:
From: Egor Ignatov
Make backspace work in superuse
From: Egor Ignatov
Make backspace work in superuser login prompt.
The problem was that bidi logical to visual ignored BN type,
so you couldn't print control characters.
Use grub_printf() 3 times, because if you print "\b \b" at
once the cursor will get stuck on the second
This patch fixes an old bug when backspace key does not work in the
username login prompt. It allows BIDI type BN characters (control
chars like '\b') in the visual line. And when grub_gfxterm_putchar
recieves this line it successfully processes backspace.
Signed-off-by: Egor Ignatov
-
This patch fixes a bug when backspace key does not work in the
username login prompt. It allows backspace characters in the BIDI
visual line. Thus grub_gfxterm_putchar receives '\b' chars that
were previously ignored.
Signed-off-by: Egor Ignatov
---
> Did you test this patch with ot
On 5/17/21 7:34 PM, Daniel Kiper wrote:
Did you test your patch outside of username login prompt, e.g. CLI or
menu entry editing? I am afraid your patch breaks at least these cases.
Daniel
Indeed I tested it with both CLI and menu entry editing and it works fine.
Thank you for taking the time
while fuzzing the XFS filesystem)
Signed-off-by: Egor Ignatov
---
grub-core/fs/xfs.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c
index 7c903f01a3..ba31559c5c 100644
--- a/grub-core/fs/xfs.c
+++ b/grub-core/fs/xfs.c
@@ -
The incorrect inode error from grub_xfs_read_inode did not propagate because
grub_print_error() resetted grub_errno, and grub_xfs_iterate_dir() did not
handle it at all.
Signed-off-by: Egor Ignatov
---
grub-core/fs/xfs.c | 14 --
1 file changed, 12 insertions(+), 2 deletions
Signed-off-by: Egor Ignatov
---
grub-core/fs/xfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c
index 8e02ab4a30..7c903f01a3 100644
--- a/grub-core/fs/xfs.c
+++ b/grub-core/fs/xfs.c
@@ -1053,6 +1053,8 @@ grub_xfs_mount (grub_disk_t disk
This patchset fixes several issues with error handling in xfs module.
Egor Ignatov (3):
fs/xfs: Handle root inode read failure in grub_xfs_mount
fs/xfs: Fix grub_xfs_iterate_dir return value in case of failure
fs/xfs: Propagate incorrect inode error from grub_xfs_read_inode
grub-core/fs
RAID 4 requires the same recovery module as RAID 5. Extend the condition to
cover both RAID levels.
Signed-off-by: Egor Ignatov
---
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index 7dc5657bb..060246589 100644
14 matches
Mail list logo
