On Mon, May 27, 2019 at 10:07:15AM +0200, Michael Grzeschik wrote:
> With this feature it is now possible to set the root
> device in userspace preperation like grub-mkimage.
Why this patch is needed? I would like to see an explanation here.
> Signed-off-by: Michael Grzeschik
> ---
> include/gr
CC-ing Vladimir.
On Mon, May 27, 2019 at 10:07:27AM +0200, Michael Grzeschik wrote:
> This is needed to make grubenv be stored in
> raw disk images. We now can run
>
> save_env -f (ata0)1024+2 VARIABLE
Why do we need/want this patch? What is the usage case for it?
Could you explain why you have t
CC-ing Vladimir.
On Mon, May 27, 2019 at 10:07:39AM +0200, Michael Grzeschik wrote:
> With this feature the grub-shell is able to search for partuuid strings.
> This reduces the complexity to find the correct boot partition on
> systems with unspecified device connectivity.
What is an usage case
Neil, could you test this patch?
On Wed, May 29, 2019 at 08:34:55AM +0200, John Paul Adrian Glaubitz wrote:
> Disable the -Wadress-of-packaed-member diagnostic for the grub_f2fs_label
> function since the result is found to be false postive.
>
> A pointer to the 'volume_name' member of 'struct gru
On Wed, May 29, 2019 at 03:16:02PM +0100, Neil MacLeod wrote:
> Hi Daniel
>
> I can confirm that grub (based on
> 53e70d30cf0d18e6c28bab0ab8d223a90d3e1b46) is building with gcc-9.1 and
> this new patch.
>
> I'm not in a position to run-time test the resulting grub binary, but
> it does at least now
On Tue, Jun 04, 2019 at 01:47:52PM +0200, Alexander Graf wrote:
>
> On 04.06.19 13:36, John Paul Adrian Glaubitz wrote:
> > On 6/4/19 12:27 PM, Alexander Graf wrote:
> >> The MIPS target currently does not compile due to the following error
> >> message:
> >>
> >> configure: error: could not forc
On Wed, Jun 05, 2019 at 12:26:23PM +0200, John Paul Adrian Glaubitz wrote:
> Hi!
>
> On 6/5/19 12:33 AM, Leif Lindholm wrote:
> > On Wed, Jun 05, 2019 at 12:11:00AM +0200, John Paul Adrian Glaubitz wrote:
> >> On 6/4/19 8:51 PM, Leif Lindholm wrote:
> >>> #ifndef GRUB_MACHINE_EMU
> >>> -#if define
On Thu, Jun 06, 2019 at 08:01:20AM +0200, John Paul Adrian Glaubitz wrote:
> Hi!
>
> On 6/5/19 7:30 PM, Eric Snowberg wrote:
> >> This is an Fujitsu M10-4 machine.
> >
> > It could be we are not enumerating the disk correctly. What kind of HBA is
> > in this system?
>
> FWIW, we don't have all of
On Tue, Mar 26, 2019 at 12:25:25PM +0100, Daniel Kiper wrote:
> On Mon, Mar 25, 2019 at 04:24:50PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> > >From 0cfd6226d200cce722e99230f5564e1bd9e45eff Mon Sep 17 00:00:00 2001
> > From: Vladimir Serbinenko
> > Dat
Folks,
I have pushed fixes for last known issues a few minutes ago. So, please
test the GRUB from latest git master branch. If nothing blows up then
I will release GRUB in a week or so.
In the meantime have a nice weekend!
Daniel
___
Grub-devel mailin
On Tue, Jun 11, 2019 at 11:18:15AM +0200, John Paul Adrian Glaubitz wrote:
> Hi!
>
> On 6/7/19 4:42 PM, Daniel Kiper wrote:
> > I have pushed fixes for last known issues a few minutes ago. So, please
> > test the GRUB from latest git master branch. If nothing blows up then
&g
On Mon, Jun 10, 2019 at 12:12:41PM +0200, Steffen Sobiech wrote:
> is there anything planned to add support for Apple's APFS file system to
> grub2?
I have not heard about any such plans. However, if somebody sends patches
then I will be happy to review them.
Daniel
On Fri, Jun 14, 2019 at 11:10:48AM +0200, Daniel Kiper wrote:
> On Tue, Jun 11, 2019 at 11:18:15AM +0200, John Paul Adrian Glaubitz wrote:
> > Hi!
> >
> > On 6/7/19 4:42 PM, Daniel Kiper wrote:
> > > I have pushed fixes for last known issues a few minutes ago. So, p
Hi all,
GRUB maintainers are proud to announce GRUB 2.04 that has been just released.
You can find list of new features and major fixes since release 2.02 in the
NEWS file.
We would like to thank all the people who have contributed to the project.
The tarball is available at https://ftp.gnu.org/
On Fri, Jul 05, 2019 at 12:12:40PM +0200, Daniel Kiper wrote:
> Hi all,
>
> GRUB maintainers are proud to announce GRUB 2.04 that has been just released.
> You can find list of new features and major fixes since release 2.02 in the
> NEWS file.
>
> We would like to thank al
On Fri, Jul 05, 2019 at 07:45:59AM -0400, David Michael wrote:
> Signed-off-by: David Michael
> ---
>
> Hi,
>
> I tried to test the new release and hit this build failure:
>
> In file included from ../grub-core/osdep/blocklist.c:6:0:
> ../grub-core/osdep/generic/blocklist.c: In function
> ‘grub_i
On Fri, Jul 05, 2019 at 12:12:40PM +0200, Daniel Kiper wrote:
> Hi all,
>
> GRUB maintainers are proud to announce GRUB 2.04 that has been just released.
> You can find list of new features and major fixes since release 2.02 in the
> NEWS file.
>
> We would like to thank al
On Tue, Jul 09, 2019 at 05:52:58PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On mingw i386-pc without this option mingw generates a
> rdata$zzz symbol that is page-aligned and hence lzma_decompress no
> longer fits in its allocated space.
Out of curiosity, why is the size of lzma_decompress li
olchains (like the one used in the
> > travis ci scripts), we end up with these relocations again. So add an
> > additional test for the '-mword-relocations' flag used by GCC.
> >
> > Reported-by: Alexander Graf
> > Signed-off-by: Leif Lindholm
&
-
> > image_target->vaddr_offset;
> >
> > switch (ELF_R_TYPE (info))
> > {
>
> This patch can fix a grub abort issue which randomly shows 'unaligned pointer'
> warnings on console. I tried this patch on QEMU v4.0.50 + grub-2.0.4-rc1.
>
> Tested-by: Chester Lin
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
Sorry for late reply but I was busy with release and other stuff.
On Sat, Jun 29, 2019 at 09:44:51PM -0400, Jason Kushmaul wrote:
> Add a configurable option for luks key recovery. Existing
> users will continue to have the default of 1 attempt.
>
> Cryptodisk is not accessible to motor impaired
he DMI.
>
> Signed-off-by: David Michael
Reviewed-by: Daniel Kiper
There are some nitpicks but I fix them before committing.
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
SMBIOS 3.0 entry, splendid.
> Reviewed-by: Leif Lindholm
Reviewed-by: Daniel Kiper
> Daniel: please consider merging this one independently on 2/2, if that
> isn't going in straightaway.
I will take both. 2/2 is in quite good shape.
Daniel
_
000 eb9d2d31-2d88-11d3-9a160090273fc14d SMBIOS
> > 0x87f0 b1b621d5-f19c-41a5-830bd9152c69aae0 DEVICE TREE
> >
> > Signed-off-by: Heinrich Schuchardt
>
> Good idea!
> Reviewed-by: Leif Lindholm
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
vant sections,
> so no effect
>
> Signed-off-by: Vladimir Serbinenko
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Mon, May 20, 2019 at 02:11:00PM +0200, Daniel Kiper wrote:
> On Mon, May 20, 2019 at 01:45:59PM +0200, Paul Menzel wrote:
> > Dear Daniel,
> >
> > On 20.05.19 13:39, Daniel Kiper wrote:
> > > CC-ing Paul.
> > >
> > > On Wed, May 15, 2019 at 09
of supported DHCP options.
>
> Signed-off-by: Andre Przywara
> Reported-by: Heinrich Schuchardt
Reviewed-by: Daniel Kiper
Daniel
PS Sorry for late reply but I was on vacation and later traveling.
Now I am back and will be clearing my grub-devel backlog.
___
la.redhat.com/show_bug.cgi?id=860834
>
> Signed-off-by: Gustavo Luiz Duarte
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
If there are no objections I will push that patch, together with the
patches reviewed this week and earlier, on the beginning of next week.
Wel
a
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Tue, Sep 17, 2019 at 05:50:58PM +0200, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> Signed-off-by: Peter Jones
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-d
Adding Nicholas...
On Tue, Sep 17, 2019 at 05:48:45PM +0200, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> This will cause "search --fs-uuid --set=root ..." not to be generated by
> grub2-mkconfig, and instead simply attempt to use the grub device name
> as it understands it.
>
> Signed
On Tue, Sep 17, 2019 at 05:52:10PM +0200, Javier Martinez Canillas wrote:
> From: Prarit Bhargava
>
> The file /etc/grub.d/10_linux does
>
> if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE_SUBMENU}" != xy ]; then
>
> when it should do
>
> if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE
"Reviewed-by: Daniel Kiper
".
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
Adding Alex and Eric...
On Mon, Sep 09, 2019 at 02:34:25PM +0200, Andreas Schwab wrote:
> This is needed for the zstd module.
>
> Signed-off-by: Andreas Schwab
> ---
> configure.ac | 2 +-
> include/grub/compiler-rt-emu.h | 5 +
> 2 files changed, 6 insertions(+), 1 deletio
On Thu, Sep 19, 2019 at 09:39:04AM +0200, Andreas Schwab wrote:
> This is needed for the zstd module.
>
> Signed-off-by: Andreas Schwab
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.or
On Fri, Aug 23, 2019 at 12:00:30PM +0100, Colin Watson wrote:
> The short form of "--version" that grub-mkconfig accepts is "-V", not
> "-v".
>
> Fixes Debian bug #935504.
>
> Signed-off-by: Colin Watson
Reviewed-by: Daniel Kiper
Daniel
Adding Alex...
In general "Reviewed-by: Daniel Kiper "
but I would to hear Alex's opinion here too...
Daniel
On Thu, Aug 15, 2019 at 04:55:13PM +0200, Andreas Schwab wrote:
> Signed-off-by: Andreas Schwab
> ---
> util/grub-install.c | 8
> 1 file change
On Thu, Sep 19, 2019 at 02:20:06PM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
>
> On 9/18/19 2:39 PM, Daniel Kiper wrote:
> > Adding Nicholas...
> >
> > On Tue, Sep 17, 2019 at 05:48:45PM +0200, Javier Martinez Canillas wrote:
> >> From: Peter Jone
On Thu, Sep 19, 2019 at 02:42:05PM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
>
> On 9/18/19 2:53 PM, Daniel Kiper wrote:
> > On Tue, Sep 17, 2019 at 05:52:10PM +0200, Javier Martinez Canillas wrote:
> >> From: Prarit Bhargava
> >>
> >> The f
On Thu, Sep 19, 2019 at 02:00:31PM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
>
> Thanks for the quick feedback.
>
> On 9/18/19 3:00 PM, Daniel Kiper wrote:
> > On Tue, Sep 17, 2019 at 05:54:44PM +0200, Javier Martinez Canillas wrote:
> >> From: Paulo Flab
On Mon, Sep 02, 2019 at 10:53:34AM +0100, Andre Przywara wrote:
> On Fri, 30 Aug 2019 15:20:19 +0200 Daniel Kiper wrote:
> > On Wed, Aug 21, 2019 at 04:58:34PM +0100, Andre Przywara wrote:
> > > Commit 5bc41db756c5 ("net/dhcp: Add explicit net_dhcp command")
>
On Sun, Sep 15, 2019 at 05:14:02PM +0200, Sam van Kampen via Grub-devel wrote:
> Hey all,
>
> To solve a problem I faced on my own system I've been working on a
> patch that adds support for viewing and editing EFI Boot* variables
> (BootOrder, BootNext, Boot) from GRUB, and was wondering if th
On Thu, Aug 29, 2019 at 01:37:14PM -0700, BJ Black wrote:
> Hi all!
>
> I recently experienced a problem on a fleet of CentOS 6 boxes with GRUB
> 0.97 that had a dodgy CMOS battery and the RTC was broken. In this
> circumstance, the timeout on the GRUB menu never moved because GRUB
> didn't think
to "true" unless
> these have been explicitly set to "false".
>
> That way, the GRUB_DISABLE_UUID variable can be used to force using the
> device names for both GRUB and Linux.
>
> Signed-off-by: Peter Jones
> Signed-off-by: Javier Martinez Canillas
In gener
ub file, keep testing for this value. And also do it for
> "yes", since it is a common mistake made by users caused by this option
> being inconsistent with the others.
>
> Signed-off-by: Prarit Bhargava
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Ki
On Mon, Sep 30, 2019 at 08:27:59AM -0400, Nicholas Vinson wrote:
> Extend partition UUID probing support in GRUB core to display pseudo partition
> UUIDs for MBR (MSDOS) partitions.
>
> Signed-off-by: Nicholas Vinson
In general "Reviewed-by: Daniel Kiper " but one nit
b
On Mon, Sep 30, 2019 at 02:16:20AM +, ERIC MARCEAU wrote:
> Hello, I was wondering if someone could incorporate the logic to
> extract the hostname on each bootable partition and report those in
> the appropriate menu options presented by grub. I have hard coded
> this with simple shell logic
Folks,
I am happy to take this patch but I need it in proper form. Michael,
"git format-patch" and "git send-email" are your friends.
Daniel
On Wed, Sep 11, 2019 at 12:29:42AM +0200, Michael Bideau wrote:
> Hi Paul and everyone,
>
> My turn to be sorry for the late reply.
> I was on my first sai
On Wed, Aug 07, 2019 at 10:18:52AM +0800, Zhang wrote:
> Hi All,
> I want to study the function malloc_in_range of the grub2.02.
> So I set the followings in the grub.cfg.
>
> serial --unit=0 --speed=115200 --word=8 --parity=no --stop=1
>
> terminal_input serial console
>
> terminal_output serial
just an incomplete cut-paste, missing a small manual
> correction.
> Better fix it.
Missing SOB. I can add it in behalf of you if it is not a problem
for you. And I will tweak a commit message a bit before committing.
Otherwise Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
f attempts
> via the "-t" option.
>
> Existing users will observe the original behavior
> with a default of 1 attempt.
>
> Reported-by: Jason J. Kushmaul
> Signed-off-by: Daniel Kiper
Both lines should be replaced with
Signed-off-by: Jason J. Kushmaul
> ---
>
than net__ variables are set for other
> options such domain name, boot file, next server, etc.
>
> Signed-off-by: Paulo Flabiano Smorigo
> Signed-off-by: Javier Martinez Canillas
In general "Reviewed-by: Daniel Kiper "
but a few nit picks belo
On Sat, Oct 05, 2019 at 12:44:24AM +0200, Javier Martinez Canillas wrote:
> Hello,
>
> This series contains some patches that have been carried in Fedora (and
> other distros) for a long time. It allows to fetch GRUB configurations
> that are customized for each machine by using the client UUID, MA
ormat specifier in grub_printf()
> and calling grub_toupper(), but it is more convenient if there is support
> for %X in grub_printf().
>
> Signed-off-by: Paulo Flabiano Smorigo
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
But I would like to see
On Sat, Oct 05, 2019 at 02:47:23AM +0100, Steve McIntyre wrote:
> On Sat, Oct 05, 2019 at 12:44:26AM +0200, Javier Martinez Canillas wrote:
> >From: Paulo Flabiano Smorigo
> >
> >The printf(3) function has support for the %X format specifier, to output
> >an unsigned hexadecimal integer in upperca
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=873406
>
> Signed-off-by: Paulo Flabiano Smorigo
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
However, one nitpick below...
> ---
>
> grub-core/net/net.c | 117 ++
On Fri, Oct 04, 2019 at 12:57:44PM +0200, Javier Martinez Canillas wrote:
> Hello Nicolas,
>
> Thanks a lot for the feedback.
>
> On 10/3/19 4:29 AM, Nicholas Vinson wrote:
>
> [snip]
>
> >>>
> >>> +if [ "x${GRUB_DISABLE_UUID}" = "xtrue" ]; then
> >>> + if [ "x${GRUB_DISABLE_LINUX_UUID}" != "xfals
than net__ variables are set for other
> options such domain name, boot file, next server, etc.
>
> Signed-off-by: Paulo Flabiano Smorigo
> Signed-off-by: Javier Martinez Canillas
> Reviewed-by: Daniel Kiper
It seems to me that this RB should land in patch #3. Does not i
On Fri, Oct 18, 2019 at 02:45:13PM +0200, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> This fixes CVE-2014-4607 - lzo: lzo1x_decompress_safe() integer overflow
>
> Resolves: http://savannah.gnu.org/bugs/?42635
OK but I would like to know how did you come up with that patch.
Please desc
On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> When user enters into the GRUB shell and tries to use help command, lot of
> information is scrolled out of screen and the user doesn't have chance to
> read it. Also, there isn't any information abou
option is that it requires
> neither an external disk executable, nor (because unlike 'which', the
> exit code is reliable) a subshell fork. This therefore represents a mild
> speedup.
Missing SOB. I can add it in your behalf if this not a problem for you.
Otherwise Reviewed-by: Dan
On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
>
> On 10/21/19 4:56 PM, Daniel Kiper wrote:
> > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote:
> >> From: Peter Jones
> >>
> >> When us
On Tue, Oct 22, 2019 at 10:48:14AM +0200, Javier Martinez Canillas wrote:
> From: Robert Marshall
>
> Add documentation to the grub info page that specifies the order
> netboot clients use to select a grub configuration file.
>
> Signed-off-by: Robert Marshall
> Signed-off-by: Javier Martinez Can
On Tue, Oct 22, 2019 at 10:48:11AM +0200, Javier Martinez Canillas wrote:
> The bootp/dhcp options enum values are a mixture of hexadecimal and decimal
> numbers. Change this to consistently use hexadecimal numbers for all values.
>
> Suggested-by: Daniel Kiper
> Signed-off-by:
On Mon, Oct 21, 2019 at 04:30:21PM +0200, Miguel Arruga Vivas wrote:
> Hi, everybody!
>
> After taking a deeper look into our (guix's) grub installation
> procedure, I have the thought that it could be a neat idea to make the
> boot directory an actual derivation instead something of the global
> s
to "true" unless
> these have been explicitly set to "false".
>
> That way, the GRUB_DISABLE_UUID variable can be used to force using the
> device names for both GRUB and Linux.
>
> Signed-off-by: Peter Jones
> Signed-off-by: Javier Martinez Canillas
>
On Fri, Oct 18, 2019 at 02:42:20PM +0200, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> Add a grub_util_readlink() helper function.
OK but for patches like that one I will be always asking for an explannation
in the commit message why we need this functionality/function(s). So, please
a
On Fri, Oct 18, 2019 at 02:42:21PM +0200, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> This lets us make /boot/grub2/grubenv a symlink to
Who or what creates that link?
> /boot/efi/EFI/fedora/grubenv even though they're different mount points,
> which allows /usr/bin/grub2-editenv to
On Fri, Oct 18, 2019 at 02:39:01PM +0200, Javier Martinez Canillas wrote:
> From: Hector Marco-Gisbert
>
> This patch fixes two integer underflows at:
> * grub-core/lib/crypto.c
> * grub-core/normal/auth.c
>
> Resolves: CVE-2015-8370
>
> Signed-off-by: Hector Marco-Gisbert
> Signed-off-
Hi Eric,
On Sat, Oct 12, 2019 at 09:41:50AM -0400, Eric McCorkle wrote:
> Hi all,
>
> I finally got a chance to resume work on FreeBSD support recently.
> Here's where things are:
>
> * I can boot on an EFI platform, however, the efifb driver never turns
> the screen on, so the screen is blank unt
On Wed, Oct 16, 2019 at 06:15:30AM +, Michael Chang wrote:
> The lvm cache logical volume is the logical volume consisting of the
> original and the cache pool logical volume. The original is usually on a
> larger and slower storage device while the cache pool is on a smaller
> and faster one.
ed by RFC 2132.
>
> Suggested-by: Daniel Kiper
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Thu, Oct 24, 2019 at 04:43:58AM +, Michael Chang wrote:
> On Wed, Oct 23, 2019 at 12:48:23PM +0200, Daniel Kiper wrote:
> > On Wed, Oct 16, 2019 at 06:15:30AM +, Michael Chang wrote:
> > > The lvm cache logical volume is the logical volume consisting of the
> >
f-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrote:
> On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote:
> > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote:
> > > Hello Daniel,
> > >
> > > On 10/21/19 4:56 PM, Dan
On Wed, Oct 23, 2019 at 01:26:54PM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
>
> On 10/22/19 4:04 PM, Daniel Kiper wrote:
> > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote:
> >> Hello Daniel,
> >>
> >> On 10/21/19
> On 24/10/2019 15:13, Hector Marco wrote:
> > Hello Daniel,
> >
> > The patch prevents that "cur_len" underflows. No negative values for
> > "cur_len" so way to underflow the "cur_len" variable and therefore
> >
> > I hope this help
than net__ variables are set for other
> options such domain name, boot file, next server, etc.
>
> Signed-off-by: Paulo Flabiano Smorigo
> Signed-off-by: Javier Martinez Canillas
> Reviewed-by: Daniel Kiper
I was going to push this today but I have found a few issues with
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=873406
>
> Signed-off-by: Paulo Flabiano Smorigo
> Signed-off-by: Javier Martinez Canillas
> Reviewed-by: Daniel Kiper
Did you at least build test whole patchset? I do not think so.
Please do that before posting any patch on g
same copy of grub-set-default will
> work on both kinds of systems.
>
> Signed-off-by: Peter Jones
> Signed-off-by: Jonathan Lebon
> Reviewed-by: Adam Jackson
> Signed-off-by: Javier Martinez Canillas
>
> ---
>
> Changes in v2:
> - Address issues pointed out by Da
Hi Max,
On Mon, Oct 28, 2019 at 10:58:21AM +, Max Tottenham via Grub-devel wrote:
> Hi Folks
>
> I've often found myself in a position where I've needed to perform some
> debugging of remote hardware that does not have a network accessible KVM
> attached. To that end, being able to remotely lo
Adding Matthew...
Matthew, whole thread is at [1].
Daniel
[1] https://lists.gnu.org/archive/html/grub-devel/2019-10/msg00103.html
On Fri, Oct 25, 2019 at 10:48:43AM -0400, Mathieu Trudel-Lapierre wrote:
> On Fri, Oct 25, 2019 at 10:28 AM Mathieu Trudel-Lapierre
> wrote:
> >
> > Signed-off-by:
same copy of grub-set-default will
> work on both kinds of systems.
>
> Signed-off-by: Peter Jones
> Signed-off-by: Jonathan Lebon
> Reviewed-by: Adam Jackson
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
> ---
> Daniel,
>
> I didn't add a che
On Fri, Oct 25, 2019 at 11:02:04AM +0200, Javier Martinez Canillas wrote:
> Hello Daniel,
>
> On 10/24/19 4:50 PM, Daniel Kiper wrote:
>
> [snip]
>
> >>
> >> From 7c4da6295ebd3a034d1f7e32099eab33efa465d4 Mon Sep 17 00:00:00 2001
> >> From: Javier Mart
On Mon, Nov 04, 2019 at 12:00:53PM +0100, Patrick Steinhardt wrote:
> On Mon, Nov 04, 2019 at 10:26:21AM +, Max Tottenham wrote:
> > On 11/02, Patrick Steinhardt wrote:
> > > The newly added jsmn library is a really bare-bones library that
> > > focusses on simplicity. Because of that, it is la
ned-off-by: Javier Martinez Canillas
> Reviewed-by: Daniel Kiper
>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Add a better commit message explaining why the change is needed.
> - Add Reviewed-by tag from Daniel Kiper.
>
> grub-core/osdep/windows/hostdisk.c| 6
t. Besides the editor
> may inadvertantly change size allocation that could have it sparse the
> filesystem which could lead to unexpected outcome.
>
> This patch adds message in grubenv file to warn the user from editing it by
> tools other than grub-editenv.
>
> Signed-off-by:
e close-on-exec flag (O_CLOEXEC)
> for new file descriptor returned by the open() system call, making it closed
> thus not inherited by the child process forked and executed by the exec()
> family of functions.
>
> Signed-off-by: Michael Chang
Reviewed-by: Daniel Kiper
Daniel
__
s
> to be adjusted, the rest is done by the existing code.
>
> Signed-off-by: David Sterba
Reviewed-by: Daniel Kiper but I will apply it
if patches are in Linux kernel 5.5 (or later). So, please drop me a line
when it happens.
Daniel
> ---
> grub-core/fs/btrfs.c | 12 ++
Adding Leif and Alex...
On Thu, Oct 31, 2019 at 01:24:01PM -0400, Mark Salter wrote:
> On Thu, 2019-10-31 at 16:59 +0100, Javier Martinez Canillas wrote:
> > On 10/31/19 12:56 PM, Vladimir 'phcoder' Serbinenko wrote:
> > > This patch looks incomplete. What if "chosen" is there but does not
> > >
;
> > - grub_strcpy (rrq, filename);
> > - rrqlen += grub_strlen (filename) + 1;
> > - rrq += grub_strlen (filename) + 1;
> > +
> > + /* Copy and normalize the filename to work-around issues on some tftp
> > + servers when file names are being matched for re
CC-ing Matthew...
On Tue, Oct 29, 2019 at 01:12:34PM +0100, Javier Martinez Canillas wrote:
> Hello Max,
>
> On 10/29/19 11:49 AM, Max Tottenham via Grub-devel wrote:
> > On 10/25, Javier Martinez Canillas wrote:
>
> [snip]
>
> >>>
> >>
> >> I think that we should go even further and make all the
On Mon, Nov 04, 2019 at 07:56:48PM +0100, Patrick Steinhardt wrote:
> On Mon, Nov 04, 2019 at 06:42:51PM +0100, Daniel Kiper wrote:
> > On Mon, Nov 04, 2019 at 12:00:53PM +0100, Patrick Steinhardt wrote:
> > > On Mon, Nov 04, 2019 at 10:26:21AM +, Max Tottenham wrote:
> &g
On Tue, Nov 05, 2019 at 02:12:13PM +0100, Patrick Steinhardt wrote:
> On Tue, Nov 05, 2019 at 12:54:38PM +, Max Tottenham via Grub-devel wrote:
> > On 11/05, Patrick Steinhardt wrote:
> > > +grub_err_t
> > > +grub_json_parse (grub_json_t **out, const char *string, grub_size_t
> > > string_len)
>
> A second fix is required to make available `_GL_ATTRIBUTE_CONST`, which
> is provided by the configure script. As "base64.h" does not include
> , it is thus not available and results in a compile error.
> This is fixed by adding an include of .
&g
ause
> of duplicated symbols, this commit moves it into its own standalone
> module "afsplitter" as a preparatory step.
>
> Signed-off-by: Patrick Steinhardt
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.or
On Tue, Nov 05, 2019 at 07:58:39AM +0100, Patrick Steinhardt wrote:
> The luks module contains quite a lot of logic to parse cipher and
> cipher-mode strings like "aes-xts-plain64" into constants to apply them
> to the `grub_cryptodisk_t` structure. This code will be required by the
> upcoming luks
On Wed, Nov 06, 2019 at 11:15:04AM -0800, Vladimir 'phcoder' Serbinenko wrote:
> Please don't do it this way. The right solution is to move it to separate
> module and include zstd module when needed. Not everybody uses btrfs
> embedded area. I recommend not to use it. Using mbr gap or BBP is the
>
On Thu, Nov 07, 2019 at 12:52:35PM +0100, Daniel Kiper wrote:
> On Wed, Nov 06, 2019 at 11:15:04AM -0800, Vladimir 'phcoder' Serbinenko wrote:
> > Please don't do it this way. The right solution is to move it to separate
> > module and include zstd module when ne
On Wed, Nov 06, 2019 at 02:08:48PM +0100, Patrick Steinhardt wrote:
> On Wed, Nov 06, 2019 at 12:44:58PM +0100, Daniel Kiper wrote:
> > On Mon, Nov 04, 2019 at 07:56:48PM +0100, Patrick Steinhardt wrote:
> > > On Mon, Nov 04, 2019 at 06:42:51PM +0100, Daniel Kiper wrote:
>
601 - 700 of 3709 matches
Mail list logo
