Re: [PATCH 0/2] Implement a grub loader for RISC-V LINUX

2020-01-16 Thread Atish Patra
Sent from my iPhone > On Jan 16, 2020, at 10:06 PM, Alexander Graf wrote: > > Hi Chester, > >> On 16.01.20 11:21, Chester Lin wrote: >> Implement an initial version of riscv loader and related commands to load >> and run linux kernel and initrd on RISC-V. I tested this series based on >> the

Re: [PATCH 0/2] Implement a grub loader for RISC-V LINUX

2020-01-17 Thread Atish Patra
On Fri, 2020-01-17 at 03:20 +, Chester Lin wrote: > Hi Alex, Atish and Anup, > > On Thu, Jan 16, 2020 at 02:27:55PM +0100, Alexander Graf wrote: > > On 16.01.20 14:14, Atish Patra wrote: > > > Sent from my iPhone > > > > > > > On Jan 16, 202

[PATCH RFC/RFT 0/3] Add grub loader support for RISC-V Linux

2020-04-26 Thread Atish Patra
here as well. https://github.com/atishp04/linux/pull/new/uefi_riscv_pr Atish Patra (3): loader: Move arm64 linux loader to common code RISC-V: Update image header RISC-V: Use common linux loader grub-core/Makefile.core.def | 8 ++-- grub-core/loader/{arm64 => efi}/linux.c | 2

[PATCH RFC/RFT 3/3] RISC-V: Use common linux loader

2020-04-26 Thread Atish Patra
RISC-V doesn't have to do anything very different from other architectures to loader EFI stub linux kernel. As a result, just use the common linux loader instead of defining a RISC-V specific linux loader. Signed-off-by: Atish Patra --- grub-core/Makefile.core.def| 4 +-- grub-core/l

[PATCH RFC/RFT 2/3] RISC-V: Update image header

2020-04-26 Thread Atish Patra
Update the RISC-V Linux kernel image headers as per the current header. Reference: /Documentation/riscv/boot-image-header.rst Signed-off-by: Atish Patra --- include/grub/riscv32/linux.h | 15 --- include/grub/riscv64/linux.h | 15 --- 2 files changed, 16 insertions

[PATCH RFC/RFT 1/3] loader: Move arm64 linux loader to common code

2020-04-26 Thread Atish Patra
ARM64 linux loader code is written in such a way that it can be reused across different architectures without much change. Move it to common code so that RISC-V doesn't have to define a separate loader. Signed-off-by: Atish Patra --- grub-core/Makefile.core.def | 4 ++-- grub

Re: [PATCH RFC/RFT 0/3] Add grub loader support for RISC-V Linux

2020-04-28 Thread Atish Patra
iesheuvel > > >>: > > >>> > >On Mon, 27 Apr 2020 at 21:36, Heinrich Schuchardt > > >> > > >>> > >wrote: > > >>> > >> > > >>> > >> On 4/27/20 1:01 PM, Daniel Kiper wrote: > >

Re: [PATCH RFC/RFT 0/3] Add grub loader support for RISC-V Linux

2020-04-29 Thread Atish Patra
On Wed, Apr 29, 2020 at 4:22 AM Leif Lindholm wrote: > > Hi Atish, > > On Tue, Apr 28, 2020 at 11:21:05 -0700, Atish Patra wrote: > > > > Hello Ard, > > > > > > > > Did I misunderstand you and you want to provide a LOAD_FILE2 > > > >

[PATCH] RISC-V: Update linux image header

2020-04-29 Thread Atish Patra
Update the RISC-V Linux kernel image headers as per the current header defined in Linux kernel. Reference: /Documentation/riscv/boot-image-header.rst Signed-off-by: Atish Patra --- include/grub/riscv32/linux.h | 15 --- include/grub/riscv64/linux.h | 15 --- 2 files

Re: efi_loader/RISC-V: misaligned load when running grubriscv64.efi

2020-07-30 Thread Atish Patra
On Thu, Jul 30, 2020 at 4:04 AM Heinrich Schuchardt wrote: > > On 30.07.20 12:16, Sean Anderson wrote: > > On 7/30/20 6:03 AM, Heinrich Schuchardt wrote: > >> Dear Sean, > >> > >> when trying to run grubriscv64.efi from the > >> trini/u-boot-gitlab-ci-runner:bionic-20200526-18Jun2020 Docker image

Re: efi_loader/RISC-V: misaligned load when running grubriscv64.efi

2020-07-30 Thread Atish Patra
On Thu, Jul 30, 2020 at 1:19 PM Heinrich Schuchardt wrote: > > Am 30. Juli 2020 22:11:39 MESZ schrieb Heinrich Schuchardt > : > >Am 30. Juli 2020 20:31:47 MESZ schrieb Atish Patra > >: > >>On Thu, Jul 30, 2020 at 4:04 AM Heinrich Schuchardt > >> wro

Re: [PATCH v2 7/8] efi: implement LoadFile2 initrd loading protocol for Linux

2020-10-26 Thread Atish Patra
On Sun, Oct 25, 2020 at 6:50 AM Ard Biesheuvel wrote: > > Recent Linux kernels will invoke the LoadFile2 protocol installed on a > well-known vendor media devicepath to load the initrd if it is exposed > by the firmware. Using this method is preferred for two reasons: > - the Linux kernel is in ch

Re: GRUB loader support for RISC-V Linux

2021-04-04 Thread Atish Patra
Hi Nikita, Yes. It was discussed earlier that we should consolidate riscv & ARM64 implementation as the ARM64 has a very generic implementation. RISC-V should also use LOAD_FILE2 always. However, I couldn’t get time to revise the patches. I am on leave until May. Is it possible to revise your p

Re: [PATCH v2 0/7] Add LoadFile2 and riscv Linux loader

2021-06-29 Thread Atish Patra
On Mon, Jun 28, 2021 at 2:24 PM Heinrich Schuchardt wrote: > > > +cc Ard Biesheuvel > > Ard, please see question for you below. > > On 6/27/21 11:01 PM, Heinrich Schuchardt wrote: > > On 6/26/21 8:07 PM, Andreas Schwab wrote: > >> On Jun 03 2021, Nikita Ermakov wrote: > >> > >>> This series conta

Re: [PATCH v2 0/7] Add LoadFile2 and riscv Linux loader

2021-07-02 Thread Atish Patra
On Wed, Jun 30, 2021 at 12:26 AM Ard Biesheuvel wrote: > > On Tue, 29 Jun 2021 at 21:13, Atish Patra wrote: > > > > On Mon, Jun 28, 2021 at 2:24 PM Heinrich Schuchardt > > wrote: > > > > > > > > > +cc Ard Biesheuvel > > > > > &

Re: [PATCH v2 0/7] Add LoadFile2 and riscv Linux loader

2021-08-27 Thread Atish Patra
l > efi: implemented LoadFile2 initrd loading protocol for Linux > linux: ignore FDT unless we need to modify it > > Atish Patra (3): > loader: Move arm64 linux loader to common code > RISC-V: Update image header > RISC-V: Use common linux loader > > Nikita Ermakov

[v5 PATCH 0/3] Unify ARM64 & RISC-V Linux Loader

2022-10-07 Thread Atish Patra
from v4->v5: 1. Removed redundant macros from header file and updated the rv32 kernel header structure. Changes from v3->V4: 1. Added all the comments on v3. 2. Dropped LoadFile2 patches as Ard's series[1] updated those patches [1] https://lists.gnu.org/archive/html/grub-devel/2022-09/msg0

[v5 PATCH 1/3] loader: Move arm64 linux loader to common code

2022-10-07 Thread Atish Patra
ARM64 linux loader code is written in such a way that it can be reused across different architectures without much change. Move it to common code so that RISC-V doesn't have to define a separate loader. Reviewed-by: Daniel Kiper Signed-off-by: Atish Patra --- grub-core/Makefile.cor

[v5 PATCH 3/3] RISC-V: Use common linux loader

2022-10-07 Thread Atish Patra
RISC-V doesn't have to do anything very different from other architectures to loader EFI stub linux kernel. As a result, just use the common linux loader instead of defining a RISC-V specific linux loader. Signed-off-by: Atish Patra --- grub-core/Makefile.core.def| 4 +-- grub-core/l

[v5 PATCH 2/3] RISC-V: Update image header

2022-10-07 Thread Atish Patra
Update the RISC-V Linux kernel image headers as per the current header. Reference: /Documentation/riscv/boot-image-header.rst 474efecb65dc: ("riscv: modify the Image header to improve compatibility with the ARM64 header") Acked-by: Heinrich Schuchardt Signed-off-by: Atish Patra --

[v6 PATCH 2/3] RISC-V: Update image header

2022-11-04 Thread Atish Patra
Update the RISC-V Linux kernel image headers as per the current header. Reference: /Documentation/riscv/boot-image-header.rst 474efecb65dc: ("riscv: modify the Image header to improve compatibility with the ARM64 header") Acked-by: Heinrich Schuchardt Signed-off-by: Atish Patra --

[v6 PATCH 3/3] RISC-V: Use common linux loader

2022-11-04 Thread Atish Patra
RISC-V doesn't have to do anything very different from other architectures to loader EFI stub linux kernel. As a result, just use the common linux loader instead of defining a RISC-V specific linux loader. Signed-off-by: Atish Patra --- grub-core/Makefile.core.def| 4 +-- grub-core/l

[v6 PATCH 1/3] loader: Move arm64 linux loader to common code

2022-11-04 Thread Atish Patra
ARM64 linux loader code is written in such a way that it can be reused across different architectures without much change. Move it to common code so that RISC-V doesn't have to define a separate loader. Reviewed-by: Daniel Kiper Signed-off-by: Atish Patra --- grub-core/Makefile.cor

[v6 PATCH 0/3] Unify ARM64 & RISC-V Linux Loader

2022-11-04 Thread Atish Patra
updated those patches [1] https://lists.gnu.org/archive/html/grub-devel/2022-10/msg00093.html Atish Patra (3): loader: Move arm64 linux loader to common code RISC-V: Update image header RISC-V: Use common linux loader grub-core/Makefile.core.def | 8 ++-- grub-core/loader/{arm64 =>

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-12-06 Thread Atish Patra
在 2022-11-08星期二的 23:59 -0800,Atish Kumar Patra写道: > > > > > > On Tue, Nov 8, 2022 at 7:56 AM Daniel Kiper > > wrote: > > > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > > > > Update the RISC-V Linux kernel image headers as per the curren

Re: [PATCH v2 2/2] efi: Put Linux specific magic number in the DOS header

2022-12-06 Thread Atish Patra
wn methods to identify x86 Linux images > > that can be booted in a non-EFI manner, and having the magic number in > > place there will ease any future transitions in loader implementations > > to merge the x86 and non-x86 EFI boot paths. > > > > Note that 32-bit ARM alread

[v7 PATCH 0/3] Unify ARM64 & RISC-V Linux Loader

2023-01-20 Thread Atish Patra
rv32 kernel header structure. Changes from v3->V4: 1. Added all the comments on v3. 2. Dropped LoadFile2 patches as Ard's series[1] updated those patches Atish Patra (3): loader: Move arm64 linux loader to common code efi: Remove arch specific image headers for RISC-V & ARM64

[v7 PATCH 1/3] loader: Move arm64 linux loader to common code

2023-01-20 Thread Atish Patra
ARM64 linux loader code is written in such a way that it can be reused across different architectures without much change. Move it to common code so that RISC-V doesn't have to define a separate loader. Signed-off-by: Atish Patra Reviewed-by: Daniel Kiper --- grub-core/Makefile.cor

[v7 PATCH 3/3] RISC-V: Use common linux loader

2023-01-20 Thread Atish Patra
RISC-V doesn't have to do anything very different from other architectures to loader EFI stub linux kernel. As a result, just use the common linux loader instead of defining a RISC-V specific linux loader. Signed-off-by: Atish Patra Reviewed-by: Daniel Kiper --- grub-core/Makefile.cor

[v7 PATCH 2/3] efi: Remove arch specific image headers for RISC-V & ARM64

2023-01-20 Thread Atish Patra
correctly. Signed-off-by: Atish Patra --- grub-core/commands/file.c | 8 +++--- grub-core/loader/arm64/xen_boot.c | 3 +- grub-core/loader/efi/linux.c | 1 - include/grub/arm64/linux.h| 48 --- include/grub/efi/efi.h| 11

Re: [v7 PATCH 2/3] efi: Remove arch specific image headers for RISC-V & ARM64

2023-02-09 Thread Atish Patra
On Thu, Feb 2, 2023 at 12:12 PM Daniel Kiper wrote: > > On Fri, Jan 20, 2023 at 05:17:13PM -0800, Atish Patra wrote: > > The arch specific image header details are not very useful as > > most of the grub just looks at the PE/COFF spec parameters (PE32 magic > > and header

Re: [v7 PATCH 2/3] efi: Remove arch specific image headers for RISC-V & ARM64

2023-02-21 Thread Atish Patra
On Tue, Feb 14, 2023 at 4:41 AM Daniel Kiper wrote: > > On Thu, Feb 09, 2023 at 04:27:11PM -0800, Atish Patra wrote: > > On Thu, Feb 2, 2023 at 12:12 PM Daniel Kiper > > wrote: > > > > > > On Fri, Jan 20, 2023 at 05:17:13PM -0800, Atish Patra wrote: &g

strange grub error on ARM64

2023-03-06 Thread Atish Patra
Hi, I am working on a cross-architecture cleanup series that removes the arch specific headers from RISC-V, ARM, ARM64 and unifies the linux loader on ARM64 & Linux. The v7 version can be found here. https://lists.gnu.org/archive/html/grub-devel/2023-02/msg00046.html It had a few bugs which are f

Re: strange grub error on ARM64

2023-03-06 Thread Atish Patra
. > > > > Daniel > > > > On Mon, Mar 06, 2023 at 10:56:52AM -0800, Atish Patra wrote: > > > Hi, > > > I am working on a cross-architecture cleanup series that removes the > > > arch specific headers from RISC-V, ARM, ARM64 and unifies the linux &

Re: strange grub error on ARM64

2023-03-09 Thread Atish Patra
On Mon, Mar 6, 2023 at 7:21 PM Michael Chang wrote: > > On Mon, Mar 06, 2023 at 04:22:53PM -0800, Atish Patra wrote: > > On Mon, Mar 6, 2023 at 1:25 PM Fabian Vogt wrote: > > > > > > Hi, > > > > > > Am Montag, 6. März 2023, 21:59:23 CET schri

[v8 PATCH 0/3] Unify ARM64 & RISC-V Linux Loader

2023-03-09 Thread Atish Patra
Added all the comments on v3. 2. Dropped LoadFile2 patches as Ard's series[1] updated those patches Atish Patra (3): loader: Move arm64 linux loader to common code efi: Remove arch specific image headers for RISC-V, ARM64, ARM RISC-V: Use common linux loader grub-core/Makefile.core.de

[v8 PATCH 2/3] efi: Remove arch specific image headers for RISC-V, ARM64, ARM

2023-03-09 Thread Atish Patra
correctly. Signed-off-by: Atish Patra --- grub-core/commands/file.c | 23 +++ grub-core/loader/arm/linux.c | 3 +- grub-core/loader/arm64/xen_boot.c | 3 +- grub-core/loader/efi/linux.c | 1 - include/grub/arm/linux.h | 20 - include/grub/arm64

[v8 PATCH 1/3] loader: Move arm64 linux loader to common code

2023-03-09 Thread Atish Patra
ARM64 linux loader code is written in such a way that it can be reused across different architectures without much change. Move it to common code so that RISC-V doesn't have to define a separate loader. Signed-off-by: Atish Patra Reviewed-by: Daniel Kiper --- grub-core/Makefile.cor

[v8 PATCH 3/3] RISC-V: Use common linux loader

2023-03-09 Thread Atish Patra
RISC-V doesn't have to do anything very different from other architectures to loader EFI stub linux kernel. As a result, just use the common linux loader instead of defining a RISC-V specific linux loader. Signed-off-by: Atish Patra Reviewed-by: Daniel Kiper --- grub-core/Makefile.cor