Re: [PATCH] include/grub/i386/linux: Update linux_kernel_params to match upstream

2025-04-03 Thread Daniel Kiper
On Thu, Mar 20, 2025 at 04:06:31PM -0700, Patrick Colp via Grub-devel wrote: > Update linux_kernel_params to match the latest upstream (v6.13.7) > version of boot_params. Refactor most things out into structs, as the > Linux kernel does. > > `edid_info` should be a struct with `unsigned char dummy[

Re: [PATCH 0/5] Fix memory leaks

2025-04-03 Thread Daniel Kiper via Grub-devel
On Thu, Mar 27, 2025 at 05:56:30PM +, Lidong Chen wrote: > These patches address memory leaks identified by Coverity. > > Lidong Chen (5): > disk/ldm: Fix memory leaks > lib/reloacator: Fix memory leaks > loader/i386/linux: Fix resource leak > fs/btrfs: Fix memory leaks > loader/xnu:

[RESEND PATCH 1/1] loader/efi/chainloader: Enhance error messages in chainloader command

2025-04-03 Thread khaliid caliy
Well i apologies the error message were somehow bad on my previous patch, and needed some improvement. diff --git a/grub-core/loader/efi/chainloader.c b/grub-core/loader/efi/chainloader.c index 869307bf3..4fd46dfda 100644 --- a/grub-core/loader/efi/chainloader.c +++ b/grub-core/loader/efi/chainloa

Re: [PATCH 4/7] Add DSA and RSA SEXP tests

2025-04-03 Thread Vladimir 'phcoder' Serbinenko
Le jeu. 3 avr. 2025, 17:59, Daniel Kiper a écrit : > On Tue, Apr 01, 2025 at 03:58:55PM +0300, Vladimir Serbinenko wrote: > > This allows us to test purely the integration of the implementation > > of DSA and RSA from libgcrypt without concerning with additional > > code. > > > > Signed-off-by: V

Re: [PATCH 6/7] libgcrypt: Fix coverity warnings

2025-04-03 Thread Vladimir 'phcoder' Serbinenko
Le jeu. 3 avr. 2025, 18:19, Daniel Kiper a écrit : > On Tue, Apr 01, 2025 at 03:58:57PM +0300, Vladimir Serbinenko wrote: > > Please split this patch into (probably) three and add CID to each one. > Good example is in commit 4dc616657 (loader/i386/bsd: Use safe math to > avoid underflow). Of cour

[PATCH v8 0/9] Update libgcrypt to 1.11

2025-04-03 Thread Vladimir Serbinenko
Update libgcrypt to 1.11 and related changes ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v8 3/9] b64dec: Adjust for compilation in GRUB environment

2025-04-03 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- grub-core/lib/b64dec.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/grub-core/lib/b64dec.c b/grub-core/lib/b64dec.c index 868d98568..8aafa9700 100644 --- a/grub-core/lib/b64dec.c +++ b/grub-core/l

[PATCH v8 2/9] Import b64dec from gpg-error

2025-04-03 Thread Vladimir Serbinenko
Imported from libgpg-error 1.51 Signed-off-by: Vladimir Serbinenko --- grub-core/lib/b64dec.c | 279 + 1 file changed, 279 insertions(+) create mode 100644 grub-core/lib/b64dec.c diff --git a/grub-core/lib/b64dec.c b/grub-core/lib/b64dec.c new file mode

[PATCH v8 6/9] keccak: Disable acceleration with SSE asm

2025-04-03 Thread Vladimir Serbinenko
Libgcrypt code assumes that on x64 all SSE registers are fair game. While it's true that CPUs in question support it, we disable it in our compilation options. Disable the offending optimization. Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/02_keccak_sse.patch | 25 ++

[PATCH v8 8/9] Remove now unneeded gcrypt compilation flag

2025-04-03 Thread Vladimir Serbinenko
HAVE_STRTOUL is now defined in stdlib.h. Include it in g10lib.h rather than defining on command line Signed-off-by: Vladimir Serbinenko --- conf/Makefile.common | 2 +- util/import_gcry.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/conf/Makefile.common b/conf/Makefile.

[PATCH v8 4/9] Adjust import script, definitions and API users for libgcrypt 1.11

2025-04-03 Thread Vladimir Serbinenko
This patches modifies the GRUB-libgcrypt API to match new libgcrypt 1.11 Signed-off-by: Vladimir Serbinenko --- autogen.sh| 5 + conf/Makefile.common | 4 +- grub-core/Makefile.core.def | 20 +- grub-core/command

Re: [PATCH 1/7] Import libgcrypt 1.10.3

2025-04-03 Thread Vladimir 'phcoder' Serbinenko
Le jeu. 3 avr. 2025, 17:40, Daniel Kiper a écrit : > On Tue, Apr 01, 2025 at 03:58:52PM +0300, Vladimir Serbinenko wrote: > > We currently use an old version of libcrypt which > > results in us having fewer ciphers and missing on many > > other improvements. > > Could you upgrade the libgcrypt to

[PATCH v2 0/1] Update linux_kernel_params

2025-04-03 Thread Patrick Colp via Grub-devel
Update linux_kernel_params to match the latest upstream v2: - Changed commit message to replace ` with " - Fixed formatting of multi-line comments - Updated names of fields in efi_info structs to match upstream - Adjusted alignment of inline comments describing offsets to be more uniform Patrick

Re: [PATCH 3/7] Adjust import script, definitions and API users for libgcrypt 1.10

2025-04-03 Thread Vladimir 'phcoder' Serbinenko
Le jeu. 3 avr. 2025, 17:51, Daniel Kiper a écrit : > On Tue, Apr 01, 2025 at 03:58:54PM +0300, Vladimir Serbinenko wrote: > > Missing commit message... > > Is it possible to split this patch into smaller ones? > > And should not these changes go to separate patches in > grub-core/lib/libgcrypt-pa

Re: [PATCH 5/7] keccak: Disable acceleration with SSE asm

2025-04-03 Thread Vladimir 'phcoder' Serbinenko
Le jeu. 3 avr. 2025, 18:06, Daniel Kiper a écrit : > On Tue, Apr 01, 2025 at 03:58:56PM +0300, Vladimir Serbinenko wrote: > > Libgcrypt code assumes that on x64 all SSE registers are fair game. > > While it's true that CPUs in question support it, we disable it in > > our compilation options. Dis

[PATCH v8 5/9] Add DSA and RSA SEXP tests

2025-04-03 Thread Vladimir Serbinenko
This allows us to test purely the integration of the implementation of DSA and RSA from libgcrypt without concerning with additional code. Signed-off-by: Vladimir Serbinenko --- grub-core/Makefile.core.def | 16 grub-core/tests/dsa_sexp_test.c | 127 gr

Re: [PATCH 5/7] keccak: Disable acceleration with SSE asm

2025-04-03 Thread Daniel Kiper
On Tue, Apr 01, 2025 at 03:58:56PM +0300, Vladimir Serbinenko wrote: > Libgcrypt code assumes that on x64 all SSE registers are fair game. > While it's true that CPUs in question support it, we disable it in > our compilation options. Disable the offending optimization. > > Signed-off-by: Vladimir

Re: [PATCH 6/7] libgcrypt: Fix coverity warnings

2025-04-03 Thread Daniel Kiper
On Tue, Apr 01, 2025 at 03:58:57PM +0300, Vladimir Serbinenko wrote: Please split this patch into (probably) three and add CID to each one. Good example is in commit 4dc616657 (loader/i386/bsd: Use safe math to avoid underflow). Of course patches should land in grub-core/lib/libgcrypt-patches. Di

Re: [PATCH 7/7] Remove now unneeded gcrypt compilation flag

2025-04-03 Thread Daniel Kiper
On Tue, Apr 01, 2025 at 03:58:58PM +0300, Vladimir Serbinenko wrote: Could you explain why this patch is needed in the commit message? Why change in util/import_gcry.py is needed? Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.

Re: [PATCH 3/7] Adjust import script, definitions and API users for libgcrypt 1.10

2025-04-03 Thread Daniel Kiper
On Tue, Apr 01, 2025 at 03:58:54PM +0300, Vladimir Serbinenko wrote: Missing commit message... Is it possible to split this patch into smaller ones? And should not these changes go to separate patches in grub-core/lib/libgcrypt-patches? Additionally, git complains in that way: Applying: Adju

Re: [PATCH 1/7] Import libgcrypt 1.10.3

2025-04-03 Thread Daniel Kiper
On Tue, Apr 01, 2025 at 03:58:52PM +0300, Vladimir Serbinenko wrote: > We currently use an old version of libcrypt which > results in us having fewer ciphers and missing on many > other improvements. Could you upgrade the libgcrypt to the latest version, i.e. 1.11.0? Additionally, could you docum

Re: [PATCH 2/7] Import b64dec from gpg-error

2025-04-03 Thread Daniel Kiper
On Tue, Apr 01, 2025 at 03:58:53PM +0300, Vladimir Serbinenko wrote: > Base on libgpg-error 1.49 but with modifications to make it compile > in GRUB environment The same comments like for patch #1. Additionally, I think the modifications should go to separate patch. ... and missing cover letter