Re: [PATCH 2/4 v11] disk/lvm: Remove unused cache_pool

2024-11-25 Thread Daniel Kiper
On Mon, Nov 11, 2024 at 01:33:18PM -0500, Patrick Plenefisch wrote: > cache_pool is never read or used, remove it > > Signed-off-by: Patrick Plenefisch Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.

Re: [PATCH 2/2] ieee1275: Add TCG2 driver for ieee1275 PowerPC firmware

2024-11-25 Thread Stefan Berger
On 11/25/24 1:22 PM, Daniel Kiper wrote: On Tue, Nov 12, 2024 at 01:04:39PM -0500, Stefan Berger wrote: Follow recent extensions of EFI support providing a TCG2 driver with a public API for getting the maximum TPM command size and passing a TPM command through to the TPM 2. Implement this func

Re: [PATCH 3/4 v11] lvm: Add support for integrity lv

2024-11-25 Thread Daniel Kiper
On Mon, Nov 11, 2024 at 01:32:59PM -0500, Patrick Plenefisch wrote: > lv matching must be done after processing the ignored feature > indirections, as integrity volumes & caches may have several levels > of indirection that the segments must be shifted through. > > pv matching must be completely fi

Re: [PATCH 4/4 v11] lvm: Add support for cachevol lv

2024-11-25 Thread Daniel Kiper
On Mon, Nov 11, 2024 at 01:33:05PM -0500, Patrick Plenefisch wrote: > Mark cachevol lv's as ignored features, which is true > only if they are configured as "writethrough". This patch > does not let grub boot from "writeback" cache-enabled lv's > > Signed-off-by: Patrick Plenefisch Reviewed-by: D

Re: [PATCH 1/4 v11] disk/lvm: Make cache_lv more generic as ignored_feature_lv

2024-11-25 Thread Daniel Kiper
On Mon, Nov 11, 2024 at 01:32:54PM -0500, Patrick Plenefisch wrote: > This patch isn't necessary by itself, but when combined with the next > two patchs it enhances readability as ignored_features_lv is then used > for multiple types of extra LV's, not just cache LV's > > Signed-off-by: Patrick Ple

Re: [PATCH 2/2] ieee1275: Add TCG2 driver for ieee1275 PowerPC firmware

2024-11-25 Thread Daniel Kiper
On Tue, Nov 12, 2024 at 01:04:39PM -0500, Stefan Berger wrote: > Follow recent extensions of EFI support providing a TCG2 driver with a > public API for getting the maximum TPM command size and passing a TPM > command through to the TPM 2. Implement this functionality using > ieee1275 PowerPC firmw

Re: [PATCH v23 00/33] Automatic Disk Unlock with TPM2

2024-11-25 Thread Daniel Kiper via Grub-devel
Hey, On Tue, Nov 19, 2024 at 10:15:24AM -0500, Stefan Berger wrote: > On 11/15/24 2:34 AM, Gary Lin wrote: > > GIT repo for v23: https://github.com/lcp/grub2/tree/tpm2-unlock-v23 > > > > This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by > > Hernan Gatta to introduce the key p

[PATCH v2 4/5] ieee1275/tcg2: Add TCG2 driver for ieee1275 PowerPC firmware

2024-11-25 Thread Stefan Berger
Follow recent extensions of EFI support providing a TCG2 driver with a public API for getting the maximum TPM command size and passing a TPM command through to the TPM 2. Implement this functionality using ieee1275 PowerPC firmware API calls. Convert the tcg2 driver code now to a built-in driver.

[PATCH v2 2/5] ieee1275/ibmvtpm: Move initializaton functions to TCG2 driver

2024-11-25 Thread Stefan Berger
Move common initialization functions from the ibmvtpm driver module into the new TCG2 driver that will be turned into a built-in driver soon. Already make the functions available to the ibmvtpm driver as public functions and variables. Signed-off-by: Stefan Berger --- grub-core/Makefile.core.def

[PATCH v2 5/5] tpm2_key_protector: Enable build for powerpc_ieee1275

2024-11-25 Thread Stefan Berger
Signed-off-by: Stefan Berger --- grub-core/Makefile.core.def | 1 + 1 file changed, 1 insertion(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 8ecedf986..f70e02e69 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -2591,6 +2591,7 @@ mo

[PATCH v2 1/5] tss2: Adjust bit fields for big endian targets

2024-11-25 Thread Stefan Berger
The TPM bit fields need to be in reverse order for big endian targets, such as ieee1275 PowerPC platforms that run grub in big endian mode. Signed-off-by: Stefan Berger Reviewed-by: Gary Lin --- grub-core/lib/tss2/tss2_structs.h | 38 +++ 1 file changed, 38 insertion

[PATCH v2 3/5] ieee1275/tcg2: Refactor grub_ieee1275_tpm_init

2024-11-25 Thread Stefan Berger
Move tpm_get_tpm_version into grub_ieee1275_tpm_init and invalidate grub_ieee1275_tpm_ihandle in case no TPM 2 could be detected. Try the initialization only once. Use the grub_ieee1275_tpm_ihandle as indicator for an available TPM instead of grub_ieee1275_tpm_version, which can now be removed. Si

[PATCH v2 0/5] Enable Automatic Disk Unlock with TPM2 on ieee1275

2024-11-25 Thread Stefan Berger
This series of patches enables the 'Automatic Disk Unlock with TPM2' support for ieee1275 PowerPC platforms. It adds a TCG2 driver for this platform, which has the same API as the one for EFI. Further, it adjusts the definition of TPM 2 related bit fields for big endian targets. Regards, Stefan