Re: [PATCH V4] ieee1275/ofdisk: vscsi lun handling on lun len

2024-11-11 Thread Avnish Chouhan
Message: 3 Date: Mon, 11 Nov 2024 14:42:55 +0530 From: Mukesh Kumar Chaurasiya To: grub-devel@gnu.org Cc: meghanaprak...@in.ibm.com, avn...@linux.vnet.ibm.com, brk...@linux.vnet.ibm.com, mamat...@linux.vnet.ibm.com, mchau...@linux.vnet.ibm.com, Mukesh Kumar Chaurasiya Sub

Re: [PATCH v22 33/33] docs: Document TPM2 key protector

2024-11-11 Thread Stefan Berger
On 11/11/24 2:45 AM, Gary Lin via Grub-devel wrote: Update the user manual to address TPM2 key protector including the two related commands, tpm2_key_protector_init and tpm2_key_protector_clear, and the user-space utility: grub-protect. Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper Rev

[PATCH V4] ieee1275/ofdisk: vscsi lun handling on lun len

2024-11-11 Thread Mukesh Kumar Chaurasiya
The information about "vscsi-report-luns" data is a list of disk details with pairs of memory addresses and lengths. 8 bytes 8 bytes lun-addr ---> 8 bytes ^| buf-addr | lun-count| > - |

Re: [PATCH] Mandatory install device check for PowerPC

2024-11-11 Thread Michal Suchánek
Hello, thanks for the patch! On Sat, Nov 09, 2024 at 11:20:08AM +0530, avnish wrote: > Hi Vladimir, > Thank you so much for your response! > > I have fine tuned the patch as per the last discussion (sorry, I missed the > v2 tag). This latest patch will add install device check only to PowerPC >

Re: [PATCH] kern/fs: honour file->read_hook in grub_fs_blocklist_read()

2024-11-11 Thread Rasmus Villemoes via Grub-devel
On Tue, Oct 15 2024, Daniel Kiper wrote: > On Fri, Oct 11, 2024 at 08:12:59PM +0200, Rasmus Villemoes via Grub-devel > wrote: >> "Vladimir 'phcoder' Serbinenko" writes: >> >> > Reviewed-by: phco...@gmail.com > > Reviewed-by: Daniel Kiper > >> Thanks. Can this be picked up, please? > > I will t

[PATCH v22 33/33] docs: Document TPM2 key protector

2024-11-11 Thread Gary Lin via Grub-devel
Update the user manual to address TPM2 key protector including the two related commands, tpm2_key_protector_init and tpm2_key_protector_clear, and the user-space utility: grub-protect. Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper --- docs/grub.texi | 525 +++

[PATCH v22 30/33] diskfilter: look up cryptodisk devices first

2024-11-11 Thread Gary Lin via Grub-devel
When using disk auto-unlocking with TPM 2.0, the typical grub.cfg may look like this: tpm2_key_protector_init --tpm2key=(hd0,gpt1)/boot/grub/sealed.tpm cryptomount -u -P tpm2 search --fs-uuid --set=root Since the disk search order is based on the order of module loading, the attacker coul

[PATCH 2/4 v11] disk/lvm: Remove unused cache_pool

2024-11-11 Thread Patrick Plenefisch
cache_pool is never read or used, remove it Signed-off-by: Patrick Plenefisch --- grub-core/disk/lvm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/grub-core/disk/lvm.c b/grub-core/disk/lvm.c index 36023279f..286132d74 100644 --- a/grub-core/disk/lvm.c +++ b/grub

[PATCH 1/4 v11] disk/lvm: Make cache_lv more generic as ignored_feature_lv

2024-11-11 Thread Patrick Plenefisch
This patch isn't necessary by itself, but when combined with the next two patchs it enhances readability as ignored_features_lv is then used for multiple types of extra LV's, not just cache LV's Signed-off-by: Patrick Plenefisch --- grub-core/disk/lvm.c | 176 +---

[PATCH 0/4 v11] LVM Cachevol and Integrity volumes break entire LVM VG

2024-11-11 Thread Patrick Plenefisch
In an effort to solve https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 for myself, I implemented basic support for cachevol and integrity volumes in LVM. This is just an extension of the cachepool support that already existed, and just like that support, I ignore all of the metadata and j

[PATCH 3/4 v11] lvm: Add support for integrity lv

2024-11-11 Thread Patrick Plenefisch
lv matching must be done after processing the ignored feature indirections, as integrity volumes & caches may have several levels of indirection that the segments must be shifted through. pv matching must be completely finished before validating a volume, otherwise referenced raid stripes may not

[PATCH 4/4 v11] lvm: Add support for cachevol lv

2024-11-11 Thread Patrick Plenefisch
Mark cachevol lv's as ignored features, which is true only if they are configured as "writethrough". This patch does not let grub boot from "writeback" cache-enabled lv's Signed-off-by: Patrick Plenefisch --- grub-core/disk/lvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/di

Re: [PATCH v22 32/33] tests: Add tpm2_key_protector_test

2024-11-11 Thread Stefan Berger
On 11/11/24 2:45 AM, Gary Lin wrote: For the tpm2_key_protector module, the TCG2 command submission function is the only difference between a QEMU instance and grub-emu. To test TPM2 key unsealing with a QEMU instance, it requires an extra OS image to invoke grub-protect to seal the LUKS key, r

Re: [PATCH v3 02/16] term/terminfo: for ppc, reset console display attr when clear screen

2024-11-11 Thread Avnish Chouhan
Message: 4 Date: Thu, 10 Oct 2024 15:43:20 -0600 From: Leo Sandoval To: grub-devel@gnu.org Subject: [PATCH v3 02/16] term/terminfo: for ppc, reset console display attr when clear screen Message-ID: <20241010214334.1749167-3-lsand...@redhat.com> Content-Type: text/plain; charset="US-ASCII"