Re: [PATCH] loader/multiboot: do not add modules before successful download

2024-10-30 Thread Daniel Kiper
Hey, On Fri, Oct 25, 2024 at 01:59:25PM +0200, Valentin Gehrke wrote: > Hey Daniel, > > did you have time yet to give the patch in my last email > a try? I just want to make sure the email didn't get > overlooked. Sorry, it looks it fell through the cracks. Anyway, I think I was going to ask you

Re: [PATCH v3 00/16] First Distro-agnostic series taken from Fedora Rawhide

2024-10-30 Thread Daniel Kiper
Leo, On Thu, Oct 10, 2024 at 03:43:18PM -0600, Leo Sandoval wrote: > This is the first patch series, taken from Fedora Rawhide spec [1] that > is distro-agnostic. The goal is to merge most of them so all the > community/distros > would benefit. I think it will be much easier to deal with patches

Re: [PATCH v3 0/3] docs: Small Fixes for Network, Secure Boot, PXE

2024-10-30 Thread Daniel Kiper
On Thu, Oct 24, 2024 at 08:37:51PM -0500, Andrew Hamilton wrote: > Currently the GRUB Manual has a few small issues captured in bug > reports (54480, 62004, and 65152). These are related to issues in > documentation for environment variables "pxe_default_server", > "pxe_default_gateway"; incorrect

Re: [PATCH] kern/main: Fix cmdpath in root directory

2024-10-30 Thread Daniel Kiper
Adding Leo... On Tue, Oct 29, 2024 at 03:57:18PM +0800, Michael Chang via Grub-devel wrote: > The "cmdpath" environment variable is set at startup to the location > from which the grub image is loaded. It includes a device part and, > optionally, an absolute directory name if the grub image is boo

Re: default entry different from timeout entry

2024-10-30 Thread Daniel Kiper
Hey, CC-ing Vladimir... On Sun, Oct 13, 2024 at 11:11:46PM +0200, Samuel Thibault wrote: > Hello, > > For the debian installation CD, when using syslinux we can set an > on-timeout entry which is different from the default entry. This is > quite important because we want sighted people to be able

[PATCH] loader/multiboot: do not add modules before successful download

2024-10-30 Thread Valentin Gehrke
Multiboot modules that could not be read successfully (e.g. via network) should not be added to the list of modules to forward to the operating system that is to be booted subsequently. This patch is necessary because even if a grub.cfg checks whether or not a module was successfully downloaded, i

Re: [PATCH v3 00/16] First Distro-agnostic series taken from Fedora Rawhide

2024-10-30 Thread Leo Sandoval
Hi Daniel, Thanks for your feedback, comment inline. On Wed, Oct 30, 2024 at 10:40 AM Daniel Kiper wrote: > Leo, > > On Thu, Oct 10, 2024 at 03:43:18PM -0600, Leo Sandoval wrote: > > This is the first patch series, taken from Fedora Rawhide spec [1] that > > is distro-agnostic. The goal is to m

[PATCH] loader/multiboot: do not add modules before successful download

2024-10-30 Thread Valentin Gehrke
Multiboot modules that could not be read successfully (e.g. via network) should not be added to the list of modules to forward to the operating system that is to be booted subsequently. This patch is necessary because even if a grub.cfg checks whether or not a module was successfully downloaded, i

[PATCH v4 3/3] docs: Correct net boot conf name for MAC addr

2024-10-30 Thread Andrew Hamilton
Correct the documentation for the grub.cfg searching via network that will be done based on a given MAC address (was missing the Ethernet Type - 01). Fixes: https://savannah.gnu.org/bugs/?65152 Signed-off-by: Andrew Hamilton Reviewed-by: Daniel Kiper --- docs/grub.texi | 4 ++-- 1 file changed

[PATCH v4 0/3] docs: Small Fixes for Network, Secure Boot, PXE

2024-10-30 Thread Andrew Hamilton
Currently the GRUB Manual has a few small issues captured in bug reports (54480, 62004, and 65152). These are related to issues in documentation for environment variables "pxe_default_server", "pxe_default_gateway"; incorrect statement that "chainloader" does not support secure boot; and an issue i

[PATCH v4 2/3] docs: Correct chainloader secure boot info

2024-10-30 Thread Andrew Hamilton
Correct documentation for secure boot with UEFI to remove statement that chainloader does not work with secure boot, as this was added by a previous GRUB update. Fixes: https://savannah.gnu.org/bugs/?62004 Signed-off-by: Andrew Hamilton Reviewed-by: Daniel Kiper --- docs/grub.texi | 14 +++

[PATCH v4 1/3] docs: Correct PXE ENV Variable Definitions

2024-10-30 Thread Andrew Hamilton
Correct documentation for pxe_default_server, pxe_default_gatway, and pxe_blksize. Only pxe_default_server is actually used (alias for net_default_server) so capture this, and remove the other two. Fixes: https://savannah.gnu.org/bugs/?54480 Signed-off-by: Andrew Hamilton Reviewed-by: Daniel Kip